4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
1 year ago
8e708cca05
Merge branch 'main' into lint/sarif
1 year ago
7826b4f5f2
Merge pull request #748 from SimonMarquis/fix/permissions
...
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
1 year ago
890c0f5769
Merge pull request #776 from SimonMarquis/fix/714
...
Keep track of matching `Network`s inside `NetworkCallback`
1 year ago
27154ef38a
Apply changes from review comments
1 year ago
479a2f00b0
Refactor icons
1 year ago
1345764649
Merge pull request #770 from android/refactor/remove_unused_statements
...
Remove unused statements
1 year ago
fecab96e4c
Keep track of matching `Network`s inside `NetworkCallback`
...
This will ensure the connectivity state remains synchronized with the `ConnectivityManager`.
Fixes #714
1 year ago
99094199bc
Remove redundant suppressions
...
Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef
1 year ago
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
1 year ago
9aba5cc0fe
Cleanup unused string resources
1 year ago
8ea9a8fa51
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
1 year ago
f914254414
Merge pull request #749 from android/tj/reactive-only-dao
...
Ensure DAO exposes only reactive types
1 year ago
d319264ef0
Provide Default dispatcher for instrumented tests
...
Change-Id: I488a9b9d9d3864ce9496614ab35332ec19d06bcc
1 year ago
b245334a18
Updating TestDataStoreModule to use ApplicationScope
1 year ago
dcc36b0228
Fix tests
...
Change-Id: Ie6b62071d2023e3a7ffe1553ab606e3f6b386a5e
1 year ago
4cdb5963a0
Add top level application scope, use IO dispatcher for DataStore
...
Change-Id: I1512b1665587c73abd5e8a78aa9abd3eed24ab79
1 year ago
cd6ad7d575
Ensure DAO exposes only reactive types
...
Change-Id: I8992ccf6525cd4c5ea9503d532b500e4d310b7fb
1 year ago
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
1 year ago
f87e769b7d
Merge pull request #681 from SimonMarquis/di/coroutine-scope
...
Add Application-wide `CoroutineScope` in the DI graph
1 year ago
bbdc62cbf4
Merge pull request #706 from gururani-abhishek/remove-onItemClick-parameter
...
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
1 year ago
76b0b08121
Adjust JDK setup to remove toolchain
...
Change-Id: Ie0f43cb8f0fe504ed3e98ef35703949959688699
1 year ago
e38e24eee9
Merge pull request #583 from SimonMarquis/jvmToolchain
...
Configure jvmToolchain for Android and Kotlin projects
1 year ago
ba1d9e14df
Merge pull request #716 from SimonMarquis/SimonMarquis-patch-3
...
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
1 year ago
a4eab289df
Merge pull request #719 from android/add-search-analytics
...
Add analytics for search queries
1 year ago
2f2dfb00a4
Mark all news resources read on first sync
...
Otherwise, there will be unread articles until the user clicks through
every article that has ever been published.
1 year ago
0e40e26f22
Add analytics for search queries
...
Change-Id: If5290a903afb928fc1c3aaa66a52d2f182aba118
1 year ago
ec9155fef9
Update ConnectivityManagerNetworkMonitor.kt
1 year ago
7819a0c6bc
Extract common code to update the Flow value
1 year ago
def5c4e881
Update ConnectivityManagerNetworkMonitor.kt
1 year ago
76c249a651
Update ConnectivityManagerNetworkMonitor.kt
1 year ago
f34ee1c01b
Update ConnectivityManagerNetworkMonitor.kt
1 year ago
de6545f5d7
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
1 year ago
6e6abd0326
Fix build
1 year ago
9562f7707d
Route notification deep link through for you screen, with spotless fixes
1 year ago
ef97cb941c
Route notification deep link through for you screen
1 year ago
8a3a16de21
Add pending intent for opening notification links
1 year ago
2499c0a0bd
Notify users when news are updated
1 year ago
ddabba8e4a
Merge branch 'main' into jvmToolchain
1 year ago
f6bdba08d9
added comment to document what happens on tapping news resource card.
1 year ago
bbc80bb0e2
added back launchCustomChromeTab()
1 year ago
51379a249d
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
...
1. removed the unused onItemClick parameter
2. removed now redundant variables it used
3. removed its description from the comments.
1 year ago
2fd1b716f6
Merge pull request #667 from SimonMarquis/cleanup/warnings
...
Cleanup warnings and replace deprecated methods
1 year ago
c746b6afcd
Merge pull request #598 from takagimeow/fix/clean-up-unused-update-topics
...
Clean up unused updateTopics and updateNewsResources methods
1 year ago
1341f7c2c5
Replace unused variable with simpler method calls
1 year ago
459717f8ba
Remove `DSL_SCOPE_VIOLATION` suppression as it is now fixed in Gradle 8.1
1 year ago
e1ae12129a
Merge pull request #662 from android/av/agp-8.0
...
Update to AGP 8.0
1 year ago
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
1 year ago
73a38720d8
Merge pull request #649 from android/tj/backend-requested-sync
...
Wire up backend requested sync
1 year ago
6b834b6f4c
Applied code review suggestions
...
Change-Id: I12fab8e0d27a8a1805e0063054ec3382bebd78f1
1 year ago
b3f2502ec2
Update core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
1 year ago
f86d174c1b
Used more explicit variable names in tests
...
Change-Id: I2e0ebead70441eced05eb786aaa7683bfefa8976
1 year ago
337c940d66
Add comments explaining backend sync and made variable names easier to grok
...
Change-Id: I90cd7444de95efa20bf243a922a772f7849a23ec
1 year ago
022cd92f4c
Update core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepository.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
1 year ago
5a43b4b74e
Run Spotless
1 year ago
aa701064a2
Add Application-wide `CoroutineScope` in the DI graph
...
Following the work of #607 .
1 year ago
9499e559e7
Delete no longer used `AUTHORS_ASSET` reference
1 year ago
6bf37adde9
Merge pull request #671 from android/kotlin-version-updates
...
Update Kotlin, Compose compiler, serialization versions
1 year ago
bea2eecd90
Update Kotlin, Compose compiler, serialization versions
...
Change-Id: I2aa0d07769e79e6f85824a391418566aef6b721e
1 year ago
05be2855d8
Wire up backend requested sync
...
Change-Id: I1d4485b589c7e94527a2a02f371cd3f030231622
1 year ago
93953c2206
Add missing method doc
1 year ago
050db2cb72
Merge branch 'main' into jr/track-viewed
1 year ago
b49767a88c
Rename getUserNewsResources to observeAll
1 year ago
086dc957c0
Update to AGP 8.0
...
Change-Id: I27eb106e484e2003d732782a39612dc72c845282
1 year ago
feafb5fbed
Merge pull request #575 from takagimeow/fix/provide-true-to-local-inspection-mode
...
Provide true to LocalInspectionMode
1 year ago
2b2f6d48ce
Merge pull request #600 from takagimeow/cleanup-unused-args
...
Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
1 year ago
0b0fdbfdbf
Merge branch 'main' into patch-2
1 year ago
08956492c8
Backend triggered sync
...
Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3
1 year ago
ba6a697844
Merge pull request #624 from SimonMarquis/gradle-sort
...
Sort and group Gradle dependencies
1 year ago
93c01ad184
Fix trailing commas based on spotless check
1 year ago
049750dd51
Merge branch 'main' into ui-polish
1 year ago
57c13d84bd
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
1 year ago
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
1 year ago
ebfbb5bafd
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
2 years ago
bd450099fb
Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository
...
This moves the responsibility for joining the UserData and the
NewsResources to UserNewsResourceRepository. This way, the work can be
done once and shared with all consumers in a SharedFlow, rather than
having each consumer perform the join itself by invoking the UseCase.
2 years ago
9ee2acf327
Add viewed status for news resources to data layer
2 years ago
ebdb8589a6
Merge pull request #608 from android/tunjid-batch-sync
...
Batch sync news resources from remote
2 years ago
d56d8e1380
Merge branch 'main' of https://github.com/takagimeow/nowinandroid into fix/clean-up-unused-update-topics
2 years ago
6d1f85b8ce
Merge pull request #607 from android/mv/tests
...
Provide a CoroutineScope to fake DataStores
2 years ago
8765d3ac57
Fix tests for batched news resource sync
...
Change-Id: I37545eba8618edc936eb12fa38628d98f85f52ed
2 years ago
1e8d1d9810
Spotless fix
...
Thought I was cool enough to edit code in the browser. Spotless said no.
2 years ago
267adfd27f
Batch sync news resources from remote
...
Batch sync news resources from remote to reduce json payload size.
2 years ago
0844d021b9
Merge pull request #603 from amalhanaja/redundant-managed-device
...
Remove redundant code block for managed virtual device creation
2 years ago
755413bfc5
Fix spotless
2 years ago
91633af376
Provide a CoroutineScope to fake DataStores
2 years ago
2f3fc85d65
Make Hilt provide Firebase.analytics
...
Change-Id: I57bec82713ce7ce3a17cd4ad0f377c28c2aedb89
2 years ago
bcd4a6de59
Remove redundant code block for managed virtual device creation
2 years ago
072364e7f1
remove newsResourceTitle
2 years ago
0a748bc899
Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/clean-up-unused-update-topics
2 years ago
ae58d1e1b0
Merge pull request #592 from android/tj/news-resource-query
...
Add NewsResourceQuery to better query encapsulation
2 years ago
09f5c3bc61
Add NewsResourceQuery to better query encapsulation
...
Change-Id: I93f8c8ae2d1144975f6f9ff1ba93be9a4600768a
2 years ago
86c021a54a
remove invalid overriding method
2 years ago
fb32580e0c
remove unused updateNewsResources method
2 years ago
67412b2720
remove invalid overriding method
2 years ago
1489bf66e3
remove unused updateTopics method
2 years ago
6a5feb767e
Merge pull request #582 from yschimke/loaders
...
Improve network pooling and avoid startup image fetches.
2 years ago
8b51107d7a
Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/provide-true-to-local-inspection-mode
...
Conflicts:
core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt
2 years ago
e1f8c51c05
Configure jvmToolchain on the single Kotlin jvm project
2 years ago
4fa730098d
Fixes
...
Change-Id: Iedcafbf0ad7b853544b7b5b3f37685a0a868c2e6
2 years ago
9e399b69ea
Improve network pooling and avoid startup image fetches.
...
Change-Id: If747fb0833d31ce7c9bedffd400160e979bc945e
2 years ago
4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
2 years ago
237375f52a
Remove unused DropdownMenu component
...
Change-Id: I7ee7e8f1995667c7e54459f4333594c4605cc5a9
2 years ago
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
2 years ago
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
2 years ago
9091abf09e
Provide true to LocalInspectionMode
2 years ago
3409f937ed
Migrate custom room configuration into a convention plugin
...
And use `CommandLineArgumentProvider` to avoid breaking cacheability: https://issuetracker.google.com/issues/132245929
2 years ago
bcb4d7d592
Replace global variables with PreviewParameterProvider
2 years ago
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
2 years ago
cfbf782613
Merge pull request #542 from android/as/dynamic-color-option
...
Add dynamic color option in settings for API >=32
2 years ago
6b48b355cc
Merge branch 'main' into tm/fix-benchmarks-no-people
...
Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7
2 years ago
46c1d510d4
Android-CI workflow -> GMD refactor ( #537 )
...
This PR is about updating the operating system to macOS-12 as the previous one was going to be deprecated, as well as updating the checkout to v3 to avoid the warnings in the panel; adding setup SDK action to accept the license which was missing from the beginning.
I also added imports instead of adding them directly with the codes.
As a reference, there was another PR with a similar topic, but it wasn't complete: #483
2 years ago
dbbe8ffecb
Small fix for naming and boolean logic
...
Change-Id: I3dd291bdd581494574c557329bf23f5ed07af0bb
2 years ago
19efc1b5e8
Fix Spotless issue manually
...
Change-Id: Icd560e6ceaaeee0a6f502fe49b3403ab07f926ef
2 years ago
6046f6e943
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
2 years ago
4633609930
Introduce GMD + ATD ( #479 )
...
Introduce Gradle Managed Device definitions to modules that have instrumented tests.
At the moment, defining it as a convention plugin isn't possible due to the bug. That bug is now fixed and will be included in Android Studio Flamingo.
Once Flamingo becomes stable, convert the GMD definitions as a convention plugin (#523 )
Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8
2 years ago
bad3ea60f5
Refactor Topics news feed, tidy a few other bits up
...
Change-Id: Id4c9d1bce484137b363ec4cd21a45ca9863a2e7f
2 years ago
45e3cfd989
fixed string issue for testTopicsChipColorBackground_matchesFollowedState test
2 years ago
de6a4ec6c7
Merge remote-tracking branch 'github/mm/chipcolor' into mm/chipcolor
2 years ago
5137cd7777
removed hardcoded strings
2 years ago
cafac8eb09
fix spotless, tidy test data
...
Change-Id: I4ceb7b85e5a8dd4d4f20088b2594c6b4030299bb
2 years ago
66046a86b0
Updated NewsResourceCardTest
2 years ago
6207fe3bcf
mapToUserNewsResources converts List<NewsResource> to List<UserNewsResource>
...
Change-Id: I072effef0f66caf51227ba8c64f0857fb837308d
2 years ago
24df51349d
Move mapping logic into secondary constructor
...
Change-Id: I032326f502d27f2d3bd9fb8273ae44df878d172c
2 years ago
355b0540aa
Move construction of UserNewsResource into separate function
...
Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2
2 years ago
99227b06b5
Spotless
2 years ago
32bc5c1590
Fix merge conflicts
2 years ago
ffb5aeba86
Added third draft of tests
2 years ago
d9e18607be
Added second draft of tests
2 years ago
8089866079
Added second draft of tests
2 years ago
ba11e6bf38
Merge pull request #491 from android/av/fix-background-composable
...
Updated background composable for gradient
2 years ago
2f454de21c
Spacing polish based on design spec
2 years ago
47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
2 years ago
0917cdebec
Refactor NiaGradientBackground to accept GradientColors
...
Change-Id: I55840b22e123490097710570bf11554554df90f9
2 years ago
1acee42167
Merge pull request #493 from andhiratobing/main
...
Set visibility modifier of composable preview to private
2 years ago
cf053ade5a
Fix build warnings
2 years ago
9a900f9900
Added first draft of tests
2 years ago
a8f55d9d38
Renamed SaveableNewsResource to UserNewsResource
2 years ago
5638e253ae
Fix unit and UI tests. Apply spotless.
...
Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5
2 years ago
ec4bceead3
Renamed SaveableNewsResource to UserNewsResource
2 years ago
6941e2082b
Renamed SaveableNewsResource to UserNewsResource
2 years ago
a1d0dfcaa5
Merge pull request #492 from ricknout/main
...
Fix issues with NiaTheme gradients and backgrounds
2 years ago
1e493c0bbc
Set visibility modifier of composable preview to private
2 years ago
c742aa3eca
Fix issues with NiaTheme gradients and backgrounds
2 years ago
7903f87dcc
Merge pull request #485 from ricknout/main
...
Update :core-designsystem module based on Figma file
2 years ago
9fd47261c9
Address design system PR feedback
2 years ago
cac02c418d
Fix ThemeTest
2 years ago
61bbd406c5
Fix ThemeTest
2 years ago
a34bc2d7c2
Fix spotless issues
2 years ago
be4ad40441
Fix spotless issues
2 years ago
c12fe1fbe5
Update :core-designsystem module based on Figma file
2 years ago
Tomáš Mlynarič
Simon Marquis
James Rose
Adetunji Dahunsi
Simon Marquis
Miłosz Moczkowski
Don Turner
TJ Dahunsi
Don Turner
Neelansh Sahai
Alex Vanyo
gururani-abhishek
Takeshi Hagikura
Márton Braun
Chris Sinco
Keisuke Takagi
Manuel Vivo
AlfianHanantio
Caren
Yuri Schimke
Angie Sasmita
Mohsen Rzna
magicalmeghan
Nick Rout
ratobing