Merge pull request #600 from takagimeow/cleanup-unused-args

Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
2 years ago · 2b2f6d48ce
parent 37908ec05c 072364e7f1
commit 2b2f6d48ce
3 changed files with 1 additions and 3 deletions
--- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt
+++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt
@ -39,7 +39,7 @@ fun AnalyticsHelper.logScreenView(screenName: String) {
    )
 }

-fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String, newsResourceTitle: String) {
+fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String) {
    logEvent(
        event = AnalyticsEvent(
            type = "news_resource_opened",
--- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt
+++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt
@ -69,7 +69,6 @@ fun LazyGridScope.newsFeed(
                    onClick = {
                        analyticsHelper.logNewsResourceOpened(
                            newsResourceId = userNewsResource.id,
-                            newsResourceTitle = userNewsResource.title,
                        )
                        launchCustomChromeTab(context, resourceUrl, backgroundColor)
                    },
--- a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt
+++ b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt
@ -56,7 +56,6 @@ fun LazyListScope.userNewsResourceCardItems(
            onClick = {
                analyticsHelper.logNewsResourceOpened(
                    newsResourceId = userNewsResource.id,
-                    newsResourceTitle = userNewsResource.title,
                )
                when (onItemClick) {
                    null -> launchCustomChromeTab(context, resourceUrl, backgroundColor)