7b6c3a16ca
Merge pull request #823 from ahmed-madhoun1/allow_localised_date_format
...
Allow localised date format
1 year ago
b2a74ba174
Merge pull request #812 from Askeri-Muhendis/main
...
Kotlin Coding conventions
1 year ago
c4686cfa54
Track when deep link notifications are opened
...
Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91
1 year ago
3114b2eeaa
Allow localised date format
1 year ago
d136965a0d
Merge branch 'main' into lint/sarif
2 years ago
6271d1c4c0
Merge branch 'android:main' into main
2 years ago
56f8a27132
Kotlin coding conventions places companion object at the bottom of the class
2 years ago
8e1e994bb1
Add named arguments
...
Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91
2 years ago
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
2 years ago
8e708cca05
Merge branch 'main' into lint/sarif
2 years ago
7826b4f5f2
Merge pull request #748 from SimonMarquis/fix/permissions
...
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
2 years ago
890c0f5769
Merge pull request #776 from SimonMarquis/fix/714
...
Keep track of matching `Network`s inside `NetworkCallback`
2 years ago
27154ef38a
Apply changes from review comments
2 years ago
479a2f00b0
Refactor icons
2 years ago
1345764649
Merge pull request #770 from android/refactor/remove_unused_statements
...
Remove unused statements
2 years ago
fecab96e4c
Keep track of matching `Network`s inside `NetworkCallback`
...
This will ensure the connectivity state remains synchronized with the `ConnectivityManager`.
Fixes #714
2 years ago
99094199bc
Remove redundant suppressions
...
Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef
2 years ago
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
2 years ago
9aba5cc0fe
Cleanup unused string resources
2 years ago
8ea9a8fa51
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
2 years ago
f914254414
Merge pull request #749 from android/tj/reactive-only-dao
...
Ensure DAO exposes only reactive types
2 years ago
d319264ef0
Provide Default dispatcher for instrumented tests
...
Change-Id: I488a9b9d9d3864ce9496614ab35332ec19d06bcc
2 years ago
b245334a18
Updating TestDataStoreModule to use ApplicationScope
2 years ago
dcc36b0228
Fix tests
...
Change-Id: Ie6b62071d2023e3a7ffe1553ab606e3f6b386a5e
2 years ago
4cdb5963a0
Add top level application scope, use IO dispatcher for DataStore
...
Change-Id: I1512b1665587c73abd5e8a78aa9abd3eed24ab79
2 years ago
cd6ad7d575
Ensure DAO exposes only reactive types
...
Change-Id: I8992ccf6525cd4c5ea9503d532b500e4d310b7fb
2 years ago
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
2 years ago
f87e769b7d
Merge pull request #681 from SimonMarquis/di/coroutine-scope
...
Add Application-wide `CoroutineScope` in the DI graph
2 years ago
bbdc62cbf4
Merge pull request #706 from gururani-abhishek/remove-onItemClick-parameter
...
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
2 years ago
76b0b08121
Adjust JDK setup to remove toolchain
...
Change-Id: Ie0f43cb8f0fe504ed3e98ef35703949959688699
2 years ago
e38e24eee9
Merge pull request #583 from SimonMarquis/jvmToolchain
...
Configure jvmToolchain for Android and Kotlin projects
2 years ago
ba1d9e14df
Merge pull request #716 from SimonMarquis/SimonMarquis-patch-3
...
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
2 years ago
a4eab289df
Merge pull request #719 from android/add-search-analytics
...
Add analytics for search queries
2 years ago
2f2dfb00a4
Mark all news resources read on first sync
...
Otherwise, there will be unread articles until the user clicks through
every article that has ever been published.
2 years ago
0e40e26f22
Add analytics for search queries
...
Change-Id: If5290a903afb928fc1c3aaa66a52d2f182aba118
2 years ago
ec9155fef9
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
7819a0c6bc
Extract common code to update the Flow value
2 years ago
def5c4e881
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
76c249a651
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
f34ee1c01b
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
de6545f5d7
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
2 years ago
6e6abd0326
Fix build
2 years ago
9562f7707d
Route notification deep link through for you screen, with spotless fixes
2 years ago
ef97cb941c
Route notification deep link through for you screen
2 years ago
8a3a16de21
Add pending intent for opening notification links
2 years ago
2499c0a0bd
Notify users when news are updated
2 years ago
ddabba8e4a
Merge branch 'main' into jvmToolchain
2 years ago
f6bdba08d9
added comment to document what happens on tapping news resource card.
2 years ago
bbc80bb0e2
added back launchCustomChromeTab()
2 years ago
51379a249d
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
...
1. removed the unused onItemClick parameter
2. removed now redundant variables it used
3. removed its description from the comments.
2 years ago
2fd1b716f6
Merge pull request #667 from SimonMarquis/cleanup/warnings
...
Cleanup warnings and replace deprecated methods
2 years ago
c746b6afcd
Merge pull request #598 from takagimeow/fix/clean-up-unused-update-topics
...
Clean up unused updateTopics and updateNewsResources methods
2 years ago
1341f7c2c5
Replace unused variable with simpler method calls
2 years ago
459717f8ba
Remove `DSL_SCOPE_VIOLATION` suppression as it is now fixed in Gradle 8.1
2 years ago
e1ae12129a
Merge pull request #662 from android/av/agp-8.0
...
Update to AGP 8.0
2 years ago
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
2 years ago
73a38720d8
Merge pull request #649 from android/tj/backend-requested-sync
...
Wire up backend requested sync
2 years ago
6b834b6f4c
Applied code review suggestions
...
Change-Id: I12fab8e0d27a8a1805e0063054ec3382bebd78f1
2 years ago
b3f2502ec2
Update core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
f86d174c1b
Used more explicit variable names in tests
...
Change-Id: I2e0ebead70441eced05eb786aaa7683bfefa8976
2 years ago
337c940d66
Add comments explaining backend sync and made variable names easier to grok
...
Change-Id: I90cd7444de95efa20bf243a922a772f7849a23ec
2 years ago
022cd92f4c
Update core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepository.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
5a43b4b74e
Run Spotless
2 years ago
aa701064a2
Add Application-wide `CoroutineScope` in the DI graph
...
Following the work of #607 .
2 years ago
9499e559e7
Delete no longer used `AUTHORS_ASSET` reference
2 years ago
6bf37adde9
Merge pull request #671 from android/kotlin-version-updates
...
Update Kotlin, Compose compiler, serialization versions
2 years ago
bea2eecd90
Update Kotlin, Compose compiler, serialization versions
...
Change-Id: I2aa0d07769e79e6f85824a391418566aef6b721e
2 years ago
05be2855d8
Wire up backend requested sync
...
Change-Id: I1d4485b589c7e94527a2a02f371cd3f030231622
2 years ago
93953c2206
Add missing method doc
2 years ago
050db2cb72
Merge branch 'main' into jr/track-viewed
2 years ago
b49767a88c
Rename getUserNewsResources to observeAll
2 years ago
086dc957c0
Update to AGP 8.0
...
Change-Id: I27eb106e484e2003d732782a39612dc72c845282
2 years ago
feafb5fbed
Merge pull request #575 from takagimeow/fix/provide-true-to-local-inspection-mode
...
Provide true to LocalInspectionMode
2 years ago
2b2f6d48ce
Merge pull request #600 from takagimeow/cleanup-unused-args
...
Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
2 years ago
0b0fdbfdbf
Merge branch 'main' into patch-2
2 years ago
08956492c8
Backend triggered sync
...
Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3
2 years ago
ba6a697844
Merge pull request #624 from SimonMarquis/gradle-sort
...
Sort and group Gradle dependencies
2 years ago
93c01ad184
Fix trailing commas based on spotless check
2 years ago
049750dd51
Merge branch 'main' into ui-polish
2 years ago
57c13d84bd
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
2 years ago
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
2 years ago
ebfbb5bafd
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
2 years ago
bd450099fb
Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository
...
This moves the responsibility for joining the UserData and the
NewsResources to UserNewsResourceRepository. This way, the work can be
done once and shared with all consumers in a SharedFlow, rather than
having each consumer perform the join itself by invoking the UseCase.
2 years ago
9ee2acf327
Add viewed status for news resources to data layer
2 years ago
ebdb8589a6
Merge pull request #608 from android/tunjid-batch-sync
...
Batch sync news resources from remote
2 years ago
d56d8e1380
Merge branch 'main' of https://github.com/takagimeow/nowinandroid into fix/clean-up-unused-update-topics
2 years ago
6d1f85b8ce
Merge pull request #607 from android/mv/tests
...
Provide a CoroutineScope to fake DataStores
2 years ago
8765d3ac57
Fix tests for batched news resource sync
...
Change-Id: I37545eba8618edc936eb12fa38628d98f85f52ed
2 years ago
1e8d1d9810
Spotless fix
...
Thought I was cool enough to edit code in the browser. Spotless said no.
2 years ago
267adfd27f
Batch sync news resources from remote
...
Batch sync news resources from remote to reduce json payload size.
2 years ago
0844d021b9
Merge pull request #603 from amalhanaja/redundant-managed-device
...
Remove redundant code block for managed virtual device creation
2 years ago
755413bfc5
Fix spotless
2 years ago
91633af376
Provide a CoroutineScope to fake DataStores
2 years ago
2f3fc85d65
Make Hilt provide Firebase.analytics
...
Change-Id: I57bec82713ce7ce3a17cd4ad0f377c28c2aedb89
2 years ago
bcd4a6de59
Remove redundant code block for managed virtual device creation
2 years ago
072364e7f1
remove newsResourceTitle
2 years ago
0a748bc899
Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/clean-up-unused-update-topics
2 years ago
ae58d1e1b0
Merge pull request #592 from android/tj/news-resource-query
...
Add NewsResourceQuery to better query encapsulation
2 years ago
09f5c3bc61
Add NewsResourceQuery to better query encapsulation
...
Change-Id: I93f8c8ae2d1144975f6f9ff1ba93be9a4600768a
2 years ago
86c021a54a
remove invalid overriding method
2 years ago
fb32580e0c
remove unused updateNewsResources method
2 years ago
67412b2720
remove invalid overriding method
2 years ago
1489bf66e3
remove unused updateTopics method
2 years ago
6a5feb767e
Merge pull request #582 from yschimke/loaders
...
Improve network pooling and avoid startup image fetches.
2 years ago
8b51107d7a
Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/provide-true-to-local-inspection-mode
...
Conflicts:
core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt
2 years ago
e1f8c51c05
Configure jvmToolchain on the single Kotlin jvm project
2 years ago
4fa730098d
Fixes
...
Change-Id: Iedcafbf0ad7b853544b7b5b3f37685a0a868c2e6
2 years ago
9e399b69ea
Improve network pooling and avoid startup image fetches.
...
Change-Id: If747fb0833d31ce7c9bedffd400160e979bc945e
2 years ago
4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
2 years ago
237375f52a
Remove unused DropdownMenu component
...
Change-Id: I7ee7e8f1995667c7e54459f4333594c4605cc5a9
2 years ago
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
2 years ago
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
2 years ago
9091abf09e
Provide true to LocalInspectionMode
2 years ago
3409f937ed
Migrate custom room configuration into a convention plugin
...
And use `CommandLineArgumentProvider` to avoid breaking cacheability: https://issuetracker.google.com/issues/132245929
2 years ago
bcb4d7d592
Replace global variables with PreviewParameterProvider
2 years ago
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
2 years ago
cfbf782613
Merge pull request #542 from android/as/dynamic-color-option
...
Add dynamic color option in settings for API >=32
2 years ago
6b48b355cc
Merge branch 'main' into tm/fix-benchmarks-no-people
...
Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7
2 years ago
46c1d510d4
Android-CI workflow -> GMD refactor ( #537 )
...
This PR is about updating the operating system to macOS-12 as the previous one was going to be deprecated, as well as updating the checkout to v3 to avoid the warnings in the panel; adding setup SDK action to accept the license which was missing from the beginning.
I also added imports instead of adding them directly with the codes.
As a reference, there was another PR with a similar topic, but it wasn't complete: #483
2 years ago
dbbe8ffecb
Small fix for naming and boolean logic
...
Change-Id: I3dd291bdd581494574c557329bf23f5ed07af0bb
2 years ago
19efc1b5e8
Fix Spotless issue manually
...
Change-Id: Icd560e6ceaaeee0a6f502fe49b3403ab07f926ef
2 years ago
6046f6e943
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
2 years ago
4633609930
Introduce GMD + ATD ( #479 )
...
Introduce Gradle Managed Device definitions to modules that have instrumented tests.
At the moment, defining it as a convention plugin isn't possible due to the bug. That bug is now fixed and will be included in Android Studio Flamingo.
Once Flamingo becomes stable, convert the GMD definitions as a convention plugin (#523 )
Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8
2 years ago
bad3ea60f5
Refactor Topics news feed, tidy a few other bits up
...
Change-Id: Id4c9d1bce484137b363ec4cd21a45ca9863a2e7f
2 years ago
45e3cfd989
fixed string issue for testTopicsChipColorBackground_matchesFollowedState test
2 years ago
de6a4ec6c7
Merge remote-tracking branch 'github/mm/chipcolor' into mm/chipcolor
2 years ago
5137cd7777
removed hardcoded strings
2 years ago
cafac8eb09
fix spotless, tidy test data
...
Change-Id: I4ceb7b85e5a8dd4d4f20088b2594c6b4030299bb
2 years ago
66046a86b0
Updated NewsResourceCardTest
2 years ago
6207fe3bcf
mapToUserNewsResources converts List<NewsResource> to List<UserNewsResource>
...
Change-Id: I072effef0f66caf51227ba8c64f0857fb837308d
2 years ago
24df51349d
Move mapping logic into secondary constructor
...
Change-Id: I032326f502d27f2d3bd9fb8273ae44df878d172c
2 years ago
355b0540aa
Move construction of UserNewsResource into separate function
...
Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2
2 years ago
99227b06b5
Spotless
2 years ago
32bc5c1590
Fix merge conflicts
2 years ago
ffb5aeba86
Added third draft of tests
2 years ago
d9e18607be
Added second draft of tests
2 years ago
8089866079
Added second draft of tests
2 years ago
ba11e6bf38
Merge pull request #491 from android/av/fix-background-composable
...
Updated background composable for gradient
2 years ago
2f454de21c
Spacing polish based on design spec
2 years ago
47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
2 years ago
0917cdebec
Refactor NiaGradientBackground to accept GradientColors
...
Change-Id: I55840b22e123490097710570bf11554554df90f9
2 years ago
1acee42167
Merge pull request #493 from andhiratobing/main
...
Set visibility modifier of composable preview to private
2 years ago
cf053ade5a
Fix build warnings
2 years ago
9a900f9900
Added first draft of tests
2 years ago
a8f55d9d38
Renamed SaveableNewsResource to UserNewsResource
2 years ago
5638e253ae
Fix unit and UI tests. Apply spotless.
...
Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5
2 years ago
ec4bceead3
Renamed SaveableNewsResource to UserNewsResource
2 years ago
6941e2082b
Renamed SaveableNewsResource to UserNewsResource
2 years ago
a1d0dfcaa5
Merge pull request #492 from ricknout/main
...
Fix issues with NiaTheme gradients and backgrounds
2 years ago
1e493c0bbc
Set visibility modifier of composable preview to private
2 years ago
c742aa3eca
Fix issues with NiaTheme gradients and backgrounds
2 years ago
7903f87dcc
Merge pull request #485 from ricknout/main
...
Update :core-designsystem module based on Figma file
2 years ago
9fd47261c9
Address design system PR feedback
2 years ago
cac02c418d
Fix ThemeTest
2 years ago
61bbd406c5
Fix ThemeTest
2 years ago
a34bc2d7c2
Fix spotless issues
2 years ago
be4ad40441
Fix spotless issues
2 years ago
c12fe1fbe5
Update :core-designsystem module based on Figma file
2 years ago
65fdb0c09c
Merge pull request #476 from android/caren/resource_type
...
Display resource type for each news resource
2 years ago
4ff9c039b3
Rename NewsResourceDataAndType -> NewsResourceMetaData
...
Change-Id: Ide67bb9adf740d9cf0bba58f369688f91e0eb85f
2 years ago
b05302fddd
Fix tests
...
Change-Id: Ie1e2408ea523e6ddc0941fe261fce7f2502e3416
2 years ago
7d42831ee9
Merge pull request #465 from android/caren/custom_chrome_tab
...
Use Chrome Custom tab for opening articles
2 years ago
352bac94fb
run spotless
...
Change-Id: Ieb751d960ade646dfe35ed7d2ca039e3b8f38ba7
2 years ago
3712ba8c2f
Add test and add string template in strings.xml for RTL purposes
...
Change-Id: I1bce9ac7534f376a9626cac2c50e1bcc7620cf61
2 years ago
f563862df3
Rename NewsResourceDateAndNewsType -> NewsResourceDateAndType
...
Change-Id: I535c62f3317d6ada882a08235c0c4465d9963201
2 years ago
f150516b3c
Display resource type for each news resource
...
Change-Id: Ib33ffd0e9b87ec91d2ee4316a4e3dbf70bb5cfc9
2 years ago
90674c0c07
Add niaTopAppBar testTag
...
Change-Id: I02a207675e106137fe005140965c96f1b50f98ce
2 years ago
0018144827
LoadingWheel testTag for every loading wheel
...
Change-Id: I7728e1717925abdfb607e93f3d48226910d42c0d
2 years ago
1280565466
Add ColorInt annotation
...
Change-Id: If6ea8e4c3a09c6de932797ddcb64bbfff1e52ede
2 years ago
4ba63c0de8
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
2 years ago
94e2bb0ec2
Run spotless
...
Change-Id: I1deee3c9b38d352afca0f646366598e32710ffca
2 years ago
45f8e069c5
Implement custom chrome tabs in NewsResourceCardList as well
...
Change-Id: Ie5851666117a7c756b3d9ad02d6e17be0d3ba904
2 years ago
55c3ebd085
Use Chrome Custom tab for opening articles
...
Change-Id: I0024038f918a18d3c3e803587a7e1c159bfb9169
2 years ago
9c22a7a4e7
Remove `Stream` suffixes
...
Change-Id: I45decae965d7e35289d3fa31fc58b8c463fbead1
2 years ago
7e0a154489
Migrate core:domain namespace to build.gradle file
2 years ago
a70761f24b
Merge pull request #441 from android/refactor/remote_fake_data_source
...
Remove FakeDataSource
2 years ago
c19b8b9319
New empty bookmarks handling ( #443 )
...
* Added the png file for error state
This should be removed later - couldn't convert the design to vector from svg - there is a problem with the `<mask` tag.
* Added two new strings based on the Figma file
* Redesign and reimplementation for the empty BookmarksScreen along with two clarifying comments.
* Removed the png file and replaced it with vector
* Code refactor after code reviewing
Made contentDescription null, removed extra spaces and renaming for the Composable function as suggested.
* Moved the modifier after Text
* Added a space after the curly bracket to pass the Spotless check
* Spotless apply
* Simplify logic in Bookmarks screen
* Change order of composables in BookmarksScreen and add previews
* Refactor after code review
Removed the space before `if`, and changed the padding from 5 to 8dp.
Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
2 years ago
a3c3b1af19
Configure `isReturnDefaultValues` for `:core:datastore`
2 years ago
23f414a05b
Configure `isReturnDefaultValues` to fix #448
2 years ago
9fa3dadcfd
Fix comment
2 years ago
841f58ef26
Check active network for connectivity state each time network changes
...
Change-Id: I5d3eb0251f62a57a5767911167067d35aeec8e6a
2 years ago
6174a3a3ef
Spotless apply
...
Change-Id: Iaf82b44487f001417265ad97acfe6eea8dd6a78f
2 years ago
67fea35e6d
Replace networkJson and FakeAssetManager with FakeNiaDataSource in all repositories
...
Change-Id: Ibeb9fd09bd862000794f41edcddd2cea434a9bb1
2 years ago
e653b738d2
Remove FakeDataSource
...
Change-Id: I5e1486feeade67f0f7276458187694e684310ad3
2 years ago
c62673d035
Merge pull request #179 from Abhimanyu14/niaicons
...
Icons alignment to use NiaIcons
2 years ago
ee8eac34b8
Refactor `:core:network` DI
...
- Delete unused `NetworkModule` from benchmark sourceSet (contains unknowns references)
- Extract common bindings into a single `NetworkModule`
- Expose "flavored" bindings through `FlavoredNetworkModule`s
2 years ago
7e0bfb43fa
Add missing binding in NetworkModule
2 years ago
b5d342468e
Merge remote-tracking branch 'fork/main' into patch/assets-as-json-files
2 years ago
cec83dc316
Merge pull request #431 from SaeedNoshadi89/show-all-news-authors
...
Show all authors in the news card
2 years ago
adeb06c5ac
replace StringBuilder with joinToString
2 years ago
dcce95ada6
remove unused import
2 years ago
e44811f265
show all authors in the news card
2 years ago
d69a37af7c
Icons alignment to use NiaIcons
2 years ago
0e6f16e0a8
Fix spotless issues
2 years ago
321b1602e1
Remove duplicated link
2 years ago
e128f9b877
Fix lint crash
2 years ago
67dea1c136
Fix spotless issues
2 years ago
fbaa8eaff5
Migrate hard-coded JSON data into JSON assets files
...
JSON minification is no longer necessary since assets files are already gzipped during APK/AAB packaging.
Fixes #391
2 years ago
90dc300783
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
2 years ago
317c72af1a
Merge branch 'main' into fix/typos
2 years ago
86ef9ff594
Make updateShouldHideOnboardingIfNecessary private
...
Change-Id: I7917b025d258a07604e98950396ec3e119e2d9a7
2 years ago
a680b14763
Fix typos
2 years ago
5b8c284c74
Rename hasDismissedOnboarding to shouldHideOnboarding
...
Change-Id: I8a6b35f7216f9944652d8da346e7458614311e08
2 years ago
6654403498
Refactor onboarding to save interests to user data
...
Change-Id: I97772a8b65e1e94a95187ebb7c514104af2d3a08
2 years ago
a9aa3eafab
Add data from the last 10 episodes
2 years ago
398c399c1c
Merge pull request #297 from android/av/remove-dolphin-preview-todos
...
Remove Preview TODOs for Dolphin
2 years ago
7a223f5d8e
Merge pull request #356 from android/jv/compose-bom
...
Update to new Compose release
2 years ago
e7b2ed623e
Update to new Compose release
2 years ago
dbff140b64
Fix minor issues
2 years ago
76daa393b1
Address review feedback from Manu
2 years ago
cf4dd1fbff
Added null branches for reading user data from datastore
2 years ago
8c30ab9f80
Add settings module, refactor top bar
2 years ago
add486a0ab
Fix spotless issues
2 years ago
7e3faad699
Add data logic for theme switcher
...
Change-Id: Ifffadb897de4f6e08f7115103f99c156a7098b70
2 years ago
a0b22d8ed2
Updates Navigation approach with new guidance ( #347 )
2 years ago
9435c1cd79
Merge branch 'github/main'
2 years ago
7e6cb46436
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
2 years ago
ee2e3db928
Add more jank tracking
2 years ago
7ca17f68ed
Merge branch 'main' into av/remove-dolphin-preview-todos
2 years ago
d0ba51efec
Merge branch 'github/main'
2 years ago
f3debd0af1
Merge "Add domain layer. See go/nia-domain-layer for details." into main
2 years ago
4a4de7d6a4
Add domain layer. See go/nia-domain-layer for details.
...
Change-Id: I3f4684005e81fb9c4163bf59c7026dcff6e88dc4
2 years ago
40c0cb2a03
Merge pull request #332 from android/kotlin-1720
...
Update Kotlin to 1.7.20
2 years ago
dcc23829d4
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
2 years ago
02c052e7f4
Update Kotlin to 1.7.20
...
Change-Id: Ib3ce03b0a1d78e90424f8431f039511c04446a62
2 years ago
8dbd53c898
Merge pull request #311 from yveskalume/main
...
Use @Upsert from Room instead of a custom helper
2 years ago
b05ea4724c
fix failling tests
...
Change-Id: I88b6d80dfb473010f8742890d9f6b17ed153ecc5
2 years ago
6351a89545
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
2 years ago
4006d8d40a
update : remove unused upsert method.
...
Change-Id: I737c7c0078512594a719fe3966cdd99ead39331f
2 years ago
9371d0d4b8
Merge pull request #304 from android/tj/sync-ui
...
Offline-first UX improvements
2 years ago
d094e96a72
update : Use @Upsert from Room instead of a custom helper
...
Change-Id: I21194fda29976e069d5cfc1e083cf48d3dd149fe
2 years ago
c4debb74e7
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
2 years ago
06e60063b5
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
2 years ago
f68a112cfe
Merge pull request #307 from android/update-kotlinx-serialization-optin
...
Opt in to experimental kotlinx.serialization API locally
2 years ago
5fd5d17caf
Opt in to experimental kotlinx.serialization API locally
...
Change-Id: Ibc88151f5a8b7a3a82e2c0043839c1cb9e016bcf
2 years ago
738210166a
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
2 years ago
8c11769622
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
2 years ago
f914d6a412
Merge pull request #299 from android/refactor/remove_episodes
...
Remove episodes related code
2 years ago
3083c5e2ce
Merge branch 'github/main'
2 years ago
d89812ee90
Merge pull request #288 from android/caren/remove_search
...
Remove Search from top app bar
2 years ago
2531f1be9f
Merge branch 'github/main'
2 years ago
f16e9d011e
Merge pull request #272 from android/caren/fix_toggle_buttons
...
Fix toggle buttons interaction when using TalkBack
2 years ago
5de3f6156b
Spotless improvements
2 years ago
303d08dd28
Spotless improvements
2 years ago
cbdf6a2d3c
Remove episodes related code
2 years ago
6765d79065
Merge branch 'github/main'
2 years ago
bfedf75665
Remove Preview TODOs for Dolphin
...
Change-Id: I35219c7dd6a902c43cd310dcaf8d0e2c2dbdec45
2 years ago
6825138452
Merge pull request #294 from dturner/proto-list-to-map
...
Change user data fields to use maps instead of lists.
2 years ago
c4c01cf99b
Change user data fields to use maps instead of lists.
2 years ago
9ae03c3590
Fix the lint warnings
2 years ago
74737cad49
Introduce Multipreview annotation to simplify the preview configurations
...
- Bump the AGP version to 7.3.0
- Introduce Multipreview annotation class that represents device
previews and theme previews
Fixes #282
2 years ago
f76984539b
Fix toggle buttons interaction when using TalkBack
2 years ago
b74767921c
Remove Search from top app bar
2 years ago
4683918cc7
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
2 years ago
d0cff2b11c
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
2 years ago
3bd81154b5
Move 'core-' module to core subfolder
2 years ago
Milosz Moczkowski
Don Turner
TJ Dahunsi
ahmedmadhoun1
Simon Marquis
İbrahim Ethem Şen
İbrahim Ethem Şen
Tomáš Mlynarič
Simon Marquis
James Rose
Adetunji Dahunsi
Don Turner
Neelansh Sahai
Alex Vanyo
gururani-abhishek
Takeshi Hagikura
Márton Braun
Chris Sinco
Keisuke Takagi
Manuel Vivo
AlfianHanantio
Caren
Yuri Schimke
Angie Sasmita
Mohsen Rzna
magicalmeghan
Nick Rout
ratobing
Caren
Jolanda Verhoef
Marek Rzeźniczek
Simon Marquis
Saeed Noshadi
Abhimanyu14
Automerger
Ben Weiss
Ben Weiss
Wojtek Kaliciński
YvesKalume
madroid