Commit Graph

487 Commits (50b13ecb21138b76e14ff0b2f4cf1dcfda9d0f43)

Author SHA1 Message Date
Simon Marquis 8ea9a8fa51 Android Lint improvements
1 year ago
Adetunji Dahunsi f914254414
Merge pull request #749 from android/tj/reactive-only-dao
2 years ago
Don Turner d319264ef0 Provide Default dispatcher for instrumented tests
2 years ago
Don Turner b245334a18 Updating TestDataStoreModule to use ApplicationScope
2 years ago
TJ Dahunsi dcc36b0228 Fix tests
2 years ago
Don Turner 4cdb5963a0 Add top level application scope, use IO dispatcher for DataStore
2 years ago
TJ Dahunsi cd6ad7d575 Ensure DAO exposes only reactive types
2 years ago
Simon Marquis 823c4db201 Grant `POST_NOTIFICATIONS` permission in more instrumented tests
2 years ago
Don Turner f87e769b7d
Merge pull request #681 from SimonMarquis/di/coroutine-scope
2 years ago
Neelansh Sahai bbdc62cbf4
Merge pull request #706 from gururani-abhishek/remove-onItemClick-parameter
2 years ago
Alex Vanyo 76b0b08121 Adjust JDK setup to remove toolchain
2 years ago
Milosz Moczkowski e38e24eee9
Merge pull request #583 from SimonMarquis/jvmToolchain
2 years ago
Adetunji Dahunsi ba1d9e14df
Merge pull request #716 from SimonMarquis/SimonMarquis-patch-3
2 years ago
Don Turner a4eab289df
Merge pull request #719 from android/add-search-analytics
2 years ago
James Rose 2f2dfb00a4 Mark all news resources read on first sync
2 years ago
Don Turner 0e40e26f22 Add analytics for search queries
2 years ago
Simon Marquis ec9155fef9
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
Simon Marquis 7819a0c6bc
Extract common code to update the Flow value
2 years ago
Simon Marquis def5c4e881
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
Simon Marquis 76c249a651
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
Simon Marquis f34ee1c01b
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
Simon Marquis de6545f5d7
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
2 years ago
TJ Dahunsi 6e6abd0326 Fix build
2 years ago
TJ Dahunsi 9562f7707d Route notification deep link through for you screen, with spotless fixes
2 years ago
TJ Dahunsi ef97cb941c Route notification deep link through for you screen
2 years ago
TJ Dahunsi 8a3a16de21 Add pending intent for opening notification links
2 years ago
TJ Dahunsi 2499c0a0bd Notify users when news are updated
2 years ago
Simon Marquis ddabba8e4a
Merge branch 'main' into jvmToolchain
2 years ago
gururani-abhishek f6bdba08d9 added comment to document what happens on tapping news resource card.
2 years ago
gururani-abhishek bbc80bb0e2 added back launchCustomChromeTab()
2 years ago
gururani-abhishek 51379a249d fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
2 years ago
Don Turner 2fd1b716f6
Merge pull request #667 from SimonMarquis/cleanup/warnings
2 years ago
Milosz Moczkowski c746b6afcd
Merge pull request #598 from takagimeow/fix/clean-up-unused-update-topics
2 years ago
Simon Marquis 1341f7c2c5 Replace unused variable with simpler method calls
2 years ago
Simon Marquis 459717f8ba Remove `DSL_SCOPE_VIOLATION` suppression as it is now fixed in Gradle 8.1
2 years ago
Don Turner e1ae12129a
Merge pull request #662 from android/av/agp-8.0
2 years ago
Takeshi Hagikura b3cdc172cd
Implement search feature (#685)
2 years ago
Adetunji Dahunsi 73a38720d8
Merge pull request #649 from android/tj/backend-requested-sync
2 years ago
Adetunji Dahunsi 6b834b6f4c Applied code review suggestions
2 years ago
Adetunji Dahunsi b3f2502ec2
Update core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt
2 years ago
Adetunji Dahunsi f86d174c1b Used more explicit variable names in tests
2 years ago
Adetunji Dahunsi 337c940d66 Add comments explaining backend sync and made variable names easier to grok
2 years ago
Adetunji Dahunsi 022cd92f4c
Update core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepository.kt
2 years ago
Simon Marquis 5a43b4b74e Run Spotless
2 years ago
Simon Marquis aa701064a2 Add Application-wide `CoroutineScope` in the DI graph
2 years ago
Simon Marquis 9499e559e7
Delete no longer used `AUTHORS_ASSET` reference
2 years ago
Milosz Moczkowski 6bf37adde9
Merge pull request #671 from android/kotlin-version-updates
2 years ago
Márton Braun bea2eecd90 Update Kotlin, Compose compiler, serialization versions
2 years ago
Adetunji Dahunsi 05be2855d8 Wire up backend requested sync
2 years ago
James Rose 93953c2206 Add missing method doc
2 years ago
James Rose 050db2cb72 Merge branch 'main' into jr/track-viewed
2 years ago
James Rose b49767a88c Rename getUserNewsResources to observeAll
2 years ago
Alex Vanyo 086dc957c0 Update to AGP 8.0
2 years ago
Milosz Moczkowski feafb5fbed
Merge pull request #575 from takagimeow/fix/provide-true-to-local-inspection-mode
2 years ago
Milosz Moczkowski 2b2f6d48ce
Merge pull request #600 from takagimeow/cleanup-unused-args
2 years ago
Milosz Moczkowski 0b0fdbfdbf
Merge branch 'main' into patch-2
2 years ago
Adetunji Dahunsi 08956492c8 Backend triggered sync
2 years ago
Milosz Moczkowski ba6a697844
Merge pull request #624 from SimonMarquis/gradle-sort
2 years ago
Chris Sinco 93c01ad184 Fix trailing commas based on spotless check
2 years ago
Chris Sinco 049750dd51 Merge branch 'main' into ui-polish
2 years ago
James Rose 57c13d84bd Incorporate code review changes: Move UserNewsResourceRepository to data
2 years ago
Simon Marquis 8ec54d19d8 Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
2 years ago
James Rose ebfbb5bafd Display unread state on the news feed and bottom nav bar
2 years ago
James Rose bd450099fb Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository
2 years ago
James Rose 9ee2acf327 Add viewed status for news resources to data layer
2 years ago
Adetunji Dahunsi ebdb8589a6
Merge pull request #608 from android/tunjid-batch-sync
2 years ago
Keisuke Takagi d56d8e1380 Merge branch 'main' of https://github.com/takagimeow/nowinandroid into fix/clean-up-unused-update-topics
2 years ago
Don Turner 6d1f85b8ce
Merge pull request #607 from android/mv/tests
2 years ago
Adetunji Dahunsi 8765d3ac57 Fix tests for batched news resource sync
2 years ago
Adetunji Dahunsi 1e8d1d9810
Spotless fix
2 years ago
Adetunji Dahunsi 267adfd27f
Batch sync news resources from remote
2 years ago
Alex Vanyo 0844d021b9
Merge pull request #603 from amalhanaja/redundant-managed-device
2 years ago
Manuel Vivo 755413bfc5 Fix spotless
2 years ago
Manuel Vivo 91633af376 Provide a CoroutineScope to fake DataStores
2 years ago
Don Turner 2f3fc85d65 Make Hilt provide Firebase.analytics
2 years ago
AlfianHanantio bcd4a6de59 Remove redundant code block for managed virtual device creation
2 years ago
Keisuke Takagi 072364e7f1 remove newsResourceTitle
2 years ago
Keisuke Takagi 0a748bc899 Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/clean-up-unused-update-topics
2 years ago
Adetunji Dahunsi ae58d1e1b0
Merge pull request #592 from android/tj/news-resource-query
2 years ago
Adetunji Dahunsi 09f5c3bc61 Add NewsResourceQuery to better query encapsulation
2 years ago
Keisuke Takagi 86c021a54a remove invalid overriding method
2 years ago
Keisuke Takagi fb32580e0c remove unused updateNewsResources method
2 years ago
Keisuke Takagi 67412b2720 remove invalid overriding method
2 years ago
Keisuke Takagi 1489bf66e3 remove unused updateTopics method
2 years ago
Caren 6a5feb767e
Merge pull request #582 from yschimke/loaders
2 years ago
Keisuke Takagi 8b51107d7a Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/provide-true-to-local-inspection-mode
2 years ago
Simon Marquis e1f8c51c05 Configure jvmToolchain on the single Kotlin jvm project
2 years ago
Yuri Schimke 4fa730098d Fixes
2 years ago
Yuri Schimke 9e399b69ea Improve network pooling and avoid startup image fetches.
2 years ago
Don Turner 4284e6912e Merge remote-tracking branch 'github/main' into feb9automerger
2 years ago
Márton Braun 237375f52a Remove unused DropdownMenu component
2 years ago
Márton Braun 322ff63dbc Route topic chip tap events up to NiaNavHost
2 years ago
Don Turner 2a4d0434a5 Add Firebase analytics. See go/nia-firebase-services.
2 years ago
Keisuke Takagi 9091abf09e Provide true to LocalInspectionMode
2 years ago
Simon Marquis 3409f937ed Migrate custom room configuration into a convention plugin
2 years ago
Miłosz Moczkowski bcb4d7d592 Replace global variables with PreviewParameterProvider
2 years ago
Márton Braun 819dd494ad Run Spotless to add trailing commas (and apply other rule updates)
2 years ago
Angie Sasmita cfbf782613
Merge pull request #542 from android/as/dynamic-color-option
2 years ago
mlykotom 6b48b355cc Merge branch 'main' into tm/fix-benchmarks-no-people
2 years ago
Mohsen Rzna 46c1d510d4
Android-CI workflow -> GMD refactor (#537)
2 years ago
Angie Sasmita dbbe8ffecb Small fix for naming and boolean logic
2 years ago
Angie Sasmita 19efc1b5e8 Fix Spotless issue manually
2 years ago
Angie Sasmita 6046f6e943 Add dynamic color option in settings for API >=32
2 years ago
Takeshi Hagikura 4633609930
Introduce GMD + ATD (#479)
2 years ago
Don Turner bad3ea60f5 Refactor Topics news feed, tidy a few other bits up
2 years ago
magicalmeghan 45e3cfd989 fixed string issue for testTopicsChipColorBackground_matchesFollowedState test
2 years ago
magicalmeghan de6a4ec6c7 Merge remote-tracking branch 'github/mm/chipcolor' into mm/chipcolor
2 years ago
magicalmeghan 5137cd7777 removed hardcoded strings
2 years ago
Don Turner cafac8eb09 fix spotless, tidy test data
2 years ago
magicalmeghan 66046a86b0 Updated NewsResourceCardTest
2 years ago
Don Turner 6207fe3bcf mapToUserNewsResources converts List<NewsResource> to List<UserNewsResource>
2 years ago
Don Turner 24df51349d Move mapping logic into secondary constructor
2 years ago
Don Turner 355b0540aa Move construction of UserNewsResource into separate function
2 years ago
Don Turner 99227b06b5 Spotless
2 years ago
Don Turner 32bc5c1590 Fix merge conflicts
2 years ago
magicalmeghan ffb5aeba86 Added third draft of tests
2 years ago
magicalmeghan d9e18607be Added second draft of tests
2 years ago
magicalmeghan 8089866079 Added second draft of tests
2 years ago
Alex Vanyo ba11e6bf38
Merge pull request #491 from android/av/fix-background-composable
2 years ago
Chris Sinco 2f454de21c Spacing polish based on design spec
2 years ago
Don Turner 47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
2 years ago
Don Turner 0917cdebec Refactor NiaGradientBackground to accept GradientColors
2 years ago
Don Turner 1acee42167
Merge pull request #493 from andhiratobing/main
2 years ago
Don Turner cf053ade5a Fix build warnings
2 years ago
magicalmeghan 9a900f9900 Added first draft of tests
2 years ago
magicalmeghan a8f55d9d38 Renamed SaveableNewsResource to UserNewsResource
2 years ago
Don Turner 5638e253ae Fix unit and UI tests. Apply spotless.
2 years ago
magicalmeghan ec4bceead3 Renamed SaveableNewsResource to UserNewsResource
2 years ago
magicalmeghan 6941e2082b Renamed SaveableNewsResource to UserNewsResource
2 years ago
Nick Rout a1d0dfcaa5
Merge pull request #492 from ricknout/main
2 years ago
ratobing 1e493c0bbc Set visibility modifier of composable preview to private
2 years ago
Nick Rout c742aa3eca Fix issues with NiaTheme gradients and backgrounds
2 years ago
Nick Rout 7903f87dcc
Merge pull request #485 from ricknout/main
2 years ago
Nick Rout 9fd47261c9 Address design system PR feedback
2 years ago
Nick Rout cac02c418d Fix ThemeTest
2 years ago
Nick Rout 61bbd406c5 Fix ThemeTest
2 years ago
Nick Rout a34bc2d7c2 Fix spotless issues
2 years ago
Nick Rout be4ad40441 Fix spotless issues
2 years ago
Nick Rout c12fe1fbe5 Update :core-designsystem module based on Figma file
2 years ago
Caren 65fdb0c09c
Merge pull request #476 from android/caren/resource_type
2 years ago
Caren 4ff9c039b3 Rename NewsResourceDataAndType -> NewsResourceMetaData
2 years ago
Caren b05302fddd Fix tests
2 years ago
Caren 7d42831ee9
Merge pull request #465 from android/caren/custom_chrome_tab
2 years ago
Caren 352bac94fb run spotless
2 years ago
Caren 3712ba8c2f Add test and add string template in strings.xml for RTL purposes
2 years ago
Caren f563862df3 Rename NewsResourceDateAndNewsType -> NewsResourceDateAndType
2 years ago
Caren f150516b3c Display resource type for each news resource
2 years ago
mlykotom 90674c0c07 Add niaTopAppBar testTag
2 years ago
mlykotom 0018144827 LoadingWheel testTag for every loading wheel
2 years ago
Caren 1280565466 Add ColorInt annotation
2 years ago
Jolanda Verhoef 4ba63c0de8 Remove author concept from app
2 years ago
Caren 94e2bb0ec2 Run spotless
2 years ago
Caren 45f8e069c5 Implement custom chrome tabs in NewsResourceCardList as well
2 years ago
Caren 55c3ebd085 Use Chrome Custom tab for opening articles
2 years ago
Márton Braun 9c22a7a4e7 Remove `Stream` suffixes
2 years ago
Marek Rzeźniczek 7e0a154489 Migrate core:domain namespace to build.gradle file
2 years ago
Milosz Moczkowski a70761f24b
Merge pull request #441 from android/refactor/remote_fake_data_source
2 years ago
Mohsen Rzna c19b8b9319
New empty bookmarks handling (#443)
2 years ago
Simon Marquis a3c3b1af19
Configure `isReturnDefaultValues` for `:core:datastore`
2 years ago
Simon Marquis 23f414a05b
Configure `isReturnDefaultValues` to fix #448
2 years ago
Don Turner 9fa3dadcfd Fix comment
2 years ago
Adetunji Dahunsi 841f58ef26 Check active network for connectivity state each time network changes
2 years ago
Miłosz Moczkowski 6174a3a3ef Spotless apply
2 years ago
Miłosz Moczkowski 67fea35e6d Replace networkJson and FakeAssetManager with FakeNiaDataSource in all repositories
2 years ago
Miłosz Moczkowski e653b738d2 Remove FakeDataSource
2 years ago
Milosz Moczkowski c62673d035
Merge pull request #179 from Abhimanyu14/niaicons
2 years ago
Simon Marquis ee8eac34b8 Refactor `:core:network` DI
2 years ago
Simon Marquis 7e0bfb43fa Add missing binding in NetworkModule
2 years ago
Simon Marquis b5d342468e Merge remote-tracking branch 'fork/main' into patch/assets-as-json-files
2 years ago
Milosz Moczkowski cec83dc316
Merge pull request #431 from SaeedNoshadi89/show-all-news-authors
2 years ago
Saeed Noshadi adeb06c5ac
replace StringBuilder with joinToString
2 years ago
Saeed Noshadi dcce95ada6
remove unused import
2 years ago
Saeed Noshadi e44811f265
show all authors in the news card
2 years ago
Abhimanyu14 d69a37af7c Icons alignment to use NiaIcons
2 years ago
Simon Marquis 0e6f16e0a8 Fix spotless issues
2 years ago
Simon Marquis 321b1602e1 Remove duplicated link
2 years ago
Simon Marquis e128f9b877 Fix lint crash
2 years ago
Simon Marquis 67dea1c136 Fix spotless issues
2 years ago
Simon Marquis fbaa8eaff5 Migrate hard-coded JSON data into JSON assets files
2 years ago
Simon Marquis 90dc300783 Migrate from JUnit assertions to Kotlin's test framework
2 years ago
Don Turner 317c72af1a
Merge branch 'main' into fix/typos
2 years ago
Don Turner 86ef9ff594 Make updateShouldHideOnboardingIfNecessary private
2 years ago
Simon Marquis a680b14763 Fix typos
2 years ago
Don Turner 5b8c284c74 Rename hasDismissedOnboarding to shouldHideOnboarding
2 years ago
Don Turner 6654403498 Refactor onboarding to save interests to user data
2 years ago
Don Turner a9aa3eafab Add data from the last 10 episodes
2 years ago
Milosz Moczkowski 398c399c1c
Merge pull request #297 from android/av/remove-dolphin-preview-todos
2 years ago
Don Turner 7a223f5d8e
Merge pull request #356 from android/jv/compose-bom
2 years ago
Jolanda Verhoef e7b2ed623e Update to new Compose release
2 years ago
Don Turner dbff140b64 Fix minor issues
2 years ago
Don Turner 76daa393b1 Address review feedback from Manu
2 years ago
Don Turner cf4dd1fbff Added null branches for reading user data from datastore
2 years ago
Don Turner 8c30ab9f80 Add settings module, refactor top bar
2 years ago
Don Turner add486a0ab Fix spotless issues
2 years ago
Alex Vanyo 7e3faad699 Add data logic for theme switcher
2 years ago
Manuel Vivo a0b22d8ed2
Updates Navigation approach with new guidance (#347)
2 years ago
Automerger 9435c1cd79 Merge branch 'github/main'
2 years ago
Ben Weiss 7e6cb46436
Merge pull request #328 from android/bw/moreJankstats
2 years ago
Ben Weiss ee2e3db928
Add more jank tracking
2 years ago
Don Turner 7ca17f68ed
Merge branch 'main' into av/remove-dolphin-preview-todos
2 years ago
Automerger d0ba51efec Merge branch 'github/main'
2 years ago
Don Turner f3debd0af1 Merge "Add domain layer. See go/nia-domain-layer for details." into main
2 years ago
Don Turner 4a4de7d6a4 Add domain layer. See go/nia-domain-layer for details.
2 years ago
Don Turner 40c0cb2a03
Merge pull request #332 from android/kotlin-1720
2 years ago
Wojtek Kaliciński dcc23829d4 Migrate packages to namespaces in build files
2 years ago
Márton Braun 02c052e7f4 Update Kotlin to 1.7.20
2 years ago
Adetunji Dahunsi 8dbd53c898
Merge pull request #311 from yveskalume/main
2 years ago
YvesKalume b05ea4724c fix failling tests
2 years ago
Don Turner 6351a89545
Merge pull request #310 from android/documentation/dep_graphs
2 years ago
YvesKalume 4006d8d40a update : remove unused upsert method.
2 years ago
Adetunji Dahunsi 9371d0d4b8
Merge pull request #304 from android/tj/sync-ui
2 years ago
YvesKalume d094e96a72 update : Use @Upsert from Room instead of a custom helper
2 years ago
Adetunji Dahunsi c4debb74e7 Give feedback when syncing on ForYouScreen
2 years ago
Milosz Moczkowski 06e60063b5 Add dependency graphs to every module
2 years ago
Márton Braun f68a112cfe
Merge pull request #307 from android/update-kotlinx-serialization-optin
2 years ago
Márton Braun 5fd5d17caf Opt in to experimental kotlinx.serialization API locally
2 years ago
Alex Vanyo 738210166a Refine backgrounds and navigation colors
2 years ago
Alex Vanyo 8c11769622 Update to material3 1.0.0-beta03 wih built-in insets support
2 years ago
Milosz Moczkowski f914d6a412
Merge pull request #299 from android/refactor/remove_episodes
2 years ago
Automerger 3083c5e2ce Merge branch 'github/main'
2 years ago
Caren d89812ee90
Merge pull request #288 from android/caren/remove_search
2 years ago
Automerger 2531f1be9f Merge branch 'github/main'
2 years ago
Caren f16e9d011e
Merge pull request #272 from android/caren/fix_toggle_buttons
2 years ago
Milosz Moczkowski 5de3f6156b Spotless improvements
2 years ago
Milosz Moczkowski 303d08dd28 Spotless improvements
2 years ago
Milosz Moczkowski cbdf6a2d3c Remove episodes related code
2 years ago
Automerger 6765d79065 Merge branch 'github/main'
2 years ago
Alex Vanyo bfedf75665 Remove Preview TODOs for Dolphin
2 years ago
Don Turner 6825138452
Merge pull request #294 from dturner/proto-list-to-map
2 years ago
Don Turner c4c01cf99b Change user data fields to use maps instead of lists.
2 years ago
Takeshi Hagikura 9ae03c3590 Fix the lint warnings
2 years ago
Takeshi Hagikura 74737cad49 Introduce Multipreview annotation to simplify the preview configurations
2 years ago
Caren Chang f76984539b Fix toggle buttons interaction when using TalkBack
2 years ago
Caren Chang b74767921c Remove Search from top app bar
2 years ago
Wojtek Kaliciński 4683918cc7 Move spotless to init script
2 years ago
Wojtek Kaliciński d0cff2b11c Build cleanup
2 years ago
madroid 3bd81154b5 Move 'core-' module to core subfolder
2 years ago