b9757b3411
remove ktx import from FirebaseAnalyticsHelper.kt
1 year ago
b2c1c11218
Update MainDispatcherRule.kt
...
Updated MainDispatcherRule parameter accessibility to private because its only needs to be accessible inside that class.
1 year ago
89863c3f87
Fix formatting issues
...
Change-Id: Ia90a4aad72db737455b70de9b4583689d6a0e5d6
1 year ago
9f26813697
upgrade to Firebase BoM 32.5.0 and drop Firebase KTX
1 year ago
78573b8efc
Merge pull request #972 from tjmtic/now-update-888
...
Update primitive mutable states to mutableState API where applicable
1 year ago
5482d81fdc
fixed for PR 985
1 year ago
2b84fafcf7
Merge remote-tracking branch 'upstream/main' into now-update-888
1 year ago
245723b5b2
Fix compiler warning: Remove single lambda parameter declaration
1 year ago
0287af8d9a
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
1 year ago
7fc67c2915
Update compose-runtime version; Update primitive mutable states to mutableState API where applicable
1 year ago
a381d13199
Merge pull request #958 from McGalanes/main
...
Use typesafe project accessors
1 year ago
301661ce86
Merge pull request #959 from McGalanes/convention-plugins-toml
...
Add convention plugins to version catalogs
1 year ago
1d0435832d
Fix spotless
...
Change-Id: Ia931fc5662af50a6045a51783d72cb5b68e2486a
1 year ago
beaa85739d
Address PR feedback
...
Change-Id: I50b49d3e216535e384b64849f915b37f6e2acbbc
1 year ago
6e96d30519
Merge pull request #912 from lihenggui/main
...
Upgrade Gradle to v8.3
1 year ago
5612396290
Fit typo in SystemTrayNotifier.kt
1 year ago
6247712064
Add convention plugins to version catalogs
1 year ago
b1266dc05a
Use typesafe project accessors for project modules
1 year ago
77451779cd
Use animateItemPlacement() on feed
...
Change-Id: Id120a6e84e0641679fa54ebf0e34bb04165aa419
1 year ago
8b759ae569
Fix spotless
...
Change-Id: I7ee8bc84beb38d00983aa7b0da3f3073e1249992
1 year ago
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
1 year ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
1 year ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
1 year ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
1 year ago
151f877bbe
Adds screenshot tests to :core:designsystem ( #931 )
...
* WIP: Adds screenshot tests to :core:designsystem
Change-Id: I0672845feba4064652dd8d60f07047b87864e121
* 🤖 Updates screenshots
* Creates tests for more components and cleans up
Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22
* WIP: More cleanup and more combinations of themes
Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523
* Added the rest of the screenshot tests for designsystem
Change-Id: Ic427db5491910781c038882055524e3f3dbed194
* Some more cleanup
Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180
* Spotless
Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6
* 🤖 Updates screenshots
* ScreenshotHelper cleanup
Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0
1 year ago
d0909a9c8f
Merge pull request #925 from SimonMarquis/remove-dispatcher
...
Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository`
1 year ago
0ddcf0b4ab
Remove unnecessary dispatcher switch in `DefaultRecentSearchRepository`
...
As mentioned in the following discussion: https://github.com/android/nowinandroid/discussions/818
Room already takes care of switching dispatchers if the DAO method is correctly annotated with the `suspend` modifier.
1 year ago
298f3ce4db
Merge branch 'android:main' into main
1 year ago
c98e6236d5
Replace identical `InstantSerializer` with KotlinX datetime default serializer
1 year ago
5b79869324
Adds dark screenshot tests and fixes background colors in ForYou ( #918 )
...
* Adds dark screenshot tests and fixes background colors in ForYou
* 🤖 Updates screenshots
1 year ago
4e6cda1965
Renamed toggle function signature with boolean parameters
...
Change-Id: I0d6c0ed4d4c0ee4bd387e5645fc558970f5f202b
1 year ago
c57fb78fa7
Merge pull request #759 from SimonMarquis/lint/sarif
...
Android Lint improvements
1 year ago
886158d3cb
Adds Screenshot testing with Roborazzi ( #876 )
...
* Adds screenshot tests using Roborazzi (Robolectric Native Graphics)
- Adds Roborazzi to convention plugins
- Adds Screenshot helper in :core-testing
- Creates screenshot suites for :app and :feature-foryou
* CI and spotless
* Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier
* CI: Moves local tests to their own step
* CI: Adds --rerun to screenshot task
* CI: Moves screenshots before local tests
* CI: Fixes wrong if statement in workflow
* CI WIP: trying to trigger the push step
* CI: Re-enables roborazzi verification
* Fixes flaky screenshot tests by setting LocalInspectionMode on
* CI: screenshot commits now use the original author intead of bot account
* CI: Disables globbing because file_pattern didn't work
* CI: Trying new file pattern for png files
* CI: Adds a check for forks
* 🤖 Updates screenshots
* Code review: toml cleanup, comments
* Use new github.event.pull_request.head.repo.fork
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Uses Robolectric qualifiers to set the dpi, adds section to README
* Spotless
* Delegates creation of repository to Hilt in test
* Revert "Use new github.event.pull_request.head.repo.fork"
* 🤖 Updates screenshots
* Empty commit to trigger GHA on main branch
* Makes time zones deterministic in screenshot tests
* Increases GMD timeout to 90m, but it has to be reduced
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
1 year ago
fcc49d141d
Upgrade Gradle to v8.3
1 year ago
928833fe5d
Merge pull request #889 from RivanParmar/main
...
Rename SearchResult.kt.kt to SearchResult.kt
1 year ago
6c0d6ad82e
Fixes icons size in onboarding and restores LocalInspection for images ( #909 )
...
* Fixes icons size in onboarding and restores LocalInspection for images
1 year ago
0ced769999
Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values
1 year ago
4a5ec5bd82
Update `var` with fake default value to the more "correct" `lateinit var`
1 year ago
f1bc6f1226
Restore `Unknown` type as empty `String`
1 year ago
c831dc673c
Fix broken text
1 year ago
daa2228132
Restore original `type` labels
1 year ago
480d8e7d7c
Fix missing removal
1 year ago
553b01fcb6
spotlessApply
1 year ago
0377fd8712
Replace `NewsResourceType` enum with simpler String type
...
See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901
1 year ago
153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
...
Fix #849 : Loading progress for image
1 year ago
9e1d46e28c
Rename SearchResult.kt.kt to SearchResult.kt
1 year ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
1 year ago
308f51f87d
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
1 year ago
2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
1 year ago
5d7e33d905
fix formatting
1 year ago
8901e5932a
Merge pull request #872 from SimonMarquis/data-objects
...
Convert 'sealed' sub-object to 'data object'
1 year ago
0e13207a40
Merge pull request #874 from SimonMarquis/string-decoder
...
Replace StringDecoder injection with simpler API
1 year ago
f203e9a218
feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
1 year ago
5abc69fb49
Merge branch 'android:main' into loading-progress-for-image
1 year ago
4d0efef3b4
Merge pull request #879 from tatsuyafujisaki/rename-constants
...
Rename constants
1 year ago
a23ffab602
fix: add label to animations for fixing lint issue
1 year ago
8aa0457ca9
Merge branch 'android:main' into loading-progress-for-image
1 year ago
4eeb045287
Rename constants
1 year ago
ec53d03854
Merge pull request #722 from android/tj/scrollbars
...
Add scrollbars to app
1 year ago
e8449112b4
Replace StringDecoder injection with simpler API
...
The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String.
For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`).
Unit tests would fail because Uri is not mocked (since we are not using Robolectric).
Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc.
FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded".
The solution to this problem was to simply use regular Java APIs:
- `URLDecoder.decode(urlEncodedTopicId, "UTF-8")`
- `URLEncoder.encode(topicId, "UTF-8")`
1 year ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
1 year ago
b7799f0475
Convert 'sealed' sub-object to 'data object'
1 year ago
5bbcc904e9
feat: make painter in one line
1 year ago
3595d8dcb5
feat: move the placeholder default value to the method
1 year ago
9f3103c212
Merge branch 'android:main' into loading-progress-for-image
1 year ago
c779b4e8ca
Typo fix for topics
...
tocpis -> topics
1 year ago
e276212574
feat: remove check if placeholder null and put a default placeholder if its not passed.
1 year ago
9c1ec17a39
fix: modifier to Modifier
1 year ago
57025e7587
fix: review notes
1 year ago
8a197800c5
feat: fix format issue
1 year ago
f4859e0bcd
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
1 year ago
06e91fd623
Merge branch 'android:main' into loading-progress-for-image
1 year ago
a294adb6b9
feat: fix format issue
1 year ago
48041fcaa4
Merge pull request #835 from blackbracken/avoid_retrieving_unnecessary_entity
...
Call getNewsResourceIds instead of getNewsResources
1 year ago
7a05f7db96
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
3284eb68a3
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
42b16bf7be
Merge remote-tracking branch 'origin/main'
1 year ago
ee8b70003d
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
9babb50c58
Interact with scrollbar only if drag direction matches scrollbar orientation
...
Change-Id: I8fb5a64098ea83458d25fd2b7363a6b5dd3fef2f
1 year ago
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
1 year ago
806726a7f0
PR feedback
...
Change-Id: I6e9f4a2ba53e81d32d07e229eb848541801eca18
1 year ago
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
1 year ago
2dba522663
Check if first item size == 0
...
Change-Id: I41acffad84d9db1cf407f77b04530643933f98bf
1 year ago
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
1 year ago
ce6eaa9d64
Fix spotless
1 year ago
4858167b24
Added clarifying comments to code and used better variable names
1 year ago
bda31e9d15
Default scrollbars to dormant
1 year ago
d6a265093d
Extract scrollbar values to constants
1 year ago
795c5e32a9
Add hoverable to scrollbar
1 year ago
31b4841cb2
Add scrollbars to app
1 year ago
56389cb760
Merge pull request #752 from SimonMarquis/kotlin-1.9.0
...
Kotlin 1.9.0
1 year ago
f7ed38182d
Add protobuf generated sources to the sourceSets
...
And update to version 3.23.4.
1 year ago
b570be2abb
reformat by spotless
1 year ago
e9a16e437d
add kdoc for getNewsResourceIds
1 year ago
805914dade
Call getNewsResourceIds instead of getNewsResources
1 year ago
7b6c3a16ca
Merge pull request #823 from ahmed-madhoun1/allow_localised_date_format
...
Allow localised date format
1 year ago
b2a74ba174
Merge pull request #812 from Askeri-Muhendis/main
...
Kotlin Coding conventions
2 years ago
c4686cfa54
Track when deep link notifications are opened
...
Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91
2 years ago
3114b2eeaa
Allow localised date format
2 years ago
d136965a0d
Merge branch 'main' into lint/sarif
2 years ago
6271d1c4c0
Merge branch 'android:main' into main
2 years ago
56f8a27132
Kotlin coding conventions places companion object at the bottom of the class
2 years ago
8e1e994bb1
Add named arguments
...
Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91
2 years ago
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
2 years ago
8e708cca05
Merge branch 'main' into lint/sarif
2 years ago
7826b4f5f2
Merge pull request #748 from SimonMarquis/fix/permissions
...
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
2 years ago
890c0f5769
Merge pull request #776 from SimonMarquis/fix/714
...
Keep track of matching `Network`s inside `NetworkCallback`
2 years ago
27154ef38a
Apply changes from review comments
2 years ago
479a2f00b0
Refactor icons
2 years ago
1345764649
Merge pull request #770 from android/refactor/remove_unused_statements
...
Remove unused statements
2 years ago
fecab96e4c
Keep track of matching `Network`s inside `NetworkCallback`
...
This will ensure the connectivity state remains synchronized with the `ConnectivityManager`.
Fixes #714
2 years ago
99094199bc
Remove redundant suppressions
...
Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef
2 years ago
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
2 years ago
9aba5cc0fe
Cleanup unused string resources
2 years ago
8ea9a8fa51
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
2 years ago
f914254414
Merge pull request #749 from android/tj/reactive-only-dao
...
Ensure DAO exposes only reactive types
2 years ago
d319264ef0
Provide Default dispatcher for instrumented tests
...
Change-Id: I488a9b9d9d3864ce9496614ab35332ec19d06bcc
2 years ago
b245334a18
Updating TestDataStoreModule to use ApplicationScope
2 years ago
dcc36b0228
Fix tests
...
Change-Id: Ie6b62071d2023e3a7ffe1553ab606e3f6b386a5e
2 years ago
4cdb5963a0
Add top level application scope, use IO dispatcher for DataStore
...
Change-Id: I1512b1665587c73abd5e8a78aa9abd3eed24ab79
2 years ago
cd6ad7d575
Ensure DAO exposes only reactive types
...
Change-Id: I8992ccf6525cd4c5ea9503d532b500e4d310b7fb
2 years ago
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
2 years ago
f87e769b7d
Merge pull request #681 from SimonMarquis/di/coroutine-scope
...
Add Application-wide `CoroutineScope` in the DI graph
2 years ago
bbdc62cbf4
Merge pull request #706 from gururani-abhishek/remove-onItemClick-parameter
...
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
2 years ago
76b0b08121
Adjust JDK setup to remove toolchain
...
Change-Id: Ie0f43cb8f0fe504ed3e98ef35703949959688699
2 years ago
e38e24eee9
Merge pull request #583 from SimonMarquis/jvmToolchain
...
Configure jvmToolchain for Android and Kotlin projects
2 years ago
ba1d9e14df
Merge pull request #716 from SimonMarquis/SimonMarquis-patch-3
...
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
2 years ago
a4eab289df
Merge pull request #719 from android/add-search-analytics
...
Add analytics for search queries
2 years ago
2f2dfb00a4
Mark all news resources read on first sync
...
Otherwise, there will be unread articles until the user clicks through
every article that has ever been published.
2 years ago
0e40e26f22
Add analytics for search queries
...
Change-Id: If5290a903afb928fc1c3aaa66a52d2f182aba118
2 years ago
ec9155fef9
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
7819a0c6bc
Extract common code to update the Flow value
2 years ago
def5c4e881
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
76c249a651
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
f34ee1c01b
Update ConnectivityManagerNetworkMonitor.kt
2 years ago
de6545f5d7
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
2 years ago
6e6abd0326
Fix build
2 years ago
9562f7707d
Route notification deep link through for you screen, with spotless fixes
2 years ago
ef97cb941c
Route notification deep link through for you screen
2 years ago
8a3a16de21
Add pending intent for opening notification links
2 years ago
2499c0a0bd
Notify users when news are updated
2 years ago
ddabba8e4a
Merge branch 'main' into jvmToolchain
2 years ago
f6bdba08d9
added comment to document what happens on tapping news resource card.
2 years ago
bbc80bb0e2
added back launchCustomChromeTab()
2 years ago
51379a249d
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
...
1. removed the unused onItemClick parameter
2. removed now redundant variables it used
3. removed its description from the comments.
2 years ago
2fd1b716f6
Merge pull request #667 from SimonMarquis/cleanup/warnings
...
Cleanup warnings and replace deprecated methods
2 years ago
c746b6afcd
Merge pull request #598 from takagimeow/fix/clean-up-unused-update-topics
...
Clean up unused updateTopics and updateNewsResources methods
2 years ago
1341f7c2c5
Replace unused variable with simpler method calls
2 years ago
459717f8ba
Remove `DSL_SCOPE_VIOLATION` suppression as it is now fixed in Gradle 8.1
2 years ago
e1ae12129a
Merge pull request #662 from android/av/agp-8.0
...
Update to AGP 8.0
2 years ago
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
2 years ago
73a38720d8
Merge pull request #649 from android/tj/backend-requested-sync
...
Wire up backend requested sync
2 years ago
6b834b6f4c
Applied code review suggestions
...
Change-Id: I12fab8e0d27a8a1805e0063054ec3382bebd78f1
2 years ago
b3f2502ec2
Update core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
f86d174c1b
Used more explicit variable names in tests
...
Change-Id: I2e0ebead70441eced05eb786aaa7683bfefa8976
2 years ago
337c940d66
Add comments explaining backend sync and made variable names easier to grok
...
Change-Id: I90cd7444de95efa20bf243a922a772f7849a23ec
2 years ago
022cd92f4c
Update core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepository.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 years ago
5a43b4b74e
Run Spotless
2 years ago
aa701064a2
Add Application-wide `CoroutineScope` in the DI graph
...
Following the work of #607 .
2 years ago
9499e559e7
Delete no longer used `AUTHORS_ASSET` reference
2 years ago
6bf37adde9
Merge pull request #671 from android/kotlin-version-updates
...
Update Kotlin, Compose compiler, serialization versions
2 years ago
bea2eecd90
Update Kotlin, Compose compiler, serialization versions
...
Change-Id: I2aa0d07769e79e6f85824a391418566aef6b721e
2 years ago
05be2855d8
Wire up backend requested sync
...
Change-Id: I1d4485b589c7e94527a2a02f371cd3f030231622
2 years ago
93953c2206
Add missing method doc
2 years ago
050db2cb72
Merge branch 'main' into jr/track-viewed
2 years ago
b49767a88c
Rename getUserNewsResources to observeAll
2 years ago
086dc957c0
Update to AGP 8.0
...
Change-Id: I27eb106e484e2003d732782a39612dc72c845282
2 years ago
feafb5fbed
Merge pull request #575 from takagimeow/fix/provide-true-to-local-inspection-mode
...
Provide true to LocalInspectionMode
2 years ago
2b2f6d48ce
Merge pull request #600 from takagimeow/cleanup-unused-args
...
Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
2 years ago
0b0fdbfdbf
Merge branch 'main' into patch-2
2 years ago
08956492c8
Backend triggered sync
...
Change-Id: I53c43b136ebb755f6258b1e815301dddb3b536a3
2 years ago
ba6a697844
Merge pull request #624 from SimonMarquis/gradle-sort
...
Sort and group Gradle dependencies
2 years ago
93c01ad184
Fix trailing commas based on spotless check
2 years ago
049750dd51
Merge branch 'main' into ui-polish
2 years ago
57c13d84bd
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
2 years ago
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
2 years ago
ebfbb5bafd
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
2 years ago
bd450099fb
Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository
...
This moves the responsibility for joining the UserData and the
NewsResources to UserNewsResourceRepository. This way, the work can be
done once and shared with all consumers in a SharedFlow, rather than
having each consumer perform the join itself by invoking the UseCase.
2 years ago
9ee2acf327
Add viewed status for news resources to data layer
2 years ago
ebdb8589a6
Merge pull request #608 from android/tunjid-batch-sync
...
Batch sync news resources from remote
2 years ago
d56d8e1380
Merge branch 'main' of https://github.com/takagimeow/nowinandroid into fix/clean-up-unused-update-topics
2 years ago
6d1f85b8ce
Merge pull request #607 from android/mv/tests
...
Provide a CoroutineScope to fake DataStores
2 years ago
8765d3ac57
Fix tests for batched news resource sync
...
Change-Id: I37545eba8618edc936eb12fa38628d98f85f52ed
2 years ago
1e8d1d9810
Spotless fix
...
Thought I was cool enough to edit code in the browser. Spotless said no.
2 years ago
267adfd27f
Batch sync news resources from remote
...
Batch sync news resources from remote to reduce json payload size.
2 years ago
0844d021b9
Merge pull request #603 from amalhanaja/redundant-managed-device
...
Remove redundant code block for managed virtual device creation
2 years ago
755413bfc5
Fix spotless
2 years ago
91633af376
Provide a CoroutineScope to fake DataStores
2 years ago
2f3fc85d65
Make Hilt provide Firebase.analytics
...
Change-Id: I57bec82713ce7ce3a17cd4ad0f377c28c2aedb89
2 years ago
bcd4a6de59
Remove redundant code block for managed virtual device creation
2 years ago
072364e7f1
remove newsResourceTitle
2 years ago
0a748bc899
Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/clean-up-unused-update-topics
2 years ago
ae58d1e1b0
Merge pull request #592 from android/tj/news-resource-query
...
Add NewsResourceQuery to better query encapsulation
2 years ago
09f5c3bc61
Add NewsResourceQuery to better query encapsulation
...
Change-Id: I93f8c8ae2d1144975f6f9ff1ba93be9a4600768a
2 years ago
86c021a54a
remove invalid overriding method
2 years ago
fb32580e0c
remove unused updateNewsResources method
2 years ago
67412b2720
remove invalid overriding method
2 years ago
1489bf66e3
remove unused updateTopics method
2 years ago
6a5feb767e
Merge pull request #582 from yschimke/loaders
...
Improve network pooling and avoid startup image fetches.
2 years ago
8b51107d7a
Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/provide-true-to-local-inspection-mode
...
Conflicts:
core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt
2 years ago
rosariopf
Mario Manhique
Don Turner
Adetunji Dahunsi
Jonathan Koren
TM
Simon Marquis
Don Turner
dahunsi
Minseong Kim
Melwin Magalhaes
Simon Marquis
Jose Alcérreca
Roy Matero
Roy Matero
Milosz Moczkowski
lihenggui
RivanParmar
qamarelsafadi
Qamar A. Safadi
AlirezaJoon
Tatsuya Fujisaki
prosixe
TJ Dahunsi
Márton Braun
blackbracken
ahmedmadhoun1
İbrahim Ethem Şen
İbrahim Ethem Şen
Tomáš Mlynarič
James Rose
Neelansh Sahai
Alex Vanyo
gururani-abhishek
Takeshi Hagikura
Chris Sinco
Keisuke Takagi
Manuel Vivo
AlfianHanantio
Caren