Commit Graph

465 Commits (dependabot/gradle/androidxLifecycle-2.8.0)

Author SHA1 Message Date
Simon Marquis 0ced769999 Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values
11 months ago
Simon Marquis 4a5ec5bd82 Update `var` with fake default value to the more "correct" `lateinit var`
11 months ago
Simon Marquis f1bc6f1226 Restore `Unknown` type as empty `String`
11 months ago
Simon Marquis c831dc673c
Fix broken text
11 months ago
Simon Marquis daa2228132 Restore original `type` labels
11 months ago
Simon Marquis 480d8e7d7c Fix missing removal
11 months ago
Simon Marquis 553b01fcb6 spotlessApply
11 months ago
Simon Marquis 0377fd8712 Replace `NewsResourceType` enum with simpler String type
11 months ago
Adetunji Dahunsi 153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
11 months ago
RivanParmar 9e1d46e28c Rename SearchResult.kt.kt to SearchResult.kt
11 months ago
Don Turner 492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
11 months ago
qamarelsafadi 308f51f87d Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
11 months ago
Qamar A. Safadi 2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
11 months ago
qamarelsafadi 5d7e33d905 fix formatting
11 months ago
Don Turner 8901e5932a
Merge pull request #872 from SimonMarquis/data-objects
11 months ago
Don Turner 0e13207a40
Merge pull request #874 from SimonMarquis/string-decoder
11 months ago
qamarelsafadi f203e9a218 feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
11 months ago
Qamar A. Safadi 5abc69fb49
Merge branch 'android:main' into loading-progress-for-image
11 months ago
Don Turner 4d0efef3b4
Merge pull request #879 from tatsuyafujisaki/rename-constants
11 months ago
AlirezaJoon a23ffab602 fix: add label to animations for fixing lint issue
11 months ago
Qamar A. Safadi 8aa0457ca9
Merge branch 'android:main' into loading-progress-for-image
11 months ago
Tatsuya Fujisaki 4eeb045287 Rename constants
11 months ago
Adetunji Dahunsi ec53d03854
Merge pull request #722 from android/tj/scrollbars
11 months ago
Simon Marquis e8449112b4 Replace StringDecoder injection with simpler API
11 months ago
Simon Marquis 4bdc9705af Fix miscellaneous warnings
11 months ago
Simon Marquis b7799f0475 Convert 'sealed' sub-object to 'data object'
11 months ago
qamarelsafadi 5bbcc904e9 feat: make painter in one line
11 months ago
qamarelsafadi 3595d8dcb5 feat: move the placeholder default value to the method
11 months ago
Qamar A. Safadi 9f3103c212
Merge branch 'android:main' into loading-progress-for-image
11 months ago
prosixe c779b4e8ca Typo fix for topics
12 months ago
qamarelsafadi e276212574 feat: remove check if placeholder null and put a default placeholder if its not passed.
12 months ago
qamarelsafadi 9c1ec17a39 fix: modifier to Modifier
12 months ago
qamarelsafadi 57025e7587 fix: review notes
12 months ago
qamarelsafadi 8a197800c5 feat: fix format issue
12 months ago
qamarelsafadi f4859e0bcd Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
12 months ago
Qamar A. Safadi 06e91fd623
Merge branch 'android:main' into loading-progress-for-image
12 months ago
qamarelsafadi a294adb6b9 feat: fix format issue
12 months ago
Adetunji Dahunsi 48041fcaa4
Merge pull request #835 from blackbracken/avoid_retrieving_unnecessary_entity
12 months ago
qamarelsafadi 7a05f7db96 feat: Show loading progress for Image Component as a solve for
12 months ago
qamarelsafadi 3284eb68a3 feat: Show loading progress for Image Component as a solve for
12 months ago
qamarelsafadi 42b16bf7be Merge remote-tracking branch 'origin/main'
12 months ago
Qamar Safadi ee8b70003d feat: Show loading progress for Image Component as a solve for
12 months ago
TJ Dahunsi 9babb50c58 Interact with scrollbar only if drag direction matches scrollbar orientation
12 months ago
TJ Dahunsi e13e84c155 Replace usages of 'displacement' to 'moved' in parameter names
12 months ago
TJ Dahunsi 806726a7f0 PR feedback
12 months ago
TJ Dahunsi eeb4973265 PR feedback
12 months ago
TJ Dahunsi 2dba522663 Check if first item size == 0
12 months ago
TJ Dahunsi cb1d50e65e Even better names
12 months ago
TJ Dahunsi ce6eaa9d64 Fix spotless
12 months ago
TJ Dahunsi 4858167b24 Added clarifying comments to code and used better variable names
12 months ago
TJ Dahunsi bda31e9d15 Default scrollbars to dormant
12 months ago
TJ Dahunsi d6a265093d Extract scrollbar values to constants
12 months ago
TJ Dahunsi 795c5e32a9 Add hoverable to scrollbar
12 months ago
TJ Dahunsi 31b4841cb2 Add scrollbars to app
12 months ago
Márton Braun 56389cb760
Merge pull request #752 from SimonMarquis/kotlin-1.9.0
12 months ago
Simon Marquis f7ed38182d Add protobuf generated sources to the sourceSets
12 months ago
blackbracken b570be2abb reformat by spotless
12 months ago
blackbracken e9a16e437d add kdoc for getNewsResourceIds
12 months ago
blackbracken 805914dade Call getNewsResourceIds instead of getNewsResources
1 year ago
Milosz Moczkowski 7b6c3a16ca
Merge pull request #823 from ahmed-madhoun1/allow_localised_date_format
1 year ago
Don Turner b2a74ba174
Merge pull request #812 from Askeri-Muhendis/main
1 year ago
TJ Dahunsi c4686cfa54 Track when deep link notifications are opened
1 year ago
ahmedmadhoun1 3114b2eeaa Allow localised date format
1 year ago
Simon Marquis d136965a0d Merge branch 'main' into lint/sarif
1 year ago
İbrahim Ethem Şen 6271d1c4c0
Merge branch 'android:main' into main
1 year ago
İbrahim Ethem Şen 56f8a27132 Kotlin coding conventions places companion object at the bottom of the class
1 year ago
Tomáš Mlynarič 8e1e994bb1 Add named arguments
1 year ago
Tomáš Mlynarič 4a8a43551a Add contentType to news feed
1 year ago
Simon Marquis 8e708cca05
Merge branch 'main' into lint/sarif
1 year ago
James Rose 7826b4f5f2
Merge pull request #748 from SimonMarquis/fix/permissions
1 year ago
Adetunji Dahunsi 890c0f5769
Merge pull request #776 from SimonMarquis/fix/714
1 year ago
Simon Marquis 27154ef38a Apply changes from review comments
1 year ago
Miłosz Moczkowski 479a2f00b0 Refactor icons
1 year ago
Milosz Moczkowski 1345764649
Merge pull request #770 from android/refactor/remove_unused_statements
1 year ago
Simon Marquis fecab96e4c Keep track of matching `Network`s inside `NetworkCallback`
1 year ago
Miłosz Moczkowski 99094199bc Remove redundant suppressions
1 year ago
Miłosz Moczkowski 5bf66739bd Remove redundant statements
1 year ago
Simon Marquis 9aba5cc0fe Cleanup unused string resources
1 year ago
Simon Marquis 8ea9a8fa51 Android Lint improvements
1 year ago
Adetunji Dahunsi f914254414
Merge pull request #749 from android/tj/reactive-only-dao
1 year ago
Don Turner d319264ef0 Provide Default dispatcher for instrumented tests
1 year ago
Don Turner b245334a18 Updating TestDataStoreModule to use ApplicationScope
1 year ago
TJ Dahunsi dcc36b0228 Fix tests
1 year ago
Don Turner 4cdb5963a0 Add top level application scope, use IO dispatcher for DataStore
1 year ago
TJ Dahunsi cd6ad7d575 Ensure DAO exposes only reactive types
1 year ago
Simon Marquis 823c4db201 Grant `POST_NOTIFICATIONS` permission in more instrumented tests
1 year ago
Don Turner f87e769b7d
Merge pull request #681 from SimonMarquis/di/coroutine-scope
1 year ago
Neelansh Sahai bbdc62cbf4
Merge pull request #706 from gururani-abhishek/remove-onItemClick-parameter
1 year ago
Alex Vanyo 76b0b08121 Adjust JDK setup to remove toolchain
1 year ago
Milosz Moczkowski e38e24eee9
Merge pull request #583 from SimonMarquis/jvmToolchain
1 year ago
Adetunji Dahunsi ba1d9e14df
Merge pull request #716 from SimonMarquis/SimonMarquis-patch-3
1 year ago
Don Turner a4eab289df
Merge pull request #719 from android/add-search-analytics
1 year ago
James Rose 2f2dfb00a4 Mark all news resources read on first sync
1 year ago
Don Turner 0e40e26f22 Add analytics for search queries
1 year ago
Simon Marquis ec9155fef9
Update ConnectivityManagerNetworkMonitor.kt
1 year ago
Simon Marquis 7819a0c6bc
Extract common code to update the Flow value
1 year ago
Simon Marquis def5c4e881
Update ConnectivityManagerNetworkMonitor.kt
1 year ago
Simon Marquis 76c249a651
Update ConnectivityManagerNetworkMonitor.kt
1 year ago
Simon Marquis f34ee1c01b
Update ConnectivityManagerNetworkMonitor.kt
1 year ago
Simon Marquis de6545f5d7
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
1 year ago
TJ Dahunsi 6e6abd0326 Fix build
1 year ago
TJ Dahunsi 9562f7707d Route notification deep link through for you screen, with spotless fixes
1 year ago
TJ Dahunsi ef97cb941c Route notification deep link through for you screen
1 year ago
TJ Dahunsi 8a3a16de21 Add pending intent for opening notification links
1 year ago
TJ Dahunsi 2499c0a0bd Notify users when news are updated
1 year ago
Simon Marquis ddabba8e4a
Merge branch 'main' into jvmToolchain
1 year ago
gururani-abhishek f6bdba08d9 added comment to document what happens on tapping news resource card.
1 year ago
gururani-abhishek bbc80bb0e2 added back launchCustomChromeTab()
1 year ago
gururani-abhishek 51379a249d fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
1 year ago
Don Turner 2fd1b716f6
Merge pull request #667 from SimonMarquis/cleanup/warnings
1 year ago
Milosz Moczkowski c746b6afcd
Merge pull request #598 from takagimeow/fix/clean-up-unused-update-topics
1 year ago
Simon Marquis 1341f7c2c5 Replace unused variable with simpler method calls
1 year ago
Simon Marquis 459717f8ba Remove `DSL_SCOPE_VIOLATION` suppression as it is now fixed in Gradle 8.1
1 year ago
Don Turner e1ae12129a
Merge pull request #662 from android/av/agp-8.0
1 year ago
Takeshi Hagikura b3cdc172cd
Implement search feature (#685)
1 year ago
Adetunji Dahunsi 73a38720d8
Merge pull request #649 from android/tj/backend-requested-sync
1 year ago
Adetunji Dahunsi 6b834b6f4c Applied code review suggestions
1 year ago
Adetunji Dahunsi b3f2502ec2
Update core/data/src/test/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepositoryTest.kt
1 year ago
Adetunji Dahunsi f86d174c1b Used more explicit variable names in tests
1 year ago
Adetunji Dahunsi 337c940d66 Add comments explaining backend sync and made variable names easier to grok
1 year ago
Adetunji Dahunsi 022cd92f4c
Update core/data/src/main/java/com/google/samples/apps/nowinandroid/core/data/repository/OfflineFirstNewsRepository.kt
1 year ago
Simon Marquis 5a43b4b74e Run Spotless
1 year ago
Simon Marquis aa701064a2 Add Application-wide `CoroutineScope` in the DI graph
1 year ago
Simon Marquis 9499e559e7
Delete no longer used `AUTHORS_ASSET` reference
1 year ago
Milosz Moczkowski 6bf37adde9
Merge pull request #671 from android/kotlin-version-updates
1 year ago
Márton Braun bea2eecd90 Update Kotlin, Compose compiler, serialization versions
1 year ago
Adetunji Dahunsi 05be2855d8 Wire up backend requested sync
1 year ago
James Rose 93953c2206 Add missing method doc
1 year ago
James Rose 050db2cb72 Merge branch 'main' into jr/track-viewed
1 year ago
James Rose b49767a88c Rename getUserNewsResources to observeAll
1 year ago
Alex Vanyo 086dc957c0 Update to AGP 8.0
1 year ago
Milosz Moczkowski feafb5fbed
Merge pull request #575 from takagimeow/fix/provide-true-to-local-inspection-mode
1 year ago
Milosz Moczkowski 2b2f6d48ce
Merge pull request #600 from takagimeow/cleanup-unused-args
1 year ago
Milosz Moczkowski 0b0fdbfdbf
Merge branch 'main' into patch-2
1 year ago
Adetunji Dahunsi 08956492c8 Backend triggered sync
1 year ago
Milosz Moczkowski ba6a697844
Merge pull request #624 from SimonMarquis/gradle-sort
1 year ago
Chris Sinco 93c01ad184 Fix trailing commas based on spotless check
1 year ago
Chris Sinco 049750dd51 Merge branch 'main' into ui-polish
1 year ago
James Rose 57c13d84bd Incorporate code review changes: Move UserNewsResourceRepository to data
1 year ago
Simon Marquis 8ec54d19d8 Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
1 year ago
James Rose ebfbb5bafd Display unread state on the news feed and bottom nav bar
1 year ago
James Rose bd450099fb Replace GetUserNewsResourcesUseCase with UserNewsResourceRepository
1 year ago
James Rose 9ee2acf327 Add viewed status for news resources to data layer
1 year ago
Adetunji Dahunsi ebdb8589a6
Merge pull request #608 from android/tunjid-batch-sync
1 year ago
Keisuke Takagi d56d8e1380 Merge branch 'main' of https://github.com/takagimeow/nowinandroid into fix/clean-up-unused-update-topics
1 year ago
Don Turner 6d1f85b8ce
Merge pull request #607 from android/mv/tests
1 year ago
Adetunji Dahunsi 8765d3ac57 Fix tests for batched news resource sync
1 year ago
Adetunji Dahunsi 1e8d1d9810
Spotless fix
1 year ago
Adetunji Dahunsi 267adfd27f
Batch sync news resources from remote
1 year ago
Alex Vanyo 0844d021b9
Merge pull request #603 from amalhanaja/redundant-managed-device
1 year ago
Manuel Vivo 755413bfc5 Fix spotless
1 year ago
Manuel Vivo 91633af376 Provide a CoroutineScope to fake DataStores
1 year ago
Don Turner 2f3fc85d65 Make Hilt provide Firebase.analytics
1 year ago
AlfianHanantio bcd4a6de59 Remove redundant code block for managed virtual device creation
1 year ago
Keisuke Takagi 072364e7f1 remove newsResourceTitle
1 year ago
Keisuke Takagi 0a748bc899 Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/clean-up-unused-update-topics
1 year ago
Adetunji Dahunsi ae58d1e1b0
Merge pull request #592 from android/tj/news-resource-query
1 year ago
Adetunji Dahunsi 09f5c3bc61 Add NewsResourceQuery to better query encapsulation
1 year ago
Keisuke Takagi 86c021a54a remove invalid overriding method
1 year ago
Keisuke Takagi fb32580e0c remove unused updateNewsResources method
1 year ago
Keisuke Takagi 67412b2720 remove invalid overriding method
1 year ago
Keisuke Takagi 1489bf66e3 remove unused updateTopics method
1 year ago
Caren 6a5feb767e
Merge pull request #582 from yschimke/loaders
1 year ago
Keisuke Takagi 8b51107d7a Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/provide-true-to-local-inspection-mode
1 year ago
Simon Marquis e1f8c51c05 Configure jvmToolchain on the single Kotlin jvm project
1 year ago
Yuri Schimke 4fa730098d Fixes
1 year ago
Yuri Schimke 9e399b69ea Improve network pooling and avoid startup image fetches.
1 year ago
Don Turner 4284e6912e Merge remote-tracking branch 'github/main' into feb9automerger
1 year ago
Márton Braun 237375f52a Remove unused DropdownMenu component
1 year ago
Márton Braun 322ff63dbc Route topic chip tap events up to NiaNavHost
1 year ago
Don Turner 2a4d0434a5 Add Firebase analytics. See go/nia-firebase-services.
1 year ago
Keisuke Takagi 9091abf09e Provide true to LocalInspectionMode
1 year ago
Simon Marquis 3409f937ed Migrate custom room configuration into a convention plugin
1 year ago
Miłosz Moczkowski bcb4d7d592 Replace global variables with PreviewParameterProvider
1 year ago
Márton Braun 819dd494ad Run Spotless to add trailing commas (and apply other rule updates)
1 year ago
Angie Sasmita cfbf782613
Merge pull request #542 from android/as/dynamic-color-option
1 year ago
mlykotom 6b48b355cc Merge branch 'main' into tm/fix-benchmarks-no-people
1 year ago
Mohsen Rzna 46c1d510d4
Android-CI workflow -> GMD refactor (#537)
1 year ago
Angie Sasmita dbbe8ffecb Small fix for naming and boolean logic
1 year ago
Angie Sasmita 19efc1b5e8 Fix Spotless issue manually
1 year ago
Angie Sasmita 6046f6e943 Add dynamic color option in settings for API >=32
1 year ago
Takeshi Hagikura 4633609930
Introduce GMD + ATD (#479)
2 years ago
Don Turner bad3ea60f5 Refactor Topics news feed, tidy a few other bits up
2 years ago
magicalmeghan 45e3cfd989 fixed string issue for testTopicsChipColorBackground_matchesFollowedState test
2 years ago
magicalmeghan de6a4ec6c7 Merge remote-tracking branch 'github/mm/chipcolor' into mm/chipcolor
2 years ago
magicalmeghan 5137cd7777 removed hardcoded strings
2 years ago
Don Turner cafac8eb09 fix spotless, tidy test data
2 years ago
magicalmeghan 66046a86b0 Updated NewsResourceCardTest
2 years ago
Don Turner 6207fe3bcf mapToUserNewsResources converts List<NewsResource> to List<UserNewsResource>
2 years ago
Don Turner 24df51349d Move mapping logic into secondary constructor
2 years ago
Don Turner 355b0540aa Move construction of UserNewsResource into separate function
2 years ago
Don Turner 99227b06b5 Spotless
2 years ago
Don Turner 32bc5c1590 Fix merge conflicts
2 years ago
magicalmeghan ffb5aeba86 Added third draft of tests
2 years ago
magicalmeghan d9e18607be Added second draft of tests
2 years ago
magicalmeghan 8089866079 Added second draft of tests
2 years ago
Alex Vanyo ba11e6bf38
Merge pull request #491 from android/av/fix-background-composable
2 years ago
Chris Sinco 2f454de21c Spacing polish based on design spec
2 years ago
Don Turner 47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
2 years ago
Don Turner 0917cdebec Refactor NiaGradientBackground to accept GradientColors
2 years ago