Apply suggestions from code review

Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com>
pull/341/head
Erick 3 years ago committed by Erick Zanardo
parent 706dbcc91c
commit 2281f2cc79

@ -48,8 +48,8 @@ class BackboxBloc extends Bloc<BackboxEvent, BackboxState> {
),
);
emit(InitialsSuccessState());
} catch (e, s) {
addError(e, s);
} catch (error, stackTrace) {
addError(error, stackTrace);
emit(InitialsFailureState());
}
}

@ -12,7 +12,7 @@ abstract class BackboxEvent extends Equatable {
/// Event that triggers the user initials display.
/// {@endtemplate}
class PlayerInitialsRequested extends BackboxEvent {
/// {@template player_initials_requested}
/// {@macro player_initials_requested}
const PlayerInitialsRequested({
required this.score,
required this.character,
@ -28,11 +28,11 @@ class PlayerInitialsRequested extends BackboxEvent {
List<Object?> get props => [score, character];
}
/// {@template player_initials_submited}
/// {@template player_initials_submitted}
/// Event that submits the user score and initials.
/// {@endtemplate}
class PlayerInitialsSubmited extends BackboxEvent {
/// {@template player_initials_requested}
class PlayerInitialsSubmitted extends BackboxEvent {
/// {@macro player_initials_submitted}
const PlayerInitialsSubmited({
required this.score,
required this.initials,

@ -26,7 +26,7 @@ class LeaderboardSuccessState extends BackboxState {
List<Object?> get props => [];
}
/// State when the leaderboard was successfully loaded.
/// State when the leaderboard failed to load.
class LeaderboardFailureState extends BackboxState {
@override
List<Object?> get props => [];

@ -13,7 +13,7 @@ final _bodyTextPaint = TextPaint(
);
/// {@template initials_submission_failure_display}
/// Display when the initials failed to submitted.
/// [Backbox] display for when a failure occurs during initials submission.
/// {@endtemplate}
class InitialsSubmissionFailureDisplay extends TextComponent
with HasGameRef<PinballGame> {

@ -13,7 +13,7 @@ final _bodyTextPaint = TextPaint(
);
/// {@template initials_submission_success_display}
/// Display when the initials were successfully submitted.
/// [Backbox] display for initials successfully submitted.
/// {@endtemplate}
class InitialsSubmissionSuccessDisplay extends TextComponent
with HasGameRef<PinballGame> {

@ -31,9 +31,9 @@ void main() {
],
);
group('PlayerInitialsSubmited', () {
group('PlayerInitialsSubmitted', () {
blocTest<BackboxBloc, BackboxState>(
'adds [LoadingState, InitialsSuccessState] when submission works',
'adds [LoadingState, InitialsSuccessState] when submission succeeds',
setUp: () {
leaderboardRepository = _MockLeaderboardRepository();
when(
@ -61,7 +61,7 @@ void main() {
);
blocTest<BackboxBloc, BackboxState>(
'adds [LoadingState, InitialsSuccessState] when submission works',
'adds [LoadingState, InitialsFailureState] when submission fails',
setUp: () {
leaderboardRepository = _MockLeaderboardRepository();
when(

@ -42,7 +42,7 @@ void main() {
});
});
group('PlayerInitialsSubmited', () {
group('PlayerInitialsSubmitted', () {
test('can be instantiated', () {
expect(
PlayerInitialsSubmited(

@ -47,7 +47,7 @@ void main() {
});
group('InitialsFormState', () {
test('can be InitialsFormState', () {
test('can be instantiated', () {
expect(
InitialsFormState(
score: 0,

Loading…
Cancel
Save