Apply suggestions from code review

Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com>
pull/341/head
Erick 3 years ago committed by Erick Zanardo
parent 706dbcc91c
commit 2281f2cc79

@ -48,8 +48,8 @@ class BackboxBloc extends Bloc<BackboxEvent, BackboxState> {
), ),
); );
emit(InitialsSuccessState()); emit(InitialsSuccessState());
} catch (e, s) { } catch (error, stackTrace) {
addError(e, s); addError(error, stackTrace);
emit(InitialsFailureState()); emit(InitialsFailureState());
} }
} }

@ -12,7 +12,7 @@ abstract class BackboxEvent extends Equatable {
/// Event that triggers the user initials display. /// Event that triggers the user initials display.
/// {@endtemplate} /// {@endtemplate}
class PlayerInitialsRequested extends BackboxEvent { class PlayerInitialsRequested extends BackboxEvent {
/// {@template player_initials_requested} /// {@macro player_initials_requested}
const PlayerInitialsRequested({ const PlayerInitialsRequested({
required this.score, required this.score,
required this.character, required this.character,
@ -28,11 +28,11 @@ class PlayerInitialsRequested extends BackboxEvent {
List<Object?> get props => [score, character]; List<Object?> get props => [score, character];
} }
/// {@template player_initials_submited} /// {@template player_initials_submitted}
/// Event that submits the user score and initials. /// Event that submits the user score and initials.
/// {@endtemplate} /// {@endtemplate}
class PlayerInitialsSubmited extends BackboxEvent { class PlayerInitialsSubmitted extends BackboxEvent {
/// {@template player_initials_requested} /// {@macro player_initials_submitted}
const PlayerInitialsSubmited({ const PlayerInitialsSubmited({
required this.score, required this.score,
required this.initials, required this.initials,

@ -26,7 +26,7 @@ class LeaderboardSuccessState extends BackboxState {
List<Object?> get props => []; List<Object?> get props => [];
} }
/// State when the leaderboard was successfully loaded. /// State when the leaderboard failed to load.
class LeaderboardFailureState extends BackboxState { class LeaderboardFailureState extends BackboxState {
@override @override
List<Object?> get props => []; List<Object?> get props => [];

@ -13,7 +13,7 @@ final _bodyTextPaint = TextPaint(
); );
/// {@template initials_submission_failure_display} /// {@template initials_submission_failure_display}
/// Display when the initials failed to submitted. /// [Backbox] display for when a failure occurs during initials submission.
/// {@endtemplate} /// {@endtemplate}
class InitialsSubmissionFailureDisplay extends TextComponent class InitialsSubmissionFailureDisplay extends TextComponent
with HasGameRef<PinballGame> { with HasGameRef<PinballGame> {

@ -13,7 +13,7 @@ final _bodyTextPaint = TextPaint(
); );
/// {@template initials_submission_success_display} /// {@template initials_submission_success_display}
/// Display when the initials were successfully submitted. /// [Backbox] display for initials successfully submitted.
/// {@endtemplate} /// {@endtemplate}
class InitialsSubmissionSuccessDisplay extends TextComponent class InitialsSubmissionSuccessDisplay extends TextComponent
with HasGameRef<PinballGame> { with HasGameRef<PinballGame> {

@ -31,9 +31,9 @@ void main() {
], ],
); );
group('PlayerInitialsSubmited', () { group('PlayerInitialsSubmitted', () {
blocTest<BackboxBloc, BackboxState>( blocTest<BackboxBloc, BackboxState>(
'adds [LoadingState, InitialsSuccessState] when submission works', 'adds [LoadingState, InitialsSuccessState] when submission succeeds',
setUp: () { setUp: () {
leaderboardRepository = _MockLeaderboardRepository(); leaderboardRepository = _MockLeaderboardRepository();
when( when(
@ -61,7 +61,7 @@ void main() {
); );
blocTest<BackboxBloc, BackboxState>( blocTest<BackboxBloc, BackboxState>(
'adds [LoadingState, InitialsSuccessState] when submission works', 'adds [LoadingState, InitialsFailureState] when submission fails',
setUp: () { setUp: () {
leaderboardRepository = _MockLeaderboardRepository(); leaderboardRepository = _MockLeaderboardRepository();
when( when(

@ -42,7 +42,7 @@ void main() {
}); });
}); });
group('PlayerInitialsSubmited', () { group('PlayerInitialsSubmitted', () {
test('can be instantiated', () { test('can be instantiated', () {
expect( expect(
PlayerInitialsSubmited( PlayerInitialsSubmited(

@ -47,7 +47,7 @@ void main() {
}); });
group('InitialsFormState', () { group('InitialsFormState', () {
test('can be InitialsFormState', () { test('can be instantiated', () {
expect( expect(
InitialsFormState( InitialsFormState(
score: 0, score: 0,

Loading…
Cancel
Save