Matt Farina
f043faf0a3
Merge pull request #30862 from OmriSteiner/fix-absolute-uri
...
fix: correctly concat absolute URIs in repo cache
4 months ago
Matt Farina
ab56ac62ba
Merge pull request #30866 from mmorel-35/thelper
...
chore: enable thelper linter
4 months ago
George Jenkins
8ba181c343
Run test OCI registry localhost
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
Matthieu MOREL
706392fabb
fix: update json-patch import path and add gomodguard settings
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
Matt Farina
b5a4781099
Adding test for list command
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 months ago
Omri Steiner
c47c8fc868
fix: correctly concat absolute URIs in repo cache
...
There used to be two implemenations for concatenating the repo URL with
the chart URI / URL. In case the chart specified an absolute URI, one of
the implementations performed an incorrect concatenation between the
two, resulting in a URL which looks like <repo-URL><absolute-chart-URI>.
This commit removes the faulty implementation and uses the other correct
one instead.
Signed-off-by: Omri Steiner <omri@steiners.co.il>
4 months ago
Matt Farina
dd40316660
Merge pull request #30842 from ayushontop/main
...
Fix : No repository is not an error,use the helm repo list command ,if there is no repository,it should not be an error #30606
4 months ago
MichaelMorris
1460ebd14a
Added test case to resource_test.go
...
Signed-off-by: MichaelMorris <michael.morris@est.tech>
4 months ago
MichaelMorris
9a2ac85077
Consider GroupVersionKind when matching resources
...
This change shall take Group, Version and Kind from GroupVersionKind
into consideration instead of the current behavior of only considering
the Kind
Closes : #12578
Signed-off-by: MichaelMorris <michael.morris@est.tech>
4 months ago
Ayush Tiwari
56b688145f
added cmd in repo_list.go for pipeline
...
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
4 months ago
Robert Sirchia
b2456202ae
Merge pull request #30850 from yetyear/main
...
refactor: use maps.Copy for cleaner map handling
4 months ago
George Jenkins
2c1257537c
Merge pull request #30829 from TerryHowe/increase-time-pkg-test-coverage
...
Increase pkg/time test coverage
4 months ago
yetyear
03448d1d79
refactor: use maps.Copy for cleaner map handling
...
Signed-off-by: yetyear <flite@outlook.com>
4 months ago
Robert Sirchia
4d580c6b95
Merge pull request #30810 from mmorel-35/usestdlibvars
...
chore: enable usestdlibvars linter
5 months ago
Terry Howe
71787cca60
fix: rename slave replica
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
George Jenkins
a1f8802de9
Merge pull request #30553 from Zhanweelee/add_mustToYaml_support
...
feat: Add mustToYaml and mustToJson template functions
5 months ago
Ayush Tiwari
e63cbae886
added cmd.ErrOrStderr()
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
5 months ago
Ayush Tiwari
95328ea0a6
removed error import
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
5 months ago
Ayush Tiwari
058bc083a8
changed Error to print
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
5 months ago
Terry Howe
da579a7aa6
chore: add test coverage for time package
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
findnature
ac8d2f9aed
refactor: use slices.Contains to simplify code
...
Signed-off-by: findnature <cricis@aliyun.com>
5 months ago
Terry Howe
f754e6a23b
chore: increase test coverage of time pkg
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
5 months ago
Matthieu MOREL
77a267dacf
chore: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Jesse Simpson
e0a67b1028
test: use more realistic unit-test scenario by not relying on Release.Name
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
d10c5f6429
style: trim space from formatted error messages
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
0e0a8cc765
fix: address no-template-associated type of error
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
013f27c294
fix: use errors.New instead of fmt.Errorf
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
868cdc261f
refactor: reduce flow-control operations
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
48922e21d1
refactor: use struct equality instead of comparing each composition
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
ac98e977c3
refactor: switch to while loop instead of for to reduce unnecessary variables
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
65084371c9
refactor: replace if MatchString with FindStringSubMatch
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
782f6c6409
refactor: shorten regex subexp syntax
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
4b9a9ecaf6
refactor: rename function and add doc-string
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
4f63c73353
refactor: remove impractical safety check
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
5202820f2f
refactor: define regexs at package scope
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
cbdc22128e
refactor: use strings.Builder instead of string concatenation
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
cdcf1bc601
style: remove unnecessary break
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
3cc4cb60ba
refactor: prevent duplicates being inserted rather than post-filtering
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
deea4a0d0e
refactor: remove more unnecessary format calls
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
0a7dd4b269
test: adjust failing test on extra whitespace
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
13b232e061
refactor: make use of regexs for err parsing
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
daf4c34879
fix: use originalErr instead of formatting original error
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
98da3e28b6
fix: add some index checking and fixed a test that relied on type-checking
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
80d7a1b33f
style: make format
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
edf0f7be59
test: adjust formatting for error in test
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
487f72b822
fix: added protection against while-true condition in unbounded for loop
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
6bb836374b
test: adjusted to make it more meaningful and to pass
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
383a758aec
fix: add quality checks to ensure formatted error doesnt remove important info
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
d8bec4e30f
fix: remove comparison from old error message to new
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
c481470985
style: renamed i variable for consistency
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
2e3f6dce28
fix: save to fileLocation rather than fileLocations[i] which gets overwritten
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
f09bbb8ab8
style: consolidate for loops
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
1357db4db1
style: removed variable only used once
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
a56daca82b
style: use interface functions instead of inline logic
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
87f9e2dc45
style: create String function for TraceableError representing one chunk of a stacktrace
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
6cd0c0082a
fix: split up the multiline errors to be more vertical
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
cc477e9f79
fix: adjust test to not require external chart
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
14f902c245
wip: draft at making cleaner stacktraces
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
George Jenkins
ecf1730689
Merge pull request #13460 from justenstall/stdlib-errors-2
...
fix: replace "github.com/pkg/errors" with stdlib "errors" package
5 months ago
Justen Stall
4905a61026
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Matt Farina
fcd37bcea7
Merge pull request #30783 from rpolishchuk/investigate-TestValidateChartIconPresence
...
fix: chart icon presence test
5 months ago
Robert Sirchia
d9bc0a948c
Merge pull request #30777 from ryanhockstad/merge-fix
...
fix: null merge. closes #30587
5 months ago
Scott Rigby
a911aa2112
Merge pull request #9175 from dastrobu/copy-dependencies-on-aliasing
...
fix: copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies
5 months ago
Daniel Strobusch
b183eccfc4
copy dependency metadata on aliasing to avoid sharing imported values
...
imported values are stored in dependency objects, which breaks if a chart dependency is shared among multiple aliases.
By copying the dependency objects in the metadata values can be imported correctly.
Supersedes #10174
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
5 months ago
Daniel Strobusch
df7befd208
copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies
...
Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases.
By copying the dependencies, parent information can be set correctly to render the templates as expected later on.
Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level.
Closes #9150
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
5 months ago
Stephen Murray
1682895636
ref(helm): Export Chart Not Found error
...
Closes #30746
Signed-off-by: Stephen Murray <stephenmurrayengineer@gmail.com>
5 months ago
Rostyslav Polishchuk
1c8d1e375f
fix: chart icon presence test
...
The `TestValidateChartIconPresence` test fails when run after
`TestValidateChartIconURL` as they both are using a global
variable `badChart.Icon`
```
: go test -v -test.shuffle 1 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 1
=== RUN TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
=== RUN TestValidateChartIconPresence
chartfile_test.go:171: validateChartIconPresence to return a linter error, got no error
--- FAIL: TestValidateChartIconPresence (0.00s)
FAIL
FAIL helm.sh/helm/v4/pkg/lint/rules 0.051s
FAIL
: go test -v -test.shuffle 2 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 2
=== RUN TestValidateChartIconPresence
--- PASS: TestValidateChartIconPresence (0.00s)
=== RUN TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
PASS
ok helm.sh/helm/v4/pkg/lint/rules 0.050s
```
This commit:
1. Remove dependency on global variable
2. Explicitly set the state of the test object.
Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>
5 months ago
Justen Stall
fc6c5e5edb
remove WaitAndGetCompletedPodPhase function
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
73545f9a3e
one more test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
4a6092bd6c
update another test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
7a316c8d51
update expected error message in install test
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Matthieu MOREL
d3eeb2c942
chore: remove github.com/hashicorp/go-multierror dependency
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Justen Stall
3877ec9049
fix golangci-lint issues
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
065e2eb3eb
updates after merge conflict resolution
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Scott Rigby
eb6e240cfe
Merge pull request #30734 from ipaqsa/feature/add-custom-template-funcs
...
feat(pkg/engine): add support for custom template funcs
5 months ago
Scott Rigby
8255300280
Merge pull request #12382 from edbmiller/ed-dot-miller/parse-chartfile-yaml-strictly
...
fix(pkg/lint): unmarshals Chart.yaml strictly
5 months ago
Ryan Hockstad
c1175a4106
fix null merge
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
5 months ago
Edward Miller
e414695a5b
fix
...
Signed-off-by: Edward Miller <edmiller287@gmail.com>
5 months ago
Benoit Tigeot
e2461de3c2
Fix test with toml bump
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Matt Farina
a842140ef6
Merge pull request #13578 from gjenkins8/rm_chart_repo_load_func
...
refactor: Remove ChartRepository `[]ChartPaths`
5 months ago
Edward Miller
629780a34a
fix: reapply error message fix
...
Signed-off-by: Edward Miller <edmiller287@gmail.com>
5 months ago
Edward Miller
9d43f70643
Update error message
...
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Edward Miller <55854159+edbmiller@users.noreply.github.com>
5 months ago
Edward Miller
14a468f24d
Add chartutil.StrictLoadChartfile for strict (WARNING-level) lint
...
Signed-off-by: Edward Miller <edmiller287@gmail.com>
5 months ago
Edward Miller
00f8561ad4
fix(pkg/lint): unmarshals Chart.yaml strictly
...
When "helm lint" is run, it now errors on invalid chartfiles,
e.g. those with duplicate keys
Closes #12381
Signed-off-by: Edward Miller <edmiller287@gmail.com>
5 months ago
wangcundashang
7bb0c85441
chore: fix function name in comment
...
Signed-off-by: wangcundashang <wangcundashang@qq.com>
5 months ago
Stepan Paksashvili
b54349d9b2
fix(pkg/engine): allow to override all functions
...
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
5 months ago
Stepan Paksashvili
5c2f89307d
feat(pkg/engine): and custom funcs to action config
...
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
5 months ago
Stepan Paksashvili
8982b57e5e
feat(pkg/engine): and custom funcs overriding test
...
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
5 months ago
Stepan Paksashvili
9073bcf53e
feat(pkg/engine): add support for custom template funcs
...
Enhances the template engine and action config to allow users to inject custom template functions via an action config when using Helm as a library.
Closes #30733
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
5 months ago
Scott Rigby
599fad1864
Merge pull request #30697 from p-se/fix-take-ownership
...
Fix --take-ownership for custom resources - closes #30622
5 months ago
Evans Mungai
1f5605a405
fix formatting errors
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Benoit Tigeot
d33e2896f0
Prevent failures with method signatures on hooks
...
changes on wait strategy. This PR try to fix linting and tests.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Scott Rigby
e397f44840
Merge pull request #30673 from nvanthao/process-all-hook-deletions-on-failure
...
fix: Process all hook deletions on failure
5 months ago
Matt Farina
01590a59b2
Merge pull request #30760 from robertsirc/add-debuging-to-jsonschema
...
adding slog debug to a few points
5 months ago
Robert Sirchia
8733103743
Merge pull request #30718 from klihub/fixes/package/multiple-charts-single-passwd-from-stdin
...
Allow signing multiple charts with a single passphrase from stdin.
5 months ago
Robert Sirchia
da096e1b7a
Merge pull request #30752 from benoittgt/bump-golangci-lint-action
...
Bump golangci lint to last major version and fix static-check errors
5 months ago
Robert Sirchia
ef0361de21
fixing as per review
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
5 months ago
Robert Sirchia
9b9ff12c6d
adding slog debug to a few points
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
5 months ago
Krisztian Litkey
3102c28804
fix: allow signing multiple charts with passphrase from stdin.
...
Cache the signing key passphrase. When signing multiple charts
with the passphrase from stdin, this allows signing all charts
instead of all but the first failing with an error about stdin
already having been closed.
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
5 months ago
Evans Mungai
e8e79cc4b4
Merge branch 'main' into fix-take-ownership
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Evans Mungai
7c37a109f2
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Matt Farina
0dffc580b0
Simpligy the JSON Schema checking
...
A new library was introduced that provides JSON Schema checking for
newer versions of the schema. In Helm v4, there is no need to have
two packages doing the JSON schema validation. The message output
can have breaking changes.
This change moves everything to the newer library. It also uses a
wrapper error to enable a clean Helm only interface for the
public Go API validation functions. This would enable the replacement
of the Schema validation library, if needed, without breaking the
Go API contract.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Matt Farina
55a4fc121b
Merge pull request #13283 from win-t/jsonschema
...
adding support for JSON Schema 2020
5 months ago
Benoit Tigeot
a1c2f47c08
avoid using reflect.DeepEqual with errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
eb65ce280b
could apply De Morgan's law
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
374805deb4
error strings should not be capitalized
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
1654664b78
could use strings.ReplaceAll instead
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
a6d0335bbb
Use fmt.Fprintf(...) instead of ...
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
a9b7732367
could remove embedded field X from selector
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Kurnia D Win
6c54351c01
Merge remote-tracking branch 'upstream/main' into jsonschema
5 months ago
Benoit Tigeot
f5aec508f5
Add detailed debug logging for resource readiness states
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Scott Rigby
9a670ae920
Merge pull request #30701 from zanuka/30617-request-for-helm-install-order-doc-update
...
updates mutate and validate web hook configs
5 months ago
Scott Rigby
0cecd910e5
Merge pull request #30713 from gjenkins8/gjenkins/rm_helmv2_template_lint_rules
...
cleanup: Remove Helm v2 template lint rules
5 months ago
Matt Farina
a536832714
Merge pull request #30749 from mattfarina/fix-alpine-chart
...
Removing the alpine test chart
5 months ago
Robert Sirchia
f5decfc28d
Merge pull request #30737 from rpolishchuk/investigation-pr-30610
...
fix: order dependent test
5 months ago
Matt Farina
91ecb56355
Removing the alpine test chart
...
A .gitignore was previously setup to ignore this file. When pkg/cmd
was setup the .gitignore was not updated. The change adds the new
location to continue to ignore this file.
Note, the previous location is still included in the .gitignore
because developers will have a file there and we do not want that
accidently included in a commit.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Matt Farina
7a1eb77e77
Merge pull request #30708 from benoittgt/migrate-kube-pkg-to-slog
...
Migrate pkg to slog
5 months ago
Matt Farina
ed005f5c32
Removing deprecation notice for this function.
...
While the constructor is not used by Helm itself, it is used by SDK
users and there is currently no alternative way to expose this.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Matt Farina
7938662f95
Remove ValidName regex
...
This regex was already deprecated.
Validation happens inside the Metadata Validate function for the
name instead of using this regex.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Benoit Tigeot
68440d7b29
Prefer using slog.Any when displaying errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
c05bcbd498
Fix nil pointer dereference in ready test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
e7eedae97c
Use the logger with proper handling of dynamic debug on 2 locations
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
cbaac7652d
Call slog directly instead of using a wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
6b5fa33633
debug log level is dynamic and set after Logger creation
...
So we should use dynamic handler to set the log level after. With this
patch we can clearly see the output. Before we were always stuck in log
level "info" and not seeing debug log level
```
bin/helm upgrade --install --debug --wait frontend \
--namespace test \
--set replicaCount=2 \
--set backend=http://backend-podinfo:9898/echo \
podinfo/podinfo
level=DEBUG msg="getting history for release" release=frontend
level=DEBUG msg="preparing upgrade" name=frontend
level=DEBUG msg="performing update" name=frontend
level=DEBUG msg="creating upgraded release" name=frontend
level=DEBUG msg="checking resources for changes" resources=2
level=DEBUG msg="no changes detected" kind=Service name=frontend-podinfo
level=DEBUG msg="patching resource" kind=Deployment name=frontend-podinfo namespace=test
level=DEBUG msg="waiting for resources" count=2 timeout=5m0s
level=DEBUG msg="waiting for resource" name=frontend-podinfo kind=Deployment expectedStatus=Current actualStatus=Unknown
level=DEBUG msg="updating status for upgraded release" name=frontend
Release "frontend" has been upgraded. Happy Helming!
NAME: frontend
LAST DEPLOYED: Thu Apr 10 09:56:25 2025
NAMESPACE: test
STATUS: deployed
REVISION: 6
DESCRIPTION: Upgrade complete
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Rostyslav Polishchuk
55eb53e3a0
fix: order dependent test
...
TestInstallRelease_Atomic_Interrupted needs the same wait
as TestInstallRelease_Wait_Interrupted (see helm/helm#12088 ).
The installation goroutine started by
TestInstallRelease_Atomic_Interrupted proceeds in the background and
may interfere with other tests (see helm/helm#30610 )
Also see helm/helm#12086 and helm/helm#12109 which are describe and address the root
cause.
Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>
5 months ago
Matt Farina
d8ca55fc66
Merge commit from fork
...
Fix for DOS when unarchiving charts
5 months ago
Mike Delucchi
e1425f1aa5
fix: correct webhook order to match Kubernetes admission flow
...
Place APIService before webhooks, with MutatingWebhookConfiguration
before ValidatingWebhookConfiguration to match standard admission control.
Signed-off-by: Mike Delucchi <git@zanuka.com>
5 months ago
Mike Delucchi
1003a3c93f
fixes kind_sorter_test to match new order
...
Signed-off-by: Mike Delucchi <git@zanuka.com>
5 months ago
Mike Delucchi
c121b6b83e
changes order of operations
...
Signed-off-by: Mike Delucchi <git@zanuka.com>
5 months ago
zanuka
9b636902c6
updates mutate and validate web hook configs
...
Signed-off-by: Mike Delucchi <git@zanuka.com>
5 months ago
Matt Farina
0740dfc7a9
Unarchiving fix
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
5 months ago
Scott Rigby
5442c6b9cb
Merge pull request #9318 from wahabmk/fix-httpgetter
...
Fix issue with helm pull failing if pulling from a repository that redirects to another domain
6 months ago
Benoit Tigeot
0c85456788
Leverage slog.Any for errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
5c746037b3
Prevent redefining verbose flags
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
710770eed4
Linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
5580f61157
Properly reproduce the nopLogger as before
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
baa597c567
Do not remove the functionality to print log in test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b6adbbb227
Enforce error style with others
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b2380720eb
Migrate to pure slog without a custom wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
3db7ebc591
Fix missing logger to SQL in test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
15de13f9d2
Fix linting issue and temporary removing logging in test acion
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b42767be40
Migrate more code to log adapter
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
83cdffe4ae
Migrate to a dedicated internal package for slog adapter + migrate more
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
fae2345edf
Demonstrate the impact of having Logger defined in kube package
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
ede73860c1
Fix call to kube log
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
3a22df9731
Deal with linting errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
394ba2d55e
Properly use DefaultLogger
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
eb2dfe7dbf
Some interesting rephrasing by Terry Howe
...
See: https://github.com/helm/helm/pull/30698#discussion_r2012394228
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
227d270788
Extra comment + Default logger fallback
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b642bca8f6
Provide an adapter to easily pass a slog.Default()
...
```
helmClient.Log = NewSlogAdapter(slog.Default())
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
d6d7cff417
Try to make log more common and more easily grepable
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
8d30464f2c
Do no mask warning alerts
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
dfaf249221
Remove unreachable error
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
f4631bf3d8
Migrate kube package to slog
...
As for helm v4. We want to migrate logs to slog.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Patrick Seidensal
e55707b09d
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 months ago
George Jenkins
be2b84685a
cleanup: Remove Helm v2 template lint rules
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
Suleiman Dibirov
000c098a41
fix(concurrency): add mutex to protect repoFailList and out in updateCharts
...
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
6 months ago
Scott Rigby
985f5af538
Merge pull request #13604 from AustinAbro321/refactor-wait
...
Introduce kstatus watcher
6 months ago
Scott Rigby
122e7b441a
Merge pull request #13458 from thudi/main
...
#13449 Resolves: Replacing NewSimpleClientSet to NewClientSet due to deprecation
6 months ago
Austin Abro
21ee721242
go fmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Austin Abro
8efd428e5d
switch back to k8s rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Austin Abro
83266254f0
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Austin Abro
386523bdbc
update to get waiter instead of set
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Robert Sirchia
0199b748aa
Merge pull request #30696 from benoittgt/report-time-waited-v4
...
Inform about time spent waiting resources to be ready in slog format
6 months ago
Wahab Ali
ec31aab851
Use NewTLSConfig instead of the outdated NewClientTLS func
...
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
6 months ago
Wahab Ali
e7895245f0
Fix lint errors
...
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
6 months ago
Wahab Ali
3ca2558f04
Do not explicitly set SNI in HTTPGetter
...
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
6 months ago
Benoit Tigeot
4f4c858f9c
Ignore unused parameter
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Matt Farina
2e6437beb5
Merge pull request #30684 from twz123/remove-clientoptresolver
...
Remove ClientOptResolver from OCI Client
6 months ago
Matt Farina
ab9f0c80b5
Merge pull request #30603 from robertsirc/converting-to-slog
...
converting inline log to slog
6 months ago
Robert Sirchia
c5991028e0
fixing matts changes
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
6 months ago
Matt Farina
e4e602e13c
Error when failed repo update.
...
In Helm v3 we did not change exit codes for existing commands to
maintain compat. A flag was introduced so a failure would result
in a non-0 exit code. A note was left to make this the default
in Helm v4. That's what this change does.
Closes #10016
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
Benoit Tigeot
94cb21c7c4
Follow convention for error with slog.Any()
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
e3e84b6dfe
"beginning wait" is dedicated to be display as debug log
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
0e4d185370
Inform about time spent waiting resources to be ready in slog format
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Austin Abro
d78b7e401a
go mod tidy
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
linghuying
fc476f7235
chore: make function comment match function name
...
Signed-off-by: linghuying <1599935829@qq.com>
6 months ago
Tom Wieczorek
835ff78f48
Remove ClientOptResolver from OCI Client
...
This option was kept to avoid compile-time incompatibilities in Helm v3
when upgrading to ORAS v2. Let's remove it for Helm v4.
This allows Helm to drop the containerd dependency entirely.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
6 months ago
Gerard Nguyen
aa9e4bb42d
rebase
...
Signed-off-by: Gerard Nguyen <gerard@replicated.com>
6 months ago
Laszlo Uveges
63b6153163
More formatting
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
acca1b04eb
Add missing license header
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
d03981b82c
Fix go imports
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
940966d9c8
Fix formatting issues
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
2eea520ba4
Delete previously successful hooks when a later hook fails
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
0a28223ae5
Restructure hooks tests to be reusable
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
788652fd27
Add dummy test case to prove that not all hooks are delted on failure
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Henrik Gerdes
597c35852a
fix: align values comments/docs to scaffold standard
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
6 months ago
Henrik Gerdes
ca367d970c
docs: more user-friendly info for httpRoute scaffold
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
6 months ago
Henrik Gerdes
1aac5b0b70
fix: use common chart-example.local hostname for http-route default
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
6 months ago
Henrik Gerdes
5d0c6e9ae4
fix: remove v1alpha2 gateway api support
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
6 months ago
Henrik Gerdes
d22939b439
fix: correct expected number of template files in unit-test
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
6 months ago
Henrik Gerdes
3fc5d689e6
docs: add notes in chart templates for accessing httproute
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
6 months ago
Henrik Gerdes
90daeadeb5
feat: add httproute from gateway-api to create chart template
...
Adds the HTTPRoute from https://gateway-api.sigs.k8s.io/reference/spec/ to the example getting started chart.
This closes #12603
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
6 months ago
Robert Sirchia
3a19576377
making changes as requested by matt
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
6 months ago
Austin Abro
10f78c814c
legacy waiter
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
0dffe83ef3
warnings
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
e773a810ee
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
7 months ago
Austin Abro
2948279fb9
cleanup if statement
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
600947b32e
client->restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Robert Sirchia
2192c4e0d1
changing errors back to warns
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Robert Sirchia
4422000330
fixing case issues with the logging of my errors
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Austin Abro
3a296aacad
rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
24dc643822
restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
0b513dcd42
Merge branch 'main' into refactor-wait
7 months ago
Austin Abro
68f72e5c3f
hook only strategy when wait=false
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
022d4db6af
move logic from cmd/helm to pkg/cmd
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
20c75f0c10
fix namespace assignment not passing through
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
George Jenkins
e354dd296d
Merge branch 'main' into rm_chart_repo_load_func
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
Rongrong Liu
12b8eb8b61
fix:add proxy support when mTLS configured
...
Signed-off-by: Rongrong Liu <lori.rongrong.liu@gmail.com>
7 months ago
Robert Sirchia
848c134e0c
fixing error messages
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Robert Sirchia
fd69bf6f32
Merge pull request #30592 from robertsirc/slog-prototype
...
changing from log to slog
7 months ago
Robert Sirchia
f50547bf51
changing error to warn as requested by Matt
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Robert Sirchia
c2e6ed8ae5
fixing build error
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Austin Abro
1704ce3067
Merge branch 'main' into refactor-wait
7 months ago
Robert Sirchia
8887d01791
fixing issues with my PR
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Robert Sirchia
c36bc25fb1
fixing missing attributes
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Robert Sirchia
1ad79a2bb7
converting inline log to slog
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Robert Sirchia
a11f4c0026
changing info to error
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Austin Abro
1a3fb75b34
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
d3814d786b
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Robert Sirchia
48f03d316b
changing from log to slog
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Matt Farina
e711488970
Move pkg/release to pkg/release/v1 to support v3 charts
...
This is part of HIP 20 which provides a means to have v3 charts
that live alongside v2 charts while having breaking changes.
The plan is to have a different release object for v3 chart
instances for at least a couple reasons:
1. So that the chart object on the release can be fundamentally
different.
2. So that Helm v3 does not detect or try to work with instances
of charts whose apiVersion it does not know about.
Note: it is expected that Helm v3 usage will be used long after
the Helm project no longer supports it. 5 years after Helm v2
had reached end-of-life there was still usage of it.
Note: The release util package is separate from the versioned
elements as it is planned to use generics to handle multiple
release object versions.
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
Austin Abro
f04c456bd6
gofmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
9f9eb28fed
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
09faaac273
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Matt Farina
35a8bd3a77
Merge pull request #30586 from mattfarina/chart-to-chart-v2
...
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
7 months ago
Matt Farina
61d3eca55c
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
...
This change moves the code, updates the import locations, and
adds a doc.go file to document what the v2 package is for.
This is part of HIP 20 for v3 charts
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
Robert Sirchia
4da004e2dc
removing old apis
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Austin Abro
29c250c233
add back interface log check
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
1cb4e66044
merge conflict
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
a18589c4d8
fmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
5a254dae21
cleanup
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
11eeb4a6b1
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
4f33e5c97f
test refactoring
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
75292c5e04
refactor
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
b79dfd09b0
refactor
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Matt Farina
bff495510d
Merge pull request #30571 from yardenshoham/exec-no-output
...
feat: error out when post-renderer produces no output
7 months ago
Matt Farina
18ca7c1002
Move pkg/releaseutil to pkg/release/util
...
The releaseutil package was originally designed to work against a
generated codebase from a protobuf in Helm v2. This is when Helm
used gRPC to communicate to a server side component named Tiller.
When Helm moved everything client side, this package remained and
it supported the release package.
This change moves releaseutil to be a sub-packge of release. This
is part of the change to support apiVersion v3 charts which is
documented in HIP 20
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
Austin Abro
297f7b9acb
squash
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Yarden Shoham
ab926212d9
Apply suggestions from code review
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
7 months ago
Felipe Santos
392ff93916
Fix flaky TestDedupeRepos ( #30576 )
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
7 months ago
Joe Julian
0fcd1d33b3
Merge pull request #11112 from felipecrs/filter-dup-repos
...
perf(dep-up): do not update the same repo multiple times
7 months ago
Yarden Shoham
f475f3e1fd
feat: error out when post-renderer produces no output
...
When the templating post-renderer produces no output, something went wrong so we error out.
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
7 months ago
Scott Rigby
2cda65d444
Merge pull request #10309 from Bez625/main
...
Add hook annotation to output hook logs to client on error
7 months ago
Matt Farina
1382a2894a
Merge pull request #30567 from mattfarina/chartutil-to-chart-util
...
Moving chartutil to chart/util
7 months ago
Robert Sirchia
8dd279271e
remove unused config.go
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Matt Farina
5c0deec327
Moving chartutil to chart/util
...
chartutil was originally created to operate on protobufs which are
no longer part of Helm. The util package makes more sense to be
part of the chart package.
This change is part of the HIP 20 to create v3 charts and
explicitly call out v2 charts. The changes for this are in smaller
bite size changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
Chris Berry
e5bc21c56b
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
9791767baa
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
6d30fa5990
Add HookOutputFunc and generic yaml unmarshaller
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Scott Rigby
52ac92fb69
clarify fix error message
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
e8a76bc3eb
fix err check
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
3796c1f4a1
remove comments about previous functionality
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
f729b9ade0
add short circuit return
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Chris Berry
243cb2e21f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
3d4e679d9f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
a55a477069
Fix lint
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris
3964f84ac8
Tidy up imports
...
Signed-off-by: Chris <bez625@gmail.com>
7 months ago
Chris Berry
cde407b7d1
Add hook annotations to output pod logs to client on success and fail
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
George Jenkins
a780fa60ed
Merge pull request #13655 from LuBingtan/dev
...
feat: support multi-document values files
7 months ago
Felipe Santos
b1fd239167
Fix tests failing after removing repo normalization
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
7 months ago
Felipe Santos
ecb5a2c9dd
Fix variable name for linter
...
And restore trimSuffix instead of trimRight, which was a mistake.
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
7 months ago
Felipe Santos
281ccb0835
Do not store the normalized chart url
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
7 months ago
Felipe Santos
bb6314adef
Do not reassign repos variable
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
7 months ago
Felipe Santos
44d53e7d49
Merge branch 'main' of https://github.com/helm/helm into filter-dup-repos
7 months ago
Robert Sirchia
8207fafe13
fixing error handling from a previous PR
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Zhanwei Li
34b679e0cc
feat: Add mustToYaml and mustToJson template functions
...
Introduces two new template functions that marshal data to YAML and
JSON, respectively, and panic on errors. This allows for strict
validation of template output formats.
Signed-off-by: Zhanwei Li <zhanweelee@gmail.com>
7 months ago
lubingtan
ef5614364b
fix: replace mergeMaps call with loader.MergeMaps in MergeValues function
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
7 months ago
lubingtan
91cd72d0e4
fix: improve LoadValues function documentation
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
7 months ago
lubingtan
fb7221bc9a
fix: add doc for func MergeMaps
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
7 months ago
lubingtan
3d84e00ce7
fix: use Reader interface as the input of LoadValues and enhance UT of LoadValues
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
7 months ago
lubingtan
92087f6e33
feat: support multi-document values files for default chart values
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
7 months ago
lubingtan
0d36cb664a
feat: support multi-document values files
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
7 months ago
Matt Farina
8edc3ac024
Merge pull request #13471 from wangjingcun/main
...
Use a more direct and less error-prone return value
7 months ago
Matt Farina
2603390c2e
Merge pull request #30470 from gjenkins8/cleanup_repotest_server
...
Cleanup `repotest.Server` constructors
7 months ago
Robert Sirchia
9408978517
Merge pull request #30294 from Zhanweelee/supports-json-arguments
...
Supports json arguments
7 months ago
Austin Abro
ea87c49d1b
print
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
efde830405
better name
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
ecd5316577
lint
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
hugehope
001d2978b6
refactor: using slices.Contains to simplify the code
...
Signed-off-by: hugehope <cmm7@sina.cn>
7 months ago
Felipe Santos
f692751a46
Merge branch 'main' of https://github.com/helm/helm into filter-dup-repos
7 months ago
Austin Abro
5d12255497
wait for delete
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
7fde4962a8
set waiter in functions
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
978d5a3318
lint
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
f2dd2c9109
add hook only waiter
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
2b03c527f1
set command line flags
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
George Jenkins
2caca2b167
remove `ChartPaths[]`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
George Jenkins
17bc0b3845
refactor: Remove ChartRepository Load() function
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
wangjingcun
8b8cc94822
Use a more direct and less error-prone return value
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
7 months ago
Austin Abro
bd3b5ee5d0
comment
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
7207565e12
lint
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
f866409c50
move statusreaders to it's own package
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
14391dea5b
pods and jobs working
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
d1cc9b39a3
tests for status reader
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Jonathan
37020c32fa
Update pkg/cli/values/options.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Jonathan <zhanweelee@gmail.com>
7 months ago
George Jenkins
234d171da5
Cleanup repotest Server constructors
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
Zhanwei Li
274d43c10d
feat: Enhance JSON value parsing in Helm CLI
...
- Add support for parsing full JSON objects with `--set-json`
- Update documentation to clarify JSON value input formats
- Improve test coverage for value parsing scenarios
- Modify `MergeValues` to handle both key=value and JSON object formats
Signed-off-by: Zhanwei Li <zhanweelee@gmail.com>
7 months ago
Austin Abro
187e99d299
custom status readers look good
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
8 months ago