3446 Commits (main)

Author	SHA1	Message	Date
Mohammadreza Asadollahifard	96c54a2963	refactor color output functions to simplify noColor checks ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	2 months ago
Mohammadreza Asadollahifard	b630ae30a5	Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes	2 months ago
Khwaja Faraz Ahmed	d50d22c970	Add test coverage for get_values/metadata.go ... Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai> Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>	2 months ago
Danilo Bürger	8096f09370	Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme ... Signed-off-by: Danilo Bürger <danilo.buerger@helsing.ai>	2 months ago
Scott Rigby	091f9a24fe	Merge pull request #13154 from carloslima/post-render-everything ... Allow post-renderer to process hooks	2 months ago
Robert Sirchia	49e82c1fe9	Merge pull request #31042 from TerryHowe/fix-test-teardown-dns-data-race ... fix: test teardown dns data race	2 months ago
jingchanglu	2da734d0b2	chore: fix typo in pkg/repo/chartrepo.go ... Signed-off-by: jingchanglu <jingchanglu@outlook.com>	2 months ago
Terry Howe	82bc9adcc2	fix: test teardown dns data race ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	2 months ago
Yuriy Losev	46b1a41631	Add release labels to the release Metadata ... Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>	2 months ago
Robert Sirchia	4b8e61093d	Merge commit from fork ... Updating link handling	2 months ago
naving1989	4310b2bc36	Fixed linting issues ... Signed-off-by: naving1989 <navinag1989@gmail.com>	2 months ago
Zach Burgess	1002ec5ae9	Update tests in lint_test.go ... Signed-off-by: Zach Burgess <zachburg@google.com>	2 months ago
Zach Burgess	35434947a3	Return a lint warning if `templates/` does not exist. ... Signed-off-by: Zach Burgess <zachburg@google.com>	2 months ago
Zach Burgess	b6e3301bef	Merge branch 'helm:main' into templates_lint	2 months ago
Zach Burgess	fe11438715	Raise error instead of warning if `crds/` is not a valid directory ... Signed-off-by: Zach Burgess <zachburg@google.com>	2 months ago
Zach Burgess	eea2d4577b	Raise an error if the `templates/` dir is not valid and return early. ... Signed-off-by: Zach Burgess <zachburg@google.com>	2 months ago
Mohammadreza Asadollahifard	1e00790b8c	refactor tests to use t.Setenv for NO_COLOR environment variable ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	2 months ago
Mohammadreza Asadollahifard	c547d1f2ae	add color output functionality and tests for release statuses ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	2 months ago
Zach Burgess	3a318c2fa3	Update crds.go after https://github.com/helm/helm/pull/31029 ... Signed-off-by: Zach Burgess <zachburg@google.com>	2 months ago
Zach Burgess	81af3c9570	Merge branch 'helm:main' into crds_lint	2 months ago
George Jenkins	d21a8a04cb	Merge pull request #31029 from gjenkins8/gjenkins/k8s_yaml_struct ... chore(refactor): Privatize 'k8sYamlStruct'	2 months ago
Zach Burgess	cc85352a0e	Use `assert.Len` instead of `assert.Lenf` ... The default message from testify is descriptive enough. Signed-off-by: Zach Burgess <zachburg@google.com>	2 months ago
Zach Burgess	c59a097209	Remove duplicate test case from crds_test.go ... The "good" test case for CRDs is done in `TestGoodChart` in lint_test.go. Signed-off-by: Zach Burgess <zachburg@google.com>	2 months ago
naving1989	3b2f9e7d6f	test: increase test coverage for pkg/cli/options.go file ... Signed-off-by: naving1989 <navinag1989@gmail.com>	2 months ago
Zach Burgess	bf9084a16a	Rename `validateCrdApiVersion` to `validateCrdAPIVersion` ... Signed-off-by: Zach Burgess <zachburg@google.com>	2 months ago
Zach Burgess	357957b0d3	Use testify and add a CRD to the `goodone` test case. ... Signed-off-by: Zach Burgess <zachburg@google.com>	2 months ago
Zach Burgess	dadaff716a	Merge branch 'helm:main' into crds_lint	2 months ago
Zach Burgess	6e30619d8f	Merge branch 'helm:main' into templates_lint	2 months ago
Matt Farina	76fdba4c8c	Updating link handling ... Signed-off-by: Matt Farina <matt.farina@suse.com>	2 months ago
George Jenkins	bbea98ed6b	Merge pull request #30898 from fidelity-contributions/fix-issue-13198 ... Fix issue 13198	3 months ago
George Jenkins	4c674728d2	Privatize 'k8sYamlStruct' ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	3 months ago
George Jenkins	edd0dabe02	Merge pull request #31021 from zachburg/test_temp_dir ... Update tests in create_test.go and package_test.go to work in a temp directory	3 months ago
Matt Farina	e8be2e540d	Merge pull request #31023 from gjenkins8/gjenkins/rm_recreate_pods ... Remove deprecated '--create-pods' flag	3 months ago
George Jenkins	a3bcc5b184	fix: 'TestRunLinterRule' stateful test ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	3 months ago
George Jenkins	5283915c57	Remove deprecated '--create-pods' flag ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	3 months ago
George Jenkins	de1bdf5820	switch to slog ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	3 months ago
George Jenkins	62ca98f521	fix up verbiage ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	3 months ago
George Jenkins	5f9cbe6f4a	fix: Port pluginCommand & command warning ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	3 months ago
Zach Burgess	eaf40b4b4f	Call `ensure.HelmHome()` in package_test.go ... Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Matt Farina	9517cfc5ce	Merge pull request #31009 from tpresa/test-coverage-pusher ... test: increase test coverage for pkg/pusher	3 months ago
Zach Burgess	c48a3435f5	Remove unnecessary calls for changing directory to `helmpath.CachePath`. ... This was only set on some tests in create_test.go and isn't affecting the test. Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Carlos Lima	6991a0a531	Make annotateAndMerge deterministic ... Signed-off-by: Carlos Lima <carlos@cpan.org>	3 months ago
Carlos Lima	c01e76b5c3	review: change annotation name to postrenderer.helm.sh/postrender-filename ... Signed-off-by: Carlos Lima <carlos@cpan.org>	3 months ago
Carlos Lima	a1416cf225	review: style changes ... Signed-off-by: Carlos Lima <carlos@cpan.org>	3 months ago
Carlos Lima	859721bd77	review: rewrite error messages from the end-user perspective ... Signed-off-by: Carlos Lima <carlos@cpan.org>	3 months ago
Carlos Lima	b26b473bf6	review: make splitAndDeannotate private ... Signed-off-by: Carlos Lima <carlos@cpan.org>	3 months ago
Carlos Lima	855b5a44b7	review: make annotateAndMerge private ... Signed-off-by: Carlos Lima <carlos@cpan.org>	3 months ago
Carlos Lima	1d993f9e2d	review: make filenameAnnotation private ... Signed-off-by: Carlos Lima <carlos@cpan.org>	3 months ago
Carlos Lima	e6362d74c8	Allow post-renderer to process hooks ... This annotates and merges all manifests before sending to the postrender, reversing the process and recovering the filenames afterwards. closes #7891 Signed-off-by: Carlos Lima <carlos@cpan.org>	3 months ago
Zach Burgess	3b26ddc22b	Update tests in create_test.go and package_test.go to work in a temp dir. ... Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Zach Burgess	b703d5b4bb	Return early when linting if the `templates/` dir does not exist ... The `vaildateTemplatesDir` function would still return `nil` if the directory doesn't exist, so the early return that was documented never occurs. Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Zach Burgess	a99c3700f0	Return early if the `/crds` directory does not exist. ... Don't silently discard the error from `os.Stat`. Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Zach Burgess	562ff982cb	Early return if the `/crds` directory does not exist and don't silently discard the error from `os.Stat`. ... Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Zach Burgess	d6ddd8e661	Document that attempting to parse YAML checks that the CRD is not a ... template Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Zach Burgess	e4c88faeff	Update test assertions ... Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Zach Burgess	bc35ea5ad7	Fix comment in pkg/lint/rules/testdata/invalidcrdsdir/values.yaml ... Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Zach Burgess	21b9aa3d94	Lint the `crds/` directory. ... This checks that the `crds/` dir only contains YAML files that define K8s resources with `kind: CustomResourceDefinition`. Checking that the YAML files are not templates will be done in a separate commit. Signed-off-by: Zach Burgess <zachburg@google.com>	3 months ago
Thiago Presa	afd63fed77	test: increase test coverage for pkg/pusher ... Signed-off-by: Thiago Presa <thiago.addevico@gmail.com>	3 months ago
Matt Farina	f0cf9c28f0	Move logging setup to be configurable ... Signed-off-by: Matt Farina <matt.farina@suse.com>	3 months ago
curlwget	bfc1af68fb	chore: fix function in comment ... Signed-off-by: curlwget <curlwget@icloud.com>	3 months ago
George Jenkins	a2a0935cba	Merge pull request #30900 from unguiculus/issue-12952 ... Add timeout flag to repo add and update commands	3 months ago
Terry Howe	f55c462a79	fix: force bearer oauth for everything ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	3 months ago
Robert Sirchia	ba0fbdeb57	Merge pull request #30979 from TerryHowe/oras-v2-login-for-v4 ... fix: OAuth username password login for v4	3 months ago
Terry Howe	df482346db	fix: lint test SetEnv errors ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	3 months ago
Terry Howe	47980159b3	fix: user username password for login ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	3 months ago
manslaughter03	bc44614a78	fix: wrap run release test error in case GetPodLogs failed. ... Signed-off-by: manslaughter03 <manslaughter03@gmail.com>	3 months ago
Terry Howe	744c6b5a97	fix: kube client create mutex ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	3 months ago
Ashmit Bhardwaj	e060fbe185	updated docs ... Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>	3 months ago
Ashmit Bhardwaj	0389407cbc	removed unnecessary binary file ... Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>	3 months ago
Ashmit Bhardwaj	b305a501e8	added documentation and test cases for api-versions flag ... Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>	3 months ago
Terry Howe	93ec064640	fix: repo update cmd mutex ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	4 months ago
acceptacross	9623fb80f1	chore: fix some function names in comment ... Signed-off-by: acceptacross <csqcqs@gmail.com>	4 months ago
Matt Farina	7031000b7d	Merge pull request #30955 from carloslima/fix-test-deleting-local-directories ... Fix tests deleting XDG_DATA_HOME	4 months ago
Scott Rigby	069b525332	Merge pull request #13586 from jessesimpson36/cleaner-stacktraces ... fix: add formatting for errors to make multiline stacktraces in helm templates	4 months ago
Carlos Lima	f8204031f1	Fix tests deleting XDG_DATA_HOME ... That includes ~/.local/share/keyrings which was the most immediatelly visible effect. Signed-off-by: Carlos Lima <carlos@cpan.org>	4 months ago
Robert Sirchia	c0aa690c90	Merge pull request #30909 from jinjiadu/main ... refactor: replace HasPrefix+TrimPrefix with CutPrefix	4 months ago
Scott Rigby	e2630d1aba	Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex ... fix: action hooks delete policy mutex	4 months ago
Scott Rigby	de745ea34b	Merge pull request #12581 from Nordix/considerAllGroupVersionKind ... Consider full GroupVersionKind when matching resources	4 months ago
Scott Rigby	e8c1acf228	Merge pull request #30809 from mmorel-35/usetesting ... chore: enable usetesting linter	4 months ago
Scott Rigby	4023c3b5ff	Merge pull request #30917 from TerryHowe/oci-transport-debugging ... fix: add debug logging to oci transport	4 months ago
Terry Howe	a8cbf3aa51	fix: action hooks delete policy mutex ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	4 months ago
Matthieu MOREL	56a2bb4188	chore: enable usetesting linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	4 months ago
Terry Howe	6ab7aa3612	fix: legacy docker support broken for login ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	4 months ago
Terry Howe	5fe7a87138	fix: add debug logging to oci transport ... Signed-off-by: Terry Howe <terrylhowe@gmail.com> Co-authored-by: Billy Zha <jinzha1@microsoft.com>	4 months ago
Benoit Tigeot	6df8eb3b3b	Fix flaky TestFindChartURL due to non-deterministic map iteration ... The test was failing intermittently because Go's map iteration order is randomized (see `range repos` in `findChartUrl`). When looking up the `baz` chart with repository URL http://example.com/helm, two repositories match due to trailing slash equivalence: - testing-relative (URL: http://example.com/helm) - contains baz chart GOOD - testing-relative-trailing-slash (URL: http://example.com/helm/) - does not contain baz chart.. NOT GOOD The urlutil.Equal() function treats these URLs as equivalent, but depending on which repository the random map iterator encounters first, the test would either pass or fail with "entry not found". So I changed the third test case from baz to foo chart, since foo exists in both matching repositories. This eliminates the race condition while preserving all test expectations and logic. `findChartURL()` iterates over a map without deterministic ordering, causing the first-match-wins behavior to be non-deterministic when multiple repositories match the same URL pattern. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	4 months ago
Scott Rigby	d4e58c54ba	Merge pull request #30928 from TerryHowe/fix-plugin-install-no-internet ... fix: plugin installer test with no Internet	4 months ago
Terry Howe	cc39d2428f	fix: plugin installer test with no Internet ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	4 months ago
Benoit Tigeot	b2fd91b8d0	Adapt error of invalid json schema with the new expected output ... Closes: https://github.com/helm/helm/pull/30907 To be able to upgrade to v6.0.2 for jsonschema lib we need to upgrade this test. I am wondering if it's related to this commit: 86cca28795 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	4 months ago
Reinhard Nägele	d448cf1943	Add timeout flag to repo add and update flags ... Signed-off-by: Reinhard Nägele <unguiculus@gmail.com> # Conflicts: # pkg/cmd/repo_update.go	4 months ago
jinjiadu	6f8e9e09a4	refactor: replace HasPrefix+TrimPrefix with CutPrefix ... Signed-off-by: jinjiadu <jinjiadu@aliyun.com>	4 months ago
Robert Sirchia	b7e127dd6b	amending missed line to delete ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	4 months ago
Robert Sirchia	937c533e37	forward porting 30902 ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	4 months ago
Robert Sirchia	52dddba759	Merge pull request #30894 from benoittgt/fix-#30881-main ... Prevent push cmd failure in 3.18 by handling version tag resolution in ORAS memory store	4 months ago
Robert Sirchia	83c26845ad	Merge pull request #30904 from benoittgt/document-ideal-registry-login-command ... [Doc] Help users avoid specifying URL scheme and path with `helm registry`	4 months ago
Benoit Tigeot	f939f6145f	Prevent fetching newReference again as we have in calling method ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	4 months ago
Benoit Tigeot	cb730c94b5	Help users avoid specifying URL scheme an path ... We’ve noticed that some users still include the URL scheme and full path when logging into an OCI registry, for example: ```sh helm registry login -u $OCI_REGISTRY_USER --password-stdin oci://ghcr.io/org/repo ``` This is no longer necessary and will not be supported in Helm v4. To guide users toward the correct usage, we should show an example of the ideal command. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	4 months ago
Robert Sirchia	1b21f04b3b	Merge pull request #30865 from mmorel-35/github.com/evanphx/json-patch/v5 ... fix: update json-patch import path and add gomodguard settings	4 months ago
Benoit Tigeot	875e149d6b	Prevent failure when resolving version tags in oras memory store ... - The newReference() function transforms version tags by replacing + with _ for OCI compatibility - But the code was using the original ref (with +) for TagBytes() - Then it tries to find the tagged reference using parsedRef.String() (with _) - This mismatch causes the Resolve method to fail with "not found" - By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed. I extracted the TagBytes function to improve testability. Push() includes several external calls that are hard to mock, so isolating this logic makes testing more manageable. Close: #30881 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	4 months ago
Matt Farina	cf7613ba6b	Reverting fix "renders int as float" ... This reverts #13533 This change has caused issues with numerous charts around things unrelated to toml. This is because of functions like typeIs/typeOf being used and acted upon. The change caused a significant regression. Note: This kind of change can be put into v3 charts, that are in active development, without causing a regression. Closes #30880 Signed-off-by: Matt Farina <matt@mattfarina.com>	4 months ago
Matt Farina	0c91649ec8	Merge pull request #30871 from gjenkins8/gjenkins/test_registry_localhost ... Run test OCI registry localhost	4 months ago
Matt Farina	f043faf0a3	Merge pull request #30862 from OmriSteiner/fix-absolute-uri ... fix: correctly concat absolute URIs in repo cache	4 months ago
Matt Farina	ab56ac62ba	Merge pull request #30866 from mmorel-35/thelper ... chore: enable thelper linter	4 months ago
George Jenkins	8ba181c343	Run test OCI registry localhost ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	4 months ago
Matthieu MOREL	157f0ba10a	chore: enable thelper ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	4 months ago
Matthieu MOREL	706392fabb	fix: update json-patch import path and add gomodguard settings ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	4 months ago
Matt Farina	b5a4781099	Adding test for list command ... Signed-off-by: Matt Farina <matt.farina@suse.com>	4 months ago
Omri Steiner	c47c8fc868	fix: correctly concat absolute URIs in repo cache ... There used to be two implemenations for concatenating the repo URL with the chart URI / URL. In case the chart specified an absolute URI, one of the implementations performed an incorrect concatenation between the two, resulting in a URL which looks like <repo-URL><absolute-chart-URI>. This commit removes the faulty implementation and uses the other correct one instead. Signed-off-by: Omri Steiner <omri@steiners.co.il>	4 months ago
Matt Farina	dd40316660	Merge pull request #30842 from ayushontop/main ... Fix : No repository is not an error,use the helm repo list command ,if there is no repository,it should not be an error #30606	4 months ago
MichaelMorris	1460ebd14a	Added test case to resource_test.go ... Signed-off-by: MichaelMorris <michael.morris@est.tech>	4 months ago
MichaelMorris	9a2ac85077	Consider GroupVersionKind when matching resources ... This change shall take Group, Version and Kind from GroupVersionKind into consideration instead of the current behavior of only considering the Kind Closes: #12578 Signed-off-by: MichaelMorris <michael.morris@est.tech>	4 months ago
Ayush Tiwari	56b688145f	added cmd in repo_list.go for pipeline ... Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>	4 months ago
Robert Sirchia	b2456202ae	Merge pull request #30850 from yetyear/main ... refactor: use maps.Copy for cleaner map handling	4 months ago
George Jenkins	2c1257537c	Merge pull request #30829 from TerryHowe/increase-time-pkg-test-coverage ... Increase pkg/time test coverage	4 months ago
yetyear	03448d1d79	refactor: use maps.Copy for cleaner map handling ... Signed-off-by: yetyear <flite@outlook.com>	4 months ago
Robert Sirchia	4d580c6b95	Merge pull request #30810 from mmorel-35/usestdlibvars ... chore: enable usestdlibvars linter	4 months ago
Terry Howe	71787cca60	fix: rename slave replica ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	5 months ago
George Jenkins	a1f8802de9	Merge pull request #30553 from Zhanweelee/add_mustToYaml_support ... feat: Add mustToYaml and mustToJson template functions	5 months ago
Ayush Tiwari	e63cbae886	added cmd.ErrOrStderr() ... Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>	5 months ago
Ayush Tiwari	95328ea0a6	removed error import ... Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>	5 months ago
Ayush Tiwari	058bc083a8	changed Error to print ... Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>	5 months ago
Terry Howe	da579a7aa6	chore: add test coverage for time package ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	5 months ago
findnature	ac8d2f9aed	refactor: use slices.Contains to simplify code ... Signed-off-by: findnature <cricis@aliyun.com>	5 months ago
Terry Howe	f754e6a23b	chore: increase test coverage of time pkg ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	5 months ago
Matthieu MOREL	77a267dacf	chore: enable usestdlibvars linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Jesse Simpson	e0a67b1028	test: use more realistic unit-test scenario by not relying on Release.Name ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	d10c5f6429	style: trim space from formatted error messages ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	0e0a8cc765	fix: address no-template-associated type of error ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	013f27c294	fix: use errors.New instead of fmt.Errorf ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	868cdc261f	refactor: reduce flow-control operations ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	48922e21d1	refactor: use struct equality instead of comparing each composition ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	ac98e977c3	refactor: switch to while loop instead of for to reduce unnecessary variables ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	65084371c9	refactor: replace if MatchString with FindStringSubMatch ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	782f6c6409	refactor: shorten regex subexp syntax ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	4b9a9ecaf6	refactor: rename function and add doc-string ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	4f63c73353	refactor: remove impractical safety check ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	5202820f2f	refactor: define regexs at package scope ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	cbdc22128e	refactor: use strings.Builder instead of string concatenation ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	cdcf1bc601	style: remove unnecessary break ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	3cc4cb60ba	refactor: prevent duplicates being inserted rather than post-filtering ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	deea4a0d0e	refactor: remove more unnecessary format calls ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	0a7dd4b269	test: adjust failing test on extra whitespace ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	13b232e061	refactor: make use of regexs for err parsing ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	daf4c34879	fix: use originalErr instead of formatting original error ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	98da3e28b6	fix: add some index checking and fixed a test that relied on type-checking ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	80d7a1b33f	style: make format ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	edf0f7be59	test: adjust formatting for error in test ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	487f72b822	fix: added protection against while-true condition in unbounded for loop ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	6bb836374b	test: adjusted to make it more meaningful and to pass ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	383a758aec	fix: add quality checks to ensure formatted error doesnt remove important info ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	d8bec4e30f	fix: remove comparison from old error message to new ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	c481470985	style: renamed i variable for consistency ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	2e3f6dce28	fix: save to fileLocation rather than fileLocations[i] which gets overwritten ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	f09bbb8ab8	style: consolidate for loops ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	1357db4db1	style: removed variable only used once ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	a56daca82b	style: use interface functions instead of inline logic ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	87f9e2dc45	style: create String function for TraceableError representing one chunk of a stacktrace ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	6cd0c0082a	fix: split up the multiline errors to be more vertical ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	cc477e9f79	fix: adjust test to not require external chart ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
Jesse Simpson	14f902c245	wip: draft at making cleaner stacktraces ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	5 months ago
George Jenkins	ecf1730689	Merge pull request #13460 from justenstall/stdlib-errors-2 ... fix: replace "github.com/pkg/errors" with stdlib "errors" package	5 months ago
Justen Stall	4905a61026	Merge branch 'main' into stdlib-errors-2 ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	5 months ago
Matt Farina	fcd37bcea7	Merge pull request #30783 from rpolishchuk/investigate-TestValidateChartIconPresence ... fix: chart icon presence test	5 months ago
Robert Sirchia	d9bc0a948c	Merge pull request #30777 from ryanhockstad/merge-fix ... fix: null merge. closes #30587	5 months ago
Scott Rigby	a911aa2112	Merge pull request #9175 from dastrobu/copy-dependencies-on-aliasing ... fix: copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies	5 months ago
Daniel Strobusch	b183eccfc4	copy dependency metadata on aliasing to avoid sharing imported values ... imported values are stored in dependency objects, which breaks if a chart dependency is shared among multiple aliases. By copying the dependency objects in the metadata values can be imported correctly. Supersedes #10174 Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>	5 months ago
Daniel Strobusch	df7befd208	copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies ... Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases. By copying the dependencies, parent information can be set correctly to render the templates as expected later on. Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level. Closes #9150 Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>	5 months ago
Stephen Murray	1682895636	ref(helm): Export Chart Not Found error ... Closes #30746 Signed-off-by: Stephen Murray <stephenmurrayengineer@gmail.com>	5 months ago
Rostyslav Polishchuk	1c8d1e375f	fix: chart icon presence test ... The `TestValidateChartIconPresence` test fails when run after `TestValidateChartIconURL` as they both are using a global variable `badChart.Icon` ``` : go test -v -test.shuffle 1 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/ -test.shuffle 1 === RUN TestValidateChartIconURL --- PASS: TestValidateChartIconURL (0.00s) === RUN TestValidateChartIconPresence chartfile_test.go:171: validateChartIconPresence to return a linter error, got no error --- FAIL: TestValidateChartIconPresence (0.00s) FAIL FAIL helm.sh/helm/v4/pkg/lint/rules 0.051s FAIL : go test -v -test.shuffle 2 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/ -test.shuffle 2 === RUN TestValidateChartIconPresence --- PASS: TestValidateChartIconPresence (0.00s) === RUN TestValidateChartIconURL --- PASS: TestValidateChartIconURL (0.00s) PASS ok helm.sh/helm/v4/pkg/lint/rules 0.050s ``` This commit: 1. Remove dependency on global variable 2. Explicitly set the state of the test object. Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>	5 months ago
Justen Stall	fc6c5e5edb	remove WaitAndGetCompletedPodPhase function ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	5 months ago
Justen Stall	73545f9a3e	one more test output ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	5 months ago
Justen Stall	4a6092bd6c	update another test output ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	5 months ago
Justen Stall	7a316c8d51	update expected error message in install test ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	5 months ago
Matthieu MOREL	d3eeb2c942	chore: remove github.com/hashicorp/go-multierror dependency ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Justen Stall	3877ec9049	fix golangci-lint issues ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	5 months ago
Justen Stall	065e2eb3eb	updates after merge conflict resolution ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	5 months ago
Justen Stall	280a9ddbdb	Merge branch 'main' into stdlib-errors-2 ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	5 months ago
Scott Rigby	eb6e240cfe	Merge pull request #30734 from ipaqsa/feature/add-custom-template-funcs ... feat(pkg/engine): add support for custom template funcs	5 months ago
Scott Rigby	8255300280	Merge pull request #12382 from edbmiller/ed-dot-miller/parse-chartfile-yaml-strictly ... fix(pkg/lint): unmarshals Chart.yaml strictly	5 months ago
Ryan Hockstad	c1175a4106	fix null merge ... Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>	5 months ago
Edward Miller	e414695a5b	fix ... Signed-off-by: Edward Miller <edmiller287@gmail.com>	5 months ago
Benoit Tigeot	e2461de3c2	Fix test with toml bump ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	5 months ago
Matt Farina	a842140ef6	Merge pull request #13578 from gjenkins8/rm_chart_repo_load_func ... refactor: Remove ChartRepository `[]ChartPaths`	5 months ago
Edward Miller	629780a34a	fix: reapply error message fix ... Signed-off-by: Edward Miller <edmiller287@gmail.com>	5 months ago
Edward Miller	9d43f70643	Update error message ... Co-authored-by: Andrew Block <andy.block@gmail.com> Signed-off-by: Edward Miller <55854159+edbmiller@users.noreply.github.com>	5 months ago
Edward Miller	14a468f24d	Add chartutil.StrictLoadChartfile for strict (WARNING-level) lint ... Signed-off-by: Edward Miller <edmiller287@gmail.com>	5 months ago
Edward Miller	00f8561ad4	fix(pkg/lint): unmarshals Chart.yaml strictly ... When "helm lint" is run, it now errors on invalid chartfiles, e.g. those with duplicate keys Closes #12381 Signed-off-by: Edward Miller <edmiller287@gmail.com>	5 months ago
wangcundashang	7bb0c85441	chore: fix function name in comment ... Signed-off-by: wangcundashang <wangcundashang@qq.com>	5 months ago
Stepan Paksashvili	b54349d9b2	fix(pkg/engine): allow to override all functions ... Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>	5 months ago
Stepan Paksashvili	5c2f89307d	feat(pkg/engine): and custom funcs to action config ... Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>	5 months ago
Stepan Paksashvili	8982b57e5e	feat(pkg/engine): and custom funcs overriding test ... Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>	5 months ago
Stepan Paksashvili	9073bcf53e	feat(pkg/engine): add support for custom template funcs ... Enhances the template engine and action config to allow users to inject custom template functions via an action config when using Helm as a library. Closes #30733 Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>	5 months ago
Scott Rigby	599fad1864	Merge pull request #30697 from p-se/fix-take-ownership ... Fix --take-ownership for custom resources - closes #30622	5 months ago
Evans Mungai	1f5605a405	fix formatting errors ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	5 months ago
Benoit Tigeot	d33e2896f0	Prevent failures with method signatures on hooks ... changes on wait strategy. This PR try to fix linting and tests. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	5 months ago
Scott Rigby	e397f44840	Merge pull request #30673 from nvanthao/process-all-hook-deletions-on-failure ... fix: Process all hook deletions on failure	5 months ago
Matt Farina	01590a59b2	Merge pull request #30760 from robertsirc/add-debuging-to-jsonschema ... adding slog debug to a few points	5 months ago
Robert Sirchia	8733103743	Merge pull request #30718 from klihub/fixes/package/multiple-charts-single-passwd-from-stdin ... Allow signing multiple charts with a single passphrase from stdin.	5 months ago
Robert Sirchia	da096e1b7a	Merge pull request #30752 from benoittgt/bump-golangci-lint-action ... Bump golangci lint to last major version and fix static-check errors	5 months ago
Robert Sirchia	ef0361de21	fixing as per review ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	5 months ago
Robert Sirchia	9b9ff12c6d	adding slog debug to a few points ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	5 months ago