Terry Howe
d461463085
Merge pull request #32299 from benoittgt/avoid-issue-with-govuln-deprecation
...
fix(ci): resolve Node 20 deprecation in govulncheck
3 hours ago
Benoit Tigeot
ed651de9b1
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
6 hours ago
Benoit Tigeot
ca24a55c31
fix(ci): resolve Node 20 deprecation in govulncheck
...
The pinned v1.0.4 used actions/checkout@v4 and
actions/setup-go@v5 internally, both built on Node 20.
Latest main uses v6 of both, which run on Node 24.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 hours ago
Terry Howe
d262c7ca79
Merge pull request #32296 from mmorel-35/gocritic-singleCaseSwitch
...
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
22 hours ago
Terry Howe
50fb6ff85b
Merge pull request #32294 from mmorel-35/testifylint
...
chore: fix several checks issues from testifylint
23 hours ago
Terry Howe
a572f23b82
Merge pull request #32298 from helm/dependabot/go_modules/main/golang.org/x/text-0.39.0
...
chore(deps): bump golang.org/x/text from 0.38.0 to 0.39.0
2 days ago
dependabot[bot]
e3fbe2e9d1
chore(deps): bump golang.org/x/text from 0.38.0 to 0.39.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.38.0 to 0.39.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.38.0...v0.39.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.39.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2 days ago
Matthieu MOREL
96b315f188
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 days ago
Matthieu MOREL
c1569ea83f
Update pkg/cmd/history_test.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 days ago
Matthieu MOREL
65077c10fa
test: replace assert.Equal with require.EqualError for improved error handling
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 days ago
Matthieu MOREL
4ade4a5495
test: replace assert.Contains with assert.ErrorContains for better error handling
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 days ago
Matthieu MOREL
f34ad6c337
chore: fix several checks issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 days ago
George Jenkins
7b999ddc07
Merge pull request #32293 from mmorel-35/gocritic-httpNoBody
...
chore: fix several checks issues from gocritic
2 days ago
Matthieu MOREL
07259ecc86
chore: fix several checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 days ago
Terry Howe
543b94d673
Merge pull request #31211 from kimsungmin1/main-fix-push-scope
...
fix: set [pull,push] scope when helm push to a registry(use token auth) - v4
5 days ago
kimsungmin1
d539556a8d
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: kimsungmin1 <142377392+kimsungmin1@users.noreply.github.com>
5 days ago
Terry Howe
b229279def
Merge pull request #32285 from helm/dependabot/github_actions/main/github/codeql-action/upload-sarif-4.36.3
...
chore(deps): bump github/codeql-action/upload-sarif from 4.36.2 to 4.36.3
5 days ago
dependabot[bot]
e9eda8c598
chore(deps): bump github/codeql-action/upload-sarif
...
Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ) from 4.36.2 to 4.36.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](8aad20d150...54f647b7e1 )
---
updated-dependencies:
- dependency-name: github/codeql-action/upload-sarif
dependency-version: 4.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
6 days ago
kimsm28
503acff975
fix(registry): resolve golangci-lint issues in token-auth tests
...
- Use (*net.ListenConfig).Listen with the test context instead of
net.Listen (noctx).
- Use suite.NoError instead of suite.Nil for the error check
(testifylint).
- Drop the unnecessary leading blank lines in the scope test funcs
(whitespace).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
6 days ago
kimsm28
4e9ca06856
chore: go mod tidy after rebase on main
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
6 days ago
kimsm28
3cbee7e935
fix(registry): use plain-http registry in token-auth scope test
...
The scope test configured a TLS registry while advertising an http token
realm. oras refuses to send credentials to an http token realm when the
registry itself was contacted over https, so the auth server was never
reached and the test timed out ("timeout waiting for auth request").
Use a plain-http registry so the registry and token-realm schemes match;
the scope carried in the token request is what this test verifies, and
that is independent of TLS.
Also make the auth handler's channel send non-blocking so that a client
retry can never block the handler and stall the push/pull flow, which
addresses the review comment about a potential deadlock.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
6 days ago
Terry Howe
26ada49c1a
Update pkg/registry/client.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
6 days ago
kimsm28
9b7a70f0ca
test: improve client_scope_test.go to avoid data races and brittle assertions
...
- Fix data race by using channel instead of shared variable for requestURL
- Make assertions more robust by parsing URL and checking query parameters instead of exact string matching
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
6 days ago
kimsm28
ee181f4570
fix typos in withScopeHint function comment
...
- Change 'bellow' to 'below' (spelling correction in multiple places)
- Change 'WithScopeHint' to 'withScopeHint' to match actual function name
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
6 days ago
kimsm28
1f0a728496
fix registry test failures by adjusting DockerRegistryHost and auth server listener management
...
- Change DockerRegistryHost to use 127.0.0.1 for HTTP tests and helm-test-registry for TLS tests to match certificate hostname
- Add defer ln.Close() to prevent resource leak in token auth server setup
- Restore requestURL variable and assertion in test body instead of handler to avoid potential race condition
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
6 days ago
kimsm28
8883c9cc70
fix variable naming requestUrl -> requestURL
...
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
6 days ago
kimsm28
530e728ea9
fix typo, remove unnecessary code, fix to avoid to use the assertion in http hanlder
...
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
6 days ago
kimsungmin1
26e5071f66
change suite.Nil, suite.NotNill to more proper function(suite.NoError, suite.Error)
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
6 days ago
kimsungmin1
8c8d6e3262
change client_scope_test.go to use httptest
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
6 days ago
kimsungmin1
9d77ccd46d
fix typo
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
6 days ago
kimsungmin1
fc743b2a1b
remove freeport dependency
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
6 days ago
kimsungmin1
319e06cda3
add newline in license header
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
6 days ago
kimsungmin1
301e3a12d5
fix scope when helm push to a registry that use token auth
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
6 days ago
Terry Howe
af25d22902
Merge pull request #32275 from helm/dependabot/github_actions/main/golangci/golangci-lint-action-9.3.0
...
chore(deps): bump golangci/golangci-lint-action from 9.2.1 to 9.3.0
1 week ago
Terry Howe
943242fb83
Merge pull request #32276 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-1.2.2
...
chore(deps): bump github.com/fluxcd/cli-utils from 1.2.1 to 1.2.2
1 week ago
dependabot[bot]
5a9b8a788f
chore(deps): bump github.com/fluxcd/cli-utils from 1.2.1 to 1.2.2
...
Bumps [github.com/fluxcd/cli-utils](https://github.com/fluxcd/cli-utils ) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/fluxcd/cli-utils/releases )
- [Commits](https://github.com/fluxcd/cli-utils/compare/v1.2.1...v1.2.2 )
---
updated-dependencies:
- dependency-name: github.com/fluxcd/cli-utils
dependency-version: 1.2.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 week ago
dependabot[bot]
f76136d39f
chore(deps): bump golangci/golangci-lint-action from 9.2.1 to 9.3.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 9.2.1 to 9.3.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](82606bf257...ba0d7d2ec0 )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-version: 9.3.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 week ago
Terry Howe
188d331dc3
Merge pull request #32259 from gjenkins8/refactor/testify-pkg-cli
...
refactor(pkg/cli): convert tests to testify assert/require
2 weeks ago
George Jenkins
144246cd28
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 weeks ago
Terry Howe
187a02298a
Merge pull request #32263 from helm/dependabot/github_actions/main/actions/setup-go-6.5.0
...
chore(deps): bump actions/setup-go from 6.4.0 to 6.5.0
2 weeks ago
dependabot[bot]
07faec5593
chore(deps): bump actions/setup-go from 6.4.0 to 6.5.0
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](4a3601121d...924ae3a1cd )
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-version: 6.5.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2 weeks ago
Terry Howe
1ffd0012d3
Merge pull request #32221 from gjenkins8/refactor/testify-pkg-small
...
refactor(pkg): convert tests to testify assert/require
2 weeks ago
Terry Howe
dd443e9685
Merge pull request #32260 from gjenkins8/refactor/testify-internal-small
...
refactor(internal): convert tests to testify assert/require
2 weeks ago
George Jenkins
addbab2e64
refactor(internal): convert tests to testify assert/require
...
Convert internal/urlutil, internal/cli/output, internal/monocular,
and internal/sympath test files from native Go testing patterns
(t.Errorf, t.Fatalf, t.Error, t.Fatal) to github.com/stretchr/testify
equivalents (assert.X, require.X).
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 weeks ago
Terry Howe
0bca9871ad
Merge pull request #32254 from gjenkins8/refactor/testify-pkg-registry
...
refactor(pkg/registry): convert tests to testify assert/require
2 weeks ago
Terry Howe
dd31a27000
Merge pull request #32256 from gjenkins8/refactor/testify-internal-util
...
refactor(internal): convert tests to testify assert/require
2 weeks ago
Terry Howe
7e2bdcb526
Merge pull request #32255 from gjenkins8/refactor/testify-pkg-release
...
refactor(pkg/release): convert tests to testify assert/require
2 weeks ago
Terry Howe
662c99f910
Merge pull request #32253 from gjenkins8/refactor/testify-repotest
...
refactor(repotest): convert tests to testify assert/require
2 weeks ago
Terry Howe
645e6369a7
Merge pull request #32252 from gjenkins8/refactor/testify-pkg-strvals
...
refactor(pkg/strvals): convert tests to testify assert/require
2 weeks ago
Terry Howe
4e810c9366
Merge pull request #32251 from gjenkins8/refactor/testify-cmd-helm
...
refactor(cmd/helm): convert tests to testify assert/require
2 weeks ago