George Jenkins
f3065ff1ba
Remove plugin deprecated 'UseTunnelDeprecated'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
George Jenkins
08840f042c
Rename 'atomic' -> 'rollback-on-failure'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
Borys Hulii
9f6beaad48
fix: k8s version parsing to match original
...
Signed-off-by: Borys Hulii <borys.hulii@bitvavo.com>
1 year ago
Luna Stadler
1031b67fff
Fix `helm pull` untar dir check with repo urls
...
The existing check worked for `helm pull downloaded-repo/chart-name`,
but often does not work when using `--repo-url`, depending on the urls
used by the charts.
Signed-off-by: Luna Stadler <luc@spreadshirt.net>
1 year ago
Artem Vdovin
118d0eb697
add concurrency test on write & load index file
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
1 year ago
Faraz Khawaja
f75100266b
Resolve conflicts
1 year ago
George Jenkins
8face0e596
Merge pull request #31060 from yumeiyin/main
...
refactor: replace Split in loops with more efficient SplitSeq
1 year ago
Robert Sirchia
619035d789
Merge pull request #31057 from danilobuerger/db/thick-lark
...
Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme
1 year ago
Joe Julian
7f4eb407c6
add missing template directory to badcrdfile testdata
...
Signed-off-by: Joe Julian <me@joejulian.name>
1 year ago
Joe Julian
08909e030b
Merge pull request #31019 from zachburg/templates_lint
...
Return early when linting if the `templates/` directory does not exist
1 year ago
Joe Julian
1f3e4ad12a
Merge pull request #31011 from yalosev/feature/add-labels-to-metadata
...
feature: add labels to metadata
1 year ago
Joe Julian
cd5ae5b19e
Merge pull request #31015 from zachburg/crds_lint
...
Add linter support for the `crds/` directory
1 year ago
Terry Howe
250ce7b5dc
chore: improve OCI debug logging
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Matt Farina
1a73633908
Merge pull request #31033 from navinag1989/test-cov-cli-options
...
test: increase test coverage for pkg/cli/options.go file
1 year ago
George Jenkins
74f2805f01
Rename 'force' to 'force-replace'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
yumeiyin
8c22fbfe4a
refactor: replace Split in loops with more efficient SplitSeq
...
Signed-off-by: yumeiyin <yin.yumei@qq.com>
1 year ago
Artem Vdovin
314bd19d11
update writing index files to writeAtomicFile
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
1 year ago
Danilo Bürger
055c4e2bec
Moved url comparison to own function
...
Signed-off-by: Danilo Bürger <info@danilobuerger.de>
1 year ago
Mohammadreza Asadollahifard
c1b3a83514
refactor: clean up color output imports in list, root, and status files
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
1 year ago
Mohammadreza Asadollahifard
d28343550f
feat: make color output opt-in by default
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
1 year ago
Mohammadreza Asadollahifard
ba8f70ae0b
refactor: move color package to internal/cli/output
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
1 year ago
Mohammadreza Asadollahifard
b72db06c49
refactor: replace NoColor with ColorMode for improved color output control
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
1 year ago
Mohammadreza Asadollahifard
96c54a2963
refactor color output functions to simplify noColor checks
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
1 year ago
Mohammadreza Asadollahifard
b630ae30a5
Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes
1 year ago
Khwaja Faraz Ahmed
d50d22c970
Add test coverage for get_values/metadata.go
...
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
1 year ago
Danilo Bürger
8096f09370
Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme
...
Signed-off-by: Danilo Bürger <danilo.buerger@helsing.ai>
1 year ago
Scott Rigby
091f9a24fe
Merge pull request #13154 from carloslima/post-render-everything
...
Allow post-renderer to process hooks
1 year ago
Robert Sirchia
49e82c1fe9
Merge pull request #31042 from TerryHowe/fix-test-teardown-dns-data-race
...
fix: test teardown dns data race
1 year ago
jingchanglu
2da734d0b2
chore: fix typo in pkg/repo/chartrepo.go
...
Signed-off-by: jingchanglu <jingchanglu@outlook.com>
1 year ago
Terry Howe
82bc9adcc2
fix: test teardown dns data race
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Yuriy Losev
46b1a41631
Add release labels to the release Metadata
...
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
1 year ago
Robert Sirchia
4b8e61093d
Merge commit from fork
...
Updating link handling
1 year ago
naving1989
4310b2bc36
Fixed linting issues
...
Signed-off-by: naving1989 <navinag1989@gmail.com>
1 year ago
Zach Burgess
1002ec5ae9
Update tests in lint_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
35434947a3
Return a lint warning if `templates/` does not exist.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
b6e3301bef
Merge branch 'helm:main' into templates_lint
1 year ago
Zach Burgess
fe11438715
Raise error instead of warning if `crds/` is not a valid directory
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
eea2d4577b
Raise an error if the `templates/` dir is not valid and return early.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Mohammadreza Asadollahifard
1e00790b8c
refactor tests to use t.Setenv for NO_COLOR environment variable
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
1 year ago
Mohammadreza Asadollahifard
c547d1f2ae
add color output functionality and tests for release statuses
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
1 year ago
Zach Burgess
3a318c2fa3
Update crds.go after https://github.com/helm/helm/pull/31029
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
81af3c9570
Merge branch 'helm:main' into crds_lint
1 year ago
George Jenkins
d21a8a04cb
Merge pull request #31029 from gjenkins8/gjenkins/k8s_yaml_struct
...
chore(refactor): Privatize 'k8sYamlStruct'
1 year ago
Zach Burgess
cc85352a0e
Use `assert.Len` instead of `assert.Lenf`
...
The default message from testify is descriptive enough.
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
c59a097209
Remove duplicate test case from crds_test.go
...
The "good" test case for CRDs is done in `TestGoodChart` in lint_test.go.
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
naving1989
3b2f9e7d6f
test: increase test coverage for pkg/cli/options.go file
...
Signed-off-by: naving1989 <navinag1989@gmail.com>
1 year ago
Zach Burgess
bf9084a16a
Rename `validateCrdApiVersion` to `validateCrdAPIVersion`
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
357957b0d3
Use testify and add a CRD to the `goodone` test case.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
dadaff716a
Merge branch 'helm:main' into crds_lint
1 year ago
Zach Burgess
6e30619d8f
Merge branch 'helm:main' into templates_lint
1 year ago
Matt Farina
76fdba4c8c
Updating link handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
George Jenkins
bbea98ed6b
Merge pull request #30898 from fidelity-contributions/fix-issue-13198
...
Fix issue 13198
1 year ago
George Jenkins
4c674728d2
Privatize 'k8sYamlStruct'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
George Jenkins
edd0dabe02
Merge pull request #31021 from zachburg/test_temp_dir
...
Update tests in create_test.go and package_test.go to work in a temp directory
1 year ago
Matt Farina
e8be2e540d
Merge pull request #31023 from gjenkins8/gjenkins/rm_recreate_pods
...
Remove deprecated '--create-pods' flag
1 year ago
George Jenkins
a3bcc5b184
fix: 'TestRunLinterRule' stateful test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
George Jenkins
5283915c57
Remove deprecated '--create-pods' flag
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
George Jenkins
de1bdf5820
switch to slog
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
George Jenkins
62ca98f521
fix up verbiage
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
George Jenkins
5f9cbe6f4a
fix: Port pluginCommand & command warning
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
Zach Burgess
eaf40b4b4f
Call `ensure.HelmHome()` in package_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Matt Farina
9517cfc5ce
Merge pull request #31009 from tpresa/test-coverage-pusher
...
test: increase test coverage for pkg/pusher
1 year ago
Zach Burgess
c48a3435f5
Remove unnecessary calls for changing directory to `helmpath.CachePath`.
...
This was only set on some tests in create_test.go and isn't
affecting the test.
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Carlos Lima
6991a0a531
Make annotateAndMerge deterministic
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
c01e76b5c3
review: change annotation name to postrenderer.helm.sh/postrender-filename
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
a1416cf225
review: style changes
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
859721bd77
review: rewrite error messages from the end-user perspective
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
b26b473bf6
review: make splitAndDeannotate private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
855b5a44b7
review: make annotateAndMerge private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
1d993f9e2d
review: make filenameAnnotation private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Carlos Lima
e6362d74c8
Allow post-renderer to process hooks
...
This annotates and merges all manifests before sending to the
postrender, reversing the process and recovering the filenames
afterwards.
closes #7891
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Zach Burgess
3b26ddc22b
Update tests in create_test.go and package_test.go to work in a temp dir.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
b703d5b4bb
Return early when linting if the `templates/` dir does not exist
...
The `vaildateTemplatesDir` function would still return `nil` if the directory doesn't exist,
so the early return that was documented never occurs.
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
a99c3700f0
Return early if the `/crds` directory does not exist.
...
Don't silently discard the error from `os.Stat`.
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
562ff982cb
Early return if the `/crds` directory does not exist and don't silently discard the error from `os.Stat`.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
d6ddd8e661
Document that attempting to parse YAML checks that the CRD is not a
...
template
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
e4c88faeff
Update test assertions
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
bc35ea5ad7
Fix comment in pkg/lint/rules/testdata/invalidcrdsdir/values.yaml
...
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Zach Burgess
21b9aa3d94
Lint the `crds/` directory.
...
This checks that the `crds/` dir only contains YAML files that define
K8s resources with `kind: CustomResourceDefinition`.
Checking that the YAML files are not templates will be done in a
separate commit.
Signed-off-by: Zach Burgess <zachburg@google.com>
1 year ago
Thiago Presa
afd63fed77
test: increase test coverage for pkg/pusher
...
Signed-off-by: Thiago Presa <thiago.addevico@gmail.com>
1 year ago
Matt Farina
f0cf9c28f0
Move logging setup to be configurable
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
curlwget
bfc1af68fb
chore: fix function in comment
...
Signed-off-by: curlwget <curlwget@icloud.com>
1 year ago
George Jenkins
a2a0935cba
Merge pull request #30900 from unguiculus/issue-12952
...
Add timeout flag to repo add and update commands
1 year ago
Terry Howe
f55c462a79
fix: force bearer oauth for everything
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Robert Sirchia
ba0fbdeb57
Merge pull request #30979 from TerryHowe/oras-v2-login-for-v4
...
fix: OAuth username password login for v4
1 year ago
Artem Vdovin
351bb78ee5
fix index concurrency
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
1 year ago
Terry Howe
df482346db
fix: lint test SetEnv errors
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Terry Howe
47980159b3
fix: user username password for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
manslaughter03
bc44614a78
fix: wrap run release test error in case GetPodLogs failed.
...
Signed-off-by: manslaughter03 <manslaughter03@gmail.com>
1 year ago
Terry Howe
744c6b5a97
fix: kube client create mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Ashmit Bhardwaj
e060fbe185
updated docs
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
1 year ago
Ashmit Bhardwaj
0389407cbc
removed unnecessary binary file
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
1 year ago
Ashmit Bhardwaj
b305a501e8
added documentation and test cases for api-versions flag
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
1 year ago
Terry Howe
93ec064640
fix: repo update cmd mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
acceptacross
9623fb80f1
chore: fix some function names in comment
...
Signed-off-by: acceptacross <csqcqs@gmail.com>
1 year ago
Matt Farina
7031000b7d
Merge pull request #30955 from carloslima/fix-test-deleting-local-directories
...
Fix tests deleting XDG_DATA_HOME
1 year ago
Scott Rigby
069b525332
Merge pull request #13586 from jessesimpson36/cleaner-stacktraces
...
fix: add formatting for errors to make multiline stacktraces in helm templates
1 year ago
Carlos Lima
f8204031f1
Fix tests deleting XDG_DATA_HOME
...
That includes ~/.local/share/keyrings which was the most immediatelly
visible effect.
Signed-off-by: Carlos Lima <carlos@cpan.org>
1 year ago
Robert Sirchia
c0aa690c90
Merge pull request #30909 from jinjiadu/main
...
refactor: replace HasPrefix+TrimPrefix with CutPrefix
1 year ago
Scott Rigby
e2630d1aba
Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex
...
fix: action hooks delete policy mutex
1 year ago
Scott Rigby
de745ea34b
Merge pull request #12581 from Nordix/considerAllGroupVersionKind
...
Consider full GroupVersionKind when matching resources
1 year ago
Scott Rigby
e8c1acf228
Merge pull request #30809 from mmorel-35/usetesting
...
chore: enable usetesting linter
1 year ago
Scott Rigby
4023c3b5ff
Merge pull request #30917 from TerryHowe/oci-transport-debugging
...
fix: add debug logging to oci transport
1 year ago
Terry Howe
a8cbf3aa51
fix: action hooks delete policy mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Terry Howe
6ab7aa3612
fix: legacy docker support broken for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Terry Howe
5fe7a87138
fix: add debug logging to oci transport
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
1 year ago
Benoit Tigeot
6df8eb3b3b
Fix flaky TestFindChartURL due to non-deterministic map iteration
...
The test was failing intermittently because Go's map iteration order
is randomized (see `range repos` in `findChartUrl`).
When looking up the `baz` chart with repository URL http://example.com/helm ,
two repositories match due to trailing slash equivalence:
- testing-relative (URL: http://example.com/helm ) - contains baz chart GOOD
- testing-relative-trailing-slash (URL: http://example.com/helm/ ) - does not contain baz chart.. NOT GOOD
The urlutil.Equal() function treats these URLs as equivalent, but
depending on which repository the random map iterator encounters
first, the test would either pass or fail with "entry not found".
So I changed the third test case from baz to foo chart, since foo exists
in both matching repositories. This eliminates the race condition while
preserving all test expectations and logic.
`findChartURL()` iterates over a map without deterministic
ordering, causing the first-match-wins behavior to be non-deterministic
when multiple repositories match the same URL pattern.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Scott Rigby
d4e58c54ba
Merge pull request #30928 from TerryHowe/fix-plugin-install-no-internet
...
fix: plugin installer test with no Internet
1 year ago
Terry Howe
cc39d2428f
fix: plugin installer test with no Internet
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Benoit Tigeot
b2fd91b8d0
Adapt error of invalid json schema with the new expected output
...
Closes: https://github.com/helm/helm/pull/30907
To be able to upgrade to v6.0.2 for jsonschema lib we need to upgrade
this test.
I am wondering if it's related to this commit:
86cca28795
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Reinhard Nägele
d448cf1943
Add timeout flag to repo add and update flags
...
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
# Conflicts:
# pkg/cmd/repo_update.go
1 year ago
jinjiadu
6f8e9e09a4
refactor: replace HasPrefix+TrimPrefix with CutPrefix
...
Signed-off-by: jinjiadu <jinjiadu@aliyun.com>
1 year ago
Robert Sirchia
b7e127dd6b
amending missed line to delete
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
937c533e37
forward porting 30902
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
52dddba759
Merge pull request #30894 from benoittgt/fix-#30881-main
...
Prevent push cmd failure in 3.18 by handling version tag resolution in ORAS memory store
1 year ago
Robert Sirchia
83c26845ad
Merge pull request #30904 from benoittgt/document-ideal-registry-login-command
...
[Doc] Help users avoid specifying URL scheme and path with `helm registry`
1 year ago
Benoit Tigeot
f939f6145f
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
cb730c94b5
Help users avoid specifying URL scheme an path
...
We’ve noticed that some users still include the URL scheme and full path
when logging into an OCI registry, for example:
```sh
helm registry login -u $OCI_REGISTRY_USER --password-stdin oci://ghcr.io/org/repo
```
This is no longer necessary and will not be supported in Helm v4.
To guide users toward the correct usage, we should show an example of
the ideal command.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Robert Sirchia
1b21f04b3b
Merge pull request #30865 from mmorel-35/github.com/evanphx/json-patch/v5
...
fix: update json-patch import path and add gomodguard settings
1 year ago
Benoit Tigeot
875e149d6b
Prevent failure when resolving version tags in oras memory store
...
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.
I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.
Close : #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Matt Farina
cf7613ba6b
Reverting fix "renders int as float"
...
This reverts #13533
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Note: This kind of change can be put into v3 charts, that are in
active development, without causing a regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
1 year ago
Matt Farina
0c91649ec8
Merge pull request #30871 from gjenkins8/gjenkins/test_registry_localhost
...
Run test OCI registry localhost
1 year ago
Matt Farina
f043faf0a3
Merge pull request #30862 from OmriSteiner/fix-absolute-uri
...
fix: correctly concat absolute URIs in repo cache
1 year ago
Matt Farina
ab56ac62ba
Merge pull request #30866 from mmorel-35/thelper
...
chore: enable thelper linter
1 year ago
George Jenkins
8ba181c343
Run test OCI registry localhost
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Matthieu MOREL
706392fabb
fix: update json-patch import path and add gomodguard settings
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Matt Farina
b5a4781099
Adding test for list command
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Omri Steiner
c47c8fc868
fix: correctly concat absolute URIs in repo cache
...
There used to be two implemenations for concatenating the repo URL with
the chart URI / URL. In case the chart specified an absolute URI, one of
the implementations performed an incorrect concatenation between the
two, resulting in a URL which looks like <repo-URL><absolute-chart-URI>.
This commit removes the faulty implementation and uses the other correct
one instead.
Signed-off-by: Omri Steiner <omri@steiners.co.il>
1 year ago
Matt Farina
dd40316660
Merge pull request #30842 from ayushontop/main
...
Fix : No repository is not an error,use the helm repo list command ,if there is no repository,it should not be an error #30606
1 year ago
MichaelMorris
1460ebd14a
Added test case to resource_test.go
...
Signed-off-by: MichaelMorris <michael.morris@est.tech>
1 year ago
MichaelMorris
9a2ac85077
Consider GroupVersionKind when matching resources
...
This change shall take Group, Version and Kind from GroupVersionKind
into consideration instead of the current behavior of only considering
the Kind
Closes : #12578
Signed-off-by: MichaelMorris <michael.morris@est.tech>
1 year ago
Ayush Tiwari
56b688145f
added cmd in repo_list.go for pipeline
...
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
1 year ago
Robert Sirchia
b2456202ae
Merge pull request #30850 from yetyear/main
...
refactor: use maps.Copy for cleaner map handling
1 year ago
George Jenkins
2c1257537c
Merge pull request #30829 from TerryHowe/increase-time-pkg-test-coverage
...
Increase pkg/time test coverage
1 year ago
yetyear
03448d1d79
refactor: use maps.Copy for cleaner map handling
...
Signed-off-by: yetyear <flite@outlook.com>
1 year ago
Robert Sirchia
4d580c6b95
Merge pull request #30810 from mmorel-35/usestdlibvars
...
chore: enable usestdlibvars linter
1 year ago
Terry Howe
71787cca60
fix: rename slave replica
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
George Jenkins
a1f8802de9
Merge pull request #30553 from Zhanweelee/add_mustToYaml_support
...
feat: Add mustToYaml and mustToJson template functions
1 year ago
Ayush Tiwari
e63cbae886
added cmd.ErrOrStderr()
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
1 year ago
Ayush Tiwari
95328ea0a6
removed error import
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
1 year ago
Ayush Tiwari
058bc083a8
changed Error to print
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
1 year ago
Terry Howe
da579a7aa6
chore: add test coverage for time package
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
findnature
ac8d2f9aed
refactor: use slices.Contains to simplify code
...
Signed-off-by: findnature <cricis@aliyun.com>
1 year ago
Terry Howe
f754e6a23b
chore: increase test coverage of time pkg
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 year ago
Matthieu MOREL
77a267dacf
chore: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Jesse Simpson
e0a67b1028
test: use more realistic unit-test scenario by not relying on Release.Name
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
d10c5f6429
style: trim space from formatted error messages
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
0e0a8cc765
fix: address no-template-associated type of error
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
013f27c294
fix: use errors.New instead of fmt.Errorf
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
868cdc261f
refactor: reduce flow-control operations
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
48922e21d1
refactor: use struct equality instead of comparing each composition
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
ac98e977c3
refactor: switch to while loop instead of for to reduce unnecessary variables
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
65084371c9
refactor: replace if MatchString with FindStringSubMatch
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
782f6c6409
refactor: shorten regex subexp syntax
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
4b9a9ecaf6
refactor: rename function and add doc-string
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
4f63c73353
refactor: remove impractical safety check
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
5202820f2f
refactor: define regexs at package scope
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
cbdc22128e
refactor: use strings.Builder instead of string concatenation
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
cdcf1bc601
style: remove unnecessary break
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
3cc4cb60ba
refactor: prevent duplicates being inserted rather than post-filtering
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
deea4a0d0e
refactor: remove more unnecessary format calls
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
0a7dd4b269
test: adjust failing test on extra whitespace
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
13b232e061
refactor: make use of regexs for err parsing
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
daf4c34879
fix: use originalErr instead of formatting original error
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
98da3e28b6
fix: add some index checking and fixed a test that relied on type-checking
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
80d7a1b33f
style: make format
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
edf0f7be59
test: adjust formatting for error in test
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
487f72b822
fix: added protection against while-true condition in unbounded for loop
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
6bb836374b
test: adjusted to make it more meaningful and to pass
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
383a758aec
fix: add quality checks to ensure formatted error doesnt remove important info
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
d8bec4e30f
fix: remove comparison from old error message to new
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
c481470985
style: renamed i variable for consistency
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
2e3f6dce28
fix: save to fileLocation rather than fileLocations[i] which gets overwritten
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
f09bbb8ab8
style: consolidate for loops
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
1357db4db1
style: removed variable only used once
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
a56daca82b
style: use interface functions instead of inline logic
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
87f9e2dc45
style: create String function for TraceableError representing one chunk of a stacktrace
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
6cd0c0082a
fix: split up the multiline errors to be more vertical
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
cc477e9f79
fix: adjust test to not require external chart
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
Jesse Simpson
14f902c245
wip: draft at making cleaner stacktraces
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
1 year ago
George Jenkins
ecf1730689
Merge pull request #13460 from justenstall/stdlib-errors-2
...
fix: replace "github.com/pkg/errors" with stdlib "errors" package
1 year ago
Justen Stall
4905a61026
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Matt Farina
fcd37bcea7
Merge pull request #30783 from rpolishchuk/investigate-TestValidateChartIconPresence
...
fix: chart icon presence test
1 year ago
Robert Sirchia
d9bc0a948c
Merge pull request #30777 from ryanhockstad/merge-fix
...
fix: null merge. closes #30587
1 year ago
Scott Rigby
a911aa2112
Merge pull request #9175 from dastrobu/copy-dependencies-on-aliasing
...
fix: copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies
1 year ago
Daniel Strobusch
b183eccfc4
copy dependency metadata on aliasing to avoid sharing imported values
...
imported values are stored in dependency objects, which breaks if a chart dependency is shared among multiple aliases.
By copying the dependency objects in the metadata values can be imported correctly.
Supersedes #10174
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
1 year ago
Daniel Strobusch
df7befd208
copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies
...
Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases.
By copying the dependencies, parent information can be set correctly to render the templates as expected later on.
Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level.
Closes #9150
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
1 year ago
Stephen Murray
1682895636
ref(helm): Export Chart Not Found error
...
Closes #30746
Signed-off-by: Stephen Murray <stephenmurrayengineer@gmail.com>
1 year ago
Rostyslav Polishchuk
1c8d1e375f
fix: chart icon presence test
...
The `TestValidateChartIconPresence` test fails when run after
`TestValidateChartIconURL` as they both are using a global
variable `badChart.Icon`
```
: go test -v -test.shuffle 1 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 1
=== RUN TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
=== RUN TestValidateChartIconPresence
chartfile_test.go:171: validateChartIconPresence to return a linter error, got no error
--- FAIL: TestValidateChartIconPresence (0.00s)
FAIL
FAIL helm.sh/helm/v4/pkg/lint/rules 0.051s
FAIL
: go test -v -test.shuffle 2 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 2
=== RUN TestValidateChartIconPresence
--- PASS: TestValidateChartIconPresence (0.00s)
=== RUN TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
PASS
ok helm.sh/helm/v4/pkg/lint/rules 0.050s
```
This commit:
1. Remove dependency on global variable
2. Explicitly set the state of the test object.
Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>
1 year ago
Justen Stall
fc6c5e5edb
remove WaitAndGetCompletedPodPhase function
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Justen Stall
73545f9a3e
one more test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Justen Stall
4a6092bd6c
update another test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Justen Stall
7a316c8d51
update expected error message in install test
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Matthieu MOREL
d3eeb2c942
chore: remove github.com/hashicorp/go-multierror dependency
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Justen Stall
3877ec9049
fix golangci-lint issues
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Justen Stall
065e2eb3eb
updates after merge conflict resolution
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Scott Rigby
eb6e240cfe
Merge pull request #30734 from ipaqsa/feature/add-custom-template-funcs
...
feat(pkg/engine): add support for custom template funcs
1 year ago
Scott Rigby
8255300280
Merge pull request #12382 from edbmiller/ed-dot-miller/parse-chartfile-yaml-strictly
...
fix(pkg/lint): unmarshals Chart.yaml strictly
1 year ago
Ryan Hockstad
c1175a4106
fix null merge
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
1 year ago
Edward Miller
e414695a5b
fix
...
Signed-off-by: Edward Miller <edmiller287@gmail.com>
1 year ago
Benoit Tigeot
e2461de3c2
Fix test with toml bump
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Matt Farina
a842140ef6
Merge pull request #13578 from gjenkins8/rm_chart_repo_load_func
...
refactor: Remove ChartRepository `[]ChartPaths`
1 year ago
Edward Miller
629780a34a
fix: reapply error message fix
...
Signed-off-by: Edward Miller <edmiller287@gmail.com>
1 year ago
Edward Miller
9d43f70643
Update error message
...
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Edward Miller <55854159+edbmiller@users.noreply.github.com>
1 year ago
Edward Miller
14a468f24d
Add chartutil.StrictLoadChartfile for strict (WARNING-level) lint
...
Signed-off-by: Edward Miller <edmiller287@gmail.com>
1 year ago
Edward Miller
00f8561ad4
fix(pkg/lint): unmarshals Chart.yaml strictly
...
When "helm lint" is run, it now errors on invalid chartfiles,
e.g. those with duplicate keys
Closes #12381
Signed-off-by: Edward Miller <edmiller287@gmail.com>
1 year ago
wangcundashang
7bb0c85441
chore: fix function name in comment
...
Signed-off-by: wangcundashang <wangcundashang@qq.com>
1 year ago
Stepan Paksashvili
b54349d9b2
fix(pkg/engine): allow to override all functions
...
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
1 year ago
Stepan Paksashvili
5c2f89307d
feat(pkg/engine): and custom funcs to action config
...
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
1 year ago
Stepan Paksashvili
8982b57e5e
feat(pkg/engine): and custom funcs overriding test
...
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
1 year ago
Stepan Paksashvili
9073bcf53e
feat(pkg/engine): add support for custom template funcs
...
Enhances the template engine and action config to allow users to inject custom template functions via an action config when using Helm as a library.
Closes #30733
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
1 year ago
Scott Rigby
599fad1864
Merge pull request #30697 from p-se/fix-take-ownership
...
Fix --take-ownership for custom resources - closes #30622
1 year ago
Evans Mungai
1f5605a405
fix formatting errors
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 year ago
Benoit Tigeot
d33e2896f0
Prevent failures with method signatures on hooks
...
changes on wait strategy. This PR try to fix linting and tests.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Scott Rigby
e397f44840
Merge pull request #30673 from nvanthao/process-all-hook-deletions-on-failure
...
fix: Process all hook deletions on failure
1 year ago
Matt Farina
01590a59b2
Merge pull request #30760 from robertsirc/add-debuging-to-jsonschema
...
adding slog debug to a few points
1 year ago
Robert Sirchia
8733103743
Merge pull request #30718 from klihub/fixes/package/multiple-charts-single-passwd-from-stdin
...
Allow signing multiple charts with a single passphrase from stdin.
1 year ago
Robert Sirchia
da096e1b7a
Merge pull request #30752 from benoittgt/bump-golangci-lint-action
...
Bump golangci lint to last major version and fix static-check errors
1 year ago
Robert Sirchia
ef0361de21
fixing as per review
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
9b9ff12c6d
adding slog debug to a few points
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Krisztian Litkey
3102c28804
fix: allow signing multiple charts with passphrase from stdin.
...
Cache the signing key passphrase. When signing multiple charts
with the passphrase from stdin, this allows signing all charts
instead of all but the first failing with an error about stdin
already having been closed.
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
1 year ago
Evans Mungai
e8e79cc4b4
Merge branch 'main' into fix-take-ownership
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 year ago
Evans Mungai
7c37a109f2
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
1 year ago
Matt Farina
0dffc580b0
Simpligy the JSON Schema checking
...
A new library was introduced that provides JSON Schema checking for
newer versions of the schema. In Helm v4, there is no need to have
two packages doing the JSON schema validation. The message output
can have breaking changes.
This change moves everything to the newer library. It also uses a
wrapper error to enable a clean Helm only interface for the
public Go API validation functions. This would enable the replacement
of the Schema validation library, if needed, without breaking the
Go API contract.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Matt Farina
55a4fc121b
Merge pull request #13283 from win-t/jsonschema
...
adding support for JSON Schema 2020
1 year ago
Benoit Tigeot
a1c2f47c08
avoid using reflect.DeepEqual with errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
eb65ce280b
could apply De Morgan's law
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
374805deb4
error strings should not be capitalized
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
1654664b78
could use strings.ReplaceAll instead
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
a6d0335bbb
Use fmt.Fprintf(...) instead of ...
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
a9b7732367
could remove embedded field X from selector
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Kurnia D Win
6c54351c01
Merge remote-tracking branch 'upstream/main' into jsonschema
1 year ago
Benoit Tigeot
f5aec508f5
Add detailed debug logging for resource readiness states
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Scott Rigby
9a670ae920
Merge pull request #30701 from zanuka/30617-request-for-helm-install-order-doc-update
...
updates mutate and validate web hook configs
1 year ago
Scott Rigby
0cecd910e5
Merge pull request #30713 from gjenkins8/gjenkins/rm_helmv2_template_lint_rules
...
cleanup: Remove Helm v2 template lint rules
1 year ago
Matt Farina
a536832714
Merge pull request #30749 from mattfarina/fix-alpine-chart
...
Removing the alpine test chart
1 year ago
Robert Sirchia
f5decfc28d
Merge pull request #30737 from rpolishchuk/investigation-pr-30610
...
fix: order dependent test
1 year ago
Matt Farina
91ecb56355
Removing the alpine test chart
...
A .gitignore was previously setup to ignore this file. When pkg/cmd
was setup the .gitignore was not updated. The change adds the new
location to continue to ignore this file.
Note, the previous location is still included in the .gitignore
because developers will have a file there and we do not want that
accidently included in a commit.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Matt Farina
7a1eb77e77
Merge pull request #30708 from benoittgt/migrate-kube-pkg-to-slog
...
Migrate pkg to slog
1 year ago
Matt Farina
ed005f5c32
Removing deprecation notice for this function.
...
While the constructor is not used by Helm itself, it is used by SDK
users and there is currently no alternative way to expose this.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Matt Farina
7938662f95
Remove ValidName regex
...
This regex was already deprecated.
Validation happens inside the Metadata Validate function for the
name instead of using this regex.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Benoit Tigeot
68440d7b29
Prefer using slog.Any when displaying errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
c05bcbd498
Fix nil pointer dereference in ready test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
e7eedae97c
Use the logger with proper handling of dynamic debug on 2 locations
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
cbaac7652d
Call slog directly instead of using a wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
6b5fa33633
debug log level is dynamic and set after Logger creation
...
So we should use dynamic handler to set the log level after. With this
patch we can clearly see the output. Before we were always stuck in log
level "info" and not seeing debug log level
```
bin/helm upgrade --install --debug --wait frontend \
--namespace test \
--set replicaCount=2 \
--set backend=http://backend-podinfo:9898/echo \
podinfo/podinfo
level=DEBUG msg="getting history for release" release=frontend
level=DEBUG msg="preparing upgrade" name=frontend
level=DEBUG msg="performing update" name=frontend
level=DEBUG msg="creating upgraded release" name=frontend
level=DEBUG msg="checking resources for changes" resources=2
level=DEBUG msg="no changes detected" kind=Service name=frontend-podinfo
level=DEBUG msg="patching resource" kind=Deployment name=frontend-podinfo namespace=test
level=DEBUG msg="waiting for resources" count=2 timeout=5m0s
level=DEBUG msg="waiting for resource" name=frontend-podinfo kind=Deployment expectedStatus=Current actualStatus=Unknown
level=DEBUG msg="updating status for upgraded release" name=frontend
Release "frontend" has been upgraded. Happy Helming!
NAME: frontend
LAST DEPLOYED: Thu Apr 10 09:56:25 2025
NAMESPACE: test
STATUS: deployed
REVISION: 6
DESCRIPTION: Upgrade complete
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Rostyslav Polishchuk
55eb53e3a0
fix: order dependent test
...
TestInstallRelease_Atomic_Interrupted needs the same wait
as TestInstallRelease_Wait_Interrupted (see helm/helm#12088 ).
The installation goroutine started by
TestInstallRelease_Atomic_Interrupted proceeds in the background and
may interfere with other tests (see helm/helm#30610 )
Also see helm/helm#12086 and helm/helm#12109 which are describe and address the root
cause.
Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>
1 year ago
Matt Farina
d8ca55fc66
Merge commit from fork
...
Fix for DOS when unarchiving charts
1 year ago
Mike Delucchi
e1425f1aa5
fix: correct webhook order to match Kubernetes admission flow
...
Place APIService before webhooks, with MutatingWebhookConfiguration
before ValidatingWebhookConfiguration to match standard admission control.
Signed-off-by: Mike Delucchi <git@zanuka.com>
1 year ago
Mike Delucchi
1003a3c93f
fixes kind_sorter_test to match new order
...
Signed-off-by: Mike Delucchi <git@zanuka.com>
1 year ago
Mike Delucchi
c121b6b83e
changes order of operations
...
Signed-off-by: Mike Delucchi <git@zanuka.com>
1 year ago
zanuka
9b636902c6
updates mutate and validate web hook configs
...
Signed-off-by: Mike Delucchi <git@zanuka.com>
1 year ago
Matt Farina
0740dfc7a9
Unarchiving fix
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
1 year ago
Scott Rigby
5442c6b9cb
Merge pull request #9318 from wahabmk/fix-httpgetter
...
Fix issue with helm pull failing if pulling from a repository that redirects to another domain
1 year ago
Benoit Tigeot
0c85456788
Leverage slog.Any for errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
5c746037b3
Prevent redefining verbose flags
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
710770eed4
Linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
5580f61157
Properly reproduce the nopLogger as before
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
baa597c567
Do not remove the functionality to print log in test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
b6adbbb227
Enforce error style with others
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
b2380720eb
Migrate to pure slog without a custom wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
3db7ebc591
Fix missing logger to SQL in test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
15de13f9d2
Fix linting issue and temporary removing logging in test acion
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
b42767be40
Migrate more code to log adapter
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
83cdffe4ae
Migrate to a dedicated internal package for slog adapter + migrate more
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
fae2345edf
Demonstrate the impact of having Logger defined in kube package
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
ede73860c1
Fix call to kube log
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
3a22df9731
Deal with linting errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
394ba2d55e
Properly use DefaultLogger
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
eb2dfe7dbf
Some interesting rephrasing by Terry Howe
...
See: https://github.com/helm/helm/pull/30698#discussion_r2012394228
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
227d270788
Extra comment + Default logger fallback
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
b642bca8f6
Provide an adapter to easily pass a slog.Default()
...
```
helmClient.Log = NewSlogAdapter(slog.Default())
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
d6d7cff417
Try to make log more common and more easily grepable
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
8d30464f2c
Do no mask warning alerts
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
dfaf249221
Remove unreachable error
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
f4631bf3d8
Migrate kube package to slog
...
As for helm v4. We want to migrate logs to slog.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Patrick Seidensal
e55707b09d
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
1 year ago
George Jenkins
be2b84685a
cleanup: Remove Helm v2 template lint rules
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
Suleiman Dibirov
000c098a41
fix(concurrency): add mutex to protect repoFailList and out in updateCharts
...
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
1 year ago
Scott Rigby
985f5af538
Merge pull request #13604 from AustinAbro321/refactor-wait
...
Introduce kstatus watcher
1 year ago
Scott Rigby
122e7b441a
Merge pull request #13458 from thudi/main
...
#13449 Resolves: Replacing NewSimpleClientSet to NewClientSet due to deprecation
1 year ago
Austin Abro
21ee721242
go fmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
8efd428e5d
switch back to k8s rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
83266254f0
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
386523bdbc
update to get waiter instead of set
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Robert Sirchia
0199b748aa
Merge pull request #30696 from benoittgt/report-time-waited-v4
...
Inform about time spent waiting resources to be ready in slog format
1 year ago
Wahab Ali
ec31aab851
Use NewTLSConfig instead of the outdated NewClientTLS func
...
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
1 year ago
Wahab Ali
e7895245f0
Fix lint errors
...
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
1 year ago
Wahab Ali
3ca2558f04
Do not explicitly set SNI in HTTPGetter
...
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
1 year ago
Benoit Tigeot
4f4c858f9c
Ignore unused parameter
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Matt Farina
2e6437beb5
Merge pull request #30684 from twz123/remove-clientoptresolver
...
Remove ClientOptResolver from OCI Client
1 year ago
Matt Farina
ab9f0c80b5
Merge pull request #30603 from robertsirc/converting-to-slog
...
converting inline log to slog
1 year ago
Robert Sirchia
c5991028e0
fixing matts changes
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Matt Farina
e4e602e13c
Error when failed repo update.
...
In Helm v3 we did not change exit codes for existing commands to
maintain compat. A flag was introduced so a failure would result
in a non-0 exit code. A note was left to make this the default
in Helm v4. That's what this change does.
Closes #10016
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Benoit Tigeot
94cb21c7c4
Follow convention for error with slog.Any()
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
e3e84b6dfe
"beginning wait" is dedicated to be display as debug log
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
0e4d185370
Inform about time spent waiting resources to be ready in slog format
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Austin Abro
d78b7e401a
go mod tidy
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
linghuying
fc476f7235
chore: make function comment match function name
...
Signed-off-by: linghuying <1599935829@qq.com>
1 year ago
Tom Wieczorek
835ff78f48
Remove ClientOptResolver from OCI Client
...
This option was kept to avoid compile-time incompatibilities in Helm v3
when upgrading to ORAS v2. Let's remove it for Helm v4.
This allows Helm to drop the containerd dependency entirely.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
1 year ago
Gerard Nguyen
aa9e4bb42d
rebase
...
Signed-off-by: Gerard Nguyen <gerard@replicated.com>
1 year ago
Laszlo Uveges
63b6153163
More formatting
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
1 year ago
Laszlo Uveges
acca1b04eb
Add missing license header
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
1 year ago
Laszlo Uveges
d03981b82c
Fix go imports
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
1 year ago
Laszlo Uveges
940966d9c8
Fix formatting issues
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
1 year ago
Laszlo Uveges
2eea520ba4
Delete previously successful hooks when a later hook fails
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
1 year ago
Laszlo Uveges
0a28223ae5
Restructure hooks tests to be reusable
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
1 year ago
Laszlo Uveges
788652fd27
Add dummy test case to prove that not all hooks are delted on failure
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
1 year ago
Henrik Gerdes
597c35852a
fix: align values comments/docs to scaffold standard
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
1 year ago
Henrik Gerdes
ca367d970c
docs: more user-friendly info for httpRoute scaffold
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
1 year ago
Henrik Gerdes
1aac5b0b70
fix: use common chart-example.local hostname for http-route default
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
1 year ago
Henrik Gerdes
5d0c6e9ae4
fix: remove v1alpha2 gateway api support
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
1 year ago
Henrik Gerdes
d22939b439
fix: correct expected number of template files in unit-test
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
1 year ago
Henrik Gerdes
3fc5d689e6
docs: add notes in chart templates for accessing httproute
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
1 year ago
Henrik Gerdes
90daeadeb5
feat: add httproute from gateway-api to create chart template
...
Adds the HTTPRoute from https://gateway-api.sigs.k8s.io/reference/spec/ to the example getting started chart.
This closes #12603
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
1 year ago
Robert Sirchia
3a19576377
making changes as requested by matt
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Austin Abro
10f78c814c
legacy waiter
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
0dffe83ef3
warnings
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
e773a810ee
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
1 year ago
Austin Abro
2948279fb9
cleanup if statement
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
600947b32e
client->restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Robert Sirchia
2192c4e0d1
changing errors back to warns
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
4422000330
fixing case issues with the logging of my errors
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Austin Abro
3a296aacad
rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
24dc643822
restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
0b513dcd42
Merge branch 'main' into refactor-wait
1 year ago
Austin Abro
68f72e5c3f
hook only strategy when wait=false
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
022d4db6af
move logic from cmd/helm to pkg/cmd
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
20c75f0c10
fix namespace assignment not passing through
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
George Jenkins
e354dd296d
Merge branch 'main' into rm_chart_repo_load_func
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
Rongrong Liu
12b8eb8b61
fix:add proxy support when mTLS configured
...
Signed-off-by: Rongrong Liu <lori.rongrong.liu@gmail.com>
1 year ago
Robert Sirchia
848c134e0c
fixing error messages
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
fd69bf6f32
Merge pull request #30592 from robertsirc/slog-prototype
...
changing from log to slog
1 year ago
Robert Sirchia
f50547bf51
changing error to warn as requested by Matt
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
c2e6ed8ae5
fixing build error
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Austin Abro
1704ce3067
Merge branch 'main' into refactor-wait
1 year ago
Robert Sirchia
8887d01791
fixing issues with my PR
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
c36bc25fb1
fixing missing attributes
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
1ad79a2bb7
converting inline log to slog
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
a11f4c0026
changing info to error
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Austin Abro
1a3fb75b34
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
d3814d786b
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Robert Sirchia
48f03d316b
changing from log to slog
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Matt Farina
e711488970
Move pkg/release to pkg/release/v1 to support v3 charts
...
This is part of HIP 20 which provides a means to have v3 charts
that live alongside v2 charts while having breaking changes.
The plan is to have a different release object for v3 chart
instances for at least a couple reasons:
1. So that the chart object on the release can be fundamentally
different.
2. So that Helm v3 does not detect or try to work with instances
of charts whose apiVersion it does not know about.
Note: it is expected that Helm v3 usage will be used long after
the Helm project no longer supports it. 5 years after Helm v2
had reached end-of-life there was still usage of it.
Note: The release util package is separate from the versioned
elements as it is planned to use generics to handle multiple
release object versions.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Austin Abro
f04c456bd6
gofmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
9f9eb28fed
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
09faaac273
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Matt Farina
35a8bd3a77
Merge pull request #30586 from mattfarina/chart-to-chart-v2
...
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
1 year ago
Matt Farina
61d3eca55c
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
...
This change moves the code, updates the import locations, and
adds a doc.go file to document what the v2 package is for.
This is part of HIP 20 for v3 charts
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Robert Sirchia
4da004e2dc
removing old apis
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Austin Abro
29c250c233
add back interface log check
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
1cb4e66044
merge conflict
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
a18589c4d8
fmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
5a254dae21
cleanup
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
11eeb4a6b1
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
4f33e5c97f
test refactoring
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
75292c5e04
refactor
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
b79dfd09b0
refactor
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Matt Farina
bff495510d
Merge pull request #30571 from yardenshoham/exec-no-output
...
feat: error out when post-renderer produces no output
1 year ago
Matt Farina
18ca7c1002
Move pkg/releaseutil to pkg/release/util
...
The releaseutil package was originally designed to work against a
generated codebase from a protobuf in Helm v2. This is when Helm
used gRPC to communicate to a server side component named Tiller.
When Helm moved everything client side, this package remained and
it supported the release package.
This change moves releaseutil to be a sub-packge of release. This
is part of the change to support apiVersion v3 charts which is
documented in HIP 20
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Austin Abro
297f7b9acb
squash
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Yarden Shoham
ab926212d9
Apply suggestions from code review
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
1 year ago
Felipe Santos
392ff93916
Fix flaky TestDedupeRepos ( #30576 )
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
1 year ago
Joe Julian
0fcd1d33b3
Merge pull request #11112 from felipecrs/filter-dup-repos
...
perf(dep-up): do not update the same repo multiple times
1 year ago
Yarden Shoham
f475f3e1fd
feat: error out when post-renderer produces no output
...
When the templating post-renderer produces no output, something went wrong so we error out.
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
1 year ago
Scott Rigby
2cda65d444
Merge pull request #10309 from Bez625/main
...
Add hook annotation to output hook logs to client on error
1 year ago
Matt Farina
1382a2894a
Merge pull request #30567 from mattfarina/chartutil-to-chart-util
...
Moving chartutil to chart/util
1 year ago
Robert Sirchia
8dd279271e
remove unused config.go
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Matt Farina
5c0deec327
Moving chartutil to chart/util
...
chartutil was originally created to operate on protobufs which are
no longer part of Helm. The util package makes more sense to be
part of the chart package.
This change is part of the HIP 20 to create v3 charts and
explicitly call out v2 charts. The changes for this are in smaller
bite size changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Chris Berry
e5bc21c56b
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Chris Berry
9791767baa
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Chris Berry
6d30fa5990
Add HookOutputFunc and generic yaml unmarshaller
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Scott Rigby
52ac92fb69
clarify fix error message
...
Signed-off-by: Scott Rigby <scott@r6by.com>
1 year ago
Scott Rigby
e8a76bc3eb
fix err check
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
1 year ago
Scott Rigby
3796c1f4a1
remove comments about previous functionality
...
Signed-off-by: Scott Rigby <scott@r6by.com>
1 year ago
Scott Rigby
f729b9ade0
add short circuit return
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
1 year ago
Chris Berry
243cb2e21f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Chris Berry
3d4e679d9f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Chris Berry
a55a477069
Fix lint
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
Chris
3964f84ac8
Tidy up imports
...
Signed-off-by: Chris <bez625@gmail.com>
1 year ago
Chris Berry
cde407b7d1
Add hook annotations to output pod logs to client on success and fail
...
Signed-off-by: Chris Berry <bez625@gmail.com>
1 year ago
George Jenkins
a780fa60ed
Merge pull request #13655 from LuBingtan/dev
...
feat: support multi-document values files
1 year ago
Felipe Santos
b1fd239167
Fix tests failing after removing repo normalization
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
1 year ago
Felipe Santos
ecb5a2c9dd
Fix variable name for linter
...
And restore trimSuffix instead of trimRight, which was a mistake.
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
1 year ago
Felipe Santos
281ccb0835
Do not store the normalized chart url
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
1 year ago
Felipe Santos
bb6314adef
Do not reassign repos variable
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
1 year ago
Felipe Santos
44d53e7d49
Merge branch 'main' of https://github.com/helm/helm into filter-dup-repos
1 year ago
Robert Sirchia
8207fafe13
fixing error handling from a previous PR
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Zhanwei Li
34b679e0cc
feat: Add mustToYaml and mustToJson template functions
...
Introduces two new template functions that marshal data to YAML and
JSON, respectively, and panic on errors. This allows for strict
validation of template output formats.
Signed-off-by: Zhanwei Li <zhanweelee@gmail.com>
1 year ago
lubingtan
ef5614364b
fix: replace mergeMaps call with loader.MergeMaps in MergeValues function
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
1 year ago
lubingtan
91cd72d0e4
fix: improve LoadValues function documentation
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
1 year ago
lubingtan
fb7221bc9a
fix: add doc for func MergeMaps
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
1 year ago
lubingtan
3d84e00ce7
fix: use Reader interface as the input of LoadValues and enhance UT of LoadValues
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
1 year ago
lubingtan
92087f6e33
feat: support multi-document values files for default chart values
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
1 year ago
lubingtan
0d36cb664a
feat: support multi-document values files
...
Signed-off-by: lubingtan <bingtanlu@gmail.com>
1 year ago
Matt Farina
8edc3ac024
Merge pull request #13471 from wangjingcun/main
...
Use a more direct and less error-prone return value
1 year ago
Matt Farina
2603390c2e
Merge pull request #30470 from gjenkins8/cleanup_repotest_server
...
Cleanup `repotest.Server` constructors
1 year ago
Robert Sirchia
9408978517
Merge pull request #30294 from Zhanweelee/supports-json-arguments
...
Supports json arguments
2 years ago
Austin Abro
ea87c49d1b
print
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
efde830405
better name
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
ecd5316577
lint
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
hugehope
001d2978b6
refactor: using slices.Contains to simplify the code
...
Signed-off-by: hugehope <cmm7@sina.cn>
2 years ago
Felipe Santos
f692751a46
Merge branch 'main' of https://github.com/helm/helm into filter-dup-repos
2 years ago
Austin Abro
5d12255497
wait for delete
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
7fde4962a8
set waiter in functions
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
978d5a3318
lint
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
f2dd2c9109
add hook only waiter
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
2b03c527f1
set command line flags
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
George Jenkins
2caca2b167
remove `ChartPaths[]`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
17bc0b3845
refactor: Remove ChartRepository Load() function
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
wangjingcun
8b8cc94822
Use a more direct and less error-prone return value
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
2 years ago
Austin Abro
bd3b5ee5d0
comment
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
7207565e12
lint
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
f866409c50
move statusreaders to it's own package
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
14391dea5b
pods and jobs working
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
d1cc9b39a3
tests for status reader
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Jonathan
37020c32fa
Update pkg/cli/values/options.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Jonathan <zhanweelee@gmail.com>
2 years ago
George Jenkins
234d171da5
Cleanup repotest Server constructors
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Zhanwei Li
274d43c10d
feat: Enhance JSON value parsing in Helm CLI
...
- Add support for parsing full JSON objects with `--set-json`
- Update documentation to clarify JSON value input formats
- Improve test coverage for value parsing scenarios
- Modify `MergeValues` to handle both key=value and JSON object formats
Signed-off-by: Zhanwei Li <zhanweelee@gmail.com>
2 years ago
Austin Abro
187e99d299
custom status readers look good
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
f49a7e134a
start watch until ready
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
cc83b7c2e6
tests passing
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
0314135290
tests passing
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
b9cbc93003
tests passing
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
59ef43e399
tests passing
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
bbe3246f0a
tests passing
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
a590999323
switch client
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
fc10174fa0
merge main
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
a8f53f98ee
WIP custom status reader
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
George Jenkins
3253059438
Merge pull request #13535 from helm/refactor_tlsutil
...
refactor: tlsutil use options pattern
2 years ago
George Jenkins
2d0091c278
Merge pull request #13665 from gjenkins8/rm_WaitAndGetCompletedPodPhase
...
chore: Remove unused `WaitAndGetCompletedPodPhase`
2 years ago
George Jenkins
547f49abf6
Merge pull request #13579 from gjenkins8/rm_chart_repo_find_repo_dups
...
refactor: Remove duplicate `FindChartIn*RepoURL` functions
2 years ago
George Jenkins
814ede5427
Merge pull request #13656 from gjenkins8/repotest_server_localhost
...
fix: Bind repotest server to `localhost`
2 years ago
George Jenkins
d637595735
chore: Remove unused `WaitAndGetCompletedPodPhase`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Terry Howe
5a7046b9bf
chore(oci): upgrade to ORAS v2
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
2 years ago
Austin Abro
f1b642cb0d
unexport newWaiter function
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
916aecf1f1
Merge remote-tracking branch 'origin/main' into refactor-wait
2 years ago
George Jenkins
c68e345663
fix: Bind repotest server to `localhost`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
0ce267d907
more options
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
7ea1d1df66
refactor: Remove duplicate `FindChartIn*RepoURL` funcs
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Robert Sirchia
963d680ae9
Merge pull request #13533 from althmoha/#12987
...
fix: (toToml) renders int as float
2 years ago
Kurnia D Win
32a87dff39
adding support for JSON Schema 2020
...
Signed-off-by: Kurnia D Win <kurnia.d.win@gmail.com>
2 years ago
George Jenkins
415c7e10fd
Merge pull request #13516 from TerryHowe/new-lint
...
chore: fix problems with latest lint
2 years ago
Scott Rigby
d53fb5058e
Merge pull request #12879 from ryanhockstad/subchart-null
...
bugfix: Override subcharts with null values
2 years ago
petercover
605b1a0cf7
chore: fix some comments
...
Signed-off-by: petercover <raowanxiang@outlook.com>
2 years ago
Althaf M
88f7dc5329
merge: fixing merge conflicts
...
Signed-off-by: Althaf M althafm@outlook.com
Signed-off-by: Althaf M <althafm@outlook.com>
2 years ago
Althaf M
57d85993cb
remove debug statements
...
Signed-off-by: Althaf M <althafm@outlook.com>
2 years ago
Althaf M
10d267ed8b
fix: (toToml) renders int as float
...
This commit fixes the issue where the yaml.Unmarshaller converts all int values into float64, this passes in option to decoder,
which enables conversion of int into .
Signed-off-by: Althaf M <althafm@outlook.com>
2 years ago
Robert Sirchia
57e94e5bd9
Merge pull request #13538 from godhanipayal/godhanipayal/ErrorLogging
...
Add Contextual Error Messages to RunWithContext
2 years ago
Robert Sirchia
ba467525ab
Merge pull request #13633 from mattfarina/cleanup-securejoin
...
Ensuring the file paths are clean prior to passing to securejoin
2 years ago
Ryan Hockstad
326c1e3f67
add test for nullifying nested global value
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
2 years ago
Matt Farina
1e256b6198
Merge pull request #13583 from jiashengz/fix-gvk
...
fix: check group for resource info match
2 years ago
Austin Abro
cf51d714e8
go fmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
George Jenkins
53a4a59eb9
Merge pull request #13600 from gjenkins8/cleanup_NewShowWithConfig
...
cleanup: `NewShowWithConfig` -> `NewShow`
2 years ago
Matt Farina
35a9ead998
Ensuring the file paths are clean prior to passing to securejoin
...
securejoin v0.4.0 made a possibly breaking change. Only clean paths
are safe to pass to SecureJoin or they could return an error or
have the wrong path. The details are in the release notes for v0.4.0.
This change ensures the paths are clean prior to passing to SecureJoin.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Austin Abro
4e12f9d530
simplify messages
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
e56a6e678f
diff
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
f746c34d09
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
a859742e28
remove rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
c2dc44deb9
use dynamic rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Payal Godhani
d82929ac2c
Merge branch 'main' into godhanipayal/ErrorLogging
...
Signed-off-by: Payal Godhani <godhanipayal@gmail.com>
2 years ago
George Jenkins
bd897c96fb
Merge pull request #13601 from gjenkins8/cleanup_values_lint
...
cleanup: Remove superseded 'lint/rules.Values' function
2 years ago
Matt Farina
0513abf363
Updating the internal version to v4
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
George Jenkins
0cf0fc29a7
more tidy
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
77fa61ad39
refactor: Consolidate lint package Run() functions
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
ca5a9e69c0
refactor: Remove redundant `NewPullWithOpts`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Payal Godhani
f8a08145fb
Resolving conflict
...
-e
Signed-off-by: Payal Godhani <godhanipayal@gmail.com>
2 years ago
Terry Howe
bcbf68f206
fix: make ORAS reference private
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 years ago
Terry Howe
22f86e5a62
fix: issue with helm template and oci chart
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 years ago
Terry Howe
633e71614e
feat: allow installation by OCI digest
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 years ago
Matt Farina
f08e2d14bb
Updating to helm.sh/helm/v4
...
Since Helm is going through breaking changes with Helm v4, the version path to
Helm needs to be updated.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
dnskr
c55b7ca400
ref(create): don't render empty resource fields
...
Signed-off-by: Denis Krivenko <dnskrv88@gmail.com>
Signed-off-by: dnskr <dnskrv88@gmail.com>
2 years ago
Matt Farina
dc26e5b3e2
Update to Go 1.23
...
Multiple changes were made to pass linting. Some Go built-in names
are being used for variables (e.g., min). This happens in the Go
source itself including the Go standard library and is not always
a bad practice.
To handle allowing some built-in names to be used the linter config
is updated to allow (via opt-in) some names to pass. This allows us
to still check for re-use of Go built-in names and opt-in to any
new uses.
There were also several cases where a value was checked for nil
before checking its length when this is already handled by len()
or the types default value. These were cleaned up.
The license validation was updated because it was checking everything
in the .git directory including all remote content that was local.
The previous vendor directory was from a time prior to Go modules
when Helm handled dependencies differently. It was no longer needed.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Matt Farina
090d3e9579
Merge pull request #13611 from mattfarina/version-v4
...
Updating the internal version to v4
2 years ago
George Jenkins
a8d39e6a17
Merge pull request #13576 from gjenkins8/consolidate_lint_run_functions
...
refactor: Consolidate lint package Run() functions
2 years ago
George Jenkins
5d13b0cac3
Merge pull request #13577 from gjenkins8/gjenkins/rm_pull_with_opts
...
refactor: Remove redundant `NewPullWithOpts`
2 years ago
Matt Farina
27bcda42dd
Updating the internal version to v4
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Austin Abro
9894d3ae78
shorten interface
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
8fe66998bf
refactor obj logic
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
f9736d9022
renames
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
d07f546003
get rid of rest client
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
eaa6e14546
test cleanup
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
674ab0d4f6
t.Parrallel
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
e9d9854364
introduce test for status wait
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
71434c0b38
implement logger
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
649475265d
implement logger
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
c26b44f651
update names
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
8ce1876192
get rid of ext interface
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
e6c6a40fe0
general error message
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
6b68a00440
change error messages
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
ac9012577a
status function
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
b8bdcc3a2b
Helm waiter
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
4c97d1276c
helm waiter
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
George Jenkins
1c807df5ba
cleanup: Remove superceeded 'lint/rules.Values' function
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
8468de42ed
cleanup: `NewShowWithConfig` -> `NewShow`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
3b9cce9669
cleanup: Remove 'ProcessDependenciesWithMerge'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Austin Abro
86338215b7
ability to create different waiters
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
cb6d48e6ae
status wait
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
4dd6e19b1d
provide path for creating new legacy waiter
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
2cb999d72b
go fmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
c3eeab67f9
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
4b59583670
delete wait and get completed phase
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Ryan Hockstad
ef2eb55283
Add test case for removing an entire object
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
2 years ago
Scott Rigby
60fcce18d1
Tests for bugfix: Override subcharts with null values #12879
...
- Add consistency for null test in given values, parent chart, subchart, and
sub-sub-chart
- Remove bar null test to keep consistent with boat=null at top level
Signed-off-by: Scott Rigby <scott@r6by.com>
2 years ago
Matt Farina
f65eaf35ce
Merge pull request #12690 from TerryHowe/oci-install-digest
...
feat: OCI install by digest
2 years ago
Jiasheng Zhu
f5d488122b
fix: check group for resource info match
...
Closes : #13582
Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com>
2 years ago
Austin Abro
db90b17484
unknown status
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
4dbdd7ce10
wait for delete working
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
9b63459bec
save state while I change up tests
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
265442c5eb
simplify things
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
28a9183ee3
context
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
b337790c10
paused as ready
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
e18f22071d
paused as ready now working
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
22af71f125
comments
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
7b896df4d1
option to wait for jobs
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
a6e5466942
refactor test
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
807cc925f5
refactor test
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
947425ee64
refactor new
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
aacaa08be2
only emebed waiter
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
859ff9b548
change structure of client
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
ad1f1c02ef
cleanup test
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
George Jenkins
88da89085e
refactor: Remove redundant `NewPullWithOpts`
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
edabef668a
more tidy
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
63623665ae
refactor: Consolidate lint package Run() functions
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Matt Farina
2236294119
Updating to helm.sh/helm/v4
...
Since Helm is going through breaking changes with Helm v4, the version path to
Helm needs to be updated.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Austin Abro
4564b8f712
make a working test
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
4c1758143f
basic design up and balling
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
a61a35240e
understand it better
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Austin Abro
6f7ac066ae
extending factory to enable getting a watcher
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
George Jenkins
b97ed6545a
Merge pull request #13232 from dnskr/helm-create-dont-render-empty-resource-fields
...
ref(create): don't render empty resource fields
2 years ago
Austin Abro
2f44164fc6
Merge branch 'refactor-wait' of github.com:AustinAbro321/helm into refactor-wait
2 years ago
Matt Farina
5727f56a96
Update to Go 1.23
...
Multiple changes were made to pass linting. Some Go built-in names
are being used for variables (e.g., min). This happens in the Go
source itself including the Go standard library and is not always
a bad practice.
To handle allowing some built-in names to be used the linter config
is updated to allow (via opt-in) some names to pass. This allows us
to still check for re-use of Go built-in names and opt-in to any
new uses.
There were also several cases where a value was checked for nil
before checking its length when this is already handled by len()
or the types default value. These were cleaned up.
The license validation was updated because it was checking everything
in the .git directory including all remote content that was local.
The previous vendor directory was from a time prior to Go modules
when Helm handled dependencies differently. It was no longer needed.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Austin Abro
41700f0248
WIP
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
Payal Godhani
5b18f525ed
Fixing a typo
...
-e
Signed-off-by: Payal Godhani <godhanipayal@gmail.com>
2 years ago
Payal Godhani
34cd8341c3
Add Contextual Error Messages to RunWithContext
...
-e
Signed-off-by: Payal Godhani <godhanipayal@gmail.com>
2 years ago
George Jenkins
e3e84343d2
refactor: tlsutil use options pattern
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Terry Howe
569f62e58b
chore: fix problems with latest lint
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 years ago
George Jenkins
b91a772d71
Merge pull request #13444 from justenstall/remove-status-flags
...
fix(status): remove --show-desc and --show-resources flags
2 years ago
Matt Farina
4dd2a7d626
Merge branch 'main' into oci-install-digest
2 years ago
Matt Farina
a1af40621a
Merge pull request #13499 from gjenkins8/shadow_oras_remoteclient_type
...
Shadow ORAS remote.Client interface
2 years ago
Andrew Block
2cea1466d3
Merge pull request #12962 from stevehipwell/add-plugin-platform-hooks
...
feat: Added multi-platform plugin hook support
2 years ago
George Jenkins
76ba8a4b9f
naming is hard
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
6dfaf955ee
Shadow ORAS remote.Client interface
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Scott Rigby
28770bfc1d
Merge pull request #12588 from rynowak/rynowak/override-authorizer
...
Make the authorizer and registry authorizer configurable
2 years ago
Ryan Nowak
1ab264cb7d
Make the authorizer and registry authorizer configurable
...
Fixes : #12584
This change makes the authorizer and registryAuthorizer of the registry client configurable via options. This allows Go SDK users to override the authentication behavior of the client.
This PR makes both the authorizer and registryAuthorizer configurable because depending on the exact scenario that may be needed. The default registryAuthorizer only supports a specific implementation of the authorizer.
Signed-off-by: Ryan Nowak <nowakra@gmail.com>
2 years ago
Steve Hipwell
bb9f0f7816
feat: Added multi-platform plugin hook support
...
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
2 years ago
George Jenkins
c724175b03
Merge pull request #13343 from niladrih/more-metadata
...
Add annotations and dependencies to get metadata output
2 years ago
Scott Rigby
bca7d31c9b
Merge pull request #12769 from banjoh/em/password-to-oci-registries
...
fix(helm): pass down username/password CLI parameters to OCI registry clients
2 years ago
Evans Mungai
7a22dd28d1
Rename CAFile to CaFile for consistency
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
Justen Stall
7df69020d8
revert duplicate slice conditions
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2 years ago
Justen Stall
62b5bdc9f6
restore error check in secrets.go
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2 years ago
Justen Stall
6aa19b8c92
more error wrapping uses
...
- replace os.IsNotExist with errors.Is and fs.ErrNotExist
- use %w directive
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2 years ago
Justen Stall
b0944e8e7e
fix incorrect error return
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2 years ago
Justen Stall
63cf42a843
fix: replace "github.com/pkg/errors" with stdlib "errors" package
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2 years ago
KISHOREKUMAR THUDI
2c8cfaea41
Replacing NewSimpleClientSet to NewClientSet due to deprecation
...
Signed-off-by: KISHOREKUMAR THUDI <kishorekumarthudi@kishore.myfiosgateway.com>
2 years ago
Robert Sirchia
21568dee29
Merge pull request #13425 from MathieuCesbron/main
...
Fix typo "re-use" to "reuse"
2 years ago
Justen Stall
483697584f
fix(status): remove --show-desc and --show-resources flags
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2 years ago
Matt Farina
2aba8a1fcd
Merge pull request #13424 from wangjingcun/main
...
fix: fix label name
2 years ago
mathieu cesbron
fc17fc75e2
Fix typo "re-use" to "reuse"
...
Signed-off-by: mathieu cesbron <mathieu.rudy.cesbron@gmail.com>
2 years ago
wangjingcun
e4062e7e00
fix: fix label name
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
2 years ago
Taylor Jasko
6f2f7d4781
Updating subchart load error to be more descriptive
...
In the event some malformed folders/files make its way into the
`charts/` directory meant for subcharts, it is possible one may see an
error message like the below:
```
Error: error unpacking foo in app: Chart.yaml file is missing
```
This error is not very descriptive, as it doesn't reference where on
disk `Chart.yaml` is missing. In the event this happens, this error is
being updated to include that `Chart.yaml` is missing for the `foo`
subchart.
Without this updated error messaging, one would need to look into Helm's
codebase to troubleshoot what exactly is wrong.
Signed-off-by: Taylor Jasko <taylor@taylorjasko.com>
2 years ago
Robert Sirchia
106e2f98e3
Merge pull request #13418 from alex-kattathra-johnson/issue-13417
...
Add tests to `helm/pkg/kube/client_test.go` to cover `wait.go`
2 years ago
Alex Johnson
9fd943b481
Add tests to `helm/pkg/kube/client_test.go` to cover `wait.go`
...
Signed-off-by: Alex Johnson <alex.kattathra.johnson@gmail.com>
2 years ago
Zach Burgess
0cc78c6ac3
Fix typo in pkg/lint/rules/chartfile_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
2 years ago
Suleiman Dibirov
f4f4a6b81f
fix(hooks): correct hooks delete order
...
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
2 years ago
Tianle Xu
a51ea6ec73
Allow tests to run on loong64
...
Signed-off-by: Tianle Xu <xtl@xtlsoft.top>
2 years ago
Andrew Block
717529a7e5
Merge pull request #13376 from helm/fix_oci_push_timestamp
...
fix: Use chart archive modifed time for OCI push
2 years ago
Robert Sirchia
5ae91e11ae
Merge pull request #13034 from mattclegg/issue-9507
...
ISSUE-9507: ADD `application/gzip,application/octet-stream` accept header
2 years ago
George Jenkins
85499b2fdc
Merge pull request #13400 from wangjingcun/main
...
chore: fix some function names in comment
2 years ago
Terry Howe
d2b94f6200
fix: make ORAS reference private
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 years ago
Terry Howe
aca7e8d775
fix: issue with helm template and oci chart
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 years ago
Terry Howe
ad9fb68fa3
feat: allow installation by OCI digest
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 years ago
wangjingcun
de9e138ec1
chore: fix some function names in comment
...
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
2 years ago
Robert Sirchia
7e6b34d7dd
removing duplicate empty test
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Robert Sirchia
16a4e37f20
fixing unit test as per Matt
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Evans Mungai
bdaa93b969
Ensure test fails without causing panic
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
Evans Mungai
3c4d0bb061
Fix failing tests
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
Evans Mungai
323f88950a
Merge remote-tracking branch 'origin/main' into em/password-to-oci-registries
2 years ago
Robert Sirchia
a205af755e
adding more unit test
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Robert Sirchia
999b85145a
adding test coverage for ready.go
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
satoru
5635ce585e
Refactor, use sort.Slice to reduce boilerplate code
...
Signed-off-by: satoru <satorulogic@gmail.com>
2 years ago
Matt Farina
8f59c8e807
Merge pull request #9713 from andreaskaris/issue9710
...
fix(helm): Retry Conflict error for createResource, deleteResource
2 years ago
Andreas Karis
79a1f2c801
fix(helm): Retry Conflict error for createResource, deleteResource
...
kubernetes might at any time throw 409 Conflict Error codes. Clients
are supposed to retry when this happens. As an example, see
kubernetes/issues/67761 where such an issues might happen when the
cluster manipulates a projects's ResourceQuotas.
Catch such Conflict Errors on createResource and deleteResource and
retry before giving up. Due to the more complex logic and focus on
kubernetes/issues/67761, this patch purposefully omits possibly
needed changes to updateResource and instead defers them to another
patch if required in the future.
Closes issue #9710
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
2 years ago
Jon Olsson
ca584648ee
minor spelling fix
...
Signed-off-by: Jon Olsson <jon.olsson@sequitor.se>
2 years ago
Matt Farina
54be5511e6
Merge pull request #12788 from vtrenton/main
...
changed Itoa to Sprintf to allow int64 value preventing 2038 overflow
2 years ago
Luis Davim
ab3c589809
chore: Make retryingRoundTripper type public
...
Make retryingRoundTripper type public to allow being used in other
projects
fixes : #13052
Signed-off-by: Luis Davim <luis.davim@gmail.com>
2 years ago
Trent V.
f9183a522a
Merge branch 'helm:main' into main
2 years ago
Trent V
4ede1c9c37
Merge branch 'helm:main' into main
2 years ago
dnskr
81c6a9085c
ref(create): don't render empty resource fields
...
Signed-off-by: Denis Krivenko <dnskrv88@gmail.com>
Signed-off-by: dnskr <dnskrv88@gmail.com>
2 years ago
George Jenkins
f5fcae8356
verbs
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
George Jenkins
02ef83fe28
fix: Use chart archive modifed time for OCI push
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Matt Farina
145d12f82f
Merge pull request #13177 from bb-Ricardo/main
...
Improves handling of Helm index with broken helm chart versions #13176
2 years ago
ricardo.bartels@telekom.de
cdbef2b7d1
Revering change unrelated to issue #13176
...
Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de>
2 years ago
Matt Farina
2da76a06e7
Merge pull request #13345 from AdamKorcz/fuzzzzz2
...
add chart fuzz tests
2 years ago
Matt Farina
7ad309791c
Merge pull request #13344 from AdamKorcz/fuzzzz1
...
add strvals fuzzer from cncf-fuzzing
2 years ago
Niladri Halder
d351b091ca
Add annotations and dependencies to get metadata output
...
The output of helm get metadata includes a subset of the fields contained in
the chart.Metadata struct. This change adds the values of the annotations field
and the dependencies field to the output.
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
2 years ago
Matt Farina
eecb848dcb
Merge pull request #13301 from NathanBaulch/typos
...
Fix typos
2 years ago
Matt Farina
d45439f2e9
Merge pull request #11923 from Bhargav-InfraCloud/helm-create-deprication-tests
...
test(create): Add test to check deprecated `apiVersion`s in resource templates created by `helm create`
2 years ago
Adam Korczynski
b203cc17c8
add strvals fuzzer from cncf-fuzzing
...
Signed-off-by: Adam Korczynski <adam@adalogics.com>
2 years ago
Adam Korczynski
e432f39ea7
add chart fuzz tests
...
Signed-off-by: Adam Korczynski <adam@adalogics.com>
2 years ago
Nathan Baulch
ef85fa7f2d
Grammar fixes
...
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
2 years ago
Nathan Baulch
ff9dd262e3
Fix typos
...
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
2 years ago
Matt Farina
b7c29d776f
Merge pull request #13329 from chenrui333/fix-test-chart
...
fix: fix testchart lint errors
2 years ago
Rui Chen
ddead08eb8
fix: fix testchart lint errors
...
Signed-off-by: Rui Chen <rui@chenrui.dev>
2 years ago
Fred Heinecke
30ce031d77
Merge branch 'main' into feat/add-toyamlpretty-1
2 years ago
Joe Julian
ff4877e696
Merge pull request #13224 from sttts/sttts-fix-apiext-registration
...
kube/client: add to global client-go scheme in init func
2 years ago
Joe Julian
1c73ea44ad
Merge remote-tracking branch 'upstream/main' into feat/toml-parsing
...
Signed-off-by: Joe Julian <me@joejulian.name>
2 years ago
Matt Farina
c81bd8912e
Revert "Improve helm dependency update performance"
...
The change in #11726 caused a regression where `helm dependency udpate`
stopped working. The format of the internal representation of the data
changed causing errors of "non-absolute URLs should be in form of
repo_name/path_to_chart". See #13324 for more details.
Since this change is in released Helm and it's a regression, reverting
the original change was the fastest and safest route to deliver a
fix as quickly as possible.
Closes #13324
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Matt Farina
d644da6205
bump version to v3.16.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 0d439e1a09 )
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Matt Farina
36ae5168bd
Merge pull request #13256 from robertsirc/issue-13229
...
Updating the inline documentation.
2 years ago
Andrew Block
a6f5844fb4
Merge pull request #13231 from dnskr/helm-create-drop-old-kubernetes-support
...
ref(create): drop old Kubernetes versions support in Ingress template
2 years ago
Joe Julian
333754479b
Merge pull request #11726 from Nordix/fixDepUpPerformance
...
Improve helm dependency update performance
2 years ago
Robert Sirchia
b92cc927d1
fixing changes as per requested.
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Robert Sirchia
b98952fb01
Merge branch 'helm:main' into issue-13229
2 years ago
Matt Farina
109dbe7c18
Merge pull request #13172 from maorfr/repository-cache-help-fix
...
fix repository-cache flag help description from file to directory
2 years ago
Robert Sirchia
e72978edcf
Updating the inline documentation.
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Scott Rigby
8a26add23f
Fix linting error for pr 12876
...
golangci-lint passed when last commit was made on #12876 , but has since failed.
This is probably because the linter has since updated.
I ran locally with the same version of golangci-lint we run in GH Actions, and
this is the only error now (an additional linting error in
pkg/action/package.go since #12876 has already been fixed.
```sh
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.58.1
./bin/golangci-lint run pkg/action/...
./bin/golangci-lint run ./...
```
we should be good now.
Signed-off-by: Scott Rigby <scott@r6by.com>
2 years ago
Matt Farina
c261d0655c
Merge pull request #12876 from manno/sdk-ignore-missing-annotations
...
Allow install, update action to adopt existing resources (sdk only)
2 years ago
Scott Rigby
f0442777bb
Merge pull request #12743 from anessi/feat/skip-schema-validation
...
feat(helm): add --skip-schema-validation flag to helm 'install', 'uprade' and 'lint'
2 years ago
dnskr
f9ba3c568b
ref(create): drop old Kubernetes versions support in Ingress template
...
Signed-off-by: Denis Krivenko <dnskrv88@gmail.com>
Signed-off-by: dnskr <dnskrv88@gmail.com>
2 years ago
Evans Mungai
0687961da4
Revert CAFile rename breaking change
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
MichaelMorris
9e5f465499
Merge branch 'helm:main' into fixDepUpPerformance
...
Signed-off-by: MichaelMorris <michael.morris@est.tech>
2 years ago
Dr. Stefan Schimanski
b9bdeca93b
kube/client: add to global client-go scheme in init func
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2 years ago
ricardo.bartels@telekom.de
af13b0d8dc
adds tests for handling of Helm index with broken chart versions #13176
...
Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de>
2 years ago
ricardo.bartels@telekom.de
154b477554
improves handling of Helm index with broken helm chart versions #13176
...
Signed-off-by: ricardo.bartels@telekom.de <ricardo.bartels@telekom.de>
2 years ago
Maor Friedman
84cbb2c59b
fix repository-cache flag help description from file to directory
...
Signed-off-by: Maor Friedman <mafriedm@redhat.com>
2 years ago
Joe Julian
4278ada158
Merge pull request #13085 from alex-kattathra-johnson/issue-12961
...
Fix race condition in TestInstallRelease_Wait_Interrupted test
2 years ago
Joe Julian
15e36139c1
Merge pull request #13130 from idsulik/issue-13127
...
fix: update error handling in Configuration.Init method, add tests for the method
2 years ago
Joe Julian
cda2c4f802
Merge pull request #12924 from porridge/drop-apis
...
Drop unused field.
2 years ago
Matt Farina
b3b6479e4c
Merge pull request #13117 from sidkmenon/sm/proxy-tls
...
Fix: add proxy support when mTLS configured on helm install/upgrade
2 years ago
anessi
acf7158565
feat(helm): add --skip-schema-validation flag to helm 'install', 'upgrade' and 'lint'
...
When --skip-schema-validation is set, any schema contain in the helm chart is ignored. Defaults to 'false'.
Closes #10398
Signed-off-by: anessi <16045045+anessi@users.noreply.github.com>
2 years ago
Matt Farina
ff03c66d44
Merge pull request #13120 from idsulik/issue-13110
...
fix(dependencyBuild): prevent race condition in concurrent helm dependency
2 years ago
Evans Mungai
12d8d28534
Add username/password to package subcommand
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
Evans Mungai
837ae4242c
Add username/password to dependency build/update subcommands
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
2 years ago
Alex Johnson
f69a2dd03e
Fix race condition in TestInstallRelease_Wait_Interrupted test
...
Signed-off-by: Alex Johnson <hello@alex-johnson.net>
2 years ago
Suleiman Dibirov
800c33a5aa
fix: update error handling in Configuration.Init method, add tests for the method
...
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
2 years ago
Evan Foster
69362df367
fix(helm): Use burst limit setting for discovery
...
When --burst-limit/$HELM_BURST_LIMIT is set, the specified value is not
currently used for the discovery client instantiated by
genericclioptions. This change sets genericclioptions.discoveryBurst to
the value of --burst-limit, meaning it should now be possible to fix
client-side throttling issues encountered by the discovery client.
This value is only configured if --burst-limit is actually set. If
--burst-limit is set to the default value, then discoveryBurst should be
left at its default of 300.
Closes #13128
Signed-off-by: Evan Foster <efoster@adobe.com>
2 years ago
Suleiman Dibirov
adeb4ca3d9
fix(dependencyBuild): prevent race condition in concurrent helm dependency
...
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
2 years ago
Sidharth Menon
b0603fb042
fix: respect proxy envvars on helm install/upgrade
...
Signed-off-by: Sidharth Menon <menon.sid.k@gmail.com>
2 years ago
Leo R. Lundgren
be88c963c4
style(pkg/chartutil): add missing dots and indentation to defaultValues
...
Pure cosmetics, add missing dots to a few comments and make indentation
coherent between different parts of the defaultValues YAML.
Signed-off-by: Leo R. Lundgren <leo@finalresort.org>
2 years ago
Andrew Block
414cf94666
Merge pull request #11600 from miles-w-3/chart-notes
...
Added support for hiding notes from install/upgrade output
2 years ago
Daniel Strobusch
90df4fa4d1
fix docs of DeployedAll
...
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
2 years ago
Matt Clegg
3c39705212
ISSUE-9507: TEST server with varied Accept Header
...
Signed-off-by: Matt Clegg <m@cle.gg>
2 years ago
Scott Rigby
51a07e7e78
Merge pull request #13013 from mattfarina/release-version-3.15
...
bump version to v3.15.0
2 years ago
fheinecke
e502486109
Merge branch 'main' into feat/add-toyamlpretty-1
...
Signed-off-by: fheinecke <23390735+fheinecke@users.noreply.github.com>
2 years ago
Matt Farina
c16b1c9f2b
Merge pull request #12867 from aauren/add_requirements.lock_warning
...
feat(load.go): add warning on requirements.lock
2 years ago
Matt Clegg
fff3547f9c
ISSUE-9507: ADD `application/gzip,application/octet-stream` accept header when downloading chart
...
Signed-off-by: Matt Clegg <m@cle.gg>
2 years ago
Matt Farina
886e626636
bump version to v3.15.0
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit d7afa3b6b4 )
2 years ago
Matt Farina
7b70fdf2a2
Merge pull request #12701 from mattfarina/bump-version-3.14
...
bump version to 3.14
2 years ago
Matt Farina
cf823d40d4
Merge pull request #12971 from dirkmueller/cert_extended_range
...
Update testdata PKI with keys that have validity until 3393 (closes #12880 )
2 years ago
Evans Mungai
76c0f297c1
Merge remote-tracking branch 'origin/main' into em/password-to-oci-registries
2 years ago
Jeff van Dam
ee41b5f0fc
Update manager_test.go
...
Signed-off-by: Jeff van Dam <jeff.van.dam@est.tech>
2 years ago
Jeff van Dam
dc761caf00
Merge branch 'helm:main' into fixDepUpPerformance
2 years ago
Calvin Krist
214fb6eff3
Fix namespace on kubeconfig error
...
Signed-off-by: Calvin Krist <calvin.krist@yahoo.com>
2 years ago
Dirk Müller
1b75d48189
Update testdata PKI with keys that have validity until 3393 ( Fixes #12880 )
...
The ca.crt had to be regenerated because there was no ca.key. Added
new ca.key so that going forward only the certs need to be updated.
Signed-off-by: Dirk Müller <dirk@dmllr.de>
2 years ago
Marcin Owsiany
f5d2ac070d
Remove somewhat incorrect comment.
...
While no longer used by the helm code, this field is part of the API exposed to helm charts as part of the .Capabilities struct.
Signed-off-by: Marcin Owsiany <marcin@redhat.com>
2 years ago
Matt Farina
a753ee7f43
Merge pull request #12866 from robertsirc/Correcting-Linting-Errors
...
Correcting linting errors
2 years ago
Marcin Owsiany
a6863a64ce
Drop unused field.
...
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
2 years ago
Bhargav Ravuri
9c0b4c8121
test(create): Test to check deprecated resource templates
...
Test to check deprecation warnings on resource templates that are
created by `helm create` against the latest Kubernetes version. This
test is run in a separate Makefile command to avoid failing other unit
tests configured to run with a specific Kubernetes version(s).
For resources that are disabled by default (like hpa and ingress),
to avoid skipping them from the helm linter test, they are enabled in
the test.
Fixes #11495
Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
2 years ago
deterclosed
dd37787ffd
chore: remove repetitive words
...
Signed-off-by: deterclosed <fliter@outlook.com>
2 years ago
Andrew Block
0a69a0dea6
Modified how created annotation is populated based on package creation time
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
2 years ago
Ryan Hockstad
5a58751a05
merge null child chart objects
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
2 years ago
Matt Farina
976ed8c0be
Merge pull request #12761 from ricardomaraschini/proxy-for-oci-download
...
bug: add proxy support for oci getter
2 years ago
Matt Farina
2dea5bf335
Merge pull request #11790 from Nordix/waitRetry
...
Add robustness to wait status checks
2 years ago
Mario Manno
a7856c0398
Add ability to adopt unmanaged resources
...
Allow the SDK actions to adopt existing resources. This allows install
and update to overwrite resources. If TakeOwnership is not set, adoption
is only possible if they existing resources have the right labels
(managed-by) and annotations (release-name, ...).
Signed-off-by: Mario Manno <mmanno@suse.com>
2 years ago
Matt Farina
25c473834e
Enabling hide secrets on install and upgrade dry run
...
This change adds a new flag to the install and upgrade commands in
the Helm client and properties to the install and upgrade action.
The new flag is --hide-secret and can only be used with the
--dry-run flag.
The --dry-run flag is designed to send all chart rendered manifests to
stdout so that they can be inspected.
When the --hide-secret flag is used the Secret content is removed from
the output.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Aaron U'Ren
29ab5c4b02
feat(load.go): add warning on requirements.lock
...
Signed-off-by: Aaron U'Ren <aauren@users.noreply.github.com>
2 years ago
Robert Sirchia
d58d7b3762
Fixing all the linting errors
...
Cleaned up all the linting errors we are getting.
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Matt Farina
764557c470
Some fixes
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Trent V
ceb44fd307
Merge branch 'helm:main' into main
3 years ago
Matt Farina
c7f318ca4c
Merge pull request #12789 from gjenkins8/fix_chart_index_load_invalid_alias
...
Fix: Ignore alias validation error for index load
3 years ago
Felipe Santos
c86a8cbd53
perf(dep-up): do not update the same repo multiple times
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
3 years ago
Trenton VanderWert
ab640a7177
added sprintf solution and found other possible overflow occurences
...
Signed-off-by: Trenton VanderWert <trenton.vanderwert@gmail.com>
3 years ago
George Jenkins
8d19bcb78a
add error messages
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 years ago
George Jenkins
68294fdae0
Fix: Ignore alias validation error for index load
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 years ago
Trenton VanderWert
4a45342887
changed Iota to FormatInt to allow int64 value preventing 2038 overflow
...
Signed-off-by: Trenton VanderWert <trenton.vanderwert@gmail.com>
3 years ago
Matt Farina
8e6a5149d2
validation fix
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Evans Mungai
dc158f6208
fix(helm): pass down username/password CLI parameters to OCI registry clients
...
When username/password parameters are passed in via the CLI
they are not passed down to the client handling requests to
OCI registries. This change ensures this happens
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 years ago
Ricardo Maraschini
94c1deae6d
bug: add proxy support for oci getter
...
adds missing proxy support on oci chart getter.
Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
3 years ago
Matt Farina
e81f6140dd
Merge pull request #12428 from matt-carr/main
...
fix(helm): fix grammatical error in default NOTES.txt
3 years ago
Matt Farina
f4c37e7db5
bump version to
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 69dcc92c56 )
3 years ago
Matt Farina
c042264a9d
Fix issues when verify generation readiness was merged
...
CI, tests, and building failed after #10920 was merged. This change
fixes the issues that were introduced.
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
b299359f66
Merge pull request #10920 from muang0/readiness-generation-check
...
Verify generation in readiness checks
3 years ago
Matt Farina
7fd08041b1
Merge pull request #12617 from porridge/dynamic-client
...
feature(pkg/engine): introduce RenderWithClientProvider
3 years ago
Antoine Deschênes
869c1d2560
lint: Add --kube-version flag to set capabilities and deprecation rules
...
Signed-off-by: Antoine Deschênes <antoine@antoinedeschenes.com>
3 years ago
Andrew Block
77d54d7dbe
Merge pull request #11351 from greed42/fast-tpl
...
Speed up `tpl`
3 years ago
Joe Julian
762a1c7adc
Merge pull request #12688 from mattfarina/bump-go-1.21
...
Update to Go 1.21 for builds
3 years ago
Matt Farina
83a76cea6a
Merge pull request #9176 from dastrobu/#9169/lint-dependency-shadowing
...
lint and validate dependency metadata to reference dependencies with …
3 years ago
Matt Farina
847369c184
Update to Go 1.21 for builds
...
Noteis:
1. This moves golangci scanning to a GitHub action. This will
enable inline pointers to issues in the PR where linting fails.
2. Go 1.21 is specified in the go.mod because Kubernetes libs
require it.
3. The lint issues were removed. Some were fixed while others
were handled by skipping linting or using _ as an argument.
Many of these can be refactored later for better cleanup.
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Joe Julian
6d96283c0b
Merge pull request #12204 from CARV-ICS-FORTH/riscv64
...
Add support for RISC-V
3 years ago
Joe Julian
e06a1432d5
Merge pull request #12530 from refl3ction/patch-1
...
helm create: move livenessProbe and readinessProbe values to default values file
3 years ago
Joe Julian
c9366c3a5c
Merge pull request #11878 from Exchizz/feature/pass-basic-auth-to-download-plugin
...
feat: pass basic auth to env-vars when running download plugins
3 years ago
Joe Julian
99b8f443d1
Merge pull request #11387 from zak905/fix_post_install_hook_issue
...
fix post install hook deletion due to before-hook-creation policy
3 years ago
Joe Julian
35e94bb99d
Merge pull request #12440 from sergelogvinov/hook-name
...
print failed hook name
3 years ago
Joe Julian
c3742e6331
Merge pull request #12662 from ialidzhikov/enh/make-ignore-pkg-public
...
Make the `ignore` pkg public again
3 years ago
Joe Julian
30c35166e8
Merge pull request #12350 from iamasmith/qps-iamasmith-1
...
QPS parameter proposal
3 years ago
Marcin Owsiany
a997de1f11
tests(pkg/engine): test RenderWithClientProvider
...
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
3 years ago
Ismail Alidzhikov
5586760133
Make the `ignore` pkg public again
...
Signed-off-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
3 years ago
Marcin Owsiany
bfec4ec926
feature(pkg/engine): introduce RenderWithClientProvider
...
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
3 years ago
Daniel Pap
f25e0d6073
show crds command output separated by document separator
...
Signed-off-by: Daniel Pap <papfdani@gmail.com>
3 years ago
Fred Heinecke
73f1dcc1d9
Added `toYamlPretty` template function
...
Signed-off-by: Fred Heinecke <fred.heinecke@goteleport.com>
3 years ago
Sean Mills
ce87ece23e
Remove excessive logging
...
Resolves helm unittest issue helm-unittest/helm-unittest#237
Signed-off-by: Sean Mills <sean.m.mills@gmail.com>
3 years ago
Matt Farina
0592b3800a
Merge pull request #12457 from genofire/patch-1
...
chore(create): indent to spaces
3 years ago
Matt Farina
c682fdfebf
Merge pull request #12539 from chojnack/main
...
Fixing release labelling in rollback
3 years ago
Matt Farina
dae8783177
Merge pull request #12447 from dm3ch/allow-filtering-using-system-labels
...
Allow using label selectors for system labels for secrets and configmap
3 years ago
Scott Rigby
2745909d3d
Merge pull request #9653 from Okhoshi/feat/reset-then-reuse-flag
...
feat(helm): Add --reset-then-reuse-values flag to 'helm upgrade'
3 years ago
Marcin Chojnacki
8814bfb490
Fixing release labelling in rollback
...
1. Fixed propagating labels to rollback release
Signed-off-by: Marcin Chojnacki <marcin.chojnacki@nokia.com>
3 years ago
Denis Policastro
9f0313e5f5
feat: move livenessProbe and readinessProbe values to default values file
...
Signed-off-by: Denis Policastro <denis.policastro@gmail.com>
3 years ago
Matt Farina
24e2864c64
Revert "fix(main): fix basic auth for helm pull or push"
...
This reverts commit 4a27baaffc .
Note, PR #11129 was layered in along with this change so the revert
preserves this API addition.
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
992dc58556
Revert "fix(registry): address anonymous pull issue"
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Dmitry Chepurovskiy
250f0bd46e
Drop filterSystemLabels usage from Query method
...
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
3 years ago
Dmitry Chepurovskiy
0ec47f8ec9
Apply review suggestions
...
Co-authored-by: French Ben <FrenchBen@users.noreply.github.com>
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
3 years ago
Serge Logvinov
b0d163771e
feat: print failed hook name
...
Add more details when a hook fails.
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
3 years ago
Matt Farina
25371e2f0d
Fixing precedence issue with the import of values.
...
The ordering should be:
1. User specified values (e.g CLI)
2. Parent chart values
3. Imported values
4. Sub-chart values
This enables parnet charts to import large set of values from a
child and then override select values.
This change is needed for backwards compatibility.
Fixes #12460
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
1b260d0a79
Merge pull request #12433 from larszi/fix-12432-helm-create-serviceaccount
...
FIX Default ServiceAccount yaml
3 years ago
Matt Farina
ff8f0276ca
Merge pull request #12429 from hiddeco/fix-swallowed-err
...
fix(registry): unswallow error
3 years ago
Miles Wilson
0c541398f2
Added support for hiding notes from install/upgrade output
...
Signed-off-by: Miles Wilson <wilson.mil@icloud.com>
3 years ago
genofire
919bffe2db
chore(create): indent to spaces
...
Signed-off-by: genofire <geno+dev@fireorbit.de>
3 years ago
Dmitry Chepurovskiy
e6d9b99255
Allow using label selectors for system labels for sql backend.
...
Fixes #12435
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
3 years ago
Dmitry Chepurovskiy
e219c756e0
Allow using label selectors for system labels for secrets and configmap
...
backends.
Fixes #12435
Signed-off-by: Dmitry Chepurovskiy <me@dm3ch.net>
3 years ago
b4nks
f004d42847
remove useless print during prepareUpgrade
...
Signed-off-by: b4nks <b4nks@protonmail.com>
3 years ago
Lars Zimmermann
828763e0d8
FIX Default ServiceAccount yaml
...
As described in issue #12432 (https://github.com/helm/helm/issues/12432 ) the default serviceaccount yaml will be created wrong. This commit will fix this.
Signed-off-by: Lars Zimmermann <info@zimmermann-lars.de>
3 years ago
Hidde Beydals
fe4c01f624
fix(registry): address anonymous pull issue
...
The assumption that either a username and/or password OR an error is
returned appears to be wrong, and results in an error later on which
looks something like the following:
```
failed to authorize: failed to fetch anonymous token: unexpected status
from GET request to https://auth.docker.io/token?scope=repository%3AXXX%2FYYY%3Apull&service=registry.docker.io :
401 Unauthorized
```
To mitigate this, confirm we actually have one of the values before
setting the `Authorization` header.
Co-authored-by: Joe Julian <me@joejulian.name>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
3 years ago
Hidde Beydals
da3c666a82
fix(registry): unswallow error
...
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
3 years ago
Matt Carr
c25736c894
Fix grammatical error
...
Signed-off-by: Matt Carr <mcarr@kinaxis.com>
3 years ago
Matt Farina
162b3efc33
Merge pull request #12394 from abrarcv170/patch-1
...
Increased release information key name max length.
3 years ago
Andy Smith
415af5b0e9
Add qps/HELM_QPS parameter
...
Signed-off-by: Andy Smith <iamasmith.home@gmail.com>
3 years ago
Matt Farina
c372b15022
bump version to v3.13.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 825e86f6a7 )
3 years ago
Matt Farina
dbef83eac3
Merge pull request #10913 from sureshdsk/pluginbug
...
fix: plugin does not load when helm base dir contains space
3 years ago
Matt Farina
30254deff4
Merge pull request #12088 from mslapek/fix/11971-run-with-ctx
...
Fix leaking goroutines in Install
3 years ago
Michał Słapek
169561a1b3
Fix leaking goroutines in Install
...
Signed-off-by: Michał Słapek <28485371+mslapek@users.noreply.github.com>
3 years ago
Matt Farina
70cbaa0a73
Merge pull request #11372 from vovtz/#11369-fix-custom-repo-cache-for-unmanaged-dependency-updates
...
#11369 Fix custom repo index cache directory for unmanaged dependency updates
3 years ago
abrarcv170
4199be82b5
Increased release information key name max length.
...
Helm release names are limited to 53 characters. By default, Release information is stored in Kubernetes as secrets, and the secret's name structure follows the pattern "sh.helm.release.v1.<release name up to 53 characters>.v<release revision>." However, in the case of using an SQL backend, this release information key is stored in the release_v1 table, and the table constraint currently limits the key name length to 67 characters. This limitation may not be suitable for release names that are within Helm's 53-character limit and need to accommodate the additional "sh.helm.release.v1." prefix and the release revision suffix.
Signed-off-by: abrarcv170 <78675575+abrarcv170@users.noreply.github.com>
3 years ago
Matt Farina
ef02cafdd0
Merge pull request #12274 from mih-kopylov/get-metadata
...
Restore `helm get metadata` command
3 years ago
Matt Farina
5a1475ee36
Merge pull request #11294 from Juneezee/test/t.TempDir
...
test: replace `ensure.TempDir` with `t.TempDir`
3 years ago
Matt Farina
4feafb528b
Merge pull request #12019 from GOodCoffeeLover/feat/rw-psql
...
sql driver with rw-roles
3 years ago
Joe Julian
e7bb860d9a
Merge pull request #12245 from hiddeco/json-index
...
Add support for creating repository indexes in JSON format
3 years ago
Jeff van Dam
183f01b32c
Made urls key more specific
...
Signed-off-by: Jeff van Dam <jeff.van.dam@est.tech>
3 years ago
Joe Julian
edc93cb988
Merge pull request #11649 from tim-chaplin-dd/tim.chaplin/fix-selector-labels-2
...
Use common labels instead of selectorLabels for pod labels
3 years ago
Joe Julian
eb4edc96c5
Merge pull request #10965 from mattfarina/factory-comment
...
Adding details on the Factory interface
3 years ago
Maxim Trofimov
4944acb341
fix conflict
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
3 years ago
Maxim Trofimov
6138e101aa
add big tests
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
3 years ago
Maxim Trofimov
199784f711
fix conflict
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
3 years ago
Maxim Trofimov
b786cb40f0
fix
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
3 years ago
Maxim Trofimov
df5904d88a
add check if all migrations already applied
...
Signed-off-by: Maxim Trofimov <qwerty65k@mail.ru>
3 years ago
Joe Julian
1d2221f9d6
Merge pull request #12290 from Ithrael/fix/helm-rollback-err-tips
...
fix(rollback): helm rollback err tips
3 years ago
Joe Julian
126333c525
Merge remote-tracking branch 'upstream/main' into #9169/lint-dependency-shadowing
3 years ago