160 Commits (main)

Author	SHA1	Message	Date
George Jenkins	81d6f04c82	Merge pull request #30867 from mmorel-35/gocritic ... chore: fix deprecatedComment issues from gocritic	2 months ago
Terry Howe	59b57c5c31	Merge pull request #31885 from mmorel-35/whitespace ... chore: fix whitespace linter	2 months ago
Matthieu MOREL	488c4a805d	Fix empty and len testifylint violations across test files ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	3 months ago
Evans Mungai	d374e823b2	Merge pull request #32086 from mmorel-35/error-is-as ... testifylint: enable error-is-as and error-nil rules	3 months ago
Robert Sirchia	6c3f397d2c	Merge pull request #32122 from quyentonndbs/chore/lint-deprecations-comment-typo ... docs: fix typo in deprecated API godoc	3 months ago
Kai Tanaka	2032ec5cba	docs: fix 'than'->'that' typo in deprecatedAPIError godoc ... Signed-off-by: Kai Tanaka <275430420+quyentonndbs@users.noreply.github.com>	3 months ago
box4wangjing	432fc8a217	refactor: use slices.Backward to simplify the code ... Signed-off-by: box4wangjing <box4wangjing@outlook.com>	3 months ago
Matthieu MOREL	f8ba28bb17	testifylint: enable error-is-as and error-nil rules ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	4 months ago
Matheus Pimenta	a4a9cc7a31	Upgrade Go to 1.26, Kubernetes to 1.36, kstatus to 1.1 ... Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	4 months ago
George Jenkins	4bd9e90aa0	Merge pull request #30811 from mmorel-35/testifylint ... chore: fix bool-compare issues from testifylint	4 months ago
George Jenkins	f7c4d75574	Merge commit from fork ... fix: Chart dot-name path bug	4 months ago
Anmol Virdi	de58531ca7	Minor nit: fix import instructions to comply with canonical import paths ... Signed-off-by: Anmol Virdi <anmolvirdi2000@gmail.com>	4 months ago
Matthieu MOREL	7edfff33eb	chore: fix unnecessary-format issues from revive ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	071558d69f	chore: fix bool-compare issues from testifylint ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	83a0138172	chore: fix deprecatedComment issues from gocritic ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
Matthieu MOREL	1e0f702f00	chore: fix whitespace linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	5 months ago
George Jenkins	610547b570	Merge pull request #31873 from mmorel-35/perfsprint-pkg-5-3294250 ... chore(pkg): fix perfsprint linter issues part 5	5 months ago
George Jenkins	60184996e5	fix: Chart dot-name path bug ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	5 months ago
George Jenkins	df8e0301ed	Merge pull request #31878 from mmorel-35/perfsprint-pkg-3-39f7a9f ... chore(pkg): fix perfsprint linter issues part 3	5 months ago
Matthieu MOREL	1d2d63cc43	chore(pkg): enable perfsprint linter ... #### Description enable perfsprint linter in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matthieu MOREL	c25c988cfb	chore(pkg): enable perfsprint linter ... #### Description enable perfsprint linter in pkg/registry Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Mads Jensen	36cb3a2fe9	Replace unneeded use of t.Fatalf with t.Fatal ... Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>	6 months ago
Matthieu MOREL	5b6c6bbfc7	fix: enable nolinlint linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
George Jenkins	be7cdb69e5	Merge pull request #31806 from mmorel-35/errorlint-pkg-4-15f432a ... fix(pkg): errorlint linter	6 months ago
George Jenkins	92b64e87ad	chore: fixes ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	6 months ago
Matt Farina	794372e317	Merge pull request #31816 from mmorel-35/errorlint-pkg-7-6d6a660 ... fix(pkg): errorlint linter	6 months ago
Joe Julian	947b429cdd	Merge pull request #31801 from mmorel-35/modernize-pkg-4-062b248 ... chore(pkg): fix modernize linter	6 months ago
Joe Julian	78f5af72be	Merge pull request #31802 from mmorel-35/modernize-pkg-5-a3c8fdb ... chore(pkg): fix modernize linter	6 months ago
Matthieu MOREL	259f76a849	fix(pkg): errorlint linter ... errorlint linter in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matthieu MOREL	6d1490ed1e	fix(pkg): errorlint linter ... #### Description errorlint linter in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matthieu MOREL	4d0ae7f33a	fix(pkg): errorlint linter ... #### Description errorlint linter in pkg Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matthieu MOREL	5cc2e55714	chore(pkg): fix modernize linter ... #### Description fix modernize linter in pkg/chart/v2/lint/rules Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matthieu MOREL	ba38159313	chore(pkg): fix modernize linter ... #### Description fix modernize linter in pkg/strvals Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Matthieu MOREL	111d4e6e0e	chore(pkg): fix modernize linter ... #### Description fix modernize linter in pkg/chart/common/util Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
Branch Vincent	c6d9a5bdc2	build: set kube version via `debug.BuildInfo` ... Signed-off-by: Branch Vincent <branchevincent@gmail.com> Signed-off-by: George Jenkins <gvjenkins@gmail.com>	8 months ago
Mads Jensen	a490bb3c20	Use errors.Is to check for io.EOF and gzip.ErrHeader ... In GoLang, using the == operator to check for a certain error will not unwrap the error chain, and therefore may hide the problem. Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>	8 months ago
Robert Sirchia	4cf7d8d025	Merge pull request #31641 from wangjingcun/main ... chore: fix some comments to improve readability	8 months ago
wangjingcun	858cf31583	chore: fix some comments to improve readability ... Signed-off-by: wangjingcun <wangjingcun@aliyun.com>	8 months ago
Mads Jensen	a18e59e465	Enable the sloglint linter ... Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>	8 months ago
Matt Farina	ff35414bed	Merge pull request #31546 from benoittgt/31544-nil-pointer ... fix(lint): prevent segmentation violation on only comment yaml in multidoc	8 months ago
Benoit Tigeot	81d244ca21	fix: prevent segmentation violation on empty yaml in multidoc ... Fixes: https://github.com/helm/helm/issues/31544 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	9 months ago
Scott Rigby	b740071279	Merge pull request #31342 from TerryHowe/chore-remove-mitchellh-dependency-3 ... chore: replace github.com/mitchellh/copystructure	9 months ago
Matt Farina	15300549f0	When time not available, using time.Now ... Note, when time is not available, the builds are not reproducible. This problem would only happen when an SDK user is using parts of the API to build their own tooling. Helm will consistently inject the dates through the higher level APIs. Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	ca8eae9361	Reproducible chart archive builds ... Building the same chart into an archive multiple times will have the same sha256 hash. Perviously, the time in the headers for a file was time.Now() which changed each time. The time is now collected from the operating system when the file is loaded and this time is used. Fixes: #3612 Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	37de51428c	Merge pull request #31376 from benoittgt/accept-yaml-yml ... Do not ignore *.yml file on linting while accepting *.yaml	10 months ago
Benoit Tigeot	06188f9dfe	Add test for isYamlFileExtension functions ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	10 months ago
Matt Farina	78cd44bd75	Merge pull request #30712 from gjenkins8/gjenkins/cleanup_lint_template ... cleanup: Remove extra lint/rules.Template functions	10 months ago
Benoit Tigeot	4a944230ea	Do not ignore *.yml file on linting while accepting *.yaml ... From : https://github.com/helm/helm/pull/30712/files#r2417446037 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	10 months ago
Terry Howe	ee322a9671	fix: flakey lint test on shuffle ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
Terry Howe	bee9c1a108	chore: replace github.com/mitchellh/copystructure ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
George Jenkins	efcb5735e5	cleanup: Remove extra lint/rules.Template functions ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	11 months ago
Matt Farina	8dc7c57f50	Update the action interfaces for chart apiversions ... This change is about handling the interfaces to public functions for different chart apiVersions. The internals are still focused on v2. This enables v3 to be layered in layer. Signed-off-by: Matt Farina <matt.farina@suse.com>	11 months ago
Benoit Tigeot	072e2a689a	Extend --skip-schema-validation for lint command ... When --skip-schema-validation is enabled, the lint command will now skip JSON schema validation for values.yaml files, allowing charts with schema validation errors to pass linting when the flag is used. This addresses the gap where --skip-schema-validation only applied to templates but not to values files, providing complete schema validation bypass when needed. Fixes: #13413 Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	11 months ago
Kamil Swiechowski	a645dfb7f8	fix:semverv2 lint test error message ... Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>	11 months ago
Kamil Swiechowski	38d1a7376f	fix: throw warning when chart version is not semverv2 ... Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>	11 months ago
Matt Farina	9dcc49cbd5	Move lint pkg to be part of each chart version ... Linting is specific to the chart versions. A v2 and v3 chart will lint differently. To accomplish this, packages like engine need to be able to handle different chart versions. This was accomplished by some changes: 1. The introduction of a Charter interface for charts 2. The ChartAccessor which is able to accept a chart and then provide access to its data via an interface. There is an interface, factory, and implementation for each version of chart. 3. Common packages were moved to a common and util packages. Due to some package loops, there are 2 packages which may get some consolidation in the future. The new interfaces provide the foundation to move the actions and cmd packages to be able to handle multiple apiVersions of charts. Signed-off-by: Matt Farina <matt.farina@suse.com>	11 months ago
Robert Sirchia	30404b4173	Merge pull request #31138 from islewis/release-3.18 ... fix(helm-lint): Add HTTP/HTTPS URL support for json schema references	12 months ago
Isaiah Lewis	62e0c78ef8	fix(helm-lint): fmt ... Signed-off-by: Isaiah Lewis <isaiah@roof12.com>	12 months ago
Isaiah Lewis	fb12b44493	fix(helm-lint): Add TLSClientConfig ... Signed-off-by: Isaiah Lewis <isaiah@roof12.com>	12 months ago
Isaiah Lewis	fa73b6743b	fix(helm-lint): Add HTTP/HTTPS URL support for json schema references ... Signed-off-by: Isaiah Lewis <isaiah@roof12.com>	1 year ago
joemicky	fab70472af	refactor: replace []byte(fmt.Sprintf) with fmt.Appendf ... Signed-off-by: joemicky <joemickychang@outlook.com>	1 year ago
Joe Julian	6ecf033700	Merge pull request #13111 from rawtaz/style-cosmetics ... style(pkg/chartutil): add missing dots and indentation to defaultValues	1 year ago
Joe Julian	3fe1cb6f02	Merge remote-tracking branch 'upstream/main' into style-cosmetics	1 year ago
Matt Farina	0c64ad1c97	fix Chart.yaml handling ... Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Borys Hulii	9f6beaad48	fix: k8s version parsing to match original ... Signed-off-by: Borys Hulii <borys.hulii@bitvavo.com>	1 year ago
yumeiyin	8c22fbfe4a	refactor: replace Split in loops with more efficient SplitSeq ... Signed-off-by: yumeiyin <yin.yumei@qq.com>	1 year ago
curlwget	bfc1af68fb	chore: fix function in comment ... Signed-off-by: curlwget <curlwget@icloud.com>	1 year ago
acceptacross	9623fb80f1	chore: fix some function names in comment ... Signed-off-by: acceptacross <csqcqs@gmail.com>	1 year ago
Benoit Tigeot	b2fd91b8d0	Adapt error of invalid json schema with the new expected output ... Closes: https://github.com/helm/helm/pull/30907 To be able to upgrade to v6.0.2 for jsonschema lib we need to upgrade this test. I am wondering if it's related to this commit: 86cca28795 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Matt Farina	cf7613ba6b	Reverting fix "renders int as float" ... This reverts #13533 This change has caused issues with numerous charts around things unrelated to toml. This is because of functions like typeIs/typeOf being used and acted upon. The change caused a significant regression. Note: This kind of change can be put into v3 charts, that are in active development, without causing a regression. Closes #30880 Signed-off-by: Matt Farina <matt@mattfarina.com>	1 year ago
Matthieu MOREL	157f0ba10a	chore: enable thelper ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
yetyear	03448d1d79	refactor: use maps.Copy for cleaner map handling ... Signed-off-by: yetyear <flite@outlook.com>	1 year ago
findnature	ac8d2f9aed	refactor: use slices.Contains to simplify code ... Signed-off-by: findnature <cricis@aliyun.com>	1 year ago
Justen Stall	4905a61026	Merge branch 'main' into stdlib-errors-2 ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Robert Sirchia	d9bc0a948c	Merge pull request #30777 from ryanhockstad/merge-fix ... fix: null merge. closes #30587	1 year ago
Daniel Strobusch	b183eccfc4	copy dependency metadata on aliasing to avoid sharing imported values ... imported values are stored in dependency objects, which breaks if a chart dependency is shared among multiple aliases. By copying the dependency objects in the metadata values can be imported correctly. Supersedes #10174 Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>	1 year ago
Daniel Strobusch	df7befd208	copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies ... Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases. By copying the dependencies, parent information can be set correctly to render the templates as expected later on. Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level. Closes #9150 Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>	1 year ago
Justen Stall	3877ec9049	fix golangci-lint issues ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Justen Stall	280a9ddbdb	Merge branch 'main' into stdlib-errors-2 ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Ryan Hockstad	c1175a4106	fix null merge ... Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>	1 year ago
Edward Miller	14a468f24d	Add chartutil.StrictLoadChartfile for strict (WARNING-level) lint ... Signed-off-by: Edward Miller <edmiller287@gmail.com>	1 year ago
Edward Miller	00f8561ad4	fix(pkg/lint): unmarshals Chart.yaml strictly ... When "helm lint" is run, it now errors on invalid chartfiles, e.g. those with duplicate keys Closes #12381 Signed-off-by: Edward Miller <edmiller287@gmail.com>	1 year ago
Matt Farina	01590a59b2	Merge pull request #30760 from robertsirc/add-debuging-to-jsonschema ... adding slog debug to a few points	1 year ago
Robert Sirchia	da096e1b7a	Merge pull request #30752 from benoittgt/bump-golangci-lint-action ... Bump golangci lint to last major version and fix static-check errors	1 year ago
Robert Sirchia	ef0361de21	fixing as per review ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	1 year ago
Robert Sirchia	9b9ff12c6d	adding slog debug to a few points ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	1 year ago
Matt Farina	0dffc580b0	Simpligy the JSON Schema checking ... A new library was introduced that provides JSON Schema checking for newer versions of the schema. In Helm v4, there is no need to have two packages doing the JSON schema validation. The message output can have breaking changes. This change moves everything to the newer library. It also uses a wrapper error to enable a clean Helm only interface for the public Go API validation functions. This would enable the replacement of the Schema validation library, if needed, without breaking the Go API contract. Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Benoit Tigeot	a9b7732367	could remove embedded field X from selector ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Kurnia D Win	6c54351c01	Merge remote-tracking branch 'upstream/main' into jsonschema	1 year ago
Matt Farina	7a1eb77e77	Merge pull request #30708 from benoittgt/migrate-kube-pkg-to-slog ... Migrate pkg to slog	1 year ago
Matt Farina	0740dfc7a9	Unarchiving fix ... Signed-off-by: Matt Farina <matt@mattfarina.com>	1 year ago
Benoit Tigeot	0c85456788	Leverage slog.Any for errors ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Matt Farina	ab9f0c80b5	Merge pull request #30603 from robertsirc/converting-to-slog ... converting inline log to slog	1 year ago
Robert Sirchia	c5991028e0	fixing matts changes ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	1 year ago
Henrik Gerdes	597c35852a	fix: align values comments/docs to scaffold standard ... Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>	1 year ago
Henrik Gerdes	ca367d970c	docs: more user-friendly info for httpRoute scaffold ... Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>	1 year ago
Henrik Gerdes	1aac5b0b70	fix: use common chart-example.local hostname for http-route default ... Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>	1 year ago
Henrik Gerdes	5d0c6e9ae4	fix: remove v1alpha2 gateway api support ... Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>	1 year ago
Henrik Gerdes	d22939b439	fix: correct expected number of template files in unit-test ... Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>	1 year ago
Henrik Gerdes	3fc5d689e6	docs: add notes in chart templates for accessing httproute ... Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>	1 year ago