9c44fd7854
feat: ignore href when hydrating ( #9662 )
...
* ignore href when hydrating
* remove unused export keyword
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
da1aa7c4a8
feat: support type annotations in `{@const ...}` tag ( #9609 )
...
* support type for const tag
* use expression directly
* lint
* format
* format
* revert
* legacy mode
* format
* revert and update .prettierignore
2 years ago
617d63dd90
fix: take event attributes into account when checking a11y ( #9664 )
...
also adjusted the warning messages slightly so they make sense for both variants of event handlers
fixes #9654
2 years ago
83fd001157
fix: prevent reactive snippet from reinitializing unnecessarily ( #9665 )
...
untrack the invocation itself, only track the snippet function
fixes #9652
2 years ago
405e9da4ff
chore: bump esrap ( #9649 )
...
* bump esrap
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
66d540d3c5
Version Packages (next) ( #9642 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
7f237c2e41
fix: omit this bind this arg if we know it's not a signal ( #9635 )
...
fixes #9629
Co-authored-by: Dominic Gannaway <dg@domgan.com>
2 years ago
dee5bed829
fix: improve each block index handling ( #9644 )
...
* fix: improve each block index handling
* format
2 years ago
02f3f42981
fix: apply keyed validation only for keyed each ( #9641 )
2 years ago
94afdc8a4b
Version Packages (next) ( #9633 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
63e5831846
fix: adjust mount and createRoot types
...
they expect the component constructor, not the instance
2 years ago
a3bc7d5698
fix: type-level back-compat for default slot and children prop
...
If someone has an existing SvelteComponent type definition and using the slot generic to type the default slot, automatically add that slot to the prop type as "children"
2 years ago
cb4b1f0a18
fix: remove constructor overload
...
The original intent was for typing generation tools like svelte2tsx to use the virtual constructor instead, but it does more harm than good. Most notably, the TS error message when props are wrong becomes completely useless. It's better for tooling to silence the deprecation message and switch over to a new virtual constructor once we remove the deprecated one.
2 years ago
b7af2ffabd
Version Packages (next) ( #9607 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
78a69acfa1
fix: dont error on stores looking like runes when runes explicitly turned off ( #9615 )
2 years ago
72d3a2a8ce
fix: better attribute casing logic ( #9626 )
...
- don't lowercase attributes on svg and custom element elements, fixes #9605
- better lowercasing + property alias checking for spreads, fixes #9305
2 years ago
ef68b66dee
fix: improve member expression mutation logic ( #9625 )
...
* fix: improve member expression mutation logic
* cleanup
* Update .changeset/moody-frogs-exist.md
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
c7121aa38c
feat: add type of `$effect.active` ( #9624 )
2 years ago
d8d9be39d3
fix: apply correct snippet scope ( #9623 )
2 years ago
509f92d29e
fix: correctly assign bind:this with multiples ( #9617 )
...
* fix: correctly assign bind:this with multiples
* better fix
* better fix
* lint
* lint
* Update packages/svelte/src/internal/client/render.js
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
c22ebffb00
chore: untrack keyed validation logic ( #9618 )
...
* untrack validation logic
* chore: untrack keyed validation logic
2 years ago
8118efd115
fix: handle undefined bubble events ( #9614 )
...
Fixes #9610
2 years ago
0283e50070
chore: reuse common templates ( #9601 )
...
#9589 - add comment and space as reusable templates to save a few bytes. We can definitely take this idea further, but this is a base to iterate from.
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2 years ago
d83bd7f7c1
Version Packages (next) ( #9576 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
88f1a8f62e
chore: better error message for not using snippet type ( #9602 )
...
language tools checks that a function passed to `{@render ..}` is returning a type that adheres to the `Snippet` return type. When it does not, the error message is pretty useless without this additional info text.
2 years ago
5f6c5ca8ae
chore: remove get_callee_name ( #9595 )
...
no longer necessary with the enhanced get_rune function
2 years ago
13c6c273c6
fix: prevent false positives when detecting runes mode ( #9599 )
...
Move references from module scope to instance scope if we determined that these references are store subscriptions
fixes #9580
2 years ago
c837771ca6
chore: better `get_rune` helper ( #9594 )
...
* chore: add $effect.active rune
* chore: add $effect.active rune
* WIP
* allow get_rune to return a keypath
* oops
---------
Co-authored-by: Dominic Gannaway <dg@domgan.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
1f4ae5ef45
chore: remove some unused code ( #9593 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
cf9130613d
feat: add $effect.active rune ( #9591 )
...
* chore: add $effect.active rune
* chore: add $effect.active rune
2 years ago
13aef5245b
put nested class warning on the declaration, not the usage site ( #9592 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
fe9c0bc19d
chore: bump esrap ( #9590 )
2 years ago
eb0b4dc6e5
chore: add inline new class warning ( #9583 )
...
* chore: add inline new class warning
* Address feedback
* address feedback
* more tests
2 years ago
1003acccc4
feat: add Snippet type ( #9584 )
...
* feat: add Snippet type
related to #9447
* one more test
2 years ago
da15806136
fix: adjust event delegation heuristics ( #9581 )
...
Fixes #9561
2 years ago
46c572a14d
chore: deduplicate
2 years ago
c011db178b
fix: select enabled option with null value when it matches bound value ( #9550 )
...
Fix select binding when matching enabled option has null value
Fix null option being selected when it doesn't match the bound value
Fixes #9545
2 years ago
1bc89b5eb6
fix: deconflict generated names against globals ( #9570 )
...
fixes #9559
2 years ago
945a90b56c
fix: disallow static state fields ( #9577 )
...
closes #9547
2 years ago
617df1f3c3
fix: adjust regex ( #9572 )
...
would error on non-quoted attributes with more than one character
2 years ago
b9664700b7
Version Packages (next) ( #9542 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
1c48d7cbdc
Typescript each indexed ( #9567 )
...
* failing test
* fix undefined index bug
* Update packages/svelte/src/compiler/phases/1-parse/read/context.js
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
225a5bfe50
set expression end to typeAnnotation end where appropriate ( #9566 )
...
* set expression end to typeAnnotation end where appropriate
* fix
* woops
* lint
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
459e4ff006
feat: native TypeScript support ( #9482 )
...
* add typescript support to parser
* fix
* unnecessary
* various
* transform assertions
* tweak
* prettier
* robustify
* fix
* see if this fixes the prettier stuff
* only parse ts in ts mode
* fixes
* fix
* fix
* fix
* fix
* more
* check
* changeset
* allow type annotations on all contexts
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
9926347ad9
fix: adjust static attribute regex ( #9552 )
...
Svelte 5 version of #9551
2 years ago
550cecf311
chore: shave off more bytes ( #9540 )
...
* shavings
* dro unused max safe int
* get rid of array_ref and object_ref
* extract STATUS_MASK
* fix test
* revert is_controlled change
* more run_all
2 years ago
bd2a586fea
chore: more transition code-golfing ( #9536 )
2 years ago
699c337908
Version Packages (next) ( #9535 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
5809ac6758
chore: rename internal object properties ( #9532 )
...
* chore: rename internal object properties
chore: rename internal object properties
order properties and add comments
add missing remove_in_transitions
* jsdoc
2 years ago
5458ea7735
Version Packages (next) ( #9530 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
b0588d7888
fix: address intro transition bugs ( #9528 )
...
* fix: address intro transition bugs
* fix: address intro transition bugs
2 years ago
298da65ed6
chore: more signal fine-tuning ( #9531 )
...
* chore: opt for two signal data-structures to reduce memory usage
2 years ago
bbd1a6c05a
chore: tune signals for better runtime perf ( #9529 )
2 years ago
a36dba7df0
Version Packages (next) ( #9519 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
f886bc133e
fix: handle intro global transition propagation correctly ( #9515 )
...
* fix: stop propagating global intros
* fix: stop propagating global intros
* add test
2 years ago
e0271f0fc7
Version Packages (next) ( #9492 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
3b2e6eac9a
fix: address unowned propagation signal issue ( #9510 )
...
* fix: address unowned propagation signal issue
* Add comments
2 years ago
378093941d
fix: ensure we visit assignments during compilation ( #9511 )
...
* fix: add missing visit for expressions
* fix: add missing visit for expressions
* Add test
2 years ago
4418ba6535
fix: add top level snippets to instance scope ( #9467 )
...
fixes #9460
2 years ago
1beb5e8dc9
fix: tweak script/style tag parsing/preprocessing logic ( #9502 )
...
Related to sveltejs/language-tools#2204 / sveltejs/language-tools#2039
The Svelte 5 version of #9486 and #9498
---------
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
c827b0c772
fix: only treat instance context exports as accessors ( #9500 )
...
* failing test for #9499
* limit export handling to instance context
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
ede1edd314
fix: emit useful error on invalid binding to derived state ( #9497 )
...
closes #9495
2 years ago
37f249350c
allow setting files ( #9463 )
2 years ago
c823dd2efa
Version Packages (next) ( #9481 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
60c273eb76
Revert "fix: address bug in before/after update" ( #9480 )
...
* Revert "fix: address bug in before/after update (#9448 )"
This reverts commit 9eb969ddd4
2 years ago
7e94dee955
Version Packages (next) ( #9431 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
c1f6ee096d
fix: handle dynamic selects with falsy select values ( #9471 )
...
when options are added later, we need to ensure the select value still stays in sync
fixes #9412
2 years ago
19f84ca730
fix: Added missing context of `svelte.js` for validation ( #9394 )
...
* fix
* add changeset
* Update .changeset/eighty-bikes-camp.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Update .changeset/eighty-bikes-camp.md
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
2 years ago
555e8f845f
enforce treeshakeability ( #9430 )
...
* enforce treeshakeability
* fix
* appease the dweeby little hall monitor
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
455fa8950e
Code golf each transitions ( #9476 )
...
* chore: improve code size of transitions
* Add changeset
2 years ago
e3e1fef238
fix: stringify attribute values before comparison ( #9475 )
...
* fix: stringify attribute values before comparison
* simplify
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
d749685b0f
fix: rework directive name handling ( #9470 )
...
* move snapshot test to a runtime test
* handle dynamic cases
* huh
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
73e8820fe7
chore: make DOM operations lazily init ( #9468 )
...
* chore: make DOM operations lazyily init
* cleanup types
* cleanup types
* cleanup types
* Update packages/svelte/src/internal/client/operations.js
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
* single line annotations
* remove unnecessary coercion
* group statements by type
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
9ef3424732
fix: support class exports ( #9465 )
2 years ago
6f3dc04c82
fix: allow member access on directives ( #9462 )
...
fixes #9445
2 years ago
9eb969ddd4
fix: address bug in before/after update ( #9448 )
...
* fix: address bug in before/after update
fix: address bug in before/after update
* Add changeset
* use every instead of filter - more explicit and enables early-exit from the loop
* Update logic and comment
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
f5101c0d8c
treat `slot` the same as other props - closes #9455 ( #9457 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
6f6c3a0787
fix: only escape attribute values for elements, not components ( #9456 )
...
* only escape attribute values for elements, not components - closes #9454
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
e90ded677e
fix: allow svelte:self in snippets ( #9439 )
...
* fix: allow svelte:self in snippets
* Create funny-wombats-argue.md
2 years ago
73ae5ef5bc
fix: tighten up event attributes and hoisting logic ( #9433 )
...
- add event delegation to spread_attributes
- add event attributes to spread
- don't delegate when bindings/actions on the same element in order to preserve backwards compatibility of ordering
- don't hoist identifiers when one of them is used in an event that is not delegateable
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2 years ago
cf63220a0e
fix: ensure keyed fallback to indexed ( #9441 )
...
Fixes #9408 . Ensures that if we have a key that matches the index, that we fallback to using an indexed each block.
2 years ago
da37c928ef
fix: support dynamic attributes containing call expressions ( #9443 )
...
Fixes #9403 . We weren't taking into account the containment of call expressions logic before.
2 years ago
66661eff04
chore: use internal `get_descriptors` helper ( #9389 )
...
* chore: use internal get_descriptors helper
* tweak changeset
* fix bad merge
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
7ab03ae36c
fix: add missing files binding ( #9415 )
...
no two-way binding because setting it involves a `DataTransfer` workaround, so it's not really officially supported that way - if you need that, you shouldn't use that binding probably. This matches the behavior in Svelte 4.
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
9aa06bdf9e
fix: check that snippet is not rendered as a component ( #9423 )
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
1fd77d7494
Version Packages (next) ( #9386 )
...
* Version Packages (next)
* Update packages/svelte/CHANGELOG.md
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
2 years ago
a990e5716a
fix tsconfig.json ( #9427 )
...
* fix tsconfig.json
* prettier
* another apparently-necessary fix
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
5768df1300
chore: remove selector api ( #9426 )
...
* chore: remove selector api
2 years ago
17e6c4f834
fix: address runtime effect issues ( #9417 )
...
* Fix runtime effect issues
* Prettier
* Add changeset
* Fix operations
* Update .changeset/khaki-mails-draw.md
* more tweaks
* more tweaks
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
8798f3b1e7
chore: split $.each into $.each_keyed/$.each_indexed ( #9422 )
...
* Split $.each into $.each_keyed/$.each_indexed
* Add changeset
* Update .changeset/quiet-camels-mate.md
* Fix typo
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
5a6afe5463
fix: correct each block update index type ( #9425 )
...
* fix: correctly handle index within each block updates
* changeset
2 years ago
1daadc357d
chore: add missing svelte/transition functions ( #9391 )
...
* chore: add missing svelte/transition functions
* lint
2 years ago
9a99554379
breaking: remove Component type, keep using SvelteComponent instead ( #9413 )
...
I came to the conclusion that when we're making up arbitrary types, we might as well keep the old class. That way:
- one less thing to worry about (language tools and other tooling basically can continue to spit out SvelteComponent )
- we can more clearly mark $set , the constructor etc as being deprecated and no longer functioning unless you use that legacy compatibility mode
- much more ergonomic to type for the user:
- const someInstance: SvelteComponent<..> instead of const someInstance: ReturnType<typeof Component<..>>
- If you're using generics, you can do export class MyComponent<T> extends SvelteComponent<{ prop: T }> {} instead of having to type out the whole function in a way that I'm not even sure how to do with generics
2 years ago
7a84e78b4d
fix: add snippet symbol to children prop ( #9395 )
...
* add snippet symbol to children prop
* fix error message for snippet validation
* changeset
2 years ago
2aacfad9ae
fix: exclude internal props from spread attributes ( #9384 )
...
* exclude internal props from spread attributes
* changeset
* tighten up
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
2 years ago
51394a4834
docs: note more breaking changes
2 years ago
28b560392b
Version Packages (next) ( #9382 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
c6c934afb2
chore: cleanup ( #9381 )
...
* lets see if this works
* fix versions
* sigh
* debugging ci is sooo fun
* oh wow
* fix stuff, changelog, add back readme
* appease prettier
* format stuff
2 years ago
fe8a9ce31d
breaking: init Svelte 5
...
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
Co-authored-by: Dominic Gannaway <dg@domgan.com>
2 years ago
1369aa5cec
Version Packages ( #9380 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
00700621bb
fix: html tag hydration: regard empty claimed_nodes array as content mismatch ( #9184 )
...
fixes #6832
2 years ago
895612514c
fix: improve a11y-click-events-have-key-events message ( #9358 )
2 years ago
28d6b34598
chore: fix failing format linting ( #9338 )
2 years ago
590503044f
Version Packages ( #9293 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
6b9b8af050
fix: ignore comments while comparing nodes in node_match ( #9197 )
...
related to issue #9088
it doesn't solve the main problem of dependencies getting invalidated whenever value of a variable gets changed.
but it fixes the behavior difference between the code with and without comments
2 years ago
ab80d9d214
fix: add missing plaintext-only value to contenteditable type ( #9242 )
...
fixes #9181
2 years ago
16c42cb085
fix: add transform-origin to SVGAttributes ( #9326 )
...
See https://svgwg.org/svg2-draft/styling.html#PresentationAttributes
2 years ago
9900c85acf
fix: support camelCase properties on custom elements ( #9328 )
...
while attributes are case insensitive, properties are not. to not introduce a breaking change, the lowercased variant is checked first.
fixes #9325
2 years ago
4efec418c2
chore: bump jsdom to address word-wrap vulnerability ( #9046 )
...
* chore: bump jsdom to address word-wrap vulnerability
* downgrade jsdom
* fix lockfile
2 years ago
052d38158f
chore: upgrade magic-string ( #9292 )
2 years ago
acb93568b0
docs: fix typo in `Action` jsdoc ( #9254 )
2 years ago
bd5e5eef9b
Version Packages ( #9121 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
26eb2a2f89
fix: false reactive component warning ( #9094 )
...
fixes #9082
2 years ago
93b17c85f7
fix: spreading attributes on option value attribute get's replaced by option's inner text ( #9125 )
...
fixes #9107
Apart from the problem with the option the same happens with the textarea.
2 years ago
228dd4d9d7
fix: svelte:element with dynamic this and spread attributes throws error ( #9112 )
...
fixes #9092
---------
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
3191147c2a
chore: document init parameters ( #9118 )
2 years ago
6fe17eabf2
fix: This makes the indeterminate HTML attribute available for use. Fixes #9176 . ( #9180 )
...
Fixes #9176 . This adds indeterminate to the list of HTMLAttributes so that one can use it without receiving an error.
2 years ago
d5a1822428
fix: style directive not updating when style attribute is present and style directive is updated via an object prop. fixes #9185 ( #9187 )
...
fixes #9185 .
I narrowed down the issue to the bug surfacing when we use object properties to update style attributes and directives. This fix removes the size check (because a single object will be of size 1 but can affect n attributes/directives via its properties).
In addition, the order of the OR is switched as the earlier condition has some reactive assignments which are not run in the current order when style_changed_var is truthy.
2 years ago
115ea1ff4a
fix: do not add module declared variables as dependencies ( #9122 )
...
closes #5943
2 years ago
b62fc8c8fd
chore: eslint rule for naming convention ( #9208 )
2 years ago
d5839ef194
fix: head duplication when binding is present ( #9124 )
...
fixes #7879
fixes #4982
2 years ago
bd64f07e98
fix: take custom attribute name into account when reflecting property ( #9140 )
...
fixes #9134
2 years ago
ba1e67844e
fix: css sourcemap generation with unicode filenames ( #9120 )
...
* fix: css sourcemap generation with unicode filenames
* format
2 years ago
50c270a54d
Version Packages ( #9096 )
...
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
05f99d20f9
feat: move svelteHTML to load the correct svelte/element ( #9070 )
...
Make IntrinsicElements extends SvelteHTMLElements
so it can be extend with declare module
converting to module so it can extend without needing another type alias
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
8b1cdde548
fix:change typescript url ( #9093 )
2 years ago
f4c4d99e13
fix: add test so #6009 doesn't regress ( #9075 )
...
closes #6009
2 years ago
6f73afb497
chore: refactor return statement in `_distance` function ( #9025 )
...
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
a08ae0f555
Version Packages ( #9037 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
99a3cc93b6
fix: allow child element with slot attribute within svelte:element ( #9038 )
...
fix #9018
2 years ago
01cbb661d0
chore: remove duplicate condition in `if` statement ( #9023 )
2 years ago
959825c7c4
chore: fix tests on Node 18.17.0 ( #9049 )
2 years ago
a71f3595a3
fix: Add data-* to svg attributes ( #9036 )
...
* Add data-* to svg attributes
* Create twelve-suits-drive.md
2 years ago
6827709373
Version Packages ( #9008 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
a2b6401c43
fix: `svelte:component` spread props change not picked up ( #9006 )
...
fix #9003 , amend #8946 (comment)
2 years ago
5d66f96d01
Version Packages ( #8928 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
f8283fbc77
fix: remove let variable from select binding dependencies ( #8969 )
...
Fixes #2943
The issue linked above invalidates a variable that is not defined in <script> but instead is defined as a let: variable, which does not make sense to invalidate, therefore, this PR exists.
2 years ago
cb1358cc41
fix: don't add accessor twice ( #8996 )
...
In dev mode, Svelte creates a setter to throw an error noting that you can't set that readonly prop, which resulted in the accessor getting applied twice to the custom element wrapper, causing an error
fixes #8971
2 years ago
657f11376c
feat: add ability to extend custom element class ( #8991 )
...
This should help everyone who has special needs and use cases around custom elements. Since Svelte components are wrapped and only run on connectedCallback, it makes sense to expose the custom element class for modification before that.
- fixes #8954 / closes #8955 - use extend to attach the function manually and save possible values to a prop
- closes #8473 / closes #4168 - use extend to set the proper static attribute and then call attachInternals in the constructor
- closes #8472 - use extend to attach anything custom you need
- closes #3091 - pass `this` to a prop of your choice and use it inside your component
- add some doc for #8987
2 years ago
4bbb5454e2
perf: optimize imports that are not mutated or reassigned ( #8948 )
...
this means such imports are seen as static and subsequently Svelte needs to generate way less code
2 years ago
33fd631b5f
chore: upgrade dependencies ( #8939 )
...
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
20dac2ae12
fix: handle patterns in destructured literals ( #8871 )
...
fixes #8863
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
66593c62f4
fix: svelte:component evaluates props once ( #8946 )
...
Fixes #6634
2 years ago
ff7a4c07d7
chore: fix broken script for generating parser tests ( #8945 )
...
---------
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
8601195a85
docs: add a couple internal JSDocs and cleanup from TS migration ( #8940 )
2 years ago
3ff0084dc3
Version Packages ( #8925 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
0a2732a2b0
fix: generate type definition with nullable types ( #8924 )
...
This results in `undefined` and `null` being added explicitly in places which is crucial in some situations
2 years ago
a12643cbb8
Version Packages ( #8911 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
136aebd8eb
fix: repair invalid raw html content during hydration ( #8912 )
...
When the HTML that is coming from raw html is invalid, the browser reshuffles things. Bail in that case to try to repair more often. Should help with https://github.com/withastro/astro/issues/7557
2 years ago
35221c8811
fix: claim svg tags in raw mustache tags correctly ( #8910 )
...
fixes #8904
2 years ago
800f6c076b
Version Packages ( #8902 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
8de9dc6144
fix: handle falsy srcset values ( #8901 )
...
fixes #8899
2 years ago
ae752c9693
Version Packages ( #8877 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
0aa03df086
fix: reflect all custom element prop updates back to attribute ( #8898 )
...
fixes #8879
2 years ago
4b3eb72346
fix: shrink custom element baseline a bit ( #8858 )
...
- use shorter class property names as they are not minified
- reuse some dom helper methods
#8826
2 years ago
2f5e371046
chore: run tsc properly ( #8884 )
...
Runs type check as part of the CI. This needs a new path alias in the tsconfig so that TS resolves the svelte import in the ambient file directly to the correct d.ts file and doesn't load Svelte through the node_modules, at which point it would load the generated ambient type definitions and throw a duplicate definitions error.
Also removes a tgz that was accidentally added
2 years ago
d2ff04f9fe
fix: use non-destructive hydration for all `@html` tags ( #8880 )
...
html tags that could be optimized to use innerHTML in mount ignored any hydration code, which leads to everything getting unmounted and mounted again. This takes the non-optimized path for hydration, too.
fixes https://github.com/sveltejs/kit/issues/10245
2 years ago
1a3e50b6b7
fix: check srcset when hydrating to prevent needless requests ( #8868 )
...
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
270cfce065
chore: adding default for disclose version ( #8874 )
2 years ago
1de2144dae
chore: tests for #8872
2 years ago
90860550ae
Version Packages ( #8855 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
b0a3fa1766
fix: ensure createEventDispatcher and ActionReturn work with generic function types ( #8872 )
...
fixes #8860
This contains a small but unfortunately unavoidable breaking change: If you used `never` to type that the second parameter of `createEventDispatcher` shouldn't be set or that the action accepts no parameters (which the docs recommended for a short time), then you need to change that to `null` and `undefined` respectively
2 years ago
1cfed0bf29
fix: relax a11y "no redundant role" rule for li, ul, ol ( #8867 )
...
fixes #8854
2 years ago
876f894c64
fix: apply transition_in/out to svelte:element with local transition ( #8865 )
...
fixes #8233
2 years ago
2b9b99bd35
fix: remove tsconfig.json from published package ( #8859 )
...
fixes #8839
2 years ago
3576c7443e
fix: Make sure 'func' doesn't clash with destructured contexts ( #8840 )
...
Fixes : #8753
2 years ago
68e6336637
chore: upgrade dependencies ( #8827 )
2 years ago
abe2ee73e1
docs: fix link to changelog ( #8845 )
2 years ago
7bab2d4033
docs: fix link in changelog
2 years ago
140bed5386
Update CHANGELOG.md ( #8809 )
...
Fix misformatted links in 4.0.0 changelog
2 years ago
0596c4797d
Version Packages ( #8799 )
...
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
60eee9a73f
chore: better error messages for CJS users ( #8790 )
2 years ago
8905877bab
fix: add any fallback to generic
...
was like this in Svelte 3
2 years ago
7cbd36d6b2
chore: Remove the need for `node:process` ( #8795 )
...
performance.now() exist in all envs we support now
2 years ago
82cc48390c
Version Packages (next) ( #8772 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
ef1b98f9d9
fix: account for sourcemap in meta info ( #8778 )
...
We need to use a different method for getting the meta info because `locate` is used to help construct the source map that references the preprocessed Svelte file. If we would now add source maps to that `locate` function it would go the the original source directly which means skipping potentially intermediate source maps which we would need in other situations. Sadly we can't map the character offset because for that we would need to the original source contents which we don't have in this context.
fixes #8360
closes #8362
2 years ago
5702142d9e
feat: attach Svelte major version info to window global ( #8761 )
...
Can be opt out by setting discloseVersion to false
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
03942162f8
chore: deindent cjs output for compiler ( #8785 )
...
makes package size a tiny bit smaller
2 years ago
f76a75b97d
chore: remove btoa fallback ( #8783 )
...
Since we're targeting NodeJS >16 we don't need any Buffer fallback as it's now built in globally from that version onwards.
2 years ago
cf32fa2497
fix(site): update tutorial links ( #8780 )
...
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 years ago
203490c3e4
breaking: use `CustomEvent` constructor instead of deprecated `createEvent` method ( #8775 )
...
closes #8474
2 years ago
78749101e7
fix: update/add links to website ( #8729 )
...
---------
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2 years ago
de8dfda049
chore: move tests to the correct place ( #8773 )
2 years ago
4d491d41cc
merge changelog for 3.59.2
2 years ago
a856128d80
merge master
2 years ago
914529fa76
feat: smaller destructor chunk ( #8763 )
...
technically a breaking change because someone with a mutation observer could rely on the order of operations
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
88504ee90a
docs(sites): Auto-generated CompileOptions ( #8756 )
...
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2 years ago
54f72f4545
fix: update onMount type to allow async to return any ( #8714 )
...
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
2 years ago
0724261b4d
chore: update code-red ( #8719 )
...
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
Co-authored-by: gtmnayan <gtmnayan@gmail.com>
2 years ago
752ee69e6b
chore: a11y tests cleanup ( #8759 )
...
closes #8728
Turns out all the removed previous test failures are indeed correct to be removed, according to the test adjustments in https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/pull/937
2 years ago
520a5784fb
Version Packages (next) ( #8733 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
cc82d5ddcb
fix: expose types for all TS resolution modes, fix SvelteComponent export ( #8721 )
...
also add some legacy import paths which should be changed in usage sites ASAP
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
2 years ago
aa8cc5d26f
fix: never use html optimization for mustache tags in hydration mode ( #8744 )
...
---------
Co-authored-by: gtmnayan <gtmnayan@gmail.com>
2 years ago
bdf10f125c
merge
2 years ago
e8e9c6cc19
chore: update `locate-character` and `dts-buddy` ( #8737 )
2 years ago
62bef809b2
Merge remote-tracking branch 'origin/version-4' into sites
2 years ago
4f1063723e
fix: Don't break in `attributeChangedCallback` if `$$component` does not exist yet ( #8701 )
...
Since the custom element class waits one tick before instantiating the `$$component` field, it's possibly undefined when `attributeChangedCallback` is called.
2 years ago
f580e2e0c8
fix: warn on boolean compilerOptions.css ( #8710 )
...
* warn on boolean compilerOptions.css
* changeset
2 years ago
20d95ddb23
merge
2 years ago
b1cafc4573
update type generation script ( #8712 )
...
* chore: playground (#8648 )
* initialize playground
* pnpm up
* tidy up git ignore
* remove fluff
* format
* rm readme
* fix jsconfig error
* add skip-worktree instructions
* reload hack
* simplify
* use rollup
* ughh
* add flag for SSR
* ...
* simplify further
* configure launch.json
* add debugger info to readme
* remove vm modules flag
* use replaceAll instead of replace
* tidy up
* fix: make it run
* add watch to launch config
* Generate type declarations with `dts-buddy` (#8702 )
* use dts-buddy
* remove debug output
* remove existing type generation script
* fix package.json
* update gitignore
* bump dts-buddy
* remove unused action entry point
* add svelte/compiler and svelte/types/compiler/preprocess modules
* bump dts-buddy
* annoying
* changeset
* bump dts-buddy
* get rid of .d.ts files
* another one
* Update packages/svelte/package.json
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
---------
Co-authored-by: Rich Harris <git@rich-harris.dev>
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
* fix: export ComponentType (#8694 )
* fix: export ComponentType
* ughh
* changeset
* fix: derived types (#8700 )
* fix: derived store types
* changeset
* Version Packages (next) (#8709 )
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update type generation script
* remove unused stuff
* fix: changeset publish script isn't called release anymore (#8711 )
* chore: remove prepare script (#8713 )
* chore: fix release workflow (#8716 )
* More readable, Fix $$_attributes
* Fix types (#8727 )
* put comment in right place
* bump dts-buddy
---------
Co-authored-by: Rich Harris <git@rich-harris.dev>
* build types
* add svelte/compiler types
* remove prepare script
* fix
* typo
* squelch errors
* Add svelte and kit to twoslash's types field
* squelch more stuff
* Add errors to account for new types
* Remove deps
* formatting tweak
* fix linting, maybe
* the hell
* gah
* Fix types a bit
* bump dts-buddy
* pnpm generate in dev mode
* Cache again
* reduce index
* bump dts-buddy
* remove comment
---------
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: Rich Harris <git@rich-harris.dev>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dominik G <dominik.goepel@gmx.de>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Puru Vijay <devpuruvj@gmail.com>
2 years ago
83e91782e6
chore: upgrade aria-query and axobject-query ( #8724 )
...
Co-authored-by: gtmnayan <gtmnayan@gmail.com>
2 years ago
cc1f4bc6ff
chore: upgrade eslint config ( #8717 )
2 years ago
d6f0b7bd5b
Fix types ( #8727 )
...
* put comment in right place
* bump dts-buddy
---------
Co-authored-by: Rich Harris <git@rich-harris.dev>
2 years ago
ad9a672171
Merge version-4
2 years ago
8bd90219ec
chore: fix release workflow ( #8716 )
2 years ago
0c6f17274e
chore: remove prepare script ( #8713 )
2 years ago
5963b6fd84
Version Packages (next) ( #8709 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 years ago
264da48887
fix: derived types ( #8700 )
...
* fix: derived store types
* changeset
2 years ago
0b15bb6928
fix: export ComponentType ( #8694 )
...
* fix: export ComponentType
* ughh
* changeset
2 years ago
1046daba6a
Generate type declarations with `dts-buddy` ( #8702 )
...
* use dts-buddy
* remove debug output
* remove existing type generation script
* fix package.json
* update gitignore
* bump dts-buddy
* remove unused action entry point
* add svelte/compiler and svelte/types/compiler/preprocess modules
* bump dts-buddy
* annoying
* changeset
* bump dts-buddy
* get rid of .d.ts files
* another one
* Update packages/svelte/package.json
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
---------
Co-authored-by: Rich Harris <git@rich-harris.dev>
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
2 years ago
276d2f86ba
merge version-4 branch
2 years ago
f2ff684b5f
chore: setup changesets ( #8668 )
...
Co-authored-by: dominikg <dominik.goepel@gmx.de>
2 years ago
f74dddd1d5
docs: correct link in changelog
2 years ago
2efd78cba4
Merge remote-tracking branch 'origin/version-4' into sites
2 years ago
fe06a39229
fix: store types and some other internal types that got lost in the conversion ( #8658 )
2 years ago
b0619377b1
docs: update changelog with minimum `rollup-plugin-svelte` and `svelte-loader` versions ( #8666 )
2 years ago
b41c4407c2
docs: update changelog to follow changesets format ( #8642 )
2 years ago
0e19350e62
docs: update changelog with required version of vite-plugin-svelte ( #8654 )
2 years ago
eb18769e59
Merge remote-tracking branch 'origin/version-4' into sites
2 years ago
79f9d8f41f
chore: remove type * for better backwards compatibility
...
doesnt need ts 5.0 then, at least for now
2 years ago
d8139430ff
Merge remote-tracking branch 'origin/version-4' into sites
2 years ago
bd51e6f3ea
Merge remote-tracking branch 'origin/version-4' into sites
2 years ago
ddfff4df8c
chore: convert to monorepo ( #8644 )
2 years ago
Rich Harris
Yuichiro Yamashita
Simon H
github-actions[bot]
Dominic Gannaway
Simon Holthausen
Theodore Brown
gtmnayan
Tee Ming
Paolo Ricciuti
Wilson Hobbs
Kelvin Soh
Ben McCann
Sina Salahshour
vhladko
Mathias Schäfer
Diego Augusto Molina
Teo
paulreece
Yeom suyun
Lyu, Wei-Da
Nguyen Tran
Михаил Туник
hackape
Conduitry
L
Eric Liu
Isaiah Banks
Jimmy Wärting
Puru Vijay
GrygrFlzr
Puru Vijay
mimbrown