11648 Commits (custom-condition)

 

All Branches   

Search

Author	SHA1	Message	Date
paoloricciuti	e2aac6a6c2	Merge branch 'add-custom-renderer-flag' into custom-condition	5 hours ago
paoloricciuti	b10f1de17f	Merge branch 'fix-interleaving' into add-custom-renderer-flag	5 hours ago
paoloricciuti	23856236f9	Merge branch 'svelte-custom-renderer' into fix-interleaving	5 hours ago
paoloricciuti	0af2ad75b1	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	5 hours ago
Minh Vu	020242d6be	fix: ensure hydration state restoration for custom element attribute updates (#18467) ... ### Problem While hydrating custom elements, set_attributes temporarily disables global hydration state via set_hydrating(false) and restores it only at the end. If a prop setter or attribute operation throws partway through, hydration mode can remain disabled globally. ### Fix Wrap the temporary hydration-state override in a try/finally block in set_attributes so set_hydrating(true) always runs when is_hydrating_custom_element is true. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 days ago
Nic Polumeyv	28b99aa8e6	fix: error at compile time when a declaration in a snippet redeclares one of its parameters (#18842) ... `{const item = 1}` inside `{#snippet row(item)}` compiles, and the output declares `item` twice in one function, so it does not parse: ```js const row = ($$anchor, item = $.noop) => { const item = 1; ``` `{let}`, `{@const}` and a nested snippet with the parameter's name do the same. In `phases/scope.js`, `EachBlock` visits its body's children in the item's own scope, so a tag that reuses the item name is a `declaration_duplicate`. `SnippetBlock` calls `context.next({ scope: child_scope })`, the `Fragment` visitor opens another scope for the body, and the tag never meets the parameter. After visiting the body, `SnippetBlock` now reports any name in the body's scope that `child_scope` also declares. A declaration in a nested block or element still shadows the parameter. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 days ago
Nic Polumeyv	5b44f26bc2	fix: keep a reactive assignment with no dependencies when `migrate` cannot turn it into a declaration (#18817) ... `migrate()` dropped a reactive assignment that has no dependencies and put nothing in its place: ```svelte $: count = 7; → (gone, `{count}` now undeclared) $: obj.x = 1; → (gone) ``` A binding the statement declares now always gets its `let`, and the statement is only removed once every target has one; otherwise it becomes `run()`: ```svelte let count = $state(7); run(() => { obj.x = 1; }); ```	2 days ago
Nic Polumeyv	8ef693e94e	fix: don't hang `migrate` on a declaration that shares a line with its script tag (#18816) ... `migrate()` never returned when a declaration shared a line with its `<script>` tag: ```svelte <script>export let answer</script> ``` The scan that removes a migrated `export let` line looked for a newline in both directions with no bound. It now stops at the script's edges.	2 days ago
Rich Harris	688a4e49b8	fix: preserve location information for `await` wrappers (#18859) ... Helps with code coverage tools: https://github.com/sveltejs/esrap/pull/124	2 days ago
svelte-triage-bot[bot]	7fe14a508a	fix: ignore stale boundary resets after destruction (#18886) ... - `destroy_effect` cleared a boundary's component context while retained reset callbacks and queued error work could still re-enter its run path. - Reset handling is intentionally shared with hydration by [#18556](https://github.com/sveltejs/svelte/pull/18556), while `onerror` is deferred for safe state mutation by [#17561](https://github.com/sveltejs/svelte/pull/17561); neither path checked the boundary lifetime. - Make retained and deferred boundary continuations inert during destruction instead of masking null contexts in `bind:this` or `#run`, which would still let dead effects and callbacks restart. - Cover resets from `onerror` and failed snippets, cleanup ordering, delayed error transforms, DOM rendering, and hydration. Fixes https://github.com/sveltejs/svelte/issues/18885	2 days ago
svelte-triage-bot[bot]	7fb397e78f	fix: handle deferred transitions aborted before initialization (#18776) ... - make deferred transition facade methods safe before the inner animation initializes - report the transition's initial position from the facade until initialization - add a runtime regression test for an out-only `crossfade` branch restored in the same update Fixes https://github.com/sveltejs/svelte/issues/18773 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 days ago
svelte-triage-bot[bot]	f908535659	fix: prevent untracked derived reads from retaining dependencies (#18829) ... Fixes https://github.com/sveltejs/svelte/issues/18827. A disconnected derived re-evaluated through `untrack` inside an effect could connect descendant deriveds because `is_updating_effect` was true, even though the active derived reader was not connected. Those descendants registered on long-lived dependencies without gaining a reaction that could later trigger their disconnect cascade. This changes `get()` to connect a derived only when its active reader is itself `CONNECTED`. Effects already carry that flag, and deriveds reached through connected readers receive it before evaluation, so tracked behavior remains intact. The now-unused `is_updating_effect` state is removed.	5 days ago
waltu	a956c2bd1f	fix: error when using `let:` directives on a component with a `children` snippet (#18873) ... Closes #13864 A `let:` directive on a component only applies to the default slot content. If the content is an explicit `{#snippet children()}` block, the value is never provided, so code like this compiles but fails at runtime with "value is not defined": ```svelte <Child let:value> {#snippet children()}Value is: {value}{/snippet} </Child> ``` This adds a compile error on the directive that points to snippet parameters instead (`{#snippet children({ value })}`, or `{ item: x }` for `let:item={x}`). Components with a `slot` attribute are not affected, since there the directive applies to the component itself. An unused `let:` next to a `children` snippet is also flagged now, but it never had any effect. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` Co-authored-by: waltu <182410443+waltuov@users.noreply.github.com>	6 days ago
G	75aa6ba38d	fix: don't warn about redundant `link` role on `<area>` without `href` (#18872) ... Since #11737, `<a role="link">` without an `href` no longer triggers `a11y_no_redundant_roles`, but `<area role="link">` without an `href` still does. Per [ARIA in HTML](https://www.w3.org/TR/html-aria/#el-area-no-href), an `<area>` without `href` has the implicit role `generic` and `link` is one of its allowed roles, so the role isn't redundant. This applies the existing `<a>` exception to `<area>` and adds test cases for `<area>` with and without `href`. Closes #9261. The `<a>` example in that issue was already fixed by #11737, but the issue was left open. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	6 days ago
Dex	f7ca0a44a5	chore: fix typos in code comments (#18860) ... Fixes four typos in code comments (no behavioral change): - `packages/svelte/src/index-client.js`: `noone` -> `no one` - `packages/svelte/src/internal/client/dom/css.js`: `Therfore` -> `Therefore` - `packages/svelte/src/internal/client/runtime.js`: `loosing` -> `losing` - `packages/svelte/src/internal/server/index.js`: `aswell` -> `as well` Checklist: title prefixed with `chore:`; comment-only change so no changeset and no behavior affected. Co-authored-by: Dextheking1 <Dextheking1@users.noreply.github.com>	6 days ago
Simon H	98e547535d	fix: flush anything pending before invoking flushSync callback function (#18878) ... no new test here but it's necessary for #18861 to work, and we might as well extract it	6 days ago
Simon H	da2f83343b	fix: read batch-local array on each-block commit (#18879) ... Another extraction from #18861 which I'm pretty sure you can also construct a buggy reproduction for today, but with #18861 it's strictly necessary so we don't need to come up with one now	6 days ago
Rich Harris	58297c5a73	chore: extract some minor changes from #18861 (#18866) ... doing my usual thing of extracting no-brainer changes from a giant PR to try and make it slightly less giant	7 days ago
paoloricciuti	60e2eadccc	chore: force `custom-renderer` custom condition	1 week ago
paoloricciuti	69b3589d93	fix: update snapshots	1 week ago
paoloricciuti	43bae11638	chore: add `custom_renderer` flag	1 week ago
paoloricciuti	032c6830ac	fix: more try finally	1 week ago
paoloricciuti	0d4752b37b	fix: test typecheck	1 week ago
paoloricciuti	edb2308c32	fix: include `segments` in upstream changes to hrm and svelte head	1 week ago
paoloricciuti	068ea005c9	fix: wrong types during rebase	1 week ago
paoloricciuti	edddec712c	fix: imports	1 week ago
paoloricciuti	1eff5b575a	chore: pass renderer in test mount	1 week ago
paoloricciuti	09809a471f	fix: pass parent renderer in `mount`	1 week ago
paoloricciuti	325af84b6e	fix: types in renderers tests	1 week ago
paoloricciuti	5b4786205d	fix: hydrate types	1 week ago
paoloricciuti	dabc1bef41	fix: prettier	1 week ago
paoloricciuti	f1ed6b5965	chore: add tests	1 week ago
paoloricciuti	8f2fd603b7	chore: regenerate types	1 week ago
paoloricciuti	aa400fad47	chore: add ability to hydrate dom custom renderers samples	1 week ago
paoloricciuti	97d797d639	fix: update test renderer to output actual dom nodes when interleaving	1 week ago
paoloricciuti	aea8b701cc	feat: accept `foreign` object in custom renderer to determine how to interleave custom renderers	1 week ago
paoloricciuti	bde2016706	fix: store `segments` and use them to remove nodes when interleaving is happening	1 week ago
paoloricciuti	2a6fe73855	chore: create error for missing foreign	1 week ago
paoloricciuti	70397bd111	fix: push renderer before executing a snippet	1 week ago
paoloricciuti	909b30d5d5	fix: wrap implicit children snippets in `renderer_snippet`	1 week ago
paoloricciuti	4e64a83d05	fix: set null renderer for snippets created by DOM components	1 week ago
paoloricciuti	b6ecbc2e05	fix: make sure pop renderer is always before `return`	1 week ago
paoloricciuti	8c0070905a	fix: always validate snippets if custom renderer is enabled	1 week ago
paoloricciuti	f734e0df90	fix: store and restore parent renderer in effect	1 week ago
paoloricciuti	bb6a1821d0	fix: skip single node optimization in custom renderer	1 week ago
paoloricciuti	1a32183157	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	1 week ago
Mariana Castro	38098a9311	fix: don't overwrite an unchanged spread `value` (#18864) ... Fixes #18862 When a `value` is applied through a spread (`<input {...props} />`), `set_attributes` always writes `element.value`, even if the element already has that value. Writing `value` on a number input clears any incomplete text: typing `250.` makes `input.value` `''` (the text is still visible, but `validity.badInput` is `true`). If the spread `value` then becomes `''` too, writing `''` erases what the user typed. This is what happens with SvelteKit remote forms: `fields.quantity.as('number')` coerces `''` to `undefined`, the spread `value` becomes `''`, and Svelte writes it back to the input. When `.` is typed: - Chromium clears the input in every locale, because `250.` is always incomplete input there. - WebKit/Safari clears it in locales where `.` is not the decimal separator (e.g. `fr-CH`), which is where the reporter saw it. A plain `<input type="number">` never clears. Neither does the same `value` in Svelte without a spread (`value={...}`), because `set_value` already skips writing when `element.value === value`. This PR adds the same check to the spread path. Svelte 3 had this check too (#3426, #3495); it was lost in Svelte 5. The first write still always happens. Writing `value` sets the input's dirty value flag, and without that flag a `defaultValue` applied afterwards would change the current value (covered by `form-default-value-spread`). This also likely affects sveltejs/kit#16270 (same symptom, plus a cursor jump caused by redundant writes). That issue is handled on the kit side in sveltejs/kit#16320; this PR is independent of it. The test runs in a real browser (`runtime-browser`). It types with `document.execCommand('insertText')`, which goes through Chromium's own editing, so `250.` is real incomplete input. The locale is not mocked. The test fails without this change and passes with it. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>	1 week ago
Tee Ming	325620ba63	fix: bypass error boundaries for hydration recovery (#18841) ... Fixes #18840 This PR rethrows the hydration error rather than catching it at the boundaries so that the svelte hydration warning can surface ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>	1 week ago
Kunpeng Xie	803f59b171	fix: avoid reinserting dynamic elements during hydration (#18855) ... Hydrating a `<svelte:element>` currently removes and reinserts the DOM node that was already claimed from the server-rendered HTML. This can restart CSS animations and disconnect/reconnect custom elements inside it. Keep claimed elements in place while preserving insertion for client-created elements and later tag changes. Capture the hydration state before rendering children, since empty or void elements can temporarily turn hydration off. Fixes #18852. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` Validation: - The real Chromium regression fails on unchanged `636eaaaa`: hydration removes all four server-rendered dynamic elements. Client mounting and server rendering pass. - The regression checks node removals and custom-element connection callbacks for ordinary, empty, void, and custom dynamic elements, then changes the tags and removes/recreates an element. - A hydration mismatch regression verifies that different client/server child branches recover while retaining the outer element and its following sibling. - `pnpm test hydration runtime-browser`: 219 passed. - Full `CI=true pnpm test`: 34 test files passed, 7,790 tests passed, 55 existing skips. The real-browser suite ran with Chromium. - `pnpm check`: passed, including build, generated type checks, and treeshakeability checks. - `pnpm lint`: passed. AI assistance: This change and its tests were prepared with OpenAI Codex. The PR description is also AI-assisted. --------- Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>	1 week ago
github-actions[bot]	636eaaaa6f	Version Packages (#18750) ... This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.57.1 ### Patch Changes - fix: cancel deferred event listeners during cleanup ([#18749](https://github.com/sveltejs/svelte/pull/18749)) - fix: preserve global CSS in components without scopable elements ([#18793](https://github.com/sveltejs/svelte/pull/18793)) - fix: reduce SSR render result garbage collection ([#18798](https://github.com/sveltejs/svelte/pull/18798)) - fix: resolve the fallback of an each block in the enclosing scope ([#18803](https://github.com/sveltejs/svelte/pull/18803)) - perf: speed up parser interactions with Acorn or avoid them where possible ([#18740](https://github.com/sveltejs/svelte/pull/18740)) - fix: prevent effect tree of batches from interfering with each other ([#18508](https://github.com/sveltejs/svelte/pull/18508)) - fix: serialize input default values during server rendering ([#18733](https://github.com/sveltejs/svelte/pull/18733)) - fix: remove `WAS_MARKED` flag in favor of `Set` ([#18127](https://github.com/sveltejs/svelte/pull/18127)) - fix: throw `set_context_after_init` when `setContext` is called after an `await` during SSR ([#18739](https://github.com/sveltejs/svelte/pull/18739)) - fix: make Object.hasOwn reactive for state proxy ownership changes ([#18838](https://github.com/sveltejs/svelte/pull/18838)) - fix: keep `$state.eager` when used as a variable initializer ([#18809](https://github.com/sveltejs/svelte/pull/18809)) - perf: avoid regex matching in parser where possible ([#18736](https://github.com/sveltejs/svelte/pull/18736)) - fix: in non-async mode, only push variable to current_sources when active_reaction is updating ([#18550](https://github.com/sveltejs/svelte/pull/18550)) - fix: recognise `aria-braillelabel` and `aria-brailleroledescription` as known ARIA attributes ([#18765](https://github.com/sveltejs/svelte/pull/18765)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago