11467 Commits (custom-condition)

 

All Branches   

Search

Author	SHA1	Message	Date
Ivan	5edd8b0602	fix: chain preprocessor sourcemaps with an empty sources[0] (#18518) ... ## Summary Fixes #18491 — the compiler discards an upstream plugin's sourcemap when it's generated without a `source` option (e.g. `new MagicString(code).generateMap()`), producing wrong devtools/stack-trace positions. ### Root cause `compile()` already supports composing an incoming sourcemap into its output via `options.sourcemap` (`merge_with_preprocessor_map` → `apply_preprocessor_sourcemap` → `combine_sourcemaps` in `packages/svelte/src/compiler/utils/mapped_code.js`). This is the same mechanism `preprocess()` uses internally, and it's the documented contract for tools that transform a `.svelte` file before compiling it (see `CompileOptions.sourcemap`'s doc comment). `combine_sourcemaps` composes maps by matching `sourcefile === filename` (the basename of the file being compiled). A sourcemap produced by `new MagicString(code).generateMap()` **without** a `source` option — which is exactly what the reporter's Vite plugin does — has `sources: ['']`. That empty string never equals `filename`, so `remapping()` treats the node as a leaf (the "original" file) instead of a branch to keep chaining through, and the whole incoming map is silently dropped. The result: every position that flows through that segment resolves to `{ source: null, line: null, column: null }`, which is what produces the wrong/missing devtools mapping described in the issue. Vite itself already has to handle this exact ambiguity: in `pluginContainer.ts`'s `_getCombinedSourcemap`, an empty `sources[0]` from a MagicString-based transform is patched to refer to the file being transformed before Vite uses it internally. This PR applies the same normalization on svelte's side, so the contract holds regardless of whether the caller happens to pass a `source` option to `generateMap()`. ### Fix In `apply_preprocessor_sourcemap`, normalize an incoming map's `sources: ['']` (or `[null]`/`[undefined]`) to `[filename]` before calling `combine_sourcemaps`, so the chain-matching step can actually find it.	1 month ago
Paolo Ricciuti	41642b70ee	fix: avoid declaration tag warning in event handlers (#18500) ... Closes #18493 Co-authored-by: justjavac <justjavac@gmail.com>	1 month ago
paoloricciuti	0c226fcf4e	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	1 month ago
Paolo Ricciuti	8fb7ceeba5	fix: don't treat declaration tags as parts inside each blocks (#18507) ... Closes #18506 Declaration tags in the scope of an each block were considered "parts" and transformed to use their value instead of the signal itself. We can safely check on the `kind` of the binding since a `kind` of `state`, `state_raw` or `derived` in the each scope needs to be a declaration tag (and it's a stable reference so we can use them directly)	1 month ago
Paolo Ricciuti	33304b4b15	Merge branch 'main' into svelte-custom-renderer	1 month ago
Paolo Ricciuti	b1cadd1eae	chore: drop dead code that make TSGO fail (#18496)	1 month ago
Paolo Ricciuti	b9e03714eb	fix: correctly transform declaration tags during SSR (#18492) ... Closes #18490	1 month ago
paoloricciuti	39887f5ace	fix: update snapshot	2 months ago
Paolo Ricciuti	7c5b06657c	Merge branch 'main' into svelte-custom-renderer	2 months ago
github-actions[bot]	eae50dfd1c	Version Packages (#18435) ... This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.4 ### Patch Changes - fix: include wrapping parentheses in `{@const}` declarator `end` position ([#18436](https://github.com/sveltejs/svelte/pull/18436)) - fix: always unset reactivity context after restoring it ([#18453](https://github.com/sveltejs/svelte/pull/18453)) - fix: don't notify `searchParams` subscribers when the URL changes without affecting the search string ([#18425](https://github.com/sveltejs/svelte/pull/18425)) - fix: strip `?` from optional parameters in `<script lang="ts">` so generated JavaScript is valid ([#18448](https://github.com/sveltejs/svelte/pull/18448)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
Simon H	36ae0622a8	fix: always unset reactivity context after restoring it (#18453) ... When calling `save`, we restore the context after the promise resolves. But we do not unset it after the subsequent synchronous execution. That means that until `unset_context` runs in `async_derived` we will not have the correct (nulled) context. That causes problems if the `save` isn't the last promise contributing to the `async_derived`, because it means the context is not properly unset until the promise _after_ the `save` within the `async_derived` settles. This can cause all sorts of mixups, including a wrong mutation error. fixes #18441	2 months ago
jyc.dev	a6985bcd24	fix: strip `?` from optional parameters in svelte lang ts (#18448) ... In `esrap@2.2.12` we fixed the missing `?` in ts files https://github.com/sveltejs/esrap/pull/139 It's good for `ts`, but bad for svelte compiler that was not removing it as it was a esrap issue not printing it :/ This issue came: https://github.com/sveltejs/esrap/issues/141 This PR is fixing the issue in the compiler stripping the `?`	2 months ago
paoloricciuti	d39049edc5	fix: lint	2 months ago
Paolo Ricciuti	4873b8028f	Merge branch 'main' into svelte-custom-renderer	2 months ago
Yuichiro Yamashita	c4daa490bb	fix: include wrapping parentheses in `{@const}` declarator end (#18436) ... `{@const x = (a)}` (and any `{@const}` whose initializer is wrapped in parentheses, e.g. `(a = b)`, `({ ... })`) produced a `VariableDeclarator` whose `end` fell before the closing `)`. `read_expression` strips the wrapping parens from the returned node but advances the parser past them, so `init.end` excludes the `)` while the parser position does not. Use the parser position for the declarator `end` instead. Fixes source slices / tooling that rely on the node range (the range previously yielded invalid, unbalanced source). <img width="2064" height="1746" alt="image" src="https://github.com/user-attachments/assets/64153ee5-d543-442d-8018-d3668acfd7a7" /> ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint`	2 months ago
Nic Polumeyv	0510174bc0	fix: make `SvelteURLSearchParams` notifications accurate (#18425) ... `SvelteURLSearchParams` has two notification bugs that surface through `SvelteURL`. The first is over-notification. Setting `url.href` always rebuilds the params and bumps their version signal, even when the search string didn't change at all. Effects that read `size` (or any params method) re-run on every unrelated `href` write, which is #17218, where it caused infinite effect loops in a router. The fix is a guard in the internal replace path that bails out when the incoming params serialize identically to the current ones. The second is under-notification, and it's sneakier. Every read method tracks the version signal, `get`, `getAll`, `has`, `keys`, `values`, `entries`, `toString`, `size`, the iterator... except `forEach`, which was never overridden. The inherited platform method reads the internal list directly and subscribes to nothing, so a template that renders params via `forEach` never updates: ```js $effect(() => { url.searchParams.forEach((value, key) => entries.push(`${key}=${value}`)); // never re-runs }); ``` We found this one in the wild while making `page.url` a `SvelteURL` in sveltejs/kit#16031. Kit's own test suite renders query params with `forEach`, and the coarse object-identity signal that previously masked the gap went away, leaving stale UI after client-side navigations. The fix is the same one-line tracking pattern every other read method already uses. Fixes #17218 --- - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	2 months ago
dependabot[bot]	8ea3ee8c62	chore(deps-dev): bump esbuild from 0.25.11 to 0.28.1 (#18427) ... Bumps [esbuild](https://github.com/evanw/esbuild) from 0.25.11 to 0.28.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/evanw/esbuild/releases">esbuild's releases</a>.</em></p> <blockquote> <h2>v0.28.1</h2> <ul> <li> <p>Disallow <code>\</code> in local development server HTTP requests (<a href="https://github.com/evanw/esbuild/security/advisories/GHSA-g7r4-m6w7-qqqr">GHSA-g7r4-m6w7-qqqr</a>)</p> <p>This release fixes a security issue where HTTP requests to esbuild's local development server could traverse outside of the serve directory on Windows using a <code>\</code> backslash character. It happened due to the use of Go's <code>path.Clean()</code> function, which only handles Unix-style <code>/</code> characters. HTTP requests with paths containing <code>\</code> are no longer allowed.</p> <p>Thanks to <a href="https://github.com/dellalibera"><code>@​dellalibera</code></a> for reporting this issue.</p> </li> <li> <p>Add integrity checks to the Deno API (<a href="https://github.com/evanw/esbuild/security/advisories/GHSA-gv7w-rqvm-qjhr">GHSA-gv7w-rqvm-qjhr</a>)</p> <p>The previous release of esbuild added integrity checks to esbuild's npm install script. This release also adds integrity checks to esbuild's Deno install script. Now esbuild's Deno API will also fail with an error if the downloaded esbuild binary contains something other than the expected content.</p> <p>Note that esbuild's Deno API installs from <code>registry.npmjs.org</code> by default, but allows the <code>NPM_CONFIG_REGISTRY</code> environment variable to override this with a custom package registry. This change means that the esbuild executable served by <code>NPM_CONFIG_REGISTRY</code> must now match the expected content.</p> <p>Thanks to <a href="https://github.com/sondt99"><code>@​sondt99</code></a> for reporting this issue.</p> </li> <li> <p>Avoid inlining <code>using</code> and <code>await using</code> declarations (<a href="https://redirect.github.com/evanw/esbuild/issues/4482">#4482</a>)</p> <p>Previously esbuild's minifier sometimes incorrectly inlined <code>using</code> and <code>await using</code> declarations into subsequent uses of that declaration, which then fails to dispose of the resource correctly. This bug happened because inlining was done for <code>let</code> and <code>const</code> declarations by avoiding doing it for <code>var</code> declarations, which no longer worked when more declaration types were added. Here's an example:</p> <pre lang="js"><code>// Original code { using x = new Resource() x.activate() } <p>// Old output (with --minify)<br /> new Resource().activate();</p> <p>// New output (with --minify)<br /> {using e=new Resource;e.activate()}<br /> </code></pre></p> </li> <li> <p>Fix module evaluation when an error is thrown (<a href="https://redirect.github.com/evanw/esbuild/issues/4461">#4461</a>, <a href="https://redirect.github.com/evanw/esbuild/pull/4467">#4467</a>)</p> <p>If an error is thrown during module evaluation, esbuild previously didn't preserve the state of the module for subsequent module references. This was observable if <code>import()</code> or <code>require()</code> is used to import a module multiple times. The thrown error is supposed to be thrown by every call to <code>import()</code> or <code>require()</code>, not just the first. With this release, esbuild will now throw the same error every time you call <code>import()</code> or <code>require()</code> on a module that throws during its evaluation.</p> </li> <li> <p>Fix some edge cases around the <code>new</code> operator (<a href="https://redirect.github.com/evanw/esbuild/issues/4477">#4477</a>)</p> <p>Previously esbuild incorrectly printed certain edge cases involving complex expressions inside the target of a <code>new</code> expression (specifically an optional chain and/or a tagged template literal). The generated code for the <code>new</code> target was not correctly wrapped with parentheses, and either contained a syntax error or had different semantics. These edge cases have been fixed so that they now correctly wrap the <code>new</code> target in parentheses. Here is an example of some affected code:</p> <pre lang="js"><code>// Original code new (foo()`bar`)() new (foo()?.bar)() <p>// Old output<br /> new foo()<code>bar</code>();<br /> new (foo())?.bar();</p> <p></code></pre></p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/evanw/esbuild/blob/main/CHANGELOG-2025.md">esbuild's changelog</a>.</em></p> <blockquote> <h1>Changelog: 2025</h1> <p>This changelog documents all esbuild versions published in the year 2025 (versions 0.25.0 through 0.27.2).</p> <h2>0.27.2</h2> <ul> <li> <p>Allow import path specifiers starting with <code>#/</code> (<a href="https://redirect.github.com/evanw/esbuild/pull/4361">#4361</a>)</p> <p>Previously the specification for <code>package.json</code> disallowed import path specifiers starting with <code>#/</code>, but this restriction <a href="https://redirect.github.com/nodejs/node/pull/60864">has recently been relaxed</a> and support for it is being added across the JavaScript ecosystem. One use case is using it for a wildcard pattern such as mapping <code>#/*</code> to <code>./src/*</code> (previously you had to use another character such as <code>#_*</code> instead, which was more confusing). There is some more context in <a href="https://redirect.github.com/nodejs/node/issues/49182">nodejs/node#49182</a>.</p> <p>This change was contributed by <a href="https://github.com/hybrist"><code>@​hybrist</code></a>.</p> </li> <li> <p>Automatically add the <code>-webkit-mask</code> prefix (<a href="https://redirect.github.com/evanw/esbuild/issues/4357">#4357</a>, <a href="https://redirect.github.com/evanw/esbuild/issues/4358">#4358</a>)</p> <p>This release automatically adds the <code>-webkit-</code> vendor prefix for the <a href="https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/mask"><code>mask</code></a> CSS shorthand property:</p> <pre lang="css"><code>/* Original code */ main { mask: url(x.png) center/5rem no-repeat } <p>/* Old output (with --target=chrome110) */<br /> main {<br /> mask: url(x.png) center/5rem no-repeat;<br /> }</p> <p>/* New output (with --target=chrome110) */<br /> main {<br /> -webkit-mask: url(x.png) center/5rem no-repeat;<br /> mask: url(x.png) center/5rem no-repeat;<br /> }<br /> </code></pre></p> <p>This change was contributed by <a href="https://github.com/BPJEnnova"><code>@​BPJEnnova</code></a>.</p> </li> <li> <p>Additional minification of <code>switch</code> statements (<a href="https://redirect.github.com/evanw/esbuild/issues/4176">#4176</a>, <a href="https://redirect.github.com/evanw/esbuild/issues/4359">#4359</a>)</p> <p>This release contains additional minification patterns for reducing <code>switch</code> statements. Here is an example:</p> <pre lang="js"><code>// Original code switch (x) { case 0: foo() break case 1: default: bar() } </code></pre> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="bb9db84c02"><code>bb9db84</code></a> publish 0.28.1 to npm</li> <li><a href="9ff053e53b"><code>9ff053e</code></a> security: add integrity checks to the Deno API</li> <li><a href="0a9bf2135b"><code>0a9bf21</code></a> enforce non-negative size in gzip parser</li> <li><a href="e2a1a71320"><code>e2a1a71</code></a> security: forbid <code>\\</code> in local dev server requests</li> <li><a href="83a2cbfc35"><code>83a2cbf</code></a> fix <a href="https://redirect.github.com/evanw/esbuild/issues/4482">#4482</a>: don't inline <code>using</code> declarations</li> <li><a href="308ad745d8"><code>308ad74</code></a> fix <a href="https://redirect.github.com/evanw/esbuild/issues/4471">#4471</a>: renaming of nested <code>var</code> declarations</li> <li><a href="f013f5f99a"><code>f013f5f</code></a> fix some typos</li> <li><a href="aafd6e48b1"><code>aafd6e4</code></a> chore: fix some minor issues in comments (<a href="https://redirect.github.com/evanw/esbuild/issues/4462">#4462</a>)</li> <li><a href="15300c30b5"><code>15300c3</code></a> follow up: cjs evaluation fixes</li> <li><a href="1bda0c31d7"><code>1bda0c3</code></a> fix <a href="https://redirect.github.com/evanw/esbuild/issues/4461">#4461</a>, fix <a href="https://redirect.github.com/evanw/esbuild/issues/4467">#4467</a>: esm evaluation fixes</li> <li>Additional commits viewable in <a href="https://github.com/evanw/esbuild/compare/v0.25.11...v0.28.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~GitHub%20Actions">GitHub Actions</a>, a new releaser for esbuild since your current version.</p> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/sveltejs/svelte/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 months ago
Paolo Ricciuti	4116e9f25e	Merge branch 'main' into svelte-custom-renderer	2 months ago
Rich Harris	2084125c0f	Unified `mount` API for components with custom renderers (#18317) ... Targets #18042. Am opening this so I can start a discussion over on that PR (https://github.com/sveltejs/svelte/pull/18042#issuecomment-4567867958) --------- Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>	2 months ago
github-actions[bot]	a9f48540e2	Version Packages (#18389) ... This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.3 ### Patch Changes - fix: ignore errors that occur in destroyed effects ([#18384](https://github.com/sveltejs/svelte/pull/18384)) - fix: type BigInts in `$state.snapshot(...)` return values ([#18388](https://github.com/sveltejs/svelte/pull/18388)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
sijie-Z	71a6515bd6	fix: check boundary exists before calling error handler in async derived (#18384) ... fixes #18383 I traced the issue to `packages/svelte/src/internal/client/error-handling.js`, specifically the `invoke_error_boundary` function. The problem is at line 56 where `effect.b.error(error)` is called without checking if `effect.b` exists. What happens is: when an async `$derived` rejects inside a `<svelte:boundary>`, the error is handled correctly the first time. But if the boundary is destroyed before the rejection fully settles (e.g. component unmounts), a subsequent settle tries to call `effect.b.error()` on a destroyed boundary where `effect.b` is `null`, causing a `TypeError`. The fix adds a null check for `effect.b` before calling `error()`. If the boundary has been destroyed, we skip it and continue bubbling up to the parent boundary. This way the error still gets handled properly instead of crashing. This could also be tested by creating a component with an async `$derived` that rejects after the component unmounts, but I wanted to get the fix up first for review. --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
sijie-Z	3d83c9abe6	fix: add bigint to Primitive type for $state.snapshot (#18388) ... Fixes #18385 ## Problem `$state.snapshot` infers BigInt properties as `never` because `bigint` is missing from the `Primitive` type definition. BigInt is a valid JavaScript primitive and is supported by `structuredClone`. ## Solution Added `bigint` to the `Primitive` type in both `packages/svelte/src/ambient.d.ts` and `packages/svelte/types/index.d.ts`. ## Before ```ts const object = $state({ number: 1n }); const snapshot = $state.snapshot(object); // snapshot.number is inferred as never ❌ After const object = $state({ number: 1n }); const snapshot = $state.snapshot(object); // snapshot.number is correctly inferred as bigint ✅ Tests and linting - [x] This is a type-only change, no runtime behavior affected --------- Co-authored-by: Rich Harris <hello@rich-harris.dev>	2 months ago
github-actions[bot]	51baf1c1af	Version Packages (#18357) ... This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.2 ### Patch Changes - fix: properly track effect end node for async sibling component ([#18371](https://github.com/sveltejs/svelte/pull/18371)) - fix: prevent false-positive reactivity loss warning ([#18373](https://github.com/sveltejs/svelte/pull/18373)) - chore: bump esrap dependency ([#18372](https://github.com/sveltejs/svelte/pull/18372)) - fix: ignore declaration tags for animation directive ([#18366](https://github.com/sveltejs/svelte/pull/18366)) - fix: reject pending async deriveds on discard ([#18308](https://github.com/sveltejs/svelte/pull/18308)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
Paolo Ricciuti	f915aa39cf	Merge branch 'main' into svelte-custom-renderer	2 months ago
paoloricciuti	cd5e2ee6a5	fix: wrap implicit children into `renderer_snippet`	2 months ago
Simon H	3d5c4ab620	fix: prevent false-positive reactivity loss warning (#18373) ... By checking that current/previous batch are null we filter out false positives. `reactivity_loss_tracker` is only reset after a microtask, so if a flush happens before that, we get warnings for things we shouldn't warn on. Fixes #18370 --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
Simon H	bdb1a0f847	fix: ensure async block assigns correct nodes to effect (#18371) ... If a block has a sole component child, we apply an optimization to not need a template. But if that sole child is wrapped in `$.async`, it can happens that the block's effect is assigned the wrong end node. In the reproduction this happens because we have two components inside a Child which is rendered only after an async block resolves. In `$.append` we have logic to not reassign nodes when the active effect didn't already run, which it has by the time we come across it (because the async work had to resolve first; we added this in https://github.com/sveltejs/svelte/pull/17120 to prevent the opposite, nodes being "rewinded" to an earlier position) and so the second sibling component's `$.append` will not set its end node to the effect. As a result the end node is wrong (too early). To fix this we assign the nodes in `$.async`. We could also use `compareDocumentPosition` in `$.append` to only ever go forward, but that feels a bit heavier performance-wise. --------- Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
Simon H	e4bfc5f45a	chore: bump esrap dependency (#18372) ... Avoid installing the broken 2.2.10 version Closes #18369	2 months ago
paoloricciuti	ee2f74ebf3	fix: lint	2 months ago
paoloricciuti	0490721eef	fix: lint and check	2 months ago
Paolo Ricciuti	114be1c593	Merge branch 'main' into svelte-custom-renderer	2 months ago
Paolo Ricciuti	56856f0b10	fix: `customRenderer` as a global option and remove `without_renderer` (#18359) ... Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	2 months ago
Minh Lê	94bd27953e	docs: fix invalid `rows` CSS property in {#each} chess-board example (#18367) ... ## Problem The `{#each}` docs page has a runnable "chess board" example whose `<style>` block uses an invalid CSS property: ```css .chess-board { display: grid; grid-template-columns: repeat(8, 1fr); rows: repeat(8, 1fr); /* ← not a real CSS property */ ... } ``` There is no `rows` shorthand or longhand in CSS, so this line is silently dropped by every browser. The example clearly intends an 8×8 grid (note the matching `grid-template-columns` line directly above). ## Fix `rows` → `grid-template-rows`. One line, in `documentation/docs/03-template-syntax/03-each.md`. No prose changes.	2 months ago
Simon H	1b4c43b8e5	fix: ignore declaration tags for animation directive (#18366) ... Fixes #18365	2 months ago
Mathias Picker	85dcb91f7c	chore: upgrade to vitest v4 (#18265) ... ## Summary Bumps `vitest` and `@vitest/coverage-v8` from `^2.1.9` to `^4.1.7` (two major versions). Three small test-harness updates compensate for vitest 4 behavior changes; all 7569 tests still pass. - **`packages/svelte/tests/runtime-browser/test.ts`** — vitest 4 removed the deprecated `describe(name, fn, opts)` signature. Pass options as the second argument. - **`packages/svelte/tests/runtime-legacy/shared.ts`** — vitest 4's jsdom env binds `virtualConsole` to the original `globalThis.console` reference *before* vitest wraps the console, so inline-`<script>` logs and `jsdomError` events no longer reach per-test `console.{log,error}` overrides. Restore vitest 2's behavior by re-routing the virtual console through the live `console` in `beforeAll`. Also promote the window-error listener to a named function and remove it in `finally` — previously leaked listeners from earlier tests kept writing to module-level `unhandled_rejection`, polluting later tests. - **`vitest.config.js`** — bump `testTimeout` to 10s. The 5s default trips a handful of dev-mode tests that exercise `effect_update_depth_exceeded`, whose ~1000 Error-stack captures per flush are slower under vitest 4's deeper async stacks. ## Test plan - [x] `pnpm test` — 7569 passed, 63 skipped, 0 failed --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
Simon H	a81f96549d	fix: reject pending async deriveds on discard (#18308) ... The rejects all async deriveds of a batch as `OBSOLETE`, so they don't hang around and bail early without triggering the batch. If we don't do this, an async derived can trigger the already done batch, which schedules an effect that is never flushed. Because it is never flushed the branches it touched on its way up are never cleared, and so anything else in that subtree is now unreactive.	2 months ago
github-actions[bot]	3ef761b87b	Version Packages (#18346) ... This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.1 ### Patch Changes - fix: error at compile time on duplicate snippet/declaration tag definitions ([#18351](https://github.com/sveltejs/svelte/pull/18351)) - fix: parse declaration tag contents more robustly ([#18353](https://github.com/sveltejs/svelte/pull/18353)) - fix: correctly transform references to earlier declarators in a declaration tag (e.g. `{let a = $state(0), b = $derived(a * 2)}`) ([#18348](https://github.com/sveltejs/svelte/pull/18348)) - fix: avoid spurious `state_referenced_locally` warnings for `$derived` declarations in declaration tags ([#18348](https://github.com/sveltejs/svelte/pull/18348)) - fix: tolerate whitespace before `let`/`const` in declaration tags ([#18348](https://github.com/sveltejs/svelte/pull/18348)) - fix: prevent infinite loop when a tag's expression ends with a trailing `/` at the end of the input ([#18350](https://github.com/sveltejs/svelte/pull/18350)) - fix: more robust parsing of declaration tags with regards to `type` ([#18330](https://github.com/sveltejs/svelte/pull/18330)) - fix: preserve newlines in spread input values when the `type` attribute is applied after `value` ([#18345](https://github.com/sveltejs/svelte/pull/18345)) - fix: update `SvelteURLSearchParams` when setting duplicate keys to the same joined value ([#18336](https://github.com/sveltejs/svelte/pull/18336)) - fix: check references for blockers on server, too ([#18352](https://github.com/sveltejs/svelte/pull/18352)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
Simon H	5b8db1be35	fix: error at compile time on duplicate snippet/declaration tag definitions (#18351)	2 months ago
Simon H	56013a2c01	fix: check references for blockers on server, too (#18352) ... We forgot the server in #18309 Fixes #18344	2 months ago
hjaber	2afb895ffa	fix: parse declaration tags with a division operator in the initializer (#18353) ... Mimic what `parseExpressionAt` does --------- Co-authored-by: hjaber <hjaber@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 months ago
paoloricciuti	e5beb7297d	fix: push renderer in effects even if it's `null` ... This is needed because effects record the renderer they were created with. But if we interlieve a DOM renderer with a Custom one, current_renderer could be a custom one when the effect reruns and if we don't push `null` it will use the custom_renderer methods instead of the DOM ones.	2 months ago
paoloricciuti	131fae3c2d	fix: update snapshot	2 months ago
paoloricciuti	f781fe485c	chore: fix type	2 months ago
paoloricciuti	a72c3650c9	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	2 months ago
paoloricciuti	c58c5565c0	fix: noop on the server for custom renderer components	2 months ago
Yuichiro Yamashita	b471c15e61	fix: don't hang on a tag whose expression ends with a trailing slash (#18350) ... close https://github.com/sveltejs/svelte/issues/18349	2 months ago
Yuichiro Yamashita	c74f44fff9	fix: don't mistake `type` identifier expressions for TS `type` declarations in tags (#18330) ... Detect TypeScript `type` declarations by actually parsing instead of by character-class blacklists, so that expressions like `{type === 'all' ? a : b}` or `{type instanceof Foo}` aren't misclassified as malformed declarations. Closes #18328 --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 months ago
Rich Harris	b76b937e00	fix: various declaration tag bugs (#18348) ... closes #18334	2 months ago
jdoughty04	378bb25097	fix: set input type before spread value (#18345) ... ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` Fixes #18332. When spread props put `value` before a later `type="hidden"` on an `<input>`, `set_attributes` currently writes the value while the element is still a text input. Browsers sanitize text input values by removing newlines, so the hidden input permanently loses them before `type` is applied. This sets an input's `type` first whenever the same spread update also includes `value` or `__value`, so the existing value handling runs with the final input type. The new runtime-browser sample covers both the problematic spread-first order and the already-working type-first order. Validation: - `corepack pnpm lint` - `CI=1 corepack pnpm test` - `corepack pnpm vitest run packages/svelte/tests/runtime-browser/test.ts -t input-type-before-value-spread` --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	2 months ago
jiyujie2006	2f6307af65	Fix searchParams.set duplicate updates (#18336) ... ## Summary - detect `SvelteURLSearchParams#set` changes by comparing duplicate value lists instead of joined strings - update reactive subscribers when duplicate params collapse to a single value with the same concatenated text - cover both `SvelteURLSearchParams` and `SvelteURL.searchParams` synchronization ## Tests - pnpm exec vitest run packages/svelte/src/reactivity/url-search-params.test.ts -t "URLSearchParams.set updates when duplicate values collapse to the same joined string" - pnpm exec vitest run packages/svelte/src/reactivity/url-search-params.test.ts packages/svelte/src/reactivity/url.test.ts --------- Co-authored-by: Rich Harris <hello@rich-harris.dev>	2 months ago