11648 Commits (custom-condition)

 

All Branches   

Search

Author	SHA1	Message	Date
Rich Harris	8030ff2a2c	fix: remove incorrect special handling of :export pseudo-selectors (#18839) ... #18793 added special handling for `:export` selectors, but this is incorrect. `:export` is (apparently) part of [Interoperable CSS](https://github.com/css-modules/icss) but Svelte doesn't (and shouldn't) know what that is. No changeset because #18793 is unreleased, and the changeset in that PR didn't mention ICSS	2 weeks ago
svelte-triage-bot[bot]	a72dc8eadb	fix: make Object.hasOwn reactive for state proxies (#18838) ... Fixes #18837 ### What changed State proxies now establish a per-property reactive dependency when `Object.hasOwn(proxy, prop)` invokes the `getOwnPropertyDescriptor` trap. Property additions and deletions therefore invalidate the expression, consistently with the `prop in proxy` operator. The source creation uses the same eligibility constraints as the existing `has` trap so inherited properties retain their existing semantics. A runtime-runes regression sample covers both adding and deleting the observed property in DOM and hydration modes. ### Tests and linting - `FILTER=object-has-own-reactive pnpm test runtime-runes --reporter=dot` — 4 passed - `pnpm exec vitest run packages/svelte/src/internal/client/proxy.test.ts --reporter=dot` — 8 passed - `pnpm test runtime-runes --reporter=dot` — 2707 passed, 34 skipped - `pnpm test --reporter=dot` — 7786 passed, 55 skipped - `cd packages/svelte && pnpm check` — passed - `pnpm format` — passed - `pnpm lint` — passed Includes a patch changeset for `svelte`. <!-- svelte-triage-bot:feedback-baseline:81ef2357a99a2592312d5483e38be3f6ddeb4be5 --> --------- Co-authored-by: svelte-triage-bot <team@svelte.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 weeks ago
paoloricciuti	b3f3a77e35	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	2 weeks ago
Nic Polumeyv	6eb720a1b7	chore: scope.js stops importing from the analysis visitors (#18787) ... `phases/scope.js` imported `validate_identifier_name` from `2-analyze/visitors/shared/utils.js`, which imports `get_rune` back from `scope.js`. The check reads a `Binding` and `Scope.declare` is its main caller, so it now lives in `scope.js`. No behaviour change.	3 weeks ago
Nic Polumeyv	e6ae460caa	chore: analysis and transform stop importing each other (#18786) ... Analysis imported `should_proxy` from `3-transform/client/utils.js` and transform imported `check_graph_for_cycles` from `2-analyze/utils`. The graph search now lives in `compiler/utils`, `should_proxy` in `phases/scope.js` next to the bindings it reads. No behaviour change.	3 weeks ago
Nic Polumeyv	5981c060d2	chore: move parser helpers next to their users (#18785) ... Phase 1 imported `disallow_children` from phase 2, `fuzzymatch` sat in the parser's utils while only analysis and `extract_svelte_ignore` used it, `create_fragment` had a file to itself although `create_attribute` lives in `phases/nodes.js`, and `push_array` had a single caller. Each now sits next to its users: `create_fragment` and `disallow_children` in `phases/nodes.js`, `fuzzymatch` in `compiler/utils`, `push_array` inside `mapped_code.js`. Four files fewer, no behaviour change.	3 weeks ago
svelte-triage-bot[bot]	f2ad10ecd2	fix: preserve global CSS without scopable elements (#18793) ... ## Summary - mark fully global selectors as used without requiring a scopable component element - preserve exact ICSS `:export` rules under the same conditions - keep elements inside `<svelte:head>` excluded from CSS hash injection - add a regression test covering both reported selector forms Fixes #18792	3 weeks ago
svelte-triage-bot[bot]	a8a9b02e38	fix: reduce SSR render result garbage collection (#18798) ... Fixes #18797. ### Problem SSR `render()` is lazy, but the wrapper benchmark discarded its result and therefore measured almost no rendering work. When `.body` was consumed, each render result's own accessor properties caused substantial garbage-collection overhead. ### Fix - Consume `render(App).body` in both the warmup and measured SSR benchmark loops. - Move lazy render-result properties onto a shared `RenderResult` prototype. - Memoize synchronous output and the asynchronous render promise while preserving lazy sync/async API behavior. - Add a regression test ensuring exposed render-result properties are inherited. - Add a patch changeset for `svelte`. The benchmark now deliberately selects the synchronous lazy-render path by reading `.body`, so the process-wide async flag imported by the reactivity benchmarks does not determine this benchmark's render mode. ### Performance on this host | Case | Time | GC time | | --- | ---: | ---: | | main, output discarded | 0.20 ms | 0.00 ms | | main, `.body` consumed before fix | 163.04 ms | 62.68 ms | | `svelte@5.38.10` | 110.05 ms | 1.39 ms | | fixed, `.body` consumed | 104.79 ms | 2.43 ms | ### Tests - `pnpm test packages/svelte/src/internal/server/renderer.test.ts` — 53 passed - `pnpm test server-side-rendering` — 234 passed, 2 skipped - `pnpm test` — 7,771 passed, 55 skipped - `pnpm lint` - `pnpm check` - `pnpm format` - `git diff --check` <!-- svelte-triage-bot:feedback-baseline:116724e3b641c84ed56b2a60d494b6cb2298bbb3 --> Co-authored-by: svelte-triage-bot <team@svelte.com>	3 weeks ago
Nic Polumeyv	6be176df2f	fix: resolve the fallback of an each block in the enclosing scope (#18803) ... In `phases/scope.js`, `EachBlock` visits `node.fallback` with the block's own scope, so `{:else}` resolves the loop's name to the each context. With `let item = $state('outer')` outside and `{#each items as item}…{:else}<button onclick={() => (item = 'changed')}>` the compiler reports "Cannot reassign or bind to each block argument" for a variable that is not the block's argument. The fallback renders when there is nothing to iterate, so it is visited in the enclosing scope, as an await block's `pending` is.	3 weeks ago
paoloricciuti	a1d9bb6936	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	3 weeks ago
Xia Chao	34b13ac3e4	fix: keep `$state.eager` when used as a variable initializer (#18809) ... fixes #18808 If you write `let x = $state.eager(...)`, the client compiler used to delete that line and then still read `x`. The page crashed with `x is not defined`. Server rendering kept the binding. Using `$state.eager(...)` directly in the markup already worked. This puts the `let` / `const` form on the same path as `$state.snapshot`. Added a runtime-runes sample that fails without this change. Co-authored-by: Xia Chao <236466140+bun-unsafe@users.noreply.github.com>	3 weeks ago
Simon H	ce89035ecb	fix: prevent effect tree of batches from interfering with each other (#18508) ... While working on another Svelte feature I noticed a bug that boils down to batches interfering with each other through the effect tree: If batch A schedules an effect, it is walked up to the root (possibly). Now if in the meantime batch B also wants to schedule effects, it can have unintended consequences. Normally this does not happen, since it's extremely hard to run into this situation. There's basically two cases: Either an unfortunate timing of microtasks, or during flushing effects are scheduling new effects which messes with a `#commit()` right after (the test case does this). To fix this we now defer walking up the tree until the batch is actually processed. That way we set + unset the markers on the branches synchronously so there's no chance of another batch interfering.	3 weeks ago
Simon H	d16099ef0f	fix: remove `WAS_MARKED` flag in favor of `Set` (#18127) ... Removes the `WAS_MARKED` logic in favor of a simple `Set` heuristic: If `mark_reactions` goes beyond a certain count, initialize it, otherwise keep it `null`. Balances the common case of not having many transitive dependencies with the edge case of cyclic dependencies as was seen in #16658 (I rechecked that reproduction and it remains fast with this change). I ran the benchmark against this and it doesn't hit the `Seen` heuristic once (i.e. even the benchmark doesn't have this extreme level of dependencies where it becomes noticeable). Fixes #18123, supersedes #18124 --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	3 weeks ago
paoloricciuti	34e0a84be3	fix: more try finally	4 weeks ago
paoloricciuti	90660afc76	fix: test typecheck	4 weeks ago
paoloricciuti	19a971cc1d	fix: include `segments` in upstream changes to hrm and svelte head	4 weeks ago
paoloricciuti	6fe7d4f5ae	fix: wrong types during rebase	4 weeks ago
paoloricciuti	5b4873cf57	fix: imports	4 weeks ago
paoloricciuti	b9ab9cbefb	chore: pass renderer in test mount	4 weeks ago
paoloricciuti	a236135396	fix: pass parent renderer in `mount`	4 weeks ago
paoloricciuti	224092b37b	fix: types in renderers tests	4 weeks ago
paoloricciuti	0cebd320f4	fix: hydrate types	4 weeks ago
paoloricciuti	6411c4282d	fix: prettier	4 weeks ago
paoloricciuti	44351a4b44	chore: add tests	4 weeks ago
paoloricciuti	8f9b2eb6da	chore: regenerate types	4 weeks ago
paoloricciuti	6d75398b47	chore: add ability to hydrate dom custom renderers samples	4 weeks ago
paoloricciuti	d395fc15d1	fix: update test renderer to output actual dom nodes when interleaving	4 weeks ago
paoloricciuti	0e942acab2	feat: accept `foreign` object in custom renderer to determine how to interleave custom renderers	4 weeks ago
paoloricciuti	607ee25071	fix: store `segments` and use them to remove nodes when interleaving is happening	4 weeks ago
paoloricciuti	b84a399d5b	chore: create error for missing foreign	4 weeks ago
paoloricciuti	c64b15a3c0	fix: push renderer before executing a snippet	4 weeks ago
paoloricciuti	328695caf4	fix: wrap implicit children snippets in `renderer_snippet`	4 weeks ago
paoloricciuti	2811fa4347	fix: set null renderer for snippets created by DOM components	4 weeks ago
paoloricciuti	8488762552	fix: make sure pop renderer is always before `return`	4 weeks ago
paoloricciuti	879d544abb	fix: always validate snippets if custom renderer is enabled	4 weeks ago
paoloricciuti	a1bf283aca	fix: store and restore parent renderer in effect	4 weeks ago
paoloricciuti	77ff56da86	fix: skip single node optimization in custom renderer	4 weeks ago
paoloricciuti	a180976a23	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	4 weeks ago
paoloricciuti	be0640be87	fix: styles with semicolons	4 weeks ago
paoloricciuti	1e5dc328cd	fix: better `customRenderer` validation	4 weeks ago
paoloricciuti	9b97b7fbf7	fix: try finally pop render	4 weeks ago
Bao Nguyen	5895c637b0	fix: recognise `aria-braillelabel` and `aria-brailleroledescription` as known ARIA attributes (#18765)	4 weeks ago
JY Wey	9e69544238	fix: in non-async mode, only push variable to current_sources when active_reaction is updating (#18550) ... fix: #16814 in non-async mode, when the derived inside `SvelteDate` is created and evaluated, the `#reaction` is from the `active_reaction` when the `SvelteDate` instance is created, which could possible in NON_UPDATING state, so the derived should not be added to `current_sources` to prevent re-run. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	4 weeks ago
Simon H	6f7857af59	chore: compiler profiling + parser bench (#18767) ... Used these to speed up parsing/find compilation bottlenecks. Useful for later analysis therefore committing it.	4 weeks ago
paoloricciuti	17e37a51bc	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	4 weeks ago
Bao Nguyen	4bf15ae6f3	fix: throw when `setContext` is called after an `await` during SSR (#18739) ... Fixes #17233.	1 month ago
Simon H	9d91a40faf	chore: bump packages (#18752) ... esrap bump ensures a bugfix, devalue silences vulnerability reports	1 month ago
Simon H	b580455c9c	fix: serialize input default values during SSR (#18733) ... Alternative to #18452 --------- Co-authored-by: svelte-triage-bot <team@svelte.com>	1 month ago
Simon H	b2c22ab66d	chore: add regression test for teardown value behavior (#18751) ... #18746 would've introduced a bug that makes this test fail. Add it now so we don't regress in the future	1 month ago
Simon H	b1142efe96	perf: speed up parser a little bit (#18736) ... ~5% in local benchmarks by avoiding regex in some places	1 month ago