Change unknown prop dev warning to look at readable props as well

pull/3956/head
tpatterson 6 years ago
parent 0aceccc31b
commit ebc092c875

@ -365,11 +365,11 @@ export default function dom(
});
let unknown_props_check;
if (component.compile_options.dev && !component.var_lookup.has('$$props') && writable_props.length) {
if (component.compile_options.dev && !component.var_lookup.has('$$props') && props.length) {
unknown_props_check = b`
const writable_props = [${writable_props.map(prop => x`'${prop.export_name}'`)}];
const props = [${props.map(prop => x`'${prop.export_name}'`)}];
@_Object.keys($$props).forEach(key => {
if (!~writable_props.indexOf(key) && key.slice(0, 2) !== '$$') @_console.warn(\`<${component.tag}> was created with unknown prop '\${key}'\`);
if (!~props.indexOf(key) && key.slice(0, 2) !== '$$') @_console.warn(\`<${component.tag}> was created with unknown prop '\${key}'\`);
});
`;
}

@ -0,0 +1,5 @@
<script>
export const foo = undefined;
</script>
<div>{foo}</div>

@ -0,0 +1,7 @@
export default {
compileOptions: {
dev: true
},
warnings: []
};

@ -0,0 +1,5 @@
<script>
import Foo from './Foo.svelte';
</script>
<Foo foo="sho"/>
Loading…
Cancel
Save