From ebc092c875efdbfd8d0e6708f99c01e395f7ff8b Mon Sep 17 00:00:00 2001 From: tpatterson Date: Tue, 19 Nov 2019 12:30:43 -0500 Subject: [PATCH] Change unknown prop dev warning to look at readable props as well --- src/compiler/compile/render_dom/index.ts | 6 +++--- .../dev-warning-unknown-props-uses-readable/Foo.svelte | 5 +++++ .../dev-warning-unknown-props-uses-readable/_config.js | 7 +++++++ .../dev-warning-unknown-props-uses-readable/main.svelte | 5 +++++ 4 files changed, 20 insertions(+), 3 deletions(-) create mode 100644 test/runtime/samples/dev-warning-unknown-props-uses-readable/Foo.svelte create mode 100644 test/runtime/samples/dev-warning-unknown-props-uses-readable/_config.js create mode 100644 test/runtime/samples/dev-warning-unknown-props-uses-readable/main.svelte diff --git a/src/compiler/compile/render_dom/index.ts b/src/compiler/compile/render_dom/index.ts index cc0c7dfe31..0b4746fe28 100644 --- a/src/compiler/compile/render_dom/index.ts +++ b/src/compiler/compile/render_dom/index.ts @@ -365,11 +365,11 @@ export default function dom( }); let unknown_props_check; - if (component.compile_options.dev && !component.var_lookup.has('$$props') && writable_props.length) { + if (component.compile_options.dev && !component.var_lookup.has('$$props') && props.length) { unknown_props_check = b` - const writable_props = [${writable_props.map(prop => x`'${prop.export_name}'`)}]; + const props = [${props.map(prop => x`'${prop.export_name}'`)}]; @_Object.keys($$props).forEach(key => { - if (!~writable_props.indexOf(key) && key.slice(0, 2) !== '$$') @_console.warn(\`<${component.tag}> was created with unknown prop '\${key}'\`); + if (!~props.indexOf(key) && key.slice(0, 2) !== '$$') @_console.warn(\`<${component.tag}> was created with unknown prop '\${key}'\`); }); `; } diff --git a/test/runtime/samples/dev-warning-unknown-props-uses-readable/Foo.svelte b/test/runtime/samples/dev-warning-unknown-props-uses-readable/Foo.svelte new file mode 100644 index 0000000000..14509b2fa1 --- /dev/null +++ b/test/runtime/samples/dev-warning-unknown-props-uses-readable/Foo.svelte @@ -0,0 +1,5 @@ + + +
{foo}
diff --git a/test/runtime/samples/dev-warning-unknown-props-uses-readable/_config.js b/test/runtime/samples/dev-warning-unknown-props-uses-readable/_config.js new file mode 100644 index 0000000000..62ad08624d --- /dev/null +++ b/test/runtime/samples/dev-warning-unknown-props-uses-readable/_config.js @@ -0,0 +1,7 @@ +export default { + compileOptions: { + dev: true + }, + + warnings: [] +}; diff --git a/test/runtime/samples/dev-warning-unknown-props-uses-readable/main.svelte b/test/runtime/samples/dev-warning-unknown-props-uses-readable/main.svelte new file mode 100644 index 0000000000..dbefea7b4d --- /dev/null +++ b/test/runtime/samples/dev-warning-unknown-props-uses-readable/main.svelte @@ -0,0 +1,5 @@ + + +