msb-public
/
svelte
mirror of https://github.com/sveltejs/svelte
1
0
Code Issues Projects Releases Wiki Activity

perf: ParseFloat only targetProp value

Browse Source
pull/5466/head
Moein Porkamel 5 years ago committed by Moein
parent 7a1cbf4d4b
commit a0ce2b708d
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File

4
src/runtime/transition/index.ts
Unescape View File

@ -111,8 +111,6 @@ export function slide(node: Element, {
}: SlideParams): TransitionConfig { }: SlideParams): TransitionConfig {
const style = getComputedStyle(node); const style = getComputedStyle(node);
const opacity = +style.opacity; const opacity = +style.opacity;
const width = parseFloat(style.width);
const height = parseFloat(style.height);
const padding_top = parseFloat(style.paddingTop); const padding_top = parseFloat(style.paddingTop);
const padding_bottom = parseFloat(style.paddingBottom); const padding_bottom = parseFloat(style.paddingBottom);
const margin_top = parseFloat(style.marginTop); const margin_top = parseFloat(style.marginTop);
@ -120,7 +118,7 @@ export function slide(node: Element, {
const border_top_width = parseFloat(style.borderTopWidth); const border_top_width = parseFloat(style.borderTopWidth);
const border_bottom_width = parseFloat(style.borderBottomWidth); const border_bottom_width = parseFloat(style.borderBottomWidth);
const targetProp = direction === 'vertical' ? 'height' : 'width'; const targetProp = direction === 'vertical' ? 'height' : 'width';
const targetPropVal = targetProp === 'height' ? height : width; const targetPropVal = targetProp === 'height' ? parseFloat(height) : parseFloat(width);
return { return {
delay, delay,

Write Preview
Loading…
Cancel
Save