From a0ce2b708d8c19c4f35323830fdda85751f2ee6d Mon Sep 17 00:00:00 2001 From: Moein Porkamel Date: Tue, 29 Sep 2020 20:12:11 +0330 Subject: [PATCH] perf: ParseFloat only targetProp value --- src/runtime/transition/index.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/runtime/transition/index.ts b/src/runtime/transition/index.ts index 700878df6e..fd1edd2974 100644 --- a/src/runtime/transition/index.ts +++ b/src/runtime/transition/index.ts @@ -111,8 +111,6 @@ export function slide(node: Element, { }: SlideParams): TransitionConfig { const style = getComputedStyle(node); const opacity = +style.opacity; - const width = parseFloat(style.width); - const height = parseFloat(style.height); const padding_top = parseFloat(style.paddingTop); const padding_bottom = parseFloat(style.paddingBottom); const margin_top = parseFloat(style.marginTop); @@ -120,7 +118,7 @@ export function slide(node: Element, { const border_top_width = parseFloat(style.borderTopWidth); const border_bottom_width = parseFloat(style.borderBottomWidth); const targetProp = direction === 'vertical' ? 'height' : 'width'; - const targetPropVal = targetProp === 'height' ? height : width; + const targetPropVal = targetProp === 'height' ? parseFloat(height) : parseFloat(width); return { delay,