aa-coordination
Rich Harris 7 months ago
parent 6e1a33162c
commit 5f61b08849

@ -1,6 +1,6 @@
/** @import { Effect, TemplateNode } from '#client' */ /** @import { Effect, TemplateNode } from '#client' */
import { FILENAME, HYDRATION_ERROR } from '../../../../constants.js'; import { FILENAME, HYDRATION_ERROR } from '../../../../constants.js';
import { branch, destroy_effect, template_effect } from '../../reactivity/effects.js'; import { remove_effect_dom, template_effect } from '../../reactivity/effects.js';
import { hydrate_next, hydrate_node, hydrating, set_hydrate_node } from '../hydration.js'; import { hydrate_next, hydrate_node, hydrating, set_hydrate_node } from '../hydration.js';
import { create_fragment_from_html } from '../reconciler.js'; import { create_fragment_from_html } from '../reconciler.js';
import { assign_nodes } from '../template.js'; import { assign_nodes } from '../template.js';
@ -9,6 +9,7 @@ import { hash, sanitize_location } from '../../../../utils.js';
import { DEV } from 'esm-env'; import { DEV } from 'esm-env';
import { dev_current_component_function } from '../../context.js'; import { dev_current_component_function } from '../../context.js';
import { get_first_child, get_next_sibling } from '../operations.js'; import { get_first_child, get_next_sibling } from '../operations.js';
import { active_effect } from '../../runtime.js';
/** /**
* @param {Element} element * @param {Element} element
@ -44,23 +45,21 @@ export function html(node, get_value, svg = false, mathml = false, skip_warning
var value = ''; var value = '';
/** @type {Effect | undefined} */
var effect;
template_effect(() => { template_effect(() => {
var effect = /** @type {Effect} */ (active_effect);
if (value === (value = get_value() ?? '')) { if (value === (value = get_value() ?? '')) {
if (hydrating) hydrate_next(); if (hydrating) hydrate_next();
return; return;
} }
if (effect !== undefined) { if (effect.nodes_start !== null) {
destroy_effect(effect); remove_effect_dom(effect.nodes_start, /** @type {TemplateNode} */ (effect.nodes_end));
effect = undefined; effect.nodes_start = effect.nodes_end = null;
} }
if (value === '') return; if (value === '') return;
effect = branch(() => {
if (hydrating) { if (hydrating) {
// We're deliberately not trying to repair mismatches between server and client, // We're deliberately not trying to repair mismatches between server and client,
// as it's costly and error-prone (and it's an edge case to have a mismatch anyway) // as it's costly and error-prone (and it's an edge case to have a mismatch anyway)
@ -68,10 +67,7 @@ export function html(node, get_value, svg = false, mathml = false, skip_warning
var next = hydrate_next(); var next = hydrate_next();
var last = next; var last = next;
while ( while (next !== null && (next.nodeType !== 8 || /** @type {Comment} */ (next).data !== '')) {
next !== null &&
(next.nodeType !== 8 || /** @type {Comment} */ (next).data !== '')
) {
last = next; last = next;
next = /** @type {TemplateNode} */ (get_next_sibling(next)); next = /** @type {TemplateNode} */ (get_next_sibling(next));
} }
@ -116,5 +112,4 @@ export function html(node, get_value, svg = false, mathml = false, skip_warning
anchor.before(node); anchor.before(node);
} }
}); });
});
} }

@ -388,7 +388,7 @@ function create_template_effect(fn, deriveds) {
}); });
} }
block(effect, TEMPLATE_EFFECT); create_effect(RENDER_EFFECT | TEMPLATE_EFFECT, effect, true);
} }
/** /**
@ -467,18 +467,7 @@ export function destroy_effect(effect, remove_dom = true) {
var removed = false; var removed = false;
if ((remove_dom || (effect.f & HEAD_EFFECT) !== 0) && effect.nodes_start !== null) { if ((remove_dom || (effect.f & HEAD_EFFECT) !== 0) && effect.nodes_start !== null) {
/** @type {TemplateNode | null} */ remove_effect_dom(effect.nodes_start, /** @type {TemplateNode} */ (effect.nodes_end));
var node = effect.nodes_start;
var end = effect.nodes_end;
while (node !== null) {
/** @type {TemplateNode | null} */
var next = node === end ? null : /** @type {TemplateNode} */ (get_next_sibling(node));
node.remove();
node = next;
}
removed = true; removed = true;
} }
@ -520,6 +509,21 @@ export function destroy_effect(effect, remove_dom = true) {
null; null;
} }
/**
*
* @param {TemplateNode | null} node
* @param {TemplateNode} end
*/
export function remove_effect_dom(node, end) {
while (node !== null) {
/** @type {TemplateNode | null} */
var next = node === end ? null : /** @type {TemplateNode} */ (get_next_sibling(node));
node.remove();
node = next;
}
}
/** /**
* Detach an effect from the effect tree, freeing up memory and * Detach an effect from the effect tree, freeing up memory and
* reducing the amount of work that happens on subsequent traversals * reducing the amount of work that happens on subsequent traversals

Loading…
Cancel
Save