is_dirty is a better name than check_dirtiness

pull/15844/head
Rich Harris 2 months ago
parent 179980e965
commit 2019451444

@ -16,7 +16,7 @@ import { deferred, define_property } from '../../shared/utils.js';
import { get_pending_boundary } from '../dom/blocks/boundary.js'; import { get_pending_boundary } from '../dom/blocks/boundary.js';
import { import {
active_effect, active_effect,
check_dirtiness, is_dirty,
is_updating_effect, is_updating_effect,
set_is_updating_effect, set_is_updating_effect,
set_signal_status, set_signal_status,
@ -273,7 +273,7 @@ export class Batch {
this.#effects.push(effect); this.#effects.push(effect);
} else if (async_mode_flag && (flags & RENDER_EFFECT) !== 0) { } else if (async_mode_flag && (flags & RENDER_EFFECT) !== 0) {
this.#render_effects.push(effect); this.#render_effects.push(effect);
} else if (check_dirtiness(effect)) { } else if (is_dirty(effect)) {
if ((flags & EFFECT_ASYNC) !== 0) { if ((flags & EFFECT_ASYNC) !== 0) {
var effects = effect.b?.pending ? this.#boundary_async_effects : this.#async_effects; var effects = effect.b?.pending ? this.#boundary_async_effects : this.#async_effects;
effects.push(effect); effects.push(effect);
@ -530,7 +530,7 @@ function flush_queued_effects(effects) {
var effect = effects[i]; var effect = effects[i];
if ((effect.f & (DESTROYED | INERT)) === 0) { if ((effect.f & (DESTROYED | INERT)) === 0) {
if (check_dirtiness(effect)) { if (is_dirty(effect)) {
var wv = write_version; var wv = write_version;
update_effect(effect); update_effect(effect);

@ -1,6 +1,6 @@
/** @import { ComponentContext, ComponentContextLegacy, Derived, Effect, TemplateNode, TransitionManager } from '#client' */ /** @import { ComponentContext, ComponentContextLegacy, Derived, Effect, TemplateNode, TransitionManager } from '#client' */
import { import {
check_dirtiness, is_dirty,
active_effect, active_effect,
active_reaction, active_reaction,
update_effect, update_effect,
@ -323,7 +323,7 @@ export function legacy_pre_effect_reset() {
set_signal_status(effect, MAYBE_DIRTY); set_signal_status(effect, MAYBE_DIRTY);
} }
if (check_dirtiness(effect)) { if (is_dirty(effect)) {
update_effect(effect); update_effect(effect);
} }
@ -614,7 +614,7 @@ function resume_children(effect, local) {
effect.f ^= INERT; effect.f ^= INERT;
// If a dependency of this effect changed while it was paused, // If a dependency of this effect changed while it was paused,
// schedule the effect to update. we don't use `check_dirtiness` // schedule the effect to update. we don't use `is_dirty`
// here because we don't want to eagerly recompute a derived like // here because we don't want to eagerly recompute a derived like
// `{#if foo}{foo.bar()}{/if}` if `foo` is now `undefined // `{#if foo}{foo.bar()}{/if}` if `foo` is now `undefined
if ((effect.f & CLEAN) === 0) { if ((effect.f & CLEAN) === 0) {

@ -11,7 +11,7 @@ import {
increment_write_version, increment_write_version,
update_effect, update_effect,
source_ownership, source_ownership,
check_dirtiness, is_dirty,
untracking, untracking,
is_destroying_effect, is_destroying_effect,
push_reaction_value push_reaction_value
@ -222,7 +222,8 @@ export function internal_set(source, value) {
if ((effect.f & CLEAN) !== 0) { if ((effect.f & CLEAN) !== 0) {
set_signal_status(effect, MAYBE_DIRTY); set_signal_status(effect, MAYBE_DIRTY);
} }
if (check_dirtiness(effect)) {
if (is_dirty(effect)) {
update_effect(effect); update_effect(effect);
} }
} }

@ -155,7 +155,7 @@ export function increment_write_version() {
* @param {Reaction} reaction * @param {Reaction} reaction
* @returns {boolean} * @returns {boolean}
*/ */
export function check_dirtiness(reaction) { export function is_dirty(reaction) {
var flags = reaction.f; var flags = reaction.f;
if ((flags & DIRTY) !== 0) { if ((flags & DIRTY) !== 0) {
@ -208,7 +208,7 @@ export function check_dirtiness(reaction) {
for (i = 0; i < length; i++) { for (i = 0; i < length; i++) {
dependency = dependencies[i]; dependency = dependencies[i];
if (check_dirtiness(/** @type {Derived} */ (dependency))) { if (is_dirty(/** @type {Derived} */ (dependency))) {
update_derived(/** @type {Derived} */ (dependency)); update_derived(/** @type {Derived} */ (dependency));
} }
@ -607,7 +607,7 @@ export function get(signal) {
if (is_derived && !is_destroying_effect && batch_deriveds === null) { if (is_derived && !is_destroying_effect && batch_deriveds === null) {
derived = /** @type {Derived} */ (signal); derived = /** @type {Derived} */ (signal);
if (check_dirtiness(derived)) { if (is_dirty(derived)) {
update_derived(derived); update_derived(derived);
} }
} }

Loading…
Cancel
Save