From 2019451444da03eae60998b5f2efbf89e4fa1a61 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Tue, 8 Jul 2025 07:23:32 -0400 Subject: [PATCH] is_dirty is a better name than check_dirtiness --- packages/svelte/src/internal/client/reactivity/batch.js | 6 +++--- packages/svelte/src/internal/client/reactivity/effects.js | 6 +++--- packages/svelte/src/internal/client/reactivity/sources.js | 5 +++-- packages/svelte/src/internal/client/runtime.js | 6 +++--- 4 files changed, 12 insertions(+), 11 deletions(-) diff --git a/packages/svelte/src/internal/client/reactivity/batch.js b/packages/svelte/src/internal/client/reactivity/batch.js index 7be2434f7d..a320331bf6 100644 --- a/packages/svelte/src/internal/client/reactivity/batch.js +++ b/packages/svelte/src/internal/client/reactivity/batch.js @@ -16,7 +16,7 @@ import { deferred, define_property } from '../../shared/utils.js'; import { get_pending_boundary } from '../dom/blocks/boundary.js'; import { active_effect, - check_dirtiness, + is_dirty, is_updating_effect, set_is_updating_effect, set_signal_status, @@ -273,7 +273,7 @@ export class Batch { this.#effects.push(effect); } else if (async_mode_flag && (flags & RENDER_EFFECT) !== 0) { this.#render_effects.push(effect); - } else if (check_dirtiness(effect)) { + } else if (is_dirty(effect)) { if ((flags & EFFECT_ASYNC) !== 0) { var effects = effect.b?.pending ? this.#boundary_async_effects : this.#async_effects; effects.push(effect); @@ -530,7 +530,7 @@ function flush_queued_effects(effects) { var effect = effects[i]; if ((effect.f & (DESTROYED | INERT)) === 0) { - if (check_dirtiness(effect)) { + if (is_dirty(effect)) { var wv = write_version; update_effect(effect); diff --git a/packages/svelte/src/internal/client/reactivity/effects.js b/packages/svelte/src/internal/client/reactivity/effects.js index a91b739d5f..92065f44d0 100644 --- a/packages/svelte/src/internal/client/reactivity/effects.js +++ b/packages/svelte/src/internal/client/reactivity/effects.js @@ -1,6 +1,6 @@ /** @import { ComponentContext, ComponentContextLegacy, Derived, Effect, TemplateNode, TransitionManager } from '#client' */ import { - check_dirtiness, + is_dirty, active_effect, active_reaction, update_effect, @@ -323,7 +323,7 @@ export function legacy_pre_effect_reset() { set_signal_status(effect, MAYBE_DIRTY); } - if (check_dirtiness(effect)) { + if (is_dirty(effect)) { update_effect(effect); } @@ -614,7 +614,7 @@ function resume_children(effect, local) { effect.f ^= INERT; // If a dependency of this effect changed while it was paused, - // schedule the effect to update. we don't use `check_dirtiness` + // schedule the effect to update. we don't use `is_dirty` // here because we don't want to eagerly recompute a derived like // `{#if foo}{foo.bar()}{/if}` if `foo` is now `undefined if ((effect.f & CLEAN) === 0) { diff --git a/packages/svelte/src/internal/client/reactivity/sources.js b/packages/svelte/src/internal/client/reactivity/sources.js index fec8fc6b42..75a65b1678 100644 --- a/packages/svelte/src/internal/client/reactivity/sources.js +++ b/packages/svelte/src/internal/client/reactivity/sources.js @@ -11,7 +11,7 @@ import { increment_write_version, update_effect, source_ownership, - check_dirtiness, + is_dirty, untracking, is_destroying_effect, push_reaction_value @@ -222,7 +222,8 @@ export function internal_set(source, value) { if ((effect.f & CLEAN) !== 0) { set_signal_status(effect, MAYBE_DIRTY); } - if (check_dirtiness(effect)) { + + if (is_dirty(effect)) { update_effect(effect); } } diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js index fcd6fb2cc4..e10115c6fe 100644 --- a/packages/svelte/src/internal/client/runtime.js +++ b/packages/svelte/src/internal/client/runtime.js @@ -155,7 +155,7 @@ export function increment_write_version() { * @param {Reaction} reaction * @returns {boolean} */ -export function check_dirtiness(reaction) { +export function is_dirty(reaction) { var flags = reaction.f; if ((flags & DIRTY) !== 0) { @@ -208,7 +208,7 @@ export function check_dirtiness(reaction) { for (i = 0; i < length; i++) { dependency = dependencies[i]; - if (check_dirtiness(/** @type {Derived} */ (dependency))) { + if (is_dirty(/** @type {Derived} */ (dependency))) { update_derived(/** @type {Derived} */ (dependency)); } @@ -607,7 +607,7 @@ export function get(signal) { if (is_derived && !is_destroying_effect && batch_deriveds === null) { derived = /** @type {Derived} */ (signal); - if (check_dirtiness(derived)) { + if (is_dirty(derived)) { update_derived(derived); } }