fix: share links open in mobile (#428)

pull/430/head
Jorge Coca 3 years ago committed by GitHub
parent bab088faea
commit bac790db95
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -212,7 +212,7 @@ class GoogleIOLinkComponent extends TextComponent with HasGameRef, Tappable {
); );
@override @override
bool onTapDown(TapDownInfo info) { bool onTapUp(TapUpInfo info) {
openLink(ShareRepository.googleIOEvent); openLink(ShareRepository.googleIOEvent);
return true; return true;
} }

@ -140,7 +140,7 @@ class FacebookButtonComponent extends SpriteComponent
final OnSocialShareTap? _onTap; final OnSocialShareTap? _onTap;
@override @override
bool onTapDown(TapDownInfo info) { bool onTapUp(TapUpInfo info) {
_onTap?.call(SharePlatform.facebook); _onTap?.call(SharePlatform.facebook);
return true; return true;
} }
@ -172,7 +172,7 @@ class TwitterButtonComponent extends SpriteComponent with HasGameRef, Tappable {
final OnSocialShareTap? _onTap; final OnSocialShareTap? _onTap;
@override @override
bool onTapDown(TapDownInfo info) { bool onTapUp(TapUpInfo info) {
_onTap?.call(SharePlatform.twitter); _onTap?.call(SharePlatform.twitter);
return true; return true;
} }

@ -99,6 +99,8 @@ class _MockShareRepository extends Mock implements ShareRepository {}
class _MockTapDownInfo extends Mock implements TapDownInfo {} class _MockTapDownInfo extends Mock implements TapDownInfo {}
class _MockTapUpInfo extends Mock implements TapUpInfo {}
class _MockUrlLauncher extends Mock class _MockUrlLauncher extends Mock
with MockPlatformInterfaceMixin with MockPlatformInterfaceMixin
implements UrlLauncherPlatform {} implements UrlLauncherPlatform {}
@ -542,7 +544,7 @@ void main() {
final facebookButton = final facebookButton =
game.descendants().whereType<FacebookButtonComponent>().first; game.descendants().whereType<FacebookButtonComponent>().first;
facebookButton.onTapDown(_MockTapDownInfo()); facebookButton.onTapUp(_MockTapUpInfo());
await game.ready(); await game.ready();
@ -598,7 +600,7 @@ void main() {
final facebookButton = final facebookButton =
game.descendants().whereType<TwitterButtonComponent>().first; game.descendants().whereType<TwitterButtonComponent>().first;
facebookButton.onTapDown(_MockTapDownInfo()); facebookButton.onTapUp(_MockTapUpInfo());
await game.ready(); await game.ready();

@ -68,6 +68,8 @@ class _MockAppLocalizations extends Mock implements AppLocalizations {
class _MockTapDownInfo extends Mock implements TapDownInfo {} class _MockTapDownInfo extends Mock implements TapDownInfo {}
class _MockTapUpInfo extends Mock implements TapUpInfo {}
class _MockUrlLauncher extends Mock class _MockUrlLauncher extends Mock
with MockPlatformInterfaceMixin with MockPlatformInterfaceMixin
implements UrlLauncherPlatform {} implements UrlLauncherPlatform {}
@ -135,7 +137,7 @@ void main() {
final googleLink = final googleLink =
component.descendants().whereType<GoogleIOLinkComponent>().first; component.descendants().whereType<GoogleIOLinkComponent>().first;
googleLink.onTapDown(_MockTapDownInfo()); googleLink.onTapUp(_MockTapUpInfo());
await game.ready(); await game.ready();

@ -52,7 +52,7 @@ class _MockAppLocalizations extends Mock implements AppLocalizations {
String get socialMediaAccount => ''; String get socialMediaAccount => '';
} }
class _MockTapDownInfo extends Mock implements TapDownInfo {} class _MockTapUpInfo extends Mock implements TapUpInfo {}
void main() { void main() {
TestWidgetsFlutterBinding.ensureInitialized(); TestWidgetsFlutterBinding.ensureInitialized();
@ -74,7 +74,7 @@ void main() {
(game) async { (game) async {
var tapped = false; var tapped = false;
final tapDownInfo = _MockTapDownInfo(); final tapUpInfo = _MockTapUpInfo();
final component = ShareDisplay( final component = ShareDisplay(
onShare: (_) => tapped = true, onShare: (_) => tapped = true,
); );
@ -83,7 +83,7 @@ void main() {
final facebookButton = final facebookButton =
component.descendants().whereType<FacebookButtonComponent>().first; component.descendants().whereType<FacebookButtonComponent>().first;
facebookButton.onTapDown(tapDownInfo); facebookButton.onTapUp(tapUpInfo);
expect(tapped, isTrue); expect(tapped, isTrue);
}, },
@ -94,7 +94,7 @@ void main() {
(game) async { (game) async {
var tapped = false; var tapped = false;
final tapDownInfo = _MockTapDownInfo(); final tapUpInfo = _MockTapUpInfo();
final component = ShareDisplay( final component = ShareDisplay(
onShare: (_) => tapped = true, onShare: (_) => tapped = true,
); );
@ -103,7 +103,7 @@ void main() {
final twitterButton = final twitterButton =
component.descendants().whereType<TwitterButtonComponent>().first; component.descendants().whereType<TwitterButtonComponent>().first;
twitterButton.onTapDown(tapDownInfo); twitterButton.onTapUp(tapUpInfo);
expect(tapped, isTrue); expect(tapped, isTrue);
}, },

Loading…
Cancel
Save