From bac790db959fa2eb61ae3c3a1a96bfc7b486145c Mon Sep 17 00:00:00 2001
From: Jorge Coca <jorgecoca@users.noreply.github.com>
Date: Sun, 8 May 2022 21:11:24 -0500
Subject: [PATCH] fix: share links open in mobile (#428)

---
 .../backbox/displays/game_over_info_display.dart       |  2 +-
 .../components/backbox/displays/share_display.dart     |  4 ++--
 test/game/components/backbox/backbox_test.dart         |  6 ++++--
 .../backbox/displays/game_over_info_display_test.dart  |  4 +++-
 .../backbox/displays/share_display_test.dart           | 10 +++++-----
 5 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/lib/game/components/backbox/displays/game_over_info_display.dart b/lib/game/components/backbox/displays/game_over_info_display.dart
index c7708bde..52939345 100644
--- a/lib/game/components/backbox/displays/game_over_info_display.dart
+++ b/lib/game/components/backbox/displays/game_over_info_display.dart
@@ -212,7 +212,7 @@ class GoogleIOLinkComponent extends TextComponent with HasGameRef, Tappable {
         );
 
   @override
-  bool onTapDown(TapDownInfo info) {
+  bool onTapUp(TapUpInfo info) {
     openLink(ShareRepository.googleIOEvent);
     return true;
   }
diff --git a/lib/game/components/backbox/displays/share_display.dart b/lib/game/components/backbox/displays/share_display.dart
index ebaaac7e..0bf61e7d 100644
--- a/lib/game/components/backbox/displays/share_display.dart
+++ b/lib/game/components/backbox/displays/share_display.dart
@@ -140,7 +140,7 @@ class FacebookButtonComponent extends SpriteComponent
   final OnSocialShareTap? _onTap;
 
   @override
-  bool onTapDown(TapDownInfo info) {
+  bool onTapUp(TapUpInfo info) {
     _onTap?.call(SharePlatform.facebook);
     return true;
   }
@@ -172,7 +172,7 @@ class TwitterButtonComponent extends SpriteComponent with HasGameRef, Tappable {
   final OnSocialShareTap? _onTap;
 
   @override
-  bool onTapDown(TapDownInfo info) {
+  bool onTapUp(TapUpInfo info) {
     _onTap?.call(SharePlatform.twitter);
     return true;
   }
diff --git a/test/game/components/backbox/backbox_test.dart b/test/game/components/backbox/backbox_test.dart
index cf28cccf..26f413f7 100644
--- a/test/game/components/backbox/backbox_test.dart
+++ b/test/game/components/backbox/backbox_test.dart
@@ -99,6 +99,8 @@ class _MockShareRepository extends Mock implements ShareRepository {}
 
 class _MockTapDownInfo extends Mock implements TapDownInfo {}
 
+class _MockTapUpInfo extends Mock implements TapUpInfo {}
+
 class _MockUrlLauncher extends Mock
     with MockPlatformInterfaceMixin
     implements UrlLauncherPlatform {}
@@ -542,7 +544,7 @@ void main() {
 
           final facebookButton =
               game.descendants().whereType<FacebookButtonComponent>().first;
-          facebookButton.onTapDown(_MockTapDownInfo());
+          facebookButton.onTapUp(_MockTapUpInfo());
 
           await game.ready();
 
@@ -598,7 +600,7 @@ void main() {
 
           final facebookButton =
               game.descendants().whereType<TwitterButtonComponent>().first;
-          facebookButton.onTapDown(_MockTapDownInfo());
+          facebookButton.onTapUp(_MockTapUpInfo());
 
           await game.ready();
 
diff --git a/test/game/components/backbox/displays/game_over_info_display_test.dart b/test/game/components/backbox/displays/game_over_info_display_test.dart
index 6b79d9fd..2bee4005 100644
--- a/test/game/components/backbox/displays/game_over_info_display_test.dart
+++ b/test/game/components/backbox/displays/game_over_info_display_test.dart
@@ -68,6 +68,8 @@ class _MockAppLocalizations extends Mock implements AppLocalizations {
 
 class _MockTapDownInfo extends Mock implements TapDownInfo {}
 
+class _MockTapUpInfo extends Mock implements TapUpInfo {}
+
 class _MockUrlLauncher extends Mock
     with MockPlatformInterfaceMixin
     implements UrlLauncherPlatform {}
@@ -135,7 +137,7 @@ void main() {
 
         final googleLink =
             component.descendants().whereType<GoogleIOLinkComponent>().first;
-        googleLink.onTapDown(_MockTapDownInfo());
+        googleLink.onTapUp(_MockTapUpInfo());
 
         await game.ready();
 
diff --git a/test/game/components/backbox/displays/share_display_test.dart b/test/game/components/backbox/displays/share_display_test.dart
index 1f882223..ddcb4001 100644
--- a/test/game/components/backbox/displays/share_display_test.dart
+++ b/test/game/components/backbox/displays/share_display_test.dart
@@ -52,7 +52,7 @@ class _MockAppLocalizations extends Mock implements AppLocalizations {
   String get socialMediaAccount => '';
 }
 
-class _MockTapDownInfo extends Mock implements TapDownInfo {}
+class _MockTapUpInfo extends Mock implements TapUpInfo {}
 
 void main() {
   TestWidgetsFlutterBinding.ensureInitialized();
@@ -74,7 +74,7 @@ void main() {
       (game) async {
         var tapped = false;
 
-        final tapDownInfo = _MockTapDownInfo();
+        final tapUpInfo = _MockTapUpInfo();
         final component = ShareDisplay(
           onShare: (_) => tapped = true,
         );
@@ -83,7 +83,7 @@ void main() {
         final facebookButton =
             component.descendants().whereType<FacebookButtonComponent>().first;
 
-        facebookButton.onTapDown(tapDownInfo);
+        facebookButton.onTapUp(tapUpInfo);
 
         expect(tapped, isTrue);
       },
@@ -94,7 +94,7 @@ void main() {
       (game) async {
         var tapped = false;
 
-        final tapDownInfo = _MockTapDownInfo();
+        final tapUpInfo = _MockTapUpInfo();
         final component = ShareDisplay(
           onShare: (_) => tapped = true,
         );
@@ -103,7 +103,7 @@ void main() {
         final twitterButton =
             component.descendants().whereType<TwitterButtonComponent>().first;
 
-        twitterButton.onTapDown(tapDownInfo);
+        twitterButton.onTapUp(tapUpInfo);
 
         expect(tapped, isTrue);
       },