feat: PR suggestions

pull/308/head
Erick Zanardo 3 years ago
parent ab6288042c
commit 7e93f320c6

@ -57,7 +57,7 @@ Future<void> showHowToPlayDialog(BuildContext context) {
context: context, context: context,
builder: (_) => HowToPlayDialog(), builder: (_) => HowToPlayDialog(),
).then((_) { ).then((_) {
audio.startScreenSelect(); audio.ioPinballVoiceOver();
}); });
} }

@ -15,8 +15,8 @@ class $AssetsSfxGen {
const $AssetsSfxGen(); const $AssetsSfxGen();
String get google => 'assets/sfx/google.mp3'; String get google => 'assets/sfx/google.mp3';
String get ioPinballVoiceOver => 'assets/sfx/io_pinball_voice_over.mp3';
String get plim => 'assets/sfx/plim.mp3'; String get plim => 'assets/sfx/plim.mp3';
String get startScreenSelect => 'assets/sfx/start_screen_select.mp3';
} }
class Assets { class Assets {

@ -74,7 +74,7 @@ class PinballAudio {
await Future.wait([ await Future.wait([
_preCacheSingleAudio(_prefixFile(Assets.sfx.google)), _preCacheSingleAudio(_prefixFile(Assets.sfx.google)),
_preCacheSingleAudio(_prefixFile(Assets.sfx.startScreenSelect)), _preCacheSingleAudio(_prefixFile(Assets.sfx.ioPinballVoiceOver)),
_preCacheSingleAudio(_prefixFile(Assets.music.background)), _preCacheSingleAudio(_prefixFile(Assets.music.background)),
]); ]);
} }
@ -90,8 +90,8 @@ class PinballAudio {
} }
/// Plays the select screen sound effect /// Plays the select screen sound effect
void startScreenSelect() { void ioPinballVoiceOver() {
_playSingleAudio(_prefixFile(Assets.sfx.startScreenSelect)); _playSingleAudio(_prefixFile(Assets.sfx.ioPinballVoiceOver));
} }
/// Plays the background music /// Plays the background music

@ -127,7 +127,7 @@ void main() {
).called(1); ).called(1);
verify( verify(
() => preCacheSingleAudio.onCall( () => preCacheSingleAudio.onCall(
'packages/pinball_audio/assets/sfx/start_screen_select.mp3', 'packages/pinball_audio/assets/sfx/io_pinball_voice_over.mp3',
), ),
).called(1); ).called(1);
verify( verify(
@ -168,14 +168,14 @@ void main() {
}); });
}); });
group('startScreenSelect', () { group('ioPinballVoiceOver', () {
test('plays the correct file', () async { test('plays the correct file', () async {
await audio.load(); await audio.load();
audio.startScreenSelect(); audio.ioPinballVoiceOver();
verify( verify(
() => playSingleAudio () => playSingleAudio.onCall(
.onCall('packages/pinball_audio/${Assets.sfx.startScreenSelect}'), 'packages/pinball_audio/${Assets.sfx.ioPinballVoiceOver}'),
).called(1); ).called(1);
}); });
}); });

@ -118,7 +118,7 @@ void main() {
await tester.tapAt(Offset.zero); await tester.tapAt(Offset.zero);
await tester.pumpAndSettle(); await tester.pumpAndSettle();
verify(audio.startScreenSelect).called(1); verify(audio.ioPinballVoiceOver).called(1);
}, },
); );
}); });

Loading…
Cancel
Save