From 7e93f320c6f95939ecbaf0c829e966151216b4e8 Mon Sep 17 00:00:00 2001
From: Erick Zanardo <erickzanardoo@gmail.com>
Date: Tue, 3 May 2022 13:20:41 -0300
Subject: [PATCH] feat: PR suggestions

---
 lib/how_to_play/widgets/how_to_play_dialog.dart     |   2 +-
 ..._screen_select.mp3 => io_pinball_voice_over.mp3} | Bin
 packages/pinball_audio/lib/gen/assets.gen.dart      |   2 +-
 packages/pinball_audio/lib/src/pinball_audio.dart   |   6 +++---
 .../pinball_audio/test/src/pinball_audio_test.dart  |  10 +++++-----
 test/how_to_play/how_to_play_dialog_test.dart       |   2 +-
 6 files changed, 11 insertions(+), 11 deletions(-)
 rename packages/pinball_audio/assets/sfx/{start_screen_select.mp3 => io_pinball_voice_over.mp3} (100%)

diff --git a/lib/how_to_play/widgets/how_to_play_dialog.dart b/lib/how_to_play/widgets/how_to_play_dialog.dart
index f1b848f8..e91698f5 100644
--- a/lib/how_to_play/widgets/how_to_play_dialog.dart
+++ b/lib/how_to_play/widgets/how_to_play_dialog.dart
@@ -57,7 +57,7 @@ Future<void> showHowToPlayDialog(BuildContext context) {
     context: context,
     builder: (_) => HowToPlayDialog(),
   ).then((_) {
-    audio.startScreenSelect();
+    audio.ioPinballVoiceOver();
   });
 }
 
diff --git a/packages/pinball_audio/assets/sfx/start_screen_select.mp3 b/packages/pinball_audio/assets/sfx/io_pinball_voice_over.mp3
similarity index 100%
rename from packages/pinball_audio/assets/sfx/start_screen_select.mp3
rename to packages/pinball_audio/assets/sfx/io_pinball_voice_over.mp3
diff --git a/packages/pinball_audio/lib/gen/assets.gen.dart b/packages/pinball_audio/lib/gen/assets.gen.dart
index da96b5c8..0f68e170 100644
--- a/packages/pinball_audio/lib/gen/assets.gen.dart
+++ b/packages/pinball_audio/lib/gen/assets.gen.dart
@@ -15,8 +15,8 @@ class $AssetsSfxGen {
   const $AssetsSfxGen();
 
   String get google => 'assets/sfx/google.mp3';
+  String get ioPinballVoiceOver => 'assets/sfx/io_pinball_voice_over.mp3';
   String get plim => 'assets/sfx/plim.mp3';
-  String get startScreenSelect => 'assets/sfx/start_screen_select.mp3';
 }
 
 class Assets {
diff --git a/packages/pinball_audio/lib/src/pinball_audio.dart b/packages/pinball_audio/lib/src/pinball_audio.dart
index 92ee01a8..6a02f27f 100644
--- a/packages/pinball_audio/lib/src/pinball_audio.dart
+++ b/packages/pinball_audio/lib/src/pinball_audio.dart
@@ -74,7 +74,7 @@ class PinballAudio {
 
     await Future.wait([
       _preCacheSingleAudio(_prefixFile(Assets.sfx.google)),
-      _preCacheSingleAudio(_prefixFile(Assets.sfx.startScreenSelect)),
+      _preCacheSingleAudio(_prefixFile(Assets.sfx.ioPinballVoiceOver)),
       _preCacheSingleAudio(_prefixFile(Assets.music.background)),
     ]);
   }
@@ -90,8 +90,8 @@ class PinballAudio {
   }
 
   /// Plays the select screen sound effect
-  void startScreenSelect() {
-    _playSingleAudio(_prefixFile(Assets.sfx.startScreenSelect));
+  void ioPinballVoiceOver() {
+    _playSingleAudio(_prefixFile(Assets.sfx.ioPinballVoiceOver));
   }
 
   /// Plays the background music
diff --git a/packages/pinball_audio/test/src/pinball_audio_test.dart b/packages/pinball_audio/test/src/pinball_audio_test.dart
index 972908e0..0cb632db 100644
--- a/packages/pinball_audio/test/src/pinball_audio_test.dart
+++ b/packages/pinball_audio/test/src/pinball_audio_test.dart
@@ -127,7 +127,7 @@ void main() {
         ).called(1);
         verify(
           () => preCacheSingleAudio.onCall(
-            'packages/pinball_audio/assets/sfx/start_screen_select.mp3',
+            'packages/pinball_audio/assets/sfx/io_pinball_voice_over.mp3',
           ),
         ).called(1);
         verify(
@@ -168,14 +168,14 @@ void main() {
       });
     });
 
-    group('startScreenSelect', () {
+    group('ioPinballVoiceOver', () {
       test('plays the correct file', () async {
         await audio.load();
-        audio.startScreenSelect();
+        audio.ioPinballVoiceOver();
 
         verify(
-          () => playSingleAudio
-              .onCall('packages/pinball_audio/${Assets.sfx.startScreenSelect}'),
+          () => playSingleAudio.onCall(
+              'packages/pinball_audio/${Assets.sfx.ioPinballVoiceOver}'),
         ).called(1);
       });
     });
diff --git a/test/how_to_play/how_to_play_dialog_test.dart b/test/how_to_play/how_to_play_dialog_test.dart
index 5c01c723..c1ff1d33 100644
--- a/test/how_to_play/how_to_play_dialog_test.dart
+++ b/test/how_to_play/how_to_play_dialog_test.dart
@@ -118,7 +118,7 @@ void main() {
 
         await tester.tapAt(Offset.zero);
         await tester.pumpAndSettle();
-        verify(audio.startScreenSelect).called(1);
+        verify(audio.ioPinballVoiceOver).called(1);
       },
     );
   });