Merge branch 'main' into refactor/left-boundary-curve

pull/238/head
Allison Ryan 3 years ago committed by GitHub
commit 5882c01ca2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -1,5 +1,9 @@
name: geometry name: geometry
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on: on:
push: push:
paths: paths:

@ -1,5 +1,9 @@
name: leaderboard_repository name: leaderboard_repository
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on: on:
push: push:
paths: paths:

@ -1,5 +1,9 @@
name: pinball name: pinball
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on: [pull_request, push] on: [pull_request, push]
jobs: jobs:

@ -1,5 +1,9 @@
name: pinball_audio name: pinball_audio
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on: on:
push: push:
paths: paths:

@ -1,5 +1,9 @@
name: pinball_components name: pinball_components
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on: on:
push: push:
paths: paths:

@ -1,5 +1,9 @@
name: pinball_flame name: pinball_flame
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on: on:
push: push:
paths: paths:

@ -1,5 +1,9 @@
name: pinball_theme name: pinball_theme
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on: on:
push: push:
paths: paths:

@ -114,9 +114,6 @@ class PinballGameLoadedView extends StatelessWidget {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
final isPlaying = context.select(
(StartGameBloc bloc) => bloc.state.status == StartGameStatus.play,
);
final gameWidgetWidth = MediaQuery.of(context).size.height * 9 / 16; final gameWidgetWidth = MediaQuery.of(context).size.height * 9 / 16;
final screenWidth = MediaQuery.of(context).size.width; final screenWidth = MediaQuery.of(context).size.width;
final leftMargin = (screenWidth / 2) - (gameWidgetWidth / 1.8); final leftMargin = (screenWidth / 2) - (gameWidgetWidth / 1.8);
@ -139,14 +136,13 @@ class PinballGameLoadedView extends StatelessWidget {
}, },
), ),
), ),
// TODO(arturplaczek): add Visibility to GameHud based on StartGameBloc
// status
Positioned( Positioned(
top: 16, top: 16,
left: leftMargin, left: leftMargin,
child: Visibility(
visible: isPlaying,
child: const GameHud(), child: const GameHud(),
), ),
),
], ],
); );
} }

@ -198,10 +198,12 @@ void main() {
find.byWidgetPredicate((w) => w is GameWidget<PinballGame>), find.byWidgetPredicate((w) => w is GameWidget<PinballGame>),
findsOneWidget, findsOneWidget,
); );
expect( // TODO(arturplaczek): add Visibility to GameHud based on StartGameBloc
find.byType(GameHud), // status
findsNothing, // expect(
); // find.byType(GameHud),
// findsNothing,
// );
}); });
testWidgets('renders a hud on play state', (tester) async { testWidgets('renders a hud on play state', (tester) async {

Loading…
Cancel
Save