diff --git a/.github/workflows/geometry.yaml b/.github/workflows/geometry.yaml index 8bf55107..ccd41914 100644 --- a/.github/workflows/geometry.yaml +++ b/.github/workflows/geometry.yaml @@ -1,5 +1,9 @@ name: geometry +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: push: paths: diff --git a/.github/workflows/leaderboard_repository.yaml b/.github/workflows/leaderboard_repository.yaml index 6eddf283..327f70b3 100644 --- a/.github/workflows/leaderboard_repository.yaml +++ b/.github/workflows/leaderboard_repository.yaml @@ -1,5 +1,9 @@ name: leaderboard_repository +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: push: paths: diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index f3e3fd99..8ed906a2 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -1,5 +1,9 @@ name: pinball +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: [pull_request, push] jobs: diff --git a/.github/workflows/pinball_audio.yaml b/.github/workflows/pinball_audio.yaml index 7a43413a..6ba3adde 100644 --- a/.github/workflows/pinball_audio.yaml +++ b/.github/workflows/pinball_audio.yaml @@ -1,5 +1,9 @@ name: pinball_audio +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: push: paths: diff --git a/.github/workflows/pinball_components.yaml b/.github/workflows/pinball_components.yaml index d75553f5..19f13044 100644 --- a/.github/workflows/pinball_components.yaml +++ b/.github/workflows/pinball_components.yaml @@ -1,5 +1,9 @@ name: pinball_components +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: push: paths: diff --git a/.github/workflows/pinball_flame.yaml b/.github/workflows/pinball_flame.yaml index 2263bb5a..297b792e 100644 --- a/.github/workflows/pinball_flame.yaml +++ b/.github/workflows/pinball_flame.yaml @@ -1,5 +1,9 @@ name: pinball_flame +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: push: paths: diff --git a/.github/workflows/pinball_theme.yaml b/.github/workflows/pinball_theme.yaml index 83206de5..15280761 100644 --- a/.github/workflows/pinball_theme.yaml +++ b/.github/workflows/pinball_theme.yaml @@ -1,5 +1,9 @@ name: pinball_theme +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: push: paths: diff --git a/lib/game/view/pinball_game_page.dart b/lib/game/view/pinball_game_page.dart index 2515dd19..be11a15c 100644 --- a/lib/game/view/pinball_game_page.dart +++ b/lib/game/view/pinball_game_page.dart @@ -114,9 +114,6 @@ class PinballGameLoadedView extends StatelessWidget { @override Widget build(BuildContext context) { - final isPlaying = context.select( - (StartGameBloc bloc) => bloc.state.status == StartGameStatus.play, - ); final gameWidgetWidth = MediaQuery.of(context).size.height * 9 / 16; final screenWidth = MediaQuery.of(context).size.width; final leftMargin = (screenWidth / 2) - (gameWidgetWidth / 1.8); @@ -139,13 +136,12 @@ class PinballGameLoadedView extends StatelessWidget { }, ), ), + // TODO(arturplaczek): add Visibility to GameHud based on StartGameBloc + // status Positioned( top: 16, left: leftMargin, - child: Visibility( - visible: isPlaying, - child: const GameHud(), - ), + child: const GameHud(), ), ], ); diff --git a/test/game/view/pinball_game_page_test.dart b/test/game/view/pinball_game_page_test.dart index 191d3676..f8b62d05 100644 --- a/test/game/view/pinball_game_page_test.dart +++ b/test/game/view/pinball_game_page_test.dart @@ -198,10 +198,12 @@ void main() { find.byWidgetPredicate((w) => w is GameWidget), findsOneWidget, ); - expect( - find.byType(GameHud), - findsNothing, - ); + // TODO(arturplaczek): add Visibility to GameHud based on StartGameBloc + // status + // expect( + // find.byType(GameHud), + // findsNothing, + // ); }); testWidgets('renders a hud on play state', (tester) async {