chore: fixed spaces between methods and other comments from pr

pull/40/head
RuiAlonso 4 years ago
parent c1d176195b
commit 1899a7e942

@ -9,6 +9,11 @@ import 'package:pinball/game/game.dart';
class Ball extends BodyComponent<PinballGame> with InitialPosition, Layered { class Ball extends BodyComponent<PinballGame> with InitialPosition, Layered {
/// {@macro ball} /// {@macro ball}
Ball() { Ball() {
// TODO(ruimiguel): while developing Ball can be launched by clicking mouse,
//and default layer is Layer.all. But on final game Ball will be always be
//be launched from Plunger and LauncherRamp will modify it to Layer.board.
//We need to see what happens if Ball appears from other place like nest
//bumper, it will need to explicit change layer to Layer.board then.
layer = Layer.board; layer = Layer.board;
} }

@ -1,4 +1,5 @@
// ignore_for_file: avoid_renaming_method_parameters // ignore_for_file: avoid_renaming_method_parameters
import 'package:flame_forge2d/flame_forge2d.dart'; import 'package:flame_forge2d/flame_forge2d.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:pinball/game/game.dart'; import 'package:pinball/game/game.dart';

@ -72,13 +72,14 @@ void main() {
); );
flameTester.test( flameTester.test(
'has all as default filter maskBits', 'has Layer.all as default filter maskBits',
(game) async { (game) async {
final ball = Ball(); final ball = Ball();
await game.ensureAdd(ball); await game.ensureAdd(ball);
await ball.mounted;
final fixture = ball.body.fixtures[0]; final fixture = ball.body.fixtures[0];
expect(fixture.filterData.maskBits, equals(Layer.all.maskBits)); expect(fixture.filterData.maskBits, equals(Layer.board.maskBits));
}, },
); );
}); });
@ -149,29 +150,5 @@ void main() {
}, },
); );
}); });
group('setLayer', () {
final flameTester = FlameTester(PinballGameTest.create);
flameTester.test(
'modifies layer correctly',
(game) async {
const newLayer = Layer.jetpack;
final ball = Ball();
await game.ensureAdd(ball);
final fixture = ball.body.fixtures[0];
expect(fixture.filterData.categoryBits, equals(1));
expect(fixture.filterData.maskBits, equals(Layer.all.maskBits));
ball.layer = newLayer;
expect(fixture.filterData.categoryBits, equals(newLayer.maskBits));
expect(fixture.filterData.maskBits, equals(newLayer.maskBits));
},
);
});
}); });
} }

@ -16,6 +16,7 @@ class TestBodyComponent extends BodyComponent with Layered {
void main() { void main() {
final flameTester = FlameTester(Forge2DGame.new); final flameTester = FlameTester(Forge2DGame.new);
group('Layered', () { group('Layered', () {
void _expectLayerOnFixtures({ void _expectLayerOnFixtures({
required List<Fixture> fixtures, required List<Fixture> fixtures,

@ -10,7 +10,7 @@ import '../../helpers/helpers.dart';
void main() { void main() {
TestWidgetsFlutterBinding.ensureInitialized(); TestWidgetsFlutterBinding.ensureInitialized();
final flameTester = FlameTester(PinballGameTest.create); final flameTester = FlameTester(Forge2DGame.new);
group('Pathway', () { group('Pathway', () {
const width = 50.0; const width = 50.0;

@ -67,7 +67,7 @@ void main() {
}, },
); );
group('fixture', () { group('first fixture', () {
const pathwayLayer = Layer.jetpack; const pathwayLayer = Layer.jetpack;
const openingLayer = Layer.opening; const openingLayer = Layer.opening;

Loading…
Cancel
Save