917822cfca
refactor: remove unused err from pkg/registry/client.go
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
b9eadd3186
chore: fix some comment format
...
Signed-off-by: wyrapeseed <wyrapeseed@outlook.com>
8 months ago
7097c8e2e5
Replicate as unit test case where we fail once a resource deletion
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
054eabddd7
Return errors on upgrade when deletion fails
...
This is a rebase of https://github.com/helm/helm/pull/12299
as the pull request was tagged for Helm v4.
Closes: https://github.com/helm/helm/issues/11375
Related: https://github.com/helm/helm/pull/7929
It was a pain to reproduce, here is a script:
```
set -u
NS=default
RELEASE=test-release
CHART=./test-chart
SA=limited-helm-sa
HELM=${HELM:-./bin/helm}
echo "Helm: $($HELM version)"
echo "Cleaning…"
$HELM uninstall "$RELEASE" -n "$NS" >/dev/null 2>&1 || true
kubectl -n "$NS" delete sa "$SA" role "${SA}-role" rolebinding "${SA}-rb" >/dev/null 2>&1 || true
kubectl -n "$NS" delete cronjob "$RELEASE-test-chart-cronjob" >/dev/null 2>&1 || true
rm -rf "$CHART" /tmp/limited-helm-kubeconfig
echo "Create minimal chart with only a CronJob"
$HELM create "$CHART" >/dev/null
rm -f "$CHART"/templates/{deployment.yaml,service.yaml,hpa.yaml,tests/test-connection.yaml,serviceaccount.yaml}
cat > "$CHART/templates/cronjob.yaml" <<'YAML'
apiVersion: batch/v1
kind: CronJob
metadata:
name: {{ include "test-chart.fullname" . }}-cronjob
spec:
schedule: "*/5 * * * *"
jobTemplate:
spec:
template:
spec:
restartPolicy: OnFailure
containers:
- name: hello
image: busybox
command: ["/bin/sh","-c","date; echo Hello from CronJob"]
YAML
echo "RBAC: allow Helm storage, basic reads/creates, but NO delete on cronjobs"
kubectl -n "$NS" apply -f - >/dev/null <<EOF
apiVersion: v1
kind: ServiceAccount
metadata:
name: $SA
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: ${SA}-role
rules:
- apiGroups: [""]
resources: ["secrets","configmaps"]
verbs: ["get","list","watch","create","patch","update","delete"]
- apiGroups: [""]
resources: ["pods","events"]
verbs: ["get","list","watch"]
- apiGroups: ["batch"]
resources: ["cronjobs"]
verbs: ["get","list","watch","create","patch","update"]
EOF
kubectl -n "$NS" apply -f - >/dev/null <<EOF
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: ${SA}-rb
subjects:
- kind: ServiceAccount
name: $SA
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
name: ${SA}-role
EOF
echo "Create kubeconfig for that SA"
TOKEN=$(kubectl -n "$NS" create token "$SA")
SERVER=$(kubectl config view --minify -o jsonpath='{.clusters[0].cluster.server}')
CA_DATA=$(kubectl config view --minify --raw -o jsonpath='{.clusters[0].cluster.certificate-authority-data}')
KCFG=/tmp/limited-helm-kubeconfig
cat > "$KCFG" <<EOF
apiVersion: v1
kind: Config
clusters:
- name: local
cluster:
server: $SERVER
certificate-authority-data: $CA_DATA
contexts:
- name: limited
context:
cluster: local
namespace: $NS
user: $SA
current-context: limited
users:
- name: $SA
user:
token: $TOKEN
EOF
set +e
echo "Install (as limited SA)"
KUBECONFIG="$KCFG" $HELM upgrade --install "$RELEASE" "$CHART" -n "$NS" --wait
echo "CronJob after install:"
kubectl -n "$NS" get cronjob "$RELEASE-test-chart-cronjob" || true
echo "Remove CronJob from chart and add a small ConfigMap to force an upgrade"
rm -f "$CHART/templates/cronjob.yaml"
cat > "$CHART/templates/configmap.yaml" <<'YAML'
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ include "test-chart.fullname" . }}-config
data:
hello: world
YAML
echo "Upgrade without CronJob (as limited SA)"
KUBECONFIG="$KCFG" $HELM upgrade --install "$RELEASE" "$CHART" -n "$NS"
RC=$?
echo "Post-upgrade verification"
if kubectl -n "$NS" get cronjob "$RELEASE-test-chart-cronjob" >/dev/null 2>&1; then
echo "OK: Stale CronJob still present: $RELEASE-test-chart-cronjob"
else
echo "NO_OK: CronJob deleted"
fi
echo "Helm exit code: $RC"
exit 0
```
With the current build:
```sh
./reproduce-helm-issue.sh
Helm: version.BuildInfo{Version:"v4.0+unreleased", GitCommit:"f19bb9cd4c99943f7a4980d6670de44affe3e472", GitTreeState:"dirty", GoVersion:"go1.24.0"}
Cleaning…
Create minimal chart with CronJob + ConfigMap (we will remove both in v2)
RBAC: allow Helm storage + delete for configmaps, but NO delete on cronjobs
Create kubeconfig for that SA
Install v1 (as limited SA)
Release "test-release" does not exist. Installing it now.
NAME: test-release
LAST DEPLOYED: Tue Oct 14 18:55:57 2025
NAMESPACE: default
STATUS: deployed
REVISION: 1
DESCRIPTION: Install complete
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=test-chart,app.kubernetes.io/instance=test-release" -o jsonpath="{.items[0].metadata.name}")
export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
echo "Visit http://127.0.0.1:8080 to use your application"
kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT
Verify v1 objects exist
NAME SCHEDULE TIMEZONE SUSPEND ACTIVE LAST SCHEDULE AGE
test-release-test-chart-cronjob */5 * * * * <none> False 0 <none> 0s
NAME DATA AGE
test-release-test-chart-config 1 0s
Prepare v2: remove BOTH CronJob and ConfigMap from the chart
Upgrade to v2 (as limited SA) — expecting CronJob delete first, then ConfigMap
- CronJob delete should FAIL (no delete permission)
- ConfigMap delete should SUCCEED (delete allowed) — proves 'continue on error' and inverted order
level=DEBUG msg="getting history for release" release=test-release
level=DEBUG msg="getting release history" name=test-release
level=DEBUG msg="preparing upgrade" name=test-release
level=DEBUG msg="getting last revision" name=test-release
level=DEBUG msg="getting release history" name=test-release
level=DEBUG msg="number of dependencies in the chart" dependencies=0
level=DEBUG msg="determined release apply method" server_side_apply=true previous_release_apply_method=ssa
level=DEBUG msg="performing update" name=test-release
level=DEBUG msg="creating upgraded release" name=test-release
level=DEBUG msg="creating release" key=sh.helm.release.v1.test-release.v2
level=DEBUG msg="getting release history" name=test-release
level=DEBUG msg="using server-side apply for resource update" forceConflicts=false dryRun=false fieldValidationDirective=Strict upgradeClientSideFieldManager=false
level=DEBUG msg="checking resources for changes" resources=0
level=DEBUG msg="deleting resource" namespace=default name=test-release-test-chart-config kind=ConfigMap
level=DEBUG msg="deleting resource" namespace=default name=test-release-test-chart-cronjob kind=CronJob
level=DEBUG msg="failed to delete resource" namespace=default name=test-release-test-chart-cronjob kind=CronJob error="cronjobs.batch \"test-release-test-chart-cronjob\" is forbidden: User \"system:serviceaccount:default:limited-helm-sa\" cannot delete resource \"cronjobs\" in API group \"batch\" in the namespace \"default\""
level=INFO msg="update completed" created=0 updated=0 deleted=1
level=WARN msg="update completed with errors" errors=1
level=DEBUG msg="updating release" key=sh.helm.release.v1.test-release.v1
level=WARN msg="upgrade failed" name=test-release error="failed to delete resource test-release-test-chart-cronjob: cronjobs.batch \"test-release-test-chart-cronjob\" is forbidden: User \"system:serviceaccount:default:limited-helm-sa\" cannot delete resource \"cronjobs\" in API group \"batch\" in the namespace \"default\""
level=DEBUG msg="updating release" key=sh.helm.release.v1.test-release.v2
Error: UPGRADE FAILED: failed to delete resource test-release-test-chart-cronjob: cronjobs.batch "test-release-test-chart-cronjob" is forbidden: User "system:serviceaccount:default:limited-helm-sa" cannot delete resource "cronjobs" in API group "batch" in the namespace "default"
Post-upgrade verification
Stale CronJob still present: test-release-test-chart-cronjob (expected if delete is forbidden)
ConfigMap deleted as expected: test-release-test-chart-config (and after CronJob attempt)
Helm exit code: 1
```
With last version v3.19:
```
HELM=/usr/local/bin/helm ./reproduce-helm-issue.sh
Helm: version.BuildInfo{Version:"v3.19.0", GitCommit:"3d8990f0836691f0229297773f3524598f46bda6", GitTreeState:"clean", GoVersion:"go1.24.7"}
Cleaning…
Create minimal chart with only a CronJob
RBAC: allow Helm storage, basic reads/creates, but NO delete on cronjobs
Create kubeconfig for that SA
Install (as limited SA)
Release "test-release" does not exist. Installing it now.
NAME: test-release
LAST DEPLOYED: Tue Oct 14 19:07:01 2025
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=test-chart,app.kubernetes.io/instance=test-release" -o jsonpath="{.items[0].metadata.name}")
export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
echo "Visit http://127.0.0.1:8080 to use your application"
kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT
CronJob after install:
NAME SCHEDULE TIMEZONE SUSPEND ACTIVE LAST SCHEDULE AGE
test-release-test-chart-cronjob */5 * * * * <none> False 0 <none> 0s
Remove CronJob from chart and add a small ConfigMap to force an upgrade
Upgrade without CronJob (as limited SA)
Release "test-release" has been upgraded. Happy Helming!
NAME: test-release
LAST DEPLOYED: Tue Oct 14 19:07:01 2025
NAMESPACE: default
STATUS: deployed
REVISION: 2
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=test-chart,app.kubernetes.io/instance=test-release" -o jsonpath="{.items[0].metadata.name}")
export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
echo "Visit http://127.0.0.1:8080 to use your application"
kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT
Post-upgrade verification
OK: Stale CronJob still present: test-release-test-chart-cronjob
Helm exit code: 0
```
Co-authored-by: dayeguilaiye <979014041@qq.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
3b2fd17799
chore: rename test registry
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
379b0899b3
fix: increase helm list test coverage
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
7dd2484aed
Merge pull request #31295 from TerryHowe/fix-make-helm-list-show-all-by-default
...
Fix make helm list show all by default
8 months ago
f0530309f0
Merge pull request #31302 from TerryHowe/fix-helm-verify-signature
...
fix: helm verify Run signature
8 months ago
f9d4373ea4
Merge pull request #31270 from TerryHowe/chore-registry-clean-up
...
chore: registry utils clean up
8 months ago
abdf6603c0
fix test for rebase
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
a03e8c9541
Merge pull request #31375 from TerryHowe/fix-release-info-time
...
fix: release info time parsing
8 months ago
f6e60138e8
Update pkg/cmd/list.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
c3aa5c51e6
chore: clean up for comments
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
b4f932a715
Fix test by making date sorting stable and updating golden files
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
8a73d97984
fix: make helm list show all by default
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
269a32a6d2
test: protect unknown hook delete policies
...
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
8 months ago
9cd40c612a
Avoid accessing .Items on nil object
...
When listing fails for whatever reason, the return value is nil, err.
so handle err explicitly.
Signed-off-by: Dirk Müller <dirk@dmllr.de>
8 months ago
06188f9dfe
Add test for isYamlFileExtension functions
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
20eb6e9b04
fix: empty time values
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
fbf02e494e
Merge pull request #30980 from gjenkins8/gjenkins/cleanup_kubeclient_interfaces
...
cleanup: Remove/consolidate redundant kube client Interfaces
8 months ago
78cd44bd75
Merge pull request #30712 from gjenkins8/gjenkins/cleanup_lint_template
...
cleanup: Remove extra lint/rules.Template functions
8 months ago
24159ec8b6
Moving new default accessor functions to internal per feedback
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
fb20e96a56
Adding a test/example for the release accessor
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
ab6e7fa58b
Removing debug statement
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
a229bf6529
Ensure the release interface is used in actions instead of the type
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
9c958dec76
Making uninstall response generic
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
f80cbe43d0
Moved release objects to enable versioning
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
2247a0074b
Move all the get commands to the new release interface
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
94bfe9ba12
Move action get metadata to chart interfaces
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
4a944230ea
Do not ignore *.yml file on linting while accepting *.yaml
...
From : https://github.com/helm/helm/pull/30712/files#r2417446037
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
4877e2d7e9
Merge pull request #30833 from gjenkins8/gjenkins/refactor_dry_run_flag
...
refactor/cleanup: Replace action 'DryRun' string with DryRunStrategy type + deprecations
8 months ago
c75026c318
doc string
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
8 months ago
1581eaa034
Apply suggestions from code review
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
8 months ago
b861de5696
Update pkg/kube/interface.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
8 months ago
600eb487f1
Merge pull request #31349 from TerryHowe/fix-shuffle-lint-test
...
fix: flakey lint test on shuffle
8 months ago
788087a821
Merge pull request #31326 from TerryHowe/sign-31181
...
Update sign tests to use testify
8 months ago
acb1b2c651
Merge pull request #31354 from TerryHowe/fix-flake-upgrade-test
...
fix: flake upgrade test
8 months ago
0adfe83ff8
Merge pull request #31227 from evankanderson/windows-filepath
...
Use filepath.Path when handling directory names
8 months ago
9590d4214a
Merge pull request #31307 from TerryHowe/fix-ignore-local-path-when-repo-provided
...
fix: Ignore absolute path when RepoUrl is provided
8 months ago
a24318c7f1
fix: flake upgrade test
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
7761d937ca
testfix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
8 months ago
a7a6a5e3b0
Merge pull request #31312 from gjenkins8/gjenkins/rm_plugin_schema_settings
...
Remove unused 'Settings' from plugin schema
8 months ago
ee322a9671
fix: flakey lint test on shuffle
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
bee9c1a108
chore: replace github.com/mitchellh/copystructure
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
472f8b2628
Fixing rollback and uninstall client WaitStrategy.
...
Signed-off-by: Rachel Weber <rawo@microsoft.com>
8 months ago
61e3d95a94
Merge pull request #31143 from TerryHowe/fix-remove-redundant-error-check
...
fix: remove redundant error check
8 months ago
f9152dc048
chore: update sign tests to use testify
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
900cf2a93d
Merge pull request #31320 from kosiew/sign-31181
...
provenance: allow RSA signing when ed25519 keys are present (switch to ProtonMail/go-crypto)
8 months ago
9c7bf37c6f
fix: Ignore absolute path when RepoUrl is provided
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Mohammad Forutan <mforutan@users.noreply.github.com>
8 months ago
cf811bb11f
chore: registry utils clean up
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
69dbd6115e
chore: fix some typos in comment
...
Signed-off-by: juejinyuxitu <juejinyuxitu@outlook.com>
8 months ago
1c8d5804e2
Refactor SQL tests to use recentUnixTimestamp for time arguments
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
8 months ago
0b5d8033b9
Add Ed25519 key presence check in mixed keyring signing test
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
8 months ago
7c9176ae35
Update dependencies and refactor crypto imports to use ProtonMail's go-crypto package
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
8 months ago
23c5662019
Merge pull request #31254 from benoittgt/fix-31253-closest-version
...
Warn when we fallback to a different version on `helm pull`
8 months ago
561a7da61c
Merge pull request #31297 from TerryHowe/fix-hide-notes-in-helm-test
...
fix: hide notes in helm test command
8 months ago
efcb5735e5
cleanup: Remove extra lint/rules.Template functions
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
8 months ago
b5de5b1591
chore: Cleanup additional/redundant kube client Interfaces
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
8 months ago
f21b143bef
refactor: Replace action 'DryRun' string with DryRunStrategy type + deprecations
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
8 months ago
6bc6231bcc
Remove unused 'Settings' from plugin schema
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
8 months ago
5b43b744b8
Merge pull request #31294 from TerryHowe/feature-remove-implicit-directory-from-helm-lint
...
Remove implicit support for helm lint current directory
8 months ago
fdb5e1a97a
Merge pull request #31301 from TerryHowe/chore-remove-helm-version-client
...
chore: remove helm version `--client` option
8 months ago
d2236e95ed
Merge pull request #31303 from mattfarina/unified-loader
...
Update the action interfaces for chart apiversions
8 months ago
8dc7c57f50
Update the action interfaces for chart apiversions
...
This change is about handling the interfaces to public functions for
different chart apiVersions. The internals are still focused on v2.
This enables v3 to be layered in layer.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
020a8eccfd
fix: helm verify run signature
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
b24bfe4168
Merge branch 'main' into delete-unused-var
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
9 months ago
469f4b457c
chore: remove helm version client option
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
90a91e097f
Merge pull request #31198 from TerryHowe/fix-pkg-engine-error-parsing
...
fix: replace pkg/engine regular expressions with parser
9 months ago
da595e0e71
Merge pull request #31293 from TerryHowe/copilot/fix-8
...
chore: remove pkg/time which is no longer needed
9 months ago
dab4fd2909
fix: hide notes in helm test command
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
838c36a0f6
Remove implicit support for helm lint current directory
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
3e1dd9a5dc
chore: remove pkg/time which is no longer needed
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
1c67fbf108
refactor: use strings.builder
...
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
9 months ago
ae4af69b9d
fix test
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
9 months ago
aaaa457f04
Merge branch 'main' into bug/index-concurrency
9 months ago
b2870379c8
Update pkg/engine/engine.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
91a65234ac
Update pkg/engine/engine.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
9112687a7e
Update pkg/engine/engine.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
6181e0a873
Make test scripts run without /bin/bash
...
The test scripts hardcoded #!/bin/bash while they are not really
requiring bash. Use the more portable #!/usr/bin/env sh instead, so that
they use the default shell.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
9 months ago
db50c37eda
remove metadata output on helm template
...
Signed-off-by: bennsimon <bennsimonotieno@gmail.com>
9 months ago
5534c01cdb
Merge pull request #31277 from benoittgt/31234-fix
...
Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10
9 months ago
20f4e1f12d
Use filepath.Path when handling directory names
...
Signed-off-by: Evan Anderson <evan.k.anderson@gmail.com>
9 months ago
99e5fce71a
Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10
...
Close : #31231
```
Error: cmd/helm/root.go:165:2: SA1019: flags.ParseErrorsWhitelist is deprecated: use [FlagSet.ParseErrorsAllowlist] instead. This field will be removed in a future release. (staticcheck)
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
1a06fe9901
Merge pull request #31275 from benoittgt/13414-v2
...
Extend --skip-schema-validation for lint command
9 months ago
072e2a689a
Extend --skip-schema-validation for lint command
...
When --skip-schema-validation is enabled, the lint command will now skip
JSON schema validation for values.yaml files, allowing charts with schema
validation errors to pass linting when the flag is used.
This addresses the gap where --skip-schema-validation only applied to
templates but not to values files, providing complete schema validation
bypass when needed.
Fixes : #13413
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
315b13334c
Merge pull request #31258 from StephanieHhnbrg/test-unreachable-client
...
Refactor unreachableKubeClient for testing into failingKubeClient
9 months ago
e19d9fb6ee
Refactor unreachableKubeClient for testing into failingKubeClient
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
9 months ago
939fff9cb9
Avoid "panic: interface conversion: interface {} is nil"
...
Closes : #31202
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
712cde4624
test: passes now
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
9 months ago
b060911075
refactor: break out into functions and draft tests
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
9 months ago
9e2d4680e1
Warn when we fallback to a different version on `helm pull`
...
Close: https://github.com/helm/helm/issues/31253
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
a645dfb7f8
fix:semverv2 lint test error message
...
Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>
9 months ago
78cf5470d1
Merge pull request #31199 from TerryHowe/fix-flaky-registry-data-race
...
fix: flaky registry data race on mockdns close
9 months ago
8602422b7a
Merge pull request #31064 from kamilswiec/main
...
lint: throw warning when chart version is not semverv2
9 months ago
50358d7ffd
Merge pull request #31200 from TerryHowe/fix-install-tests
...
fix: installer action goroutine count
9 months ago
8025a397e6
Ignore duplicated URN in logs
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
03bb62f63d
jsonschema: warn and ignore unresolved URN $ref to match v3.18.4
...
- v3.18.5 switched jsonschema and began resolving external $ref
at compile-time, exposing missing urn handling
(“no URLLoader registered for urn:…”).
- Add urn scheme loader and pluggable URNResolver. If unresolved, log
a warning and return a permissive true schema (back-compat).
- Apply to pkg/chart/v2 and internal/chart/v3 validators. Not sure about
that
Note: external URNs need AddResource/Resolver (the CLI uses --map for
this). Warning may appear twice since both validators run.
Another strategy could be to add the option to import more "external
schema" explicitly but it is another PR. Something similar to `--map`
from jsonschema package
(santhosh-tekuri/jsonschema@ed65924).
Close : #31170
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
fc22b6df31
Merge pull request #31222 from benoittgt/30987-ghcr-io
...
Prevent failing `helm push` on ghcr.io using standard GET auth token flow
9 months ago
191154640f
Merge pull request #31197 from tzchenxixi/main
...
chore: fix function name
9 months ago
38d1a7376f
fix: throw warning when chart version is not semverv2
...
Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>
9 months ago
618b14a772
Merge pull request #31225 from mattfarina/move-lint-to-chart
...
Move lint pkg to be part of each chart version
9 months ago
a8151ef4fe
Cleanup plugin config
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
9 months ago
ed6cab39c6
Merge pull request #31219 from gjenkins8/gjenkins/plugin-integration/rm_setup_plugin_env
9 months ago
9dcc49cbd5
Move lint pkg to be part of each chart version
...
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.
To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:
1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
provide access to its data via an interface. There is an
interface, factory, and implementation for each version of
chart.
3. Common packages were moved to a common and util packages.
Due to some package loops, there are 2 packages which may
get some consolidation in the future.
The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
52267ee74b
Move repo package to versioned directory
...
The repo package is internally versioned at v1. Repos were designed
to be versioned. This change moves it to a versioned directory the
same way other packages are now being handled.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
6f957f4922
Move the release util to the versioned directory
...
The release util package is directly related to the v1 of
releases and uses the v1 of releases.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
5926ec83dd
Remove SetupPluginEnv
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
9 months ago
665c5a1fc9
Merge pull request #31224 from gjenkins8/gjenkins/postrenderer_plugin_message_value
...
fix: Adjust PostRenderer plugin output to value
9 months ago
d99d732542
fix: Adjust PostRenderer plugin output to value
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
9 months ago
5595c0d005
Prevent failing helm push on ghcr.io using standard GET auth token flow
...
Fix GHCR auth by not forcing OAuth2 POST but also reset
ForceAttemptOAuth2 after login.
- Remove ForceAttemptOAuth2 in NewClient and only enable during Login
ping and always restore to false.
- Aligns with OCI Distribution auth (token via GET), avoiding GHCR 405
on POST /token.
- Some tests
Failures logs:
```sh
~/p/lifen/test/helm-f/quicktest ❯ ../../../helm/bin/helm push quicktest-0.1.0.tgz oci://ghcr.io/benoittgt/helm-charts --debug
level=DEBUG msg=HEAD id=0 url=https://ghcr.io/v2/benoittgt/helm-charts/quicktest/manifests/sha256:af359fd8fb968ec1097afbd6e8e1dac9ee130861082e54dc2340d0c019407873 header=" \"Accept\": \"application/vnd.docker.distribution.manifest.v2+json, application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.manifest.v1+json, application/vnd.oci.image.index.v1+json, application/vnd.oci.artifact.manifest.v1+json\"\n \"User-Agent\": \"Helm/4.0+unreleased\""
level=DEBUG msg=Resp id=0 status="401 Unauthorized" header=" \"Www-Authenticate\": \"Bearer realm=\\\"https://ghcr.io/token \\\",service=\\\"ghcr.io\\\",scope=\\\"repository:benoittgt/helm-charts/quicktest:pull\\\"\"\n \"Date\": \"Mon, 01 Sep 2025 13:56:35 GMT\"\n \"Content-Length\": \"73\"\n \"X-Github-Request-Id\": \"DC73:115F:2B40F2C:2BAB567:68B5A613\"\n \"Content-Type\": \"application/json\"" body=" Response body is empty"
level=DEBUG msg=POST id=1 url=https://ghcr.io/token header=" \"Content-Type\": \"application/x-www-form-urlencoded\"\n \"User-Agent\": \"Helm/4.0+unreleased\""
level=DEBUG msg=Resp id=1 status="405 Method Not Allowed" header=" \"Docker-Distribution-Api-Version\": \"registry/2.0\"\n \"Strict-Transport-Security\": \"max-age=63072000; includeSubDomains; preload\"\n \"Date\": \"Mon, 01 Sep 2025 13:56:35 GMT\"\n \"Content-Length\": \"78\"\n \"X-Github-Request-Id\": \"DC73:115F:2B40F75:2BAB5C2:68B5A613\"\n \"Content-Type\": \"application/json\"" body="{\"errors\":[{\"code\":\"UNSUPPORTED\",\"message\":\"The operation is unsupported.\"}]}\n"
Error: failed to perform "Exists" on destination: HEAD "https://ghcr.io/v2/benoittgt/helm-charts/quicktest/manifests/sha256:af359fd8fb968ec1097afbd6e8e1dac9ee130861082e54dc2340d0c019407873 ": POST "https://ghcr.io/token ": response status code 405: unsupported: The operation is unsupported.
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
89aca09e5e
chore: fix function name
...
Signed-off-by: tzchenxixi <tzchenxixi@icloud.com>
9 months ago
c35755a197
Remove legacy Command/Hooks from v1 Subprocess ( #23 )
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
9 months ago
591d863df5
Move Postrenderer to a plugin type
...
Fix/add back postrenderer args unit tests
Signed-off-by: Scott Rigby <scott@r6by.com>
9 months ago
e814ff3c38
Remove unnecessary file i/o operations from signing and verifying
...
Signed-off-by: Scott Rigby <scott@r6by.com>
9 months ago
9ea35da0d0
[HIP-0026] Plugin packaging, signing, and verification ( #31176 )
...
* Plugin packaging, signing and verification
Signed-off-by: Scott Rigby <scott@r6by.com>
* wrap keyring read error with more explicit message
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* skip unnecessary check
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Change behavior for installing plugin with missing .prov file (now warns and continues instead of failing)
Signed-off-by: Scott Rigby <scott@r6by.com>
* Add comprehensive plugin verification tests
- Test missing .prov files (warns but continues)
- Test invalid .prov file formats (fails verification)
- Test hash mismatches in .prov files (fails verification)
- Test .prov file access errors (fails appropriately)
- Test directory plugins don't support verification
- Test installation without verification enabled (succeeds)
- Test with valid .prov files (fails on empty keyring as expected)
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
b12cd28503
fix: installer action goroutine count
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
892e86182f
Merge pull request #31194 from gjenkins8/gjenkins/plugin-integration/wasm_runtime
...
[HIP-0026] Plugin extism/v1 runtime
9 months ago
80f659ce8b
Merge pull request #31178 from mattfarina/env-content-cache
...
Add content cache to helm env
9 months ago
8068578266
chore: delete unused var in installer.go
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
9 months ago
2658a00863
fix output message value
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
9 months ago
ce97a2449e
fix: move mockdns to packge level
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
6273f9b38e
fix: flaky registry data race on mockdns close
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
284bd980b6
fix: replace pkg/engine regular expressions with parser
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
b6545e903a
code review + bug fixes
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
9 months ago
934f761e08
Merge pull request #30812 from gjenkins8/gjenkins/chartrelease_server_side_apply
...
HIP-0023: Helm support server-side apply
9 months ago
fd41fdd9c9
New registry plugin func GetPluginName. Re-use regsitry.reference
...
Signed-off-by: Scott Rigby <scott@r6by.com>
9 months ago
7d22bb25fa
Plugin OCI installer
...
Signed-off-by: Scott Rigby <scott@r6by.com>
9 months ago
533eddc57d
Add content cache to helm env
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
a7578fec74
Plugin types and plugin apiVersion v1
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
9 months ago
be74ab72a0
[HIP-0026] Plugin runtime interface ( #31145 )
...
* Runtime abstraction to encapsulate subprocess code and enable future runtimes
Also fix race condition in TestPrepareCommandExtraArgs by replacing the shared variable modification with a local copy
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Remove commented out code
Co-authored-by: Joe Julian <me@joejulian.name>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Check test failure string
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Co-authored-by: Joe Julian <me@joejulian.name>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
9 months ago
0f1b410f14
Merge pull request #31165 from mattfarina/content-cache
...
Initial addition of content based cache
9 months ago
a0d6b0d383
Merge pull request #13629 from gjenkins8/rename_atomic_rollbackonfailure
...
Rename 'atomic' -> 'rollback-on-failure'
9 months ago
29d12ba09e
Merge pull request #31156 from estroz/fix-resolve-client
...
fix: set repo authorizer in registry.Client.Resolve()
9 months ago
fc5bd02a1b
Merge pull request #31175 from cuiweixie/atomic.Uint64
...
pkg/register: refactor to use atomic.Uint64
9 months ago
fea6d8eb04
Updating to tested content cache
...
A few things are added here:
1. The cache is made to be more generic as a content based cache.
It could be used for other things such as plugins
2. Flags were added to specify the content cache locaiton rather
than rely on the repository cache. Keeping the 2 the same
hid bugs and errors.
3. Tests were added and updated to ensure the cache is used and
tested
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
4596c0e062
Merge pull request #31142 from helm/gjenkins/main/mv_plugin_internal
...
[HIP-0026] Move pkg/plugin -> internal/plugin
9 months ago
04cb1bad67
pkg/register: refactor to use atomic.Uint64
...
Signed-off-by: cuiweixie <cuiweixie@gmail.com>
9 months ago
ebc874ef84
fix client-side to server-side field manager migration
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
9 months ago
30404b4173
Merge pull request #31138 from islewis/release-3.18
...
fix(helm-lint): Add HTTP/HTTPS URL support for json schema references
9 months ago
62e0c78ef8
fix(helm-lint): fmt
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
9 months ago
6ac2c34689
Initial addition of content based cache
...
The previous cache was based on chart name and version. If 2 charts
with different content had the same name and version they would collide.
Helm did not trust the cache because of this and always downloaded
content. It was a short lived cache.
This commit introduces a content based cache which is based on the
content rather than file name. Charts with the same name but different
content are no longer an issue.
While the system assumes a file based interface, the cache system
is pluggable. In the future, it should return bytes for the content
instead of paths to it. That would requie a larger change for Helm 5
or later.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
3726d01c5c
Merge pull request #31132 from joemicky/main
...
refactor: replace []byte(fmt.Sprintf) with fmt.Appendf
9 months ago
e1e23d2af1
fix: set repo authorizer in registry.Client.Resolve()
...
Signed-off-by: Eric Stroczynski <estroczynski@nvidia.com>
10 months ago
b4b2392f7e
mergefix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
fb12b44493
fix(helm-lint): Add TLSClientConfig
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
10 months ago
de9ea4d1e3
Merge pull request #30992 from TerryHowe/force-oath-v4
...
fix: force bearer oauth for if registry requests bearer auth
10 months ago
e2dcbe28bf
Helm client/SDK support server-side apply
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
0943d032a7
Merge branch 'main' into em/fix-username-password
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
a1c84f9a4c
Move pkg/plugin -> internal/plugin
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
1e22b2fe7c
fix: remove redundant error check
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
10 months ago
fa73b6743b
fix(helm-lint): Add HTTP/HTTPS URL support for json schema references
...
Signed-off-by: Isaiah Lewis <isaiah@roof12.com>
10 months ago
36e52c828d
Merge pull request #31030 from gjenkins8/gjenkins/kubeclient_ssa
...
HIP-0023: Kube client support server-side apply
10 months ago
47529bbffb
Merge pull request #31133 from joemicky/use_CutPrefix
...
refactor: replace HasPrefix+TrimPrefix with CutPrefix
10 months ago
762ef3ee80
refactor: omit unnecessary reassignment
...
Signed-off-by: joemicky <joemickychang@outlook.com>
10 months ago
a3d2da4d2e
refactor: replace HasPrefix+TrimPrefix with CutPrefix
...
Signed-off-by: joemicky <joemickychang@outlook.com>
10 months ago
fab70472af
refactor: replace []byte(fmt.Sprintf) with fmt.Appendf
...
Signed-off-by: joemicky <joemickychang@outlook.com>
10 months ago
e1b9173812
Merge pull request #12624 from papdaniel/main
...
show crds command output separated by document separator
10 months ago
36532f36b1
Merge pull request #11700 from suzaku/use-sort-slice
...
Refactor, use sort.Slice to reduce boilerplate code
10 months ago
4b493f036c
Merge remote-tracking branch 'upstream/main' into papdaniel/main
10 months ago
6ecf033700
Merge pull request #13111 from rawtaz/style-cosmetics
...
style(pkg/chartutil): add missing dots and indentation to defaultValues
10 months ago
3fe1cb6f02
Merge remote-tracking branch 'upstream/main' into style-cosmetics
10 months ago
92bc614fbf
Merge remote-tracking branch 'upstream/main' into use-sort-slice
10 months ago
943ca1d0ca
Merge pull request #30891 from gjenkins8/gjenkins/port_plugin_warn
...
fix: Port pluginCommand & command warning
10 months ago
d7d072b7f6
Merge commit from fork
...
Advisory fix 1
10 months ago
ba53075a9d
Merge pull request #12968 from sjeandeaux/helm-uninstall-dry-run
...
helm uninstall dry run support `--ignore-not-found`
10 months ago
b2dc411f9d
code review (error checks, collapse forceConflicts, UpdateApplyFunc)
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
99dc23f00b
switch target<->original
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
741facca43
Update pkg/kube/client_test.go
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
45141451b4
Kube client support server-side apply
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
8affd6178f
Merge pull request #31126 from paologallinaharbur/fix/leverageSameTLSconfig
...
fix(transport): leverage same tls config
10 months ago
523d0b305e
Merge pull request #31076 from matheuscscp/registry-tls-memory
...
pkg/registry: Login option for passing TLS config in memory
10 months ago
44a594fef5
review
...
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
10 months ago
c5901abba6
Merge pull request #31050 from spreadshirt/fix-helm-pull-ud-check
...
Fix `helm pull` untar dir check with repo urls
10 months ago
f3c9407052
fix(transport): leverage same tls config
...
Signed-off-by: Paolo Gallina <paologallina1992@gmail.com>
10 months ago
8434935a3d
fix fallthrough
...
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
10 months ago
65209bed54
Update pkg/action/uninstall.go
...
Co-authored-by: Eddy Moulton <eddy@moulton.com.au>
Signed-off-by: Stephane Jeandeaux <sjeandeaux@users.noreply.github.com>
10 months ago
b3568a67a8
helm uninstall
...
The goal is to have the same behaviour with or without dry-run with --ignore-not-found
close #12970
Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
10 months ago
ae0fe82bc3
Merge remote-tracking branch 'upstream/main' into get-values-test
10 months ago
85164e5705
fix lint errors
...
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
10 months ago
ded25c1908
Add tests for alias
...
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
10 months ago
97af5a5e85
Fix linter warning
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
5e86e43eda
Add tests for pull command using OCI registry
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
9e1cbbebcb
fix linting warning
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
5e6a411c1f
fix: use username and password if provided
...
Ref: #31114
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
6597fecce3
test(pkg/kube/wait): Add unit tests for waitForPodSuccess, waitForJob and SelectorsForObject.
...
Signed-off-by: Pavani Pogula <pogulapavani@gmail.com>
10 months ago
d4ed9210df
test(pkg/kube/roundtripper): Add unit tests for roundtripper.go
...
Signed-off-by: Pavani Pogula <pogulapavani@gmail.com>
10 months ago
3c5d68d62e
Merge pull request #31109 from carlossg/panic3
...
fix: prevent panic when ChartDownloader.getOciURI
10 months ago
18b7d45999
Merge pull request #31034 from Mazafard/feat/color-output-and-test-fixes
...
Feat: Add color output functionality and tests for release statuses
10 months ago
9b217506bd
Merge pull request #31106 from irikeish/test/pkg_kube_client
...
test(pkg/kube): add test for Client.isReachable
10 months ago
93106ba2b6
Merge pull request #30982 from gjenkins8/gjenkins/force_replace_flag
...
Rename 'force' to 'force-replace'
10 months ago
4e483d36bd
fix: prevent panic when ChartDownloader.getOciURI
...
needs to lookup tags because no version is provided
but no RegistryClient is provided
Signed-off-by: Carlos Sanchez <carlos@apache.org>
10 months ago
6007d5773e
Merge pull request #31094 from mikelolasagasti/drop-freeport
...
chore(deps): remove phayes/freeport module
10 months ago
008bd7fc82
test(pkg/kube/client): add test for isReachable
...
Signed-off-by: Atish Kumar <allolro@gmail.com>
10 months ago
b25fa862d5
fix: assign KUBECONFIG environment variable value to env.Kubeconfig
...
Signed-off-by: LinPr <314573849@qq.com>
10 months ago
85243914a4
feat: switch yaml library to go.yaml.in/yaml/v3
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
10 months ago
69efc0d4fb
Handle messy index files
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
0c64ad1c97
fix Chart.yaml handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
7007d4d485
chore(deps): remove phayes/freeport module
...
Replaces the `phayes/freeport` module with the standard library's
`net.Listen("tcp", "127.0.0.1:0")` idiom. This removes an unnecessary
dependency and simplifies the codebase.
Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
10 months ago
a37934a892
fix linting issue
...
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
10 months ago
2d2d4a868d
Fix struct declaration
...
Signed-off-by: Faraz Khawaja <khwajafarazahmed@yahoo.com>
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
10 months ago
802e09038c
pkg/registry: Login option for passing TLS config in memory
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
10 months ago
a42b76421b
Merge pull request #31078 from 8tomat8/master
...
fix: k8s version parsing to match original
10 months ago
0865d70304
refactor: change default color output setting to auto and remove ColorEnabled method
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
10 months ago
4ef0f3d5e2
Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes
10 months ago
f3065ff1ba
Remove plugin deprecated 'UseTunnelDeprecated'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
08840f042c
Rename 'atomic' -> 'rollback-on-failure'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
10 months ago
9f6beaad48
fix: k8s version parsing to match original
...
Signed-off-by: Borys Hulii <borys.hulii@bitvavo.com>
10 months ago
1031b67fff
Fix `helm pull` untar dir check with repo urls
...
The existing check worked for `helm pull downloaded-repo/chart-name`,
but often does not work when using `--repo-url`, depending on the urls
used by the charts.
Signed-off-by: Luna Stadler <luc@spreadshirt.net>
10 months ago
118d0eb697
add concurrency test on write & load index file
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
10 months ago
f75100266b
Resolve conflicts
11 months ago
8face0e596
Merge pull request #31060 from yumeiyin/main
...
refactor: replace Split in loops with more efficient SplitSeq
11 months ago
619035d789
Merge pull request #31057 from danilobuerger/db/thick-lark
...
Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme
11 months ago
7f4eb407c6
add missing template directory to badcrdfile testdata
...
Signed-off-by: Joe Julian <me@joejulian.name>
11 months ago
08909e030b
Merge pull request #31019 from zachburg/templates_lint
...
Return early when linting if the `templates/` directory does not exist
11 months ago
1f3e4ad12a
Merge pull request #31011 from yalosev/feature/add-labels-to-metadata
...
feature: add labels to metadata
11 months ago
cd5ae5b19e
Merge pull request #31015 from zachburg/crds_lint
...
Add linter support for the `crds/` directory
11 months ago
250ce7b5dc
chore: improve OCI debug logging
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
11 months ago
1a73633908
Merge pull request #31033 from navinag1989/test-cov-cli-options
...
test: increase test coverage for pkg/cli/options.go file
11 months ago
74f2805f01
Rename 'force' to 'force-replace'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
8c22fbfe4a
refactor: replace Split in loops with more efficient SplitSeq
...
Signed-off-by: yumeiyin <yin.yumei@qq.com>
11 months ago
314bd19d11
update writing index files to writeAtomicFile
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
11 months ago
055c4e2bec
Moved url comparison to own function
...
Signed-off-by: Danilo Bürger <info@danilobuerger.de>
11 months ago
c1b3a83514
refactor: clean up color output imports in list, root, and status files
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
11 months ago
d28343550f
feat: make color output opt-in by default
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
11 months ago
ba8f70ae0b
refactor: move color package to internal/cli/output
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
11 months ago
b72db06c49
refactor: replace NoColor with ColorMode for improved color output control
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
11 months ago
96c54a2963
refactor color output functions to simplify noColor checks
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
11 months ago
b630ae30a5
Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes
11 months ago
d50d22c970
Add test coverage for get_values/metadata.go
...
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
11 months ago
8096f09370
Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme
...
Signed-off-by: Danilo Bürger <danilo.buerger@helsing.ai>
11 months ago
091f9a24fe
Merge pull request #13154 from carloslima/post-render-everything
...
Allow post-renderer to process hooks
11 months ago
49e82c1fe9
Merge pull request #31042 from TerryHowe/fix-test-teardown-dns-data-race
...
fix: test teardown dns data race
11 months ago
2da734d0b2
chore: fix typo in pkg/repo/chartrepo.go
...
Signed-off-by: jingchanglu <jingchanglu@outlook.com>
11 months ago
82bc9adcc2
fix: test teardown dns data race
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
11 months ago
46b1a41631
Add release labels to the release Metadata
...
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
11 months ago
4b8e61093d
Merge commit from fork
...
Updating link handling
11 months ago
4310b2bc36
Fixed linting issues
...
Signed-off-by: naving1989 <navinag1989@gmail.com>
11 months ago
1002ec5ae9
Update tests in lint_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
35434947a3
Return a lint warning if `templates/` does not exist.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
b6e3301bef
Merge branch 'helm:main' into templates_lint
11 months ago
fe11438715
Raise error instead of warning if `crds/` is not a valid directory
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
eea2d4577b
Raise an error if the `templates/` dir is not valid and return early.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
1e00790b8c
refactor tests to use t.Setenv for NO_COLOR environment variable
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
11 months ago
c547d1f2ae
add color output functionality and tests for release statuses
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
11 months ago
3a318c2fa3
Update crds.go after https://github.com/helm/helm/pull/31029
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
81af3c9570
Merge branch 'helm:main' into crds_lint
11 months ago
d21a8a04cb
Merge pull request #31029 from gjenkins8/gjenkins/k8s_yaml_struct
...
chore(refactor): Privatize 'k8sYamlStruct'
11 months ago
cc85352a0e
Use `assert.Len` instead of `assert.Lenf`
...
The default message from testify is descriptive enough.
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
c59a097209
Remove duplicate test case from crds_test.go
...
The "good" test case for CRDs is done in `TestGoodChart` in lint_test.go.
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
3b2f9e7d6f
test: increase test coverage for pkg/cli/options.go file
...
Signed-off-by: naving1989 <navinag1989@gmail.com>
11 months ago
bf9084a16a
Rename `validateCrdApiVersion` to `validateCrdAPIVersion`
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
357957b0d3
Use testify and add a CRD to the `goodone` test case.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
dadaff716a
Merge branch 'helm:main' into crds_lint
11 months ago
6e30619d8f
Merge branch 'helm:main' into templates_lint
11 months ago
76fdba4c8c
Updating link handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
11 months ago
bbea98ed6b
Merge pull request #30898 from fidelity-contributions/fix-issue-13198
...
Fix issue 13198
11 months ago
4c674728d2
Privatize 'k8sYamlStruct'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
edd0dabe02
Merge pull request #31021 from zachburg/test_temp_dir
...
Update tests in create_test.go and package_test.go to work in a temp directory
11 months ago
e8be2e540d
Merge pull request #31023 from gjenkins8/gjenkins/rm_recreate_pods
...
Remove deprecated '--create-pods' flag
11 months ago
a3bcc5b184
fix: 'TestRunLinterRule' stateful test
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
5283915c57
Remove deprecated '--create-pods' flag
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
de1bdf5820
switch to slog
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
62ca98f521
fix up verbiage
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
5f9cbe6f4a
fix: Port pluginCommand & command warning
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
eaf40b4b4f
Call `ensure.HelmHome()` in package_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
9517cfc5ce
Merge pull request #31009 from tpresa/test-coverage-pusher
...
test: increase test coverage for pkg/pusher
11 months ago
c48a3435f5
Remove unnecessary calls for changing directory to `helmpath.CachePath`.
...
This was only set on some tests in create_test.go and isn't
affecting the test.
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
6991a0a531
Make annotateAndMerge deterministic
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
11 months ago
c01e76b5c3
review: change annotation name to postrenderer.helm.sh/postrender-filename
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
11 months ago
a1416cf225
review: style changes
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
11 months ago
859721bd77
review: rewrite error messages from the end-user perspective
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
11 months ago
b26b473bf6
review: make splitAndDeannotate private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
11 months ago
855b5a44b7
review: make annotateAndMerge private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
11 months ago
1d993f9e2d
review: make filenameAnnotation private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
11 months ago
e6362d74c8
Allow post-renderer to process hooks
...
This annotates and merges all manifests before sending to the
postrender, reversing the process and recovering the filenames
afterwards.
closes #7891
Signed-off-by: Carlos Lima <carlos@cpan.org>
11 months ago
3b26ddc22b
Update tests in create_test.go and package_test.go to work in a temp dir.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
b703d5b4bb
Return early when linting if the `templates/` dir does not exist
...
The `vaildateTemplatesDir` function would still return `nil` if the directory doesn't exist,
so the early return that was documented never occurs.
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
a99c3700f0
Return early if the `/crds` directory does not exist.
...
Don't silently discard the error from `os.Stat`.
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
562ff982cb
Early return if the `/crds` directory does not exist and don't silently discard the error from `os.Stat`.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
d6ddd8e661
Document that attempting to parse YAML checks that the CRD is not a
...
template
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
e4c88faeff
Update test assertions
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
bc35ea5ad7
Fix comment in pkg/lint/rules/testdata/invalidcrdsdir/values.yaml
...
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
21b9aa3d94
Lint the `crds/` directory.
...
This checks that the `crds/` dir only contains YAML files that define
K8s resources with `kind: CustomResourceDefinition`.
Checking that the YAML files are not templates will be done in a
separate commit.
Signed-off-by: Zach Burgess <zachburg@google.com>
11 months ago
afd63fed77
test: increase test coverage for pkg/pusher
...
Signed-off-by: Thiago Presa <thiago.addevico@gmail.com>
11 months ago
f0cf9c28f0
Move logging setup to be configurable
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
11 months ago
bfc1af68fb
chore: fix function in comment
...
Signed-off-by: curlwget <curlwget@icloud.com>
11 months ago
a2a0935cba
Merge pull request #30900 from unguiculus/issue-12952
...
Add timeout flag to repo add and update commands
11 months ago
f55c462a79
fix: force bearer oauth for everything
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
11 months ago
ba0fbdeb57
Merge pull request #30979 from TerryHowe/oras-v2-login-for-v4
...
fix: OAuth username password login for v4
12 months ago
351bb78ee5
fix index concurrency
...
Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
12 months ago
df482346db
fix: lint test SetEnv errors
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
12 months ago
47980159b3
fix: user username password for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
12 months ago
bc44614a78
fix: wrap run release test error in case GetPodLogs failed.
...
Signed-off-by: manslaughter03 <manslaughter03@gmail.com>
12 months ago
744c6b5a97
fix: kube client create mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
12 months ago
e060fbe185
updated docs
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
12 months ago
0389407cbc
removed unnecessary binary file
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
12 months ago
b305a501e8
added documentation and test cases for api-versions flag
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
12 months ago
93ec064640
fix: repo update cmd mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
12 months ago
9623fb80f1
chore: fix some function names in comment
...
Signed-off-by: acceptacross <csqcqs@gmail.com>
1 year ago
7031000b7d
Merge pull request #30955 from carloslima/fix-test-deleting-local-directories
...
Fix tests deleting XDG_DATA_HOME
1 year ago
Terry Howe
wyrapeseed
Benoit Tigeot
George Jenkins
Scott Rigby
Matt Farina
copilot-swe-agent[bot]
Marcin Owsiany
Dirk Müller
Robert Sirchia
Joe Julian
Rachel Weber
juejinyuxitu
Siew Kam Onn
zyfy29
reddaisyy
Artem Vdovin
Tom Wieczorek
bennsimon
Evan Anderson
Stephanie Hohenberg
Jesse Simpson
Kamil Swiechowski
tzchenxixi
cuiweixie
Isaiah Lewis
Eric Stroczynski
Evans Mungai
joemicky
Stephane Jeandeaux
Paolo Gallina
Stephane Jeandeaux
Khwaja Faraz Ahmed
Pavani Pogula
Carlos Sanchez
Atish Kumar
LinPr
Mikel Olasagasti Uranga
Khwaja Faraz Ahmed
Faraz Khawaja
Matheus Pimenta
Mohammadreza Asadollahifard
Borys Hulii
Luna Stadler
yumeiyin
Danilo Bürger
Danilo Bürger
jingchanglu
Yuriy Losev
naving1989
Zach Burgess
Zach Burgess
Carlos Lima
Thiago Presa
curlwget
manslaughter03
Ashmit Bhardwaj
acceptacross