Merge pull request #31301 from TerryHowe/chore-remove-helm-version-client

chore: remove helm version `--client` option

pkg/cmd/testdata/output/version-client-shorthand.txt

@@ -1 +0,0 @@
-version.BuildInfo{Version:"v4.0", GitCommit:"", GitTreeState:"", GoVersion:""}

pkg/cmd/testdata/output/version-client.txt

@@ -1 +0,0 @@
-version.BuildInfo{Version:"v4.0", GitCommit:"", GitTreeState:"", GoVersion:""}

pkg/cmd/version.go

@@ -62,7 +62,7 @@ func newVersionCmd(out io.Writer) *cobra.Command {
 
 	cmd := &cobra.Command{
 		Use:               "version",
-		Short:             "print the client version information",
+		Short:             "print the helm version information",
 		Long:              versionDesc,
 		Args:              require.NoArgs,
 		ValidArgsFunction: noMoreArgsCompFunc,
@@ -73,8 +73,6 @@ func newVersionCmd(out io.Writer) *cobra.Command {
 	f := cmd.Flags()
 	f.BoolVar(&o.short, "short", false, "print the version number")
 	f.StringVar(&o.template, "template", "", "template for version string format")
-	f.BoolP("client", "c", true, "display client version information")
-	f.MarkHidden("client")
 
 	return cmd
 }

pkg/cmd/version_test.go

@@ -32,14 +32,6 @@ func TestVersion(t *testing.T) {
 		name:   "template",
 		cmd:    "version --template='Version: {{.Version}}'",
 		golden: "output/version-template.txt",
-	}, {
-		name:   "client",
-		cmd:    "version --client",
-		golden: "output/version-client.txt",
-	}, {
-		name:   "client shorthand",
-		cmd:    "version -c",
-		golden: "output/version-client-shorthand.txt",
 	}}
 	runTestCmd(t, tests)
 }