From 469f4b457cfe0c55b421c25ab2d071963888e1fb Mon Sep 17 00:00:00 2001 From: Terry Howe Date: Tue, 16 Sep 2025 15:26:39 -0600 Subject: [PATCH] chore: remove helm version client option Signed-off-by: Terry Howe --- pkg/cmd/testdata/output/version-client-shorthand.txt | 1 - pkg/cmd/testdata/output/version-client.txt | 1 - pkg/cmd/version.go | 4 +--- pkg/cmd/version_test.go | 8 -------- 4 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 pkg/cmd/testdata/output/version-client-shorthand.txt delete mode 100644 pkg/cmd/testdata/output/version-client.txt diff --git a/pkg/cmd/testdata/output/version-client-shorthand.txt b/pkg/cmd/testdata/output/version-client-shorthand.txt deleted file mode 100644 index 3b138ae77..000000000 --- a/pkg/cmd/testdata/output/version-client-shorthand.txt +++ /dev/null @@ -1 +0,0 @@ -version.BuildInfo{Version:"v4.0", GitCommit:"", GitTreeState:"", GoVersion:""} diff --git a/pkg/cmd/testdata/output/version-client.txt b/pkg/cmd/testdata/output/version-client.txt deleted file mode 100644 index 3b138ae77..000000000 --- a/pkg/cmd/testdata/output/version-client.txt +++ /dev/null @@ -1 +0,0 @@ -version.BuildInfo{Version:"v4.0", GitCommit:"", GitTreeState:"", GoVersion:""} diff --git a/pkg/cmd/version.go b/pkg/cmd/version.go index 0211716fe..80fb0d712 100644 --- a/pkg/cmd/version.go +++ b/pkg/cmd/version.go @@ -62,7 +62,7 @@ func newVersionCmd(out io.Writer) *cobra.Command { cmd := &cobra.Command{ Use: "version", - Short: "print the client version information", + Short: "print the helm version information", Long: versionDesc, Args: require.NoArgs, ValidArgsFunction: noMoreArgsCompFunc, @@ -73,8 +73,6 @@ func newVersionCmd(out io.Writer) *cobra.Command { f := cmd.Flags() f.BoolVar(&o.short, "short", false, "print the version number") f.StringVar(&o.template, "template", "", "template for version string format") - f.BoolP("client", "c", true, "display client version information") - f.MarkHidden("client") return cmd } diff --git a/pkg/cmd/version_test.go b/pkg/cmd/version_test.go index c06c72309..9551de767 100644 --- a/pkg/cmd/version_test.go +++ b/pkg/cmd/version_test.go @@ -32,14 +32,6 @@ func TestVersion(t *testing.T) { name: "template", cmd: "version --template='Version: {{.Version}}'", golden: "output/version-template.txt", - }, { - name: "client", - cmd: "version --client", - golden: "output/version-client.txt", - }, { - name: "client shorthand", - cmd: "version -c", - golden: "output/version-client-shorthand.txt", }} runTestCmd(t, tests) }