Moving new default accessor functions to internal per feedback

Signed-off-by: Matt Farina <matt.farina@suse.com>

pkg/release/common.go

@@ -25,11 +25,11 @@ import (
 	v1release "helm.sh/helm/v4/pkg/release/v1"
 )
 
-var NewAccessor func(rel Releaser) (Accessor, error) = NewDefaultAccessor //nolint:revive
+var NewAccessor func(rel Releaser) (Accessor, error) = newDefaultAccessor //nolint:revive
 
-var NewHookAccessor func(rel Hook) (HookAccessor, error) = NewDefaultHookAccessor //nolint:revive
+var NewHookAccessor func(rel Hook) (HookAccessor, error) = newDefaultHookAccessor //nolint:revive
 
-func NewDefaultAccessor(rel Releaser) (Accessor, error) {
+func newDefaultAccessor(rel Releaser) (Accessor, error) {
 	switch v := rel.(type) {
 	case v1release.Release:
 		return &v1Accessor{&v}, nil
@@ -40,7 +40,7 @@ func NewDefaultAccessor(rel Releaser) (Accessor, error) {
 	}
 }
 
-func NewDefaultHookAccessor(hook Hook) (HookAccessor, error) {
+func newDefaultHookAccessor(hook Hook) (HookAccessor, error) {
 	switch h := hook.(type) {
 	case v1release.Hook:
 		return &v1HookAccessor{&h}, nil

pkg/release/common_test.go

@@ -44,7 +44,7 @@ func TestNewDefaultAccessor(t *testing.T) {
 		ApplyMethod: "csa",
 	}
 
-	// NewDefaultAccessor should not be called directly Instead, NewAccessor should be
+	// newDefaultAccessor should not be called directly Instead, NewAccessor should be
 	// called and it will call NewDefaultAccessor. NewAccessor can be changed to a
 	// non-default accessor by a user so the test calls the default implementation.
 	// The accessor provides a means to access data on resources that are different types
@@ -53,7 +53,7 @@ func TestNewDefaultAccessor(t *testing.T) {
 	// and unmarshalling data (e.g. coming and going from JSON or YAML). But, structs
 	// can't be used with interfaces. The accessors enable access to the underlying data
 	// in a manner that works with Go interfaces.
-	accessor, err := NewDefaultAccessor(rel)
+	accessor, err := newDefaultAccessor(rel)
 	is.NoError(err)
 
 	// Verify information