findnature
ac8d2f9aed
refactor: use slices.Contains to simplify code
...
Signed-off-by: findnature <cricis@aliyun.com>
5 months ago
George Jenkins
31e22b9866
Merge pull request #30800 from mmorel-35/fix-dep-fs
...
fix: dep fs errors
5 months ago
Matthieu MOREL
15b83a9959
fix: dep fs errors
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Matt Farina
ab15810701
Merge pull request #30786 from mmorel-35/clean-up
...
refactor: reorganize .golangci.yml for better clarity and structure
5 months ago
Robert Sirchia
4161d77aba
Merge pull request #30803 from mattfarina/fix-errors-windows
...
Fixing windows build
5 months ago
Matt Farina
ed356cfca8
Fixing windows build
...
The package github.com/pkg/errors was removed via the pull request #13460 .
This change did not correctly handle the case in the windows code and CI
did not exercise this to find the error.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
George Jenkins
e865a0f540
Merge pull request #30801 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-0.36.0-flux.13
...
build(deps): bump github.com/fluxcd/cli-utils from 0.36.0-flux.12 to 0.36.0-flux.13
5 months ago
dependabot[bot]
ef64468187
build(deps): bump github.com/fluxcd/cli-utils
...
Bumps [github.com/fluxcd/cli-utils](https://github.com/fluxcd/cli-utils ) from 0.36.0-flux.12 to 0.36.0-flux.13.
- [Commits](https://github.com/fluxcd/cli-utils/compare/v0.36.0-flux.12...v0.36.0-flux.13 )
---
updated-dependencies:
- dependency-name: github.com/fluxcd/cli-utils
dependency-version: 0.36.0-flux.13
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
Matthieu MOREL
3270d35d3f
refactor: reorganize .golangci.yml for better clarity and structure
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
George Jenkins
ecf1730689
Merge pull request #13460 from justenstall/stdlib-errors-2
...
fix: replace "github.com/pkg/errors" with stdlib "errors" package
5 months ago
Justen Stall
4905a61026
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Matt Farina
fcd37bcea7
Merge pull request #30783 from rpolishchuk/investigate-TestValidateChartIconPresence
...
fix: chart icon presence test
5 months ago
Robert Sirchia
d9bc0a948c
Merge pull request #30777 from ryanhockstad/merge-fix
...
fix: null merge. closes #30587
5 months ago
Scott Rigby
a911aa2112
Merge pull request #9175 from dastrobu/copy-dependencies-on-aliasing
...
fix: copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies
5 months ago
Joe Julian
dd0d80d246
Merge pull request #30788 from stephenpmurray/refactor/chart-not-found-error-type
...
ref(helm): Export Chart Not Found error
5 months ago
Robert Sirchia
789ce7fd10
Merge pull request #30785 from mmorel-35/fix-govulncheck
...
fix: govulncheck workflow
5 months ago
Daniel Strobusch
b183eccfc4
copy dependency metadata on aliasing to avoid sharing imported values
...
imported values are stored in dependency objects, which breaks if a chart dependency is shared among multiple aliases.
By copying the dependency objects in the metadata values can be imported correctly.
Supersedes #10174
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
5 months ago
Daniel Strobusch
df7befd208
copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies
...
Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases.
By copying the dependencies, parent information can be set correctly to render the templates as expected later on.
Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level.
Closes #9150
Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
5 months ago
Stephen Murray
1682895636
ref(helm): Export Chart Not Found error
...
Closes #30746
Signed-off-by: Stephen Murray <stephenmurrayengineer@gmail.com>
5 months ago
Rostyslav Polishchuk
1c8d1e375f
fix: chart icon presence test
...
The `TestValidateChartIconPresence` test fails when run after
`TestValidateChartIconURL` as they both are using a global
variable `badChart.Icon`
```
: go test -v -test.shuffle 1 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 1
=== RUN TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
=== RUN TestValidateChartIconPresence
chartfile_test.go:171: validateChartIconPresence to return a linter error, got no error
--- FAIL: TestValidateChartIconPresence (0.00s)
FAIL
FAIL helm.sh/helm/v4/pkg/lint/rules 0.051s
FAIL
: go test -v -test.shuffle 2 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 2
=== RUN TestValidateChartIconPresence
--- PASS: TestValidateChartIconPresence (0.00s)
=== RUN TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
PASS
ok helm.sh/helm/v4/pkg/lint/rules 0.050s
```
This commit:
1. Remove dependency on global variable
2. Explicitly set the state of the test object.
Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>
5 months ago
Justen Stall
700103d76a
chore: add depguard rule for github.com/pkg/errors
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
18aae5a121
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Matthieu MOREL
a0c84b9246
fix: govulncheck workflow
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Scott Rigby
9c0d90a291
Merge pull request #30781 from mmorel-35/github.com/hashicorp/go-multierror
...
chore: remove `github.com/hashicorp/go-multierror` dependency
5 months ago
Robert Sirchia
9609005d2c
Merge pull request #30784 from scottrigby/add-terryhowe-triage-maintainer
...
chore(OWNERS): Add TerryHowe as Triage Maintainer
5 months ago
Scott Rigby
33f5e9d0f4
chore(OWNERS): Add TerryHowe as Triage Maintainer
...
Adding @TerryHowe to OWNERS file as Triage Maintainer, as agreed by
supermajority vote by core maintainers.
- Nomination email (public Helm mailing list):
https://lists.cncf.io/g/cncf-helm/topic/nominating_terry_howe_as_a/112379173
- Voting email (provate Helm core mailing list):
https://lists.cncf.io/g/cncf-helm-core-maintainers/topic/voting_for_terry_howe_as/112379286
Welcome, @TerryHowe! Glad to have you on board ☺️
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Justen Stall
fc6c5e5edb
remove WaitAndGetCompletedPodPhase function
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
73545f9a3e
one more test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
4a6092bd6c
update another test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
7a316c8d51
update expected error message in install test
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
6c3fc1d755
Merge pull request #1 from justenstall/stdlib-errors-2-lint-issues
...
Fix lint issues
5 months ago
Matthieu MOREL
d3eeb2c942
chore: remove github.com/hashicorp/go-multierror dependency
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Justen Stall
3877ec9049
fix golangci-lint issues
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
065e2eb3eb
updates after merge conflict resolution
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Scott Rigby
eb6e240cfe
Merge pull request #30734 from ipaqsa/feature/add-custom-template-funcs
...
feat(pkg/engine): add support for custom template funcs
5 months ago
Scott Rigby
8255300280
Merge pull request #12382 from edbmiller/ed-dot-miller/parse-chartfile-yaml-strictly
...
fix(pkg/lint): unmarshals Chart.yaml strictly
5 months ago
Ryan Hockstad
c1175a4106
fix null merge
...
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
5 months ago
George Jenkins
879d158a80
Merge pull request #30775 from benoittgt/bump-toml
...
Bump toml
5 months ago
Edward Miller
e414695a5b
fix
...
Signed-off-by: Edward Miller <edmiller287@gmail.com>
5 months ago
Benoit Tigeot
e2461de3c2
Fix test with toml bump
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
39d7b8fcd4
Bump toml
...
Closes: https://github.com/helm/helm/pull/30682
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Matt Farina
a842140ef6
Merge pull request #13578 from gjenkins8/rm_chart_repo_load_func
...
refactor: Remove ChartRepository `[]ChartPaths`
5 months ago
Matt Farina
07b0dca046
Merge pull request #30677 from dongjiang1989/update-golang-version
...
chore: Update Golang to v1.24
5 months ago
Edward Miller
629780a34a
fix: reapply error message fix
...
Signed-off-by: Edward Miller <edmiller287@gmail.com>
5 months ago
Edward Miller
9d43f70643
Update error message
...
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Edward Miller <55854159+edbmiller@users.noreply.github.com>
5 months ago
Edward Miller
14a468f24d
Add chartutil.StrictLoadChartfile for strict (WARNING-level) lint
...
Signed-off-by: Edward Miller <edmiller287@gmail.com>
5 months ago
Edward Miller
00f8561ad4
fix(pkg/lint): unmarshals Chart.yaml strictly
...
When "helm lint" is run, it now errors on invalid chartfiles,
e.g. those with duplicate keys
Closes #12381
Signed-off-by: Edward Miller <edmiller287@gmail.com>
5 months ago
Robert Sirchia
7571f77163
Merge pull request #30770 from helm/dependabot/go_modules/main/github.com/rubenv/sql-migrate-1.8.0
...
build(deps): bump github.com/rubenv/sql-migrate from 1.7.2 to 1.8.0
5 months ago
Robert Sirchia
0e7e282636
Merge pull request #30773 from wangcundashang/main
...
chore: fix function name in comment
5 months ago