Terry Howe
c3aa5c51e6
chore: clean up for comments
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
3 months ago
copilot-swe-agent[bot]
b4f932a715
Fix test by making date sorting stable and updating golden files
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
3 months ago
Terry Howe
8a73d97984
fix: make helm list show all by default
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
3 months ago
Terry Howe
20eb6e9b04
fix: empty time values
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
3 months ago
Matt Farina
ab6e7fa58b
Removing debug statement
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 months ago
Matt Farina
a229bf6529
Ensure the release interface is used in actions instead of the type
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 months ago
Matt Farina
f80cbe43d0
Moved release objects to enable versioning
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 months ago
Matt Farina
2247a0074b
Move all the get commands to the new release interface
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 months ago
George Jenkins
4877e2d7e9
Merge pull request #30833 from gjenkins8/gjenkins/refactor_dry_run_flag
...
refactor/cleanup: Replace action 'DryRun' string with DryRunStrategy type + deprecations
3 months ago
George Jenkins
0adfe83ff8
Merge pull request #31227 from evankanderson/windows-filepath
...
Use filepath.Path when handling directory names
4 months ago
George Jenkins
7761d937ca
testfix
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
George Jenkins
a7a6a5e3b0
Merge pull request #31312 from gjenkins8/gjenkins/rm_plugin_schema_settings
...
Remove unused 'Settings' from plugin schema
4 months ago
George Jenkins
561a7da61c
Merge pull request #31297 from TerryHowe/fix-hide-notes-in-helm-test
...
fix: hide notes in helm test command
4 months ago
George Jenkins
f21b143bef
refactor: Replace action 'DryRun' string with DryRunStrategy type + deprecations
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
George Jenkins
6bc6231bcc
Remove unused 'Settings' from plugin schema
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
4 months ago
Robert Sirchia
5b43b744b8
Merge pull request #31294 from TerryHowe/feature-remove-implicit-directory-from-helm-lint
...
Remove implicit support for helm lint current directory
4 months ago
Robert Sirchia
fdb5e1a97a
Merge pull request #31301 from TerryHowe/chore-remove-helm-version-client
...
chore: remove helm version `--client` option
4 months ago
Matt Farina
d2236e95ed
Merge pull request #31303 from mattfarina/unified-loader
...
Update the action interfaces for chart apiversions
4 months ago
Matt Farina
8dc7c57f50
Update the action interfaces for chart apiversions
...
This change is about handling the interfaces to public functions for
different chart apiVersions. The internals are still focused on v2.
This enables v3 to be layered in layer.
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 months ago
Terry Howe
020a8eccfd
fix: helm verify run signature
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
zyfy29
b24bfe4168
Merge branch 'main' into delete-unused-var
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
4 months ago
Terry Howe
469f4b457c
chore: remove helm version client option
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
dab4fd2909
fix: hide notes in helm test command
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
copilot-swe-agent[bot]
838c36a0f6
Remove implicit support for helm lint current directory
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
3e1dd9a5dc
chore: remove pkg/time which is no longer needed
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Tom Wieczorek
6181e0a873
Make test scripts run without /bin/bash
...
The test scripts hardcoded #!/bin/bash while they are not really
requiring bash. Use the more portable #!/usr/bin/env sh instead, so that
they use the default shell.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
4 months ago
Robert Sirchia
5534c01cdb
Merge pull request #31277 from benoittgt/31234-fix
...
Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10
4 months ago
Evan Anderson
20f4e1f12d
Use filepath.Path when handling directory names
...
Signed-off-by: Evan Anderson <evan.k.anderson@gmail.com>
4 months ago
Benoit Tigeot
99e5fce71a
Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10
...
Close : #31231
```
Error: cmd/helm/root.go:165:2: SA1019: flags.ParseErrorsWhitelist is deprecated: use [FlagSet.ParseErrorsAllowlist] instead. This field will be removed in a future release. (staticcheck)
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Kamil Swiechowski
38d1a7376f
fix: throw warning when chart version is not semverv2
...
Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>
5 months ago
Matt Farina
618b14a772
Merge pull request #31225 from mattfarina/move-lint-to-chart
...
Move lint pkg to be part of each chart version
5 months ago
George Jenkins
a8151ef4fe
Cleanup plugin config
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Scott Rigby
ed6cab39c6
Merge pull request #31219 from gjenkins8/gjenkins/plugin-integration/rm_setup_plugin_env
5 months ago
Matt Farina
9dcc49cbd5
Move lint pkg to be part of each chart version
...
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.
To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:
1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
provide access to its data via an interface. There is an
interface, factory, and implementation for each version of
chart.
3. Common packages were moved to a common and util packages.
Due to some package loops, there are 2 packages which may
get some consolidation in the future.
The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Matt Farina
52267ee74b
Move repo package to versioned directory
...
The repo package is internally versioned at v1. Repos were designed
to be versioned. This change moves it to a versioned directory the
same way other packages are now being handled.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Matt Farina
6f957f4922
Move the release util to the versioned directory
...
The release util package is directly related to the v1 of
releases and uses the v1 of releases.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
George Jenkins
5926ec83dd
Remove SetupPluginEnv
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
George Jenkins
c35755a197
Remove legacy Command/Hooks from v1 Subprocess ( #23 )
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Scott Rigby
591d863df5
Move Postrenderer to a plugin type
...
Fix/add back postrenderer args unit tests
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
e814ff3c38
Remove unnecessary file i/o operations from signing and verifying
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
9ea35da0d0
[HIP-0026] Plugin packaging, signing, and verification ( #31176 )
...
* Plugin packaging, signing and verification
Signed-off-by: Scott Rigby <scott@r6by.com>
* wrap keyring read error with more explicit message
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* skip unnecessary check
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Change behavior for installing plugin with missing .prov file (now warns and continues instead of failing)
Signed-off-by: Scott Rigby <scott@r6by.com>
* Add comprehensive plugin verification tests
- Test missing .prov files (warns but continues)
- Test invalid .prov file formats (fails verification)
- Test hash mismatches in .prov files (fails verification)
- Test .prov file access errors (fails appropriately)
- Test directory plugins don't support verification
- Test installation without verification enabled (succeeds)
- Test with valid .prov files (fails on empty keyring as expected)
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
George Jenkins
80f659ce8b
Merge pull request #31178 from mattfarina/env-content-cache
...
Add content cache to helm env
5 months ago
zyfy29
8068578266
chore: delete unused var in installer.go
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
5 months ago
George Jenkins
934f761e08
Merge pull request #30812 from gjenkins8/gjenkins/chartrelease_server_side_apply
...
HIP-0023: Helm support server-side apply
5 months ago
Scott Rigby
7d22bb25fa
Plugin OCI installer
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Matt Farina
533eddc57d
Add content cache to helm env
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Scott Rigby
a7578fec74
Plugin types and plugin apiVersion v1
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
5 months ago
Scott Rigby
be74ab72a0
[HIP-0026] Plugin runtime interface ( #31145 )
...
* Runtime abstraction to encapsulate subprocess code and enable future runtimes
Also fix race condition in TestPrepareCommandExtraArgs by replacing the shared variable modification with a local copy
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Remove commented out code
Co-authored-by: Joe Julian <me@joejulian.name>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Check test failure string
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Co-authored-by: Joe Julian <me@joejulian.name>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Matt Farina
0f1b410f14
Merge pull request #31165 from mattfarina/content-cache
...
Initial addition of content based cache
5 months ago
George Jenkins
a0d6b0d383
Merge pull request #13629 from gjenkins8/rename_atomic_rollbackonfailure
...
Rename 'atomic' -> 'rollback-on-failure'
5 months ago
Matt Farina
fea6d8eb04
Updating to tested content cache
...
A few things are added here:
1. The cache is made to be more generic as a content based cache.
It could be used for other things such as plugins
2. Flags were added to specify the content cache locaiton rather
than rely on the repository cache. Keeping the 2 the same
hid bugs and errors.
3. Tests were added and updated to ensure the cache is used and
tested
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
George Jenkins
4596c0e062
Merge pull request #31142 from helm/gjenkins/main/mv_plugin_internal
...
[HIP-0026] Move pkg/plugin -> internal/plugin
5 months ago
George Jenkins
e2dcbe28bf
Helm client/SDK support server-side apply
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Evans Mungai
0943d032a7
Merge branch 'main' into em/fix-username-password
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
George Jenkins
a1c84f9a4c
Move pkg/plugin -> internal/plugin
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Robert Sirchia
47529bbffb
Merge pull request #31133 from joemicky/use_CutPrefix
...
refactor: replace HasPrefix+TrimPrefix with CutPrefix
5 months ago
joemicky
762ef3ee80
refactor: omit unnecessary reassignment
...
Signed-off-by: joemicky <joemickychang@outlook.com>
5 months ago
joemicky
a3d2da4d2e
refactor: replace HasPrefix+TrimPrefix with CutPrefix
...
Signed-off-by: joemicky <joemickychang@outlook.com>
5 months ago
Robert Sirchia
c5901abba6
Merge pull request #31050 from spreadshirt/fix-helm-pull-ud-check
...
Fix `helm pull` untar dir check with repo urls
6 months ago
Evans Mungai
97af5a5e85
Fix linter warning
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
Evans Mungai
5e86e43eda
Add tests for pull command using OCI registry
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
George Jenkins
18b7d45999
Merge pull request #31034 from Mazafard/feat/color-output-and-test-fixes
...
Feat: Add color output functionality and tests for release statuses
6 months ago
George Jenkins
93106ba2b6
Merge pull request #30982 from gjenkins8/gjenkins/force_replace_flag
...
Rename 'force' to 'force-replace'
6 months ago
Mohammadreza Asadollahifard
4ef0f3d5e2
Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes
6 months ago
George Jenkins
08840f042c
Rename 'atomic' -> 'rollback-on-failure'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
Luna Stadler
1031b67fff
Fix `helm pull` untar dir check with repo urls
...
The existing check worked for `helm pull downloaded-repo/chart-name`,
but often does not work when using `--repo-url`, depending on the urls
used by the charts.
Signed-off-by: Luna Stadler <luc@spreadshirt.net>
6 months ago
George Jenkins
8face0e596
Merge pull request #31060 from yumeiyin/main
...
refactor: replace Split in loops with more efficient SplitSeq
6 months ago
Joe Julian
08909e030b
Merge pull request #31019 from zachburg/templates_lint
...
Return early when linting if the `templates/` directory does not exist
6 months ago
Joe Julian
1f3e4ad12a
Merge pull request #31011 from yalosev/feature/add-labels-to-metadata
...
feature: add labels to metadata
6 months ago
George Jenkins
74f2805f01
Rename 'force' to 'force-replace'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
yumeiyin
8c22fbfe4a
refactor: replace Split in loops with more efficient SplitSeq
...
Signed-off-by: yumeiyin <yin.yumei@qq.com>
6 months ago
Mohammadreza Asadollahifard
c1b3a83514
refactor: clean up color output imports in list, root, and status files
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
6 months ago
Mohammadreza Asadollahifard
d28343550f
feat: make color output opt-in by default
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
6 months ago
Mohammadreza Asadollahifard
ba8f70ae0b
refactor: move color package to internal/cli/output
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
6 months ago
Mohammadreza Asadollahifard
b72db06c49
refactor: replace NoColor with ColorMode for improved color output control
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
6 months ago
Yuriy Losev
46b1a41631
Add release labels to the release Metadata
...
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
7 months ago
Zach Burgess
35434947a3
Return a lint warning if `templates/` does not exist.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Mohammadreza Asadollahifard
c547d1f2ae
add color output functionality and tests for release statuses
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Zach Burgess
6e30619d8f
Merge branch 'helm:main' into templates_lint
7 months ago
George Jenkins
bbea98ed6b
Merge pull request #30898 from fidelity-contributions/fix-issue-13198
...
Fix issue 13198
7 months ago
George Jenkins
edd0dabe02
Merge pull request #31021 from zachburg/test_temp_dir
...
Update tests in create_test.go and package_test.go to work in a temp directory
7 months ago
George Jenkins
5283915c57
Remove deprecated '--create-pods' flag
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
Zach Burgess
eaf40b4b4f
Call `ensure.HelmHome()` in package_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
c48a3435f5
Remove unnecessary calls for changing directory to `helmpath.CachePath`.
...
This was only set on some tests in create_test.go and isn't
affecting the test.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
3b26ddc22b
Update tests in create_test.go and package_test.go to work in a temp dir.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
b703d5b4bb
Return early when linting if the `templates/` dir does not exist
...
The `vaildateTemplatesDir` function would still return `nil` if the directory doesn't exist,
so the early return that was documented never occurs.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Matt Farina
f0cf9c28f0
Move logging setup to be configurable
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
George Jenkins
a2a0935cba
Merge pull request #30900 from unguiculus/issue-12952
...
Add timeout flag to repo add and update commands
7 months ago
manslaughter03
bc44614a78
fix: wrap run release test error in case GetPodLogs failed.
...
Signed-off-by: manslaughter03 <manslaughter03@gmail.com>
7 months ago
Ashmit Bhardwaj
e060fbe185
updated docs
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
8 months ago
Ashmit Bhardwaj
0389407cbc
removed unnecessary binary file
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
8 months ago
Ashmit Bhardwaj
b305a501e8
added documentation and test cases for api-versions flag
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
8 months ago
Terry Howe
93ec064640
fix: repo update cmd mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
8 months ago
Reinhard Nägele
d448cf1943
Add timeout flag to repo add and update flags
...
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
# Conflicts:
# pkg/cmd/repo_update.go
8 months ago
Robert Sirchia
83c26845ad
Merge pull request #30904 from benoittgt/document-ideal-registry-login-command
...
[Doc] Help users avoid specifying URL scheme and path with `helm registry`
8 months ago
Benoit Tigeot
cb730c94b5
Help users avoid specifying URL scheme an path
...
We’ve noticed that some users still include the URL scheme and full path
when logging into an OCI registry, for example:
```sh
helm registry login -u $OCI_REGISTRY_USER --password-stdin oci://ghcr.io/org/repo
```
This is no longer necessary and will not be supported in Helm v4.
To guide users toward the correct usage, we should show an example of
the ideal command.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Matt Farina
cf7613ba6b
Reverting fix "renders int as float"
...
This reverts #13533
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Note: This kind of change can be put into v3 charts, that are in
active development, without causing a regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
8 months ago
Matt Farina
ab56ac62ba
Merge pull request #30866 from mmorel-35/thelper
...
chore: enable thelper linter
8 months ago
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
8 months ago