Matt Farina
fea6d8eb04
Updating to tested content cache
...
A few things are added here:
1. The cache is made to be more generic as a content based cache.
It could be used for other things such as plugins
2. Flags were added to specify the content cache locaiton rather
than rely on the repository cache. Keeping the 2 the same
hid bugs and errors.
3. Tests were added and updated to ensure the cache is used and
tested
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
George Jenkins
4596c0e062
Merge pull request #31142 from helm/gjenkins/main/mv_plugin_internal
...
[HIP-0026] Move pkg/plugin -> internal/plugin
5 months ago
George Jenkins
e2dcbe28bf
Helm client/SDK support server-side apply
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Evans Mungai
0943d032a7
Merge branch 'main' into em/fix-username-password
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
George Jenkins
a1c84f9a4c
Move pkg/plugin -> internal/plugin
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Robert Sirchia
47529bbffb
Merge pull request #31133 from joemicky/use_CutPrefix
...
refactor: replace HasPrefix+TrimPrefix with CutPrefix
5 months ago
joemicky
762ef3ee80
refactor: omit unnecessary reassignment
...
Signed-off-by: joemicky <joemickychang@outlook.com>
5 months ago
joemicky
a3d2da4d2e
refactor: replace HasPrefix+TrimPrefix with CutPrefix
...
Signed-off-by: joemicky <joemickychang@outlook.com>
5 months ago
Robert Sirchia
c5901abba6
Merge pull request #31050 from spreadshirt/fix-helm-pull-ud-check
...
Fix `helm pull` untar dir check with repo urls
6 months ago
Evans Mungai
97af5a5e85
Fix linter warning
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
Evans Mungai
5e86e43eda
Add tests for pull command using OCI registry
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
6 months ago
George Jenkins
18b7d45999
Merge pull request #31034 from Mazafard/feat/color-output-and-test-fixes
...
Feat: Add color output functionality and tests for release statuses
6 months ago
George Jenkins
93106ba2b6
Merge pull request #30982 from gjenkins8/gjenkins/force_replace_flag
...
Rename 'force' to 'force-replace'
6 months ago
Mohammadreza Asadollahifard
4ef0f3d5e2
Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes
6 months ago
George Jenkins
08840f042c
Rename 'atomic' -> 'rollback-on-failure'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
Luna Stadler
1031b67fff
Fix `helm pull` untar dir check with repo urls
...
The existing check worked for `helm pull downloaded-repo/chart-name`,
but often does not work when using `--repo-url`, depending on the urls
used by the charts.
Signed-off-by: Luna Stadler <luc@spreadshirt.net>
6 months ago
George Jenkins
8face0e596
Merge pull request #31060 from yumeiyin/main
...
refactor: replace Split in loops with more efficient SplitSeq
6 months ago
Joe Julian
08909e030b
Merge pull request #31019 from zachburg/templates_lint
...
Return early when linting if the `templates/` directory does not exist
6 months ago
Joe Julian
1f3e4ad12a
Merge pull request #31011 from yalosev/feature/add-labels-to-metadata
...
feature: add labels to metadata
6 months ago
George Jenkins
74f2805f01
Rename 'force' to 'force-replace'
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
yumeiyin
8c22fbfe4a
refactor: replace Split in loops with more efficient SplitSeq
...
Signed-off-by: yumeiyin <yin.yumei@qq.com>
6 months ago
Mohammadreza Asadollahifard
c1b3a83514
refactor: clean up color output imports in list, root, and status files
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Mohammadreza Asadollahifard
d28343550f
feat: make color output opt-in by default
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Mohammadreza Asadollahifard
ba8f70ae0b
refactor: move color package to internal/cli/output
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Mohammadreza Asadollahifard
b72db06c49
refactor: replace NoColor with ColorMode for improved color output control
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Yuriy Losev
46b1a41631
Add release labels to the release Metadata
...
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
7 months ago
Zach Burgess
35434947a3
Return a lint warning if `templates/` does not exist.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Mohammadreza Asadollahifard
c547d1f2ae
add color output functionality and tests for release statuses
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
7 months ago
Zach Burgess
6e30619d8f
Merge branch 'helm:main' into templates_lint
7 months ago
George Jenkins
bbea98ed6b
Merge pull request #30898 from fidelity-contributions/fix-issue-13198
...
Fix issue 13198
7 months ago
George Jenkins
edd0dabe02
Merge pull request #31021 from zachburg/test_temp_dir
...
Update tests in create_test.go and package_test.go to work in a temp directory
7 months ago
George Jenkins
5283915c57
Remove deprecated '--create-pods' flag
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
7 months ago
Zach Burgess
eaf40b4b4f
Call `ensure.HelmHome()` in package_test.go
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
c48a3435f5
Remove unnecessary calls for changing directory to `helmpath.CachePath`.
...
This was only set on some tests in create_test.go and isn't
affecting the test.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
3b26ddc22b
Update tests in create_test.go and package_test.go to work in a temp dir.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Zach Burgess
b703d5b4bb
Return early when linting if the `templates/` dir does not exist
...
The `vaildateTemplatesDir` function would still return `nil` if the directory doesn't exist,
so the early return that was documented never occurs.
Signed-off-by: Zach Burgess <zachburg@google.com>
7 months ago
Matt Farina
f0cf9c28f0
Move logging setup to be configurable
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
George Jenkins
a2a0935cba
Merge pull request #30900 from unguiculus/issue-12952
...
Add timeout flag to repo add and update commands
7 months ago
manslaughter03
bc44614a78
fix: wrap run release test error in case GetPodLogs failed.
...
Signed-off-by: manslaughter03 <manslaughter03@gmail.com>
8 months ago
Ashmit Bhardwaj
e060fbe185
updated docs
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
8 months ago
Ashmit Bhardwaj
0389407cbc
removed unnecessary binary file
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
8 months ago
Ashmit Bhardwaj
b305a501e8
added documentation and test cases for api-versions flag
...
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
8 months ago
Terry Howe
93ec064640
fix: repo update cmd mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8 months ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
8 months ago
Reinhard Nägele
d448cf1943
Add timeout flag to repo add and update flags
...
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
# Conflicts:
# pkg/cmd/repo_update.go
8 months ago
Robert Sirchia
83c26845ad
Merge pull request #30904 from benoittgt/document-ideal-registry-login-command
...
[Doc] Help users avoid specifying URL scheme and path with `helm registry`
8 months ago
Benoit Tigeot
cb730c94b5
Help users avoid specifying URL scheme an path
...
We’ve noticed that some users still include the URL scheme and full path
when logging into an OCI registry, for example:
```sh
helm registry login -u $OCI_REGISTRY_USER --password-stdin oci://ghcr.io/org/repo
```
This is no longer necessary and will not be supported in Helm v4.
To guide users toward the correct usage, we should show an example of
the ideal command.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
8 months ago
Matt Farina
cf7613ba6b
Reverting fix "renders int as float"
...
This reverts #13533
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Note: This kind of change can be put into v3 charts, that are in
active development, without causing a regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
8 months ago
Matt Farina
ab56ac62ba
Merge pull request #30866 from mmorel-35/thelper
...
chore: enable thelper linter
8 months ago
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
8 months ago
Matt Farina
b5a4781099
Adding test for list command
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
8 months ago
Ayush Tiwari
56b688145f
added cmd in repo_list.go for pipeline
...
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
8 months ago
Ayush Tiwari
e63cbae886
added cmd.ErrOrStderr()
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
9 months ago
Ayush Tiwari
95328ea0a6
removed error import
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
9 months ago
Ayush Tiwari
058bc083a8
changed Error to print
...
Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>
9 months ago
findnature
ac8d2f9aed
refactor: use slices.Contains to simplify code
...
Signed-off-by: findnature <cricis@aliyun.com>
9 months ago
Justen Stall
73545f9a3e
one more test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
9 months ago
Justen Stall
4a6092bd6c
update another test output
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
9 months ago
Justen Stall
3877ec9049
fix golangci-lint issues
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
9 months ago
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
9 months ago
Robert Sirchia
da096e1b7a
Merge pull request #30752 from benoittgt/bump-golangci-lint-action
...
Bump golangci lint to last major version and fix static-check errors
9 months ago
Matt Farina
0dffc580b0
Simpligy the JSON Schema checking
...
A new library was introduced that provides JSON Schema checking for
newer versions of the schema. In Helm v4, there is no need to have
two packages doing the JSON schema validation. The message output
can have breaking changes.
This change moves everything to the newer library. It also uses a
wrapper error to enable a clean Helm only interface for the
public Go API validation functions. This would enable the replacement
of the Schema validation library, if needed, without breaking the
Go API contract.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
Benoit Tigeot
eb65ce280b
could apply De Morgan's law
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
374805deb4
error strings should not be capitalized
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
1654664b78
could use strings.ReplaceAll instead
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
a6d0335bbb
Use fmt.Fprintf(...) instead of ...
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Benoit Tigeot
a9b7732367
could remove embedded field X from selector
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
9 months ago
Matt Farina
91ecb56355
Removing the alpine test chart
...
A .gitignore was previously setup to ignore this file. When pkg/cmd
was setup the .gitignore was not updated. The change adds the new
location to continue to ignore this file.
Note, the previous location is still included in the .gitignore
because developers will have a file there and we do not want that
accidently included in a commit.
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
Benoit Tigeot
e7eedae97c
Use the logger with proper handling of dynamic debug on 2 locations
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
cbaac7652d
Call slog directly instead of using a wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
6b5fa33633
debug log level is dynamic and set after Logger creation
...
So we should use dynamic handler to set the log level after. With this
patch we can clearly see the output. Before we were always stuck in log
level "info" and not seeing debug log level
```
bin/helm upgrade --install --debug --wait frontend \
--namespace test \
--set replicaCount=2 \
--set backend=http://backend-podinfo:9898/echo \
podinfo/podinfo
level=DEBUG msg="getting history for release" release=frontend
level=DEBUG msg="preparing upgrade" name=frontend
level=DEBUG msg="performing update" name=frontend
level=DEBUG msg="creating upgraded release" name=frontend
level=DEBUG msg="checking resources for changes" resources=2
level=DEBUG msg="no changes detected" kind=Service name=frontend-podinfo
level=DEBUG msg="patching resource" kind=Deployment name=frontend-podinfo namespace=test
level=DEBUG msg="waiting for resources" count=2 timeout=5m0s
level=DEBUG msg="waiting for resource" name=frontend-podinfo kind=Deployment expectedStatus=Current actualStatus=Unknown
level=DEBUG msg="updating status for upgraded release" name=frontend
Release "frontend" has been upgraded. Happy Helming!
NAME: frontend
LAST DEPLOYED: Thu Apr 10 09:56:25 2025
NAMESPACE: test
STATUS: deployed
REVISION: 6
DESCRIPTION: Upgrade complete
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
0c85456788
Leverage slog.Any for errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
710770eed4
Linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
b2380720eb
Migrate to pure slog without a custom wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
b42767be40
Migrate more code to log adapter
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
83cdffe4ae
Migrate to a dedicated internal package for slog adapter + migrate more
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Benoit Tigeot
fae2345edf
Demonstrate the impact of having Logger defined in kube package
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
Suleiman Dibirov
000c098a41
fix(concurrency): add mutex to protect repoFailList and out in updateCharts
...
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
10 months ago
Austin Abro
83266254f0
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
10 months ago
Austin Abro
386523bdbc
update to get waiter instead of set
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
10 months ago
Matt Farina
e4e602e13c
Error when failed repo update.
...
In Helm v3 we did not change exit codes for existing commands to
maintain compat. A flag was introduced so a failure would result
in a non-0 exit code. A note was left to make this the default
in Helm v4. That's what this change does.
Closes #10016
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
Austin Abro
d78b7e401a
go mod tidy
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
10 months ago
Henrik Gerdes
d22939b439
fix: correct expected number of template files in unit-test
...
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
11 months ago
Austin Abro
0dffe83ef3
warnings
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
e773a810ee
Update pkg/cmd/flags.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
11 months ago
Austin Abro
0b513dcd42
Merge branch 'main' into refactor-wait
11 months ago
Austin Abro
68f72e5c3f
hook only strategy when wait=false
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
022d4db6af
move logic from cmd/helm to pkg/cmd
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
20c75f0c10
fix namespace assignment not passing through
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Rongrong Liu
12b8eb8b61
fix:add proxy support when mTLS configured
...
Signed-off-by: Rongrong Liu <lori.rongrong.liu@gmail.com>
11 months ago
Austin Abro
1704ce3067
Merge branch 'main' into refactor-wait
11 months ago
Austin Abro
d3814d786b
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
f04c456bd6
gofmt
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
9f9eb28fed
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
1cb4e66044
merge conflict
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago
Austin Abro
297f7b9acb
squash
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
11 months ago