879461e499
fix(helm): update TestSqlUpdate to assert label sync transaction
...
Signed-off-by: Jeremy Schoemaker <jeremy@shoemoney.com>
2 days ago
f1eb1698e1
fix(helm): rollback transaction on failed Commit in Update
...
Signed-off-by: Jeremy Schoemaker <jeremy@shoemoney.com>
2 weeks ago
9f87f42380
fix(helm): sync custom_labels_v1 on Update
...
Fix verified RED->GREEN. SQL driver Update never syncs custom_labels_v1 — label changes silently dropped at sql.go:579
Signed-off-by: Jeremy Schoemaker <jeremy@shoemoney.com>
2 weeks ago
d62bee21c2
Merge pull request #32570 from MsfPablo/fix-readiness-log-typo
...
fix: correct 'doest not match' in readiness debug logs
2 weeks ago
1af7ea274a
Merge branch 'main' into fix-readiness-log-typo
2 weeks ago
0f4decb96b
chore(deps): bump the github-actions group across 1 directory with 4 updates ( #32574 )
...
Bumps the github-actions group with 4 updates in the / directory: [github/codeql-action/init](https://github.com/github/codeql-action ), [github/codeql-action/autobuild](https://github.com/github/codeql-action ), [github/codeql-action/analyze](https://github.com/github/codeql-action ) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ).
Updates `github/codeql-action/init` from 4.37.7 to 4.37.8
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ff2f1c621b...db488ddef3https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ff2f1c621b...db488ddef3https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ff2f1c621b...db488ddef3https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ff2f1c621b...db488ddef3
2 weeks ago
fb1930096e
chore(deps): bump the k8s-io group with 7 updates ( #32572 )
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.36.3` | `0.36.4` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.36.3` | `0.36.4` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.36.3` | `0.36.4` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.36.3` | `0.36.4` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.36.3` | `0.36.4` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.36.3` | `0.36.4` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.36.3` | `0.36.4` |
Updates `k8s.io/api` from 0.36.3 to 0.36.4
- [Commits](https://github.com/kubernetes/api/compare/v0.36.3...v0.36.4 )
Updates `k8s.io/apiextensions-apiserver` from 0.36.3 to 0.36.4
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.36.3...v0.36.4 )
Updates `k8s.io/apimachinery` from 0.36.3 to 0.36.4
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.36.3...v0.36.4 )
Updates `k8s.io/apiserver` from 0.36.3 to 0.36.4
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.36.3...v0.36.4 )
Updates `k8s.io/cli-runtime` from 0.36.3 to 0.36.4
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.36.3...v0.36.4 )
Updates `k8s.io/client-go` from 0.36.3 to 0.36.4
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.36.3...v0.36.4 )
Updates `k8s.io/kubectl` from 0.36.3 to 0.36.4
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.36.3...v0.36.4 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.36.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.36.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.36.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.36.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.36.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.36.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.36.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 weeks ago
6888b0a280
fix: correct 'doest not match' in readiness debug logs
...
Signed-off-by: MsfPablo <pablogarciacaceres5@gmail.com>
2 weeks ago
67d54fd880
fix(provenance): support GnuPG keybox (pubring.kbx) keyrings ( #32281 )
...
* fix(provenance): support GnuPG keybox (pubring.kbx) keyrings
Starting with GnuPG 2.1, file-backed public keyrings can use
~/.gnupg/pubring.kbx instead of the legacy pubring.gpg. Helm only read
the legacy format, so chart and plugin verification failed on
installations using the file-backed keybox.
Make the keyring loader format-aware:
- GnuPG keybox (pubring.kbx): extract OpenPGP keyblocks from the
keybox container without adding a dependency. Skip ephemeral blobs,
matching GnuPG's own read behavior.
- ASCII-armored keyrings: load single or concatenated exports.
- Legacy binary packet streams (pubring.gpg): retain the existing path.
defaultKeyring() falls back to pubring.kbx when pubring.gpg is absent.
pubring.gpg keeps precedence when both files exist.
This change covers file-backed public keyrings. It does not read the
SQLite database used by keyboxd, which needs a separate design.
Related to #31836
Signed-off-by: Ruslan Shaydullin <shaydullin.r.d@outlook.com>
* fix(provenance): treat only not-exist as keyring absence in defaultKeyring
A stat error other than 'not exist' (e.g. a permission problem) meant
the file may well be present, but defaultKeyring() skipped past it: an
unreadable pubring.gpg silently lost precedence to pubring.kbx, and the
surfaced error could point at the wrong file. Treat only fs.ErrNotExist
as absence. For any other stat error, return that path unchanged so the
real error surfaces when the keyring is opened.
Signed-off-by: Ruslan Shaydullin <shaydullin.r.d@outlook.com>
---------
Signed-off-by: Ruslan Shaydullin <shaydullin.r.d@outlook.com>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
3 weeks ago
e9b85e4de1
chore(deps): bump github.com/stretchr/testify from 1.12.0 to 1.12.1 ( #32562 )
...
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify ) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/stretchr/testify/releases )
- [Commits](https://github.com/stretchr/testify/compare/v1.12.0...v1.12.1 )
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-version: 1.12.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 weeks ago
9b447b4048
Merge pull request #32485 from Mentigen/fix/stamp-mod-times-normalize
...
fix(chart): normalize StampModTimes timestamp to UTC/truncate + Chart.lock reproducibility test
3 weeks ago
fa9e77c0c3
Merge pull request #32525 from locker95/fix/values-eof-multiple-of-buffer
...
fix(loader): do not drop values files ending at a 4096-byte boundary
3 weeks ago
c000a408b8
chore(deps): bump the github-actions group across 1 directory with 4 updates ( #32556 )
...
Bumps the github-actions group with 4 updates in the / directory: [github/codeql-action/init](https://github.com/github/codeql-action ), [github/codeql-action/autobuild](https://github.com/github/codeql-action ), [github/codeql-action/analyze](https://github.com/github/codeql-action ) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ).
Updates `github/codeql-action/init` from 4.37.6 to 4.37.7
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](5595ccaf91...ff2f1c621bhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](5595ccaf91...ff2f1c621bhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](5595ccaf91...ff2f1c621bhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](5595ccaf91...ff2f1c621b
3 weeks ago
bafdcde8ec
chore(deps): bump github.com/stretchr/testify from 1.11.1 to 1.12.0 ( #32555 )
...
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify ) from 1.11.1 to 1.12.0.
- [Release notes](https://github.com/stretchr/testify/releases )
- [Commits](https://github.com/stretchr/testify/compare/v1.11.1...v1.12.0 )
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-version: 1.12.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 weeks ago
2a29f1770b
chore(deps): bump golang.org/x/crypto from 0.54.0 to 0.55.0 ( #32545 )
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.54.0 to 0.55.0.
- [Commits](https://github.com/golang/crypto/compare/v0.54.0...v0.55.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.55.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 weeks ago
edb94f897d
chore(deps): bump golang.org/x/text from 0.40.0 to 0.41.0 ( #32543 )
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.40.0 to 0.41.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.40.0...v0.41.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.41.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 weeks ago
fd4ed4952b
test(loader): cover 8192-byte EOF boundary for LoadValues
...
Also drop the extra blank line before the test. Addresses review on
#32525 .
Signed-off-by: Dean Chen <862469039@qq.com>
1 month ago
601445e88c
fix(loader): do not drop values files ending at a 4096-byte boundary
...
YAMLReader can return EOF without yielding the last line when that line
has no trailing newline and its length is a multiple of bufio's default
buffer. Read the file fully and ensure a trailing newline before parsing
so compact JSON values files are not silently ignored.
Fixes #32506
Signed-off-by: Dean Chen <862469039@qq.com>
1 month ago
f3d68cdbea
chore(deps): bump the github-actions group with 4 updates ( #32523 )
...
Bumps the github-actions group with 4 updates: [github/codeql-action/init](https://github.com/github/codeql-action ), [github/codeql-action/autobuild](https://github.com/github/codeql-action ), [github/codeql-action/analyze](https://github.com/github/codeql-action ) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ).
Updates `github/codeql-action/init` from 4.37.5 to 4.37.6
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d1ba80a13d...5595ccaf91https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d1ba80a13d...5595ccaf91https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d1ba80a13d...5595ccaf91https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d1ba80a13d...5595ccaf91
1 month ago
a0c2f6dade
fix: bump go.opentelemetry.io/otel to v1.44.0 for GO-2026-5158 ( #32521 )
...
* fix: bump go.opentelemetry.io/otel to v1.44.0 for GO-2026-5158
govulncheck on main flags GO-2026-5158 in go.opentelemetry.io/otel@v1.43.0
(fixed in v1.44.0). Bump the transitive otel dependency to clear the
vulnerability.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
* fix: bump otel/sdk and otel/sdk/metric to v1.44.0 for version parity
Keep the lockstep-versioned OpenTelemetry core and SDK modules aligned at
v1.44.0 to avoid version skew.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
---------
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 month ago
f8a308cd47
chore(deps): bump github.com/santhosh-tekuri/jsonschema/v6 ( #32514 )
...
Bumps [github.com/santhosh-tekuri/jsonschema/v6](https://github.com/santhosh-tekuri/jsonschema ) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/santhosh-tekuri/jsonschema/releases )
- [Commits](https://github.com/santhosh-tekuri/jsonschema/compare/v6.0.2...v6.0.3 )
---
updated-dependencies:
- dependency-name: github.com/santhosh-tekuri/jsonschema/v6
dependency-version: 6.0.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 month ago
e8a24895d1
Merge pull request #31580 from biagiopietro/feature/rollback-description-flag
...
feat(rollback): add --description flag to provide rollback reason
1 month ago
819e069eb9
Merge pull request #32516 from helm/dependabot/github_actions/main/github-actions-abda45ccb9
...
chore(deps): bump the github-actions group with 4 updates
1 month ago
47eb219a71
chore(deps): bump the github-actions group with 4 updates
...
Bumps the github-actions group with 4 updates: [github/codeql-action/init](https://github.com/github/codeql-action ), [github/codeql-action/autobuild](https://github.com/github/codeql-action ), [github/codeql-action/analyze](https://github.com/github/codeql-action ) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ).
Updates `github/codeql-action/init` from 4.37.4 to 4.37.5
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f205ea1c33...d1ba80a13dhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f205ea1c33...d1ba80a13dhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f205ea1c33...d1ba80a13dhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f205ea1c33...d1ba80a13d
1 month ago
b44d98328b
Merge branch 'helm:main' into feature/rollback-description-flag
1 month ago
ae877c8bfb
chore(deps): bump the github-actions group with 4 updates ( #32508 )
...
Bumps the github-actions group with 4 updates: [github/codeql-action/init](https://github.com/github/codeql-action ), [github/codeql-action/autobuild](https://github.com/github/codeql-action ), [github/codeql-action/analyze](https://github.com/github/codeql-action ) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ).
Updates `github/codeql-action/init` from 4.37.3 to 4.37.4
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e4fba868fa...f205ea1c33https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e4fba868fa...f205ea1c33https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e4fba868fa...f205ea1c33https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e4fba868fa...f205ea1c33
1 month ago
2b239b84e4
Merge branch 'helm:main' into feature/rollback-description-flag
1 month ago
a8ab76e86f
test(action): poll for the interrupted install goroutine instead of a zero-margin sleep ( #32328 )
...
TestInstallRelease_Wait_Interrupted and
TestInstallRelease_RollbackOnFailure_Interrupted assert that the detached
installation goroutine has exited by sleeping a fixed 10s -- exactly the
FailingKubeClient WaitDuration the goroutine blocks on. Sleeping the same
duration the goroutine takes is a zero-margin race: if the goroutine
finishes a hair after the fixed sleep elapses (scheduler jitter under load),
getGoroutineCount() has not decremented yet and the assertion flakes.
Replace the fixed sleep + point-in-time assert with is.Eventually polling
getGoroutineCount() (30s ceiling, 10ms tick). It returns as soon as the
goroutine has actually finished and no longer races the exact wait
duration. Test-only; no change to install behavior.
Signed-off-by: Nikolaus Schuetz <nikolauspschuetz@gmail.com>
1 month ago
ac1c68746f
chore(deps): bump actions/stale in the github-actions group ( #32487 )
...
Bumps the github-actions group with 1 update: [actions/stale](https://github.com/actions/stale ).
Updates `actions/stale` from 10.4.0 to 11.0.0
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](1e223db275...4391f3da66
1 month ago
9b1eb018a3
Merge pull request #32339 from 1solomonwakhungu/fix/get-helm-cache-busting
...
fix(scripts): add cache-busting to Helm version checks
1 month ago
e923167513
test(package): fix errorlint + exact path match in lock test
...
- Replace `err == io.EOF` with `errors.Is(err, io.EOF)` (errorlint).
- Match Chart.lock by full tar path ("chart-with-lock/Chart.lock")
instead of path.Base to avoid false positives from subchart lock files.
- Break out of the loop after finding the entry (early exit).
Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
1 month ago
3c3be926aa
fix(chart): normalize StampModTimes timestamp + Chart.lock test
...
Closes #32396 .
StampModTimes now normalizes the supplied time to UTC and truncates to
whole seconds before stamping. Without this, an SDK caller passing a
local-timezone or sub-second time.Time would produce a Chart.lock
generated: field with a timezone offset or fractional seconds, making
the lock file content non-reproducible across machines even when the
same SOURCE_DATE_EPOCH value is used — defeating the purpose of the
feature.
Also add:
- testdata/charts/chart-with-lock fixture: a minimal chart with a
Chart.lock whose generated: timestamp predates SOURCE_DATE_EPOCH.
- TestRunWithSourceDateEpochStampsLockGenerated: packages the fixture
with SourceDateEpoch set to a non-UTC, sub-second time.Time and
asserts that the resulting archive's Chart.lock entry has both the
correct tar modtime and the correct (normalized) generated: value in
the marshaled YAML.
Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
1 month ago
7e641d30a9
Merge pull request #32481 from mmorel-35/gofumpt
...
chore: fix gofumpt issues
1 month ago
fda6e6043d
Merge pull request #32484 from helm/dependabot/go_modules/main/go.yaml.in/yaml/v3-3.0.5
...
chore(deps): bump go.yaml.in/yaml/v3 from 3.0.4 to 3.0.5
1 month ago
ce27485634
chore(deps): bump go.yaml.in/yaml/v3 from 3.0.4 to 3.0.5
...
Bumps [go.yaml.in/yaml/v3](https://github.com/yaml/go-yaml ) from 3.0.4 to 3.0.5.
- [Commits](https://github.com/yaml/go-yaml/compare/v3.0.4...v3.0.5 )
---
updated-dependencies:
- dependency-name: go.yaml.in/yaml/v3
dependency-version: 3.0.5
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 months ago
bc0114c708
fix(scripts): clarify cache-busting behavior
...
Signed-off-by: Solomon Wakhungu <65043605+1solomonwakhungu@users.noreply.github.com>
2 months ago
24bbb46c62
chore: fix gofumpt issues
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
bbaf420a10
fix(scripts): address cache-busting review feedback
...
Signed-off-by: Solomon Wakhungu <65043605+1solomonwakhungu@users.noreply.github.com>
2 months ago
f3edb83df4
Make golangci-lint happy
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
94a3315f4d
Added missing import
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
500f02d597
Readded "unicode/utf8"
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
f1ede7c9c1
Potential fix for pull request finding
...
If the CLI-side description validation is removed, the unicode/utf8 import becomes unused and should also be dropped.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
4fcc4e4b3d
Apply suggestions from code review
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
91520a7806
refactor(rollback): validate description length before cluster reachability check
...
Move description length validation to the beginning of Run(), before
IsReachable(), so programmatic callers get an immediate validation
error instead of a potentially misleading cluster reachability failure.
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
e73dfab5fb
refactor(test): reuse existing rollback.txt golden file
...
Remove duplicate rollback-with-description.txt fixture that had
identical content to rollback.txt.
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
b177a8e906
Removed extra space in rollback-with-description.txt
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
a92611c202
Enhance rune count in pkg/cmd/rollback.go and pkg/action/rollback.go
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
8a34f3b7b4
Use rune count to count properly multi-byte UTF-8 characters
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
cb91040c44
Enhanced rollback description length
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
e69e424ab1
Changed if construction
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
Jeremy Schoemaker
Robert Sirchia
dependabot[bot]
MsfPablo
Ruslan Shaydullin
George Jenkins
Matt Farina
Dean Chen
Terry Howe
MrJack
Nikolaus Schuetz
Ilya Kiselev
Solomon Wakhungu
Matthieu MOREL