Enhanced the isExplicitEmptyOverride function to correctly identify
empty maps and placeholders created by --set key={}, preventing
unintentional reintroduction of chart defaults. Added regression
tests to ensure proper treatment of empty map placeholders and
validated that CLI values maintain empty maps after coalescing.
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
Reordered coalesceValues and coalesceTablesFullKey to convert
explicit empty overrides into empty maps before merging. This
prevents default map entries from resurfacing, even for nested
tables. Additionally, the regression suite is expanded to cover
nested empty overrides, ensuring empty maps are preserved across
different override shapes.
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
This change is about handling the interfaces to public functions for
different chart apiVersions. The internals are still focused on v2.
This enables v3 to be layered in layer.
Signed-off-by: Matt Farina <matt.farina@suse.com>
Close: #31231
```
Error: cmd/helm/root.go:165:2: SA1019: flags.ParseErrorsWhitelist is deprecated: use [FlagSet.ParseErrorsAllowlist] instead. This field will be removed in a future release. (staticcheck)
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
When --skip-schema-validation is enabled, the lint command will now skip
JSON schema validation for values.yaml files, allowing charts with schema
validation errors to pass linting when the flag is used.
This addresses the gap where --skip-schema-validation only applied to
templates but not to values files, providing complete schema validation
bypass when needed.
Fixes: #13413
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.
To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:
1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
provide access to its data via an interface. There is an
interface, factory, and implementation for each version of
chart.
3. Common packages were moved to a common and util packages.
Due to some package loops, there are 2 packages which may
get some consolidation in the future.
The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.
Signed-off-by: Matt Farina <matt.farina@suse.com>
The repo package is internally versioned at v1. Repos were designed
to be versioned. This change moves it to a versioned directory the
same way other packages are now being handled.
Signed-off-by: Matt Farina <matt.farina@suse.com>
Siew Kam Onn
George Jenkins
Robert Sirchia
Matt Farina
Terry Howe
copilot-swe-agent[bot]
reddaisyy
bennsimon
Benoit Tigeot
Scott Rigby
Stephanie Hohenberg
Jesse Simpson
Kamil Swiechowski