Siew Kam Onn
69d007f70e
Add helper function calls in TestMergeValuesExplicitEmptyOverrides for clarity
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
3 months ago
Siew Kam Onn
dfa49faa79
Fix isExplicitEmptyOverride for empty maps handling
...
Enhanced the isExplicitEmptyOverride function to correctly identify
empty maps and placeholders created by --set key={}, preventing
unintentional reintroduction of chart defaults. Added regression
tests to ensure proper treatment of empty map placeholders and
validated that CLI values maintain empty maps after coalescing.
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
3 months ago
Siew Kam Onn
47956d503a
Update TestParseSet to handle nested empty lists in input
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
3 months ago
Siew Kam Onn
b099506632
Refactor coalesce functions to handle empty maps
...
Reordered coalesceValues and coalesceTablesFullKey to convert
explicit empty overrides into empty maps before merging. This
prevents default map entries from resurfacing, even for nested
tables. Additionally, the regression suite is expanded to cover
nested empty overrides, ensuring empty maps are preserved across
different override shapes.
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
3 months ago
Siew Kam Onn
2f2a54a0aa
Refactor tests in coalesce_test.go to use require and assert for better error handling and readability
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
3 months ago
Siew Kam Onn
cf8ebe8e5c
Clarify behavior for empty destination tables in coalesceTablesFullKey function
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
3 months ago
Siew Kam Onn
7a54bdca44
Add test for CoalesceTables with empty destination table
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
3 months ago
Siew Kam Onn
58aaf2f263
Add test for coalescing values with empty map overrides
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
3 months ago
George Jenkins
23c5662019
Merge pull request #31254 from benoittgt/fix-31253-closest-version
...
Warn when we fallback to a different version on `helm pull`
4 months ago
George Jenkins
561a7da61c
Merge pull request #31297 from TerryHowe/fix-hide-notes-in-helm-test
...
fix: hide notes in helm test command
4 months ago
George Jenkins
891338cd05
Merge pull request #31315 from benoittgt/avoid-golint-warning
...
Remove unused golangci-lint rules that produce warning
4 months ago
Benoit Tigeot
34c2d5c1a9
Remove unused golangci-lint rules that produce warning
...
Avoid this noisy output when running local linting:
```sh
❯ golangci-lint run ./...
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Text: "var-naming: avoid meaningless package names", Linters: "revive"]
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Robert Sirchia
5b43b744b8
Merge pull request #31294 from TerryHowe/feature-remove-implicit-directory-from-helm-lint
...
Remove implicit support for helm lint current directory
4 months ago
Robert Sirchia
fdb5e1a97a
Merge pull request #31301 from TerryHowe/chore-remove-helm-version-client
...
chore: remove helm version `--client` option
4 months ago
Matt Farina
d2236e95ed
Merge pull request #31303 from mattfarina/unified-loader
...
Update the action interfaces for chart apiversions
4 months ago
Matt Farina
8dc7c57f50
Update the action interfaces for chart apiversions
...
This change is about handling the interfaces to public functions for
different chart apiVersions. The internals are still focused on v2.
This enables v3 to be layered in layer.
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 months ago
Terry Howe
469f4b457c
chore: remove helm version client option
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Matt Farina
90a91e097f
Merge pull request #31198 from TerryHowe/fix-pkg-engine-error-parsing
...
fix: replace pkg/engine regular expressions with parser
4 months ago
Matt Farina
da595e0e71
Merge pull request #31293 from TerryHowe/copilot/fix-8
...
chore: remove pkg/time which is no longer needed
4 months ago
Matt Farina
0befdb90a1
Merge pull request #31287 from miledxz/fileutil-tests-improvements
...
improve fileutil test coverage
4 months ago
Matt Farina
c722b3da16
Merge pull request #31292 from reddaisyy/main
...
refactor: use strings.builder
4 months ago
Terry Howe
dab4fd2909
fix: hide notes in helm test command
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
copilot-swe-agent[bot]
838c36a0f6
Remove implicit support for helm lint current directory
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
3e1dd9a5dc
chore: remove pkg/time which is no longer needed
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
reddaisyy
1c67fbf108
refactor: use strings.builder
...
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
4 months ago
Terry Howe
b2870379c8
Update pkg/engine/engine.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
91a65234ac
Update pkg/engine/engine.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Terry Howe
9112687a7e
Update pkg/engine/engine.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Matt Farina
ff61915cda
Merge pull request #31279 from helm/dependabot/go_modules/main/k8s-io-f3078102d3
...
chore(deps): bump the k8s-io group with 7 updates
4 months ago
Robert Sirchia
b8928db403
Merge pull request #31286 from yajianggroup/main
...
refactor: use strings.CutPrefix
4 months ago
Mile Druzijanic
934b4550d9
improve fileutil test coverage
...
Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>
4 months ago
Scott Rigby
78309b3d45
Merge pull request #31285 from bennsimon/remove-metadata-output-helm-template
...
fix: remove leftover debugging line that outputs invalid YAML for helm template command
4 months ago
yajianggroup
cfaf30083a
refactor: use strings.CutPrefix
...
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
4 months ago
bennsimon
db50c37eda
remove metadata output on helm template
...
Signed-off-by: bennsimon <bennsimonotieno@gmail.com>
4 months ago
dependabot[bot]
fcd082e034
chore(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.34.0` | `0.34.1` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.34.0` | `0.34.1` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.34.0` | `0.34.1` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.34.0` | `0.34.1` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.34.0` | `0.34.1` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.34.0` | `0.34.1` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.34.0` | `0.34.1` |
Updates `k8s.io/api` from 0.34.0 to 0.34.1
- [Commits](https://github.com/kubernetes/api/compare/v0.34.0...v0.34.1 )
Updates `k8s.io/apiextensions-apiserver` from 0.34.0 to 0.34.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.34.0...v0.34.1 )
Updates `k8s.io/apimachinery` from 0.34.0 to 0.34.1
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.34.0...v0.34.1 )
Updates `k8s.io/apiserver` from 0.34.0 to 0.34.1
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.34.0...v0.34.1 )
Updates `k8s.io/cli-runtime` from 0.34.0 to 0.34.1
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.34.0...v0.34.1 )
Updates `k8s.io/client-go` from 0.34.0 to 0.34.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.34.0...v0.34.1 )
Updates `k8s.io/kubectl` from 0.34.0 to 0.34.1
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.34.0...v0.34.1 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.34.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.34.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.34.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.34.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.34.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.34.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.34.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
Robert Sirchia
5534c01cdb
Merge pull request #31277 from benoittgt/31234-fix
...
Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10
4 months ago
Benoit Tigeot
99e5fce71a
Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10
...
Close : #31231
```
Error: cmd/helm/root.go:165:2: SA1019: flags.ParseErrorsWhitelist is deprecated: use [FlagSet.ParseErrorsAllowlist] instead. This field will be removed in a future release. (staticcheck)
```
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
Matt Farina
1a06fe9901
Merge pull request #31275 from benoittgt/13414-v2
...
Extend --skip-schema-validation for lint command
4 months ago
Matt Farina
c9da6b0edd
Merge pull request #31273 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.42.0
...
chore(deps): bump golang.org/x/crypto from 0.41.0 to 0.42.0
4 months ago
Benoit Tigeot
072e2a689a
Extend --skip-schema-validation for lint command
...
When --skip-schema-validation is enabled, the lint command will now skip
JSON schema validation for values.yaml files, allowing charts with schema
validation errors to pass linting when the flag is used.
This addresses the gap where --skip-schema-validation only applied to
templates but not to values files, providing complete schema validation
bypass when needed.
Fixes : #13413
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
4 months ago
dependabot[bot]
62cd5d8ba8
chore(deps): bump golang.org/x/crypto from 0.41.0 to 0.42.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.41.0 to 0.42.0.
- [Commits](https://github.com/golang/crypto/compare/v0.41.0...v0.42.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.42.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
Matt Farina
71cd76cacd
Merge pull request #31264 from helm/dependabot/go_modules/main/golang.org/x/term-0.35.0
...
chore(deps): bump golang.org/x/term from 0.34.0 to 0.35.0
4 months ago
Matt Farina
7ca094d78a
Merge pull request #31266 from helm/dependabot/go_modules/main/sigs.k8s.io/controller-runtime-0.22.1
...
chore(deps): bump sigs.k8s.io/controller-runtime from 0.22.0 to 0.22.1
4 months ago
Matt Farina
4502836bc9
Merge pull request #31272 from TerryHowe/fix-idea-gitignore-file
...
fix: idea gitignore entry
4 months ago
Terry Howe
b539309aa2
fix: idea gitignore entry
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Scott Rigby
315b13334c
Merge pull request #31258 from StephanieHhnbrg/test-unreachable-client
...
Refactor unreachableKubeClient for testing into failingKubeClient
4 months ago
dependabot[bot]
86c19fdc2a
chore(deps): bump sigs.k8s.io/controller-runtime from 0.22.0 to 0.22.1
...
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime ) from 0.22.0 to 0.22.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases )
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.22.0...v0.22.1 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
dependency-version: 0.22.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
dependabot[bot]
fae2736d1b
chore(deps): bump golang.org/x/term from 0.34.0 to 0.35.0
...
Bumps [golang.org/x/term](https://github.com/golang/term ) from 0.34.0 to 0.35.0.
- [Commits](https://github.com/golang/term/compare/v0.34.0...v0.35.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/term
dependency-version: 0.35.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
Scott Rigby
cd78e2396b
Merge pull request #31259 from StephanieHhnbrg/test-coverage-makefile
...
Adapt test-coverage command to be able to run for a certain package
4 months ago
Stephanie Hohenberg
e19d9fb6ee
Refactor unreachableKubeClient for testing into failingKubeClient
...
Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>
4 months ago