Matthieu MOREL
259f76a849
fix(pkg): errorlint linter
...
errorlint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
025418291a
fix(internal): errorlint linter
...
errorlint linter in internal/third_party/dep/fs
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
6d1490ed1e
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
4d0ae7f33a
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
abecafa0f5
fix(internal): errorlint linter
...
#### Description
errorlint linter in internal
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
4330bdea04
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
c8989d984f
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
Matthieu MOREL
edbd705bd0
fix(cmd): errorlint linter
...
#### Description
errorlint linter in cmd/helm
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
George Jenkins
5638c35399
chore: new KEYS entry for George Jenkins
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
Terry Howe
9b22aa4e05
Merge pull request #31795 from mmorel-35/modernize-internal-1-bbfa1fe
...
chore(internal): fix modernize linter
3 months ago
Joe Julian
c040f470ac
Merge pull request #31799 from mmorel-35/modernize-internal-2-d850a43
...
chore(internal): fix modernize linter
3 months ago
Orgad Shaneh
76eb37c01a
fix(downloader): safely handle concurrent file writes on Windows
...
When multiple processes try to download the same chart version
concurrently (e.g., via Terraform), they can race to write the
destination file. On Windows, this results in 'Access Denied'
errors because the file cannot be renamed while another process
has a handle to the destination.
This commit introduces 'PlatformAtomicWriteFile' to the fileutil
package. On Unix-like systems, it simply delegates to AtomicWriteFile,
maintaining existing behavior. On Windows, it coordinates writes using
a lock file (.lock). It acquires the lock, then performs the atomic
write.
Crucially, this implementation ensures that existing files are
overwritten (rather than skipped). This ensures that if a chart is
republished with the same version, the local cache is correctly updated,
preventing stale data issues.
Fixes #31633
Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>
3 months ago
Terry Howe
1468449ff5
Merge pull request #31794 from mmorel-35/modernize-pkg-1-f9be97c
...
chore(pkg): fix modernize linter
3 months ago
Manuel Alonso
9817a68618
fix(install): check nil for restClientGetter and fix tests
...
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
3 months ago
Evans Mungai
5aac32077f
feat(create): add --chart-api-version flag (when HELM_EXPERIMENTAL_CHART_V3 env var is set) ( #31592 )
...
* feat(create): add hidden --chart-api-version flag
Add --chart-api-version flag to helm create command to allow selecting
chart API version (v2 or v3) when creating a new chart.
- Default is v2 (existing behavior unchanged)
- v3 uses internal/chart/v3 scaffold generator
- Invalid versions return clear error message
- Works with --starter flag
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add HELM_EXPERIMENTAL_CHART_V3 feature gate to create command
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* make chartv3 private and use loader to load the chart
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Hide chart-api-version flag until chart v3 is officially released
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Conditionally hide the --chart-api-version flag if chart v3 is not enabled
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add internal gates package for internal feature gates
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
* Add doc for internal/gates package
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
---------
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago
Matthieu MOREL
0d75d8611d
chore(pkg): fix modernize linter
...
#### Description
fix modernize linter in pkg/engine
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
859292e31b
chore(internal): fix modernize linter
...
#### Description
fix modernize linter in internal/chart/v3
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
5cc2e55714
chore(pkg): fix modernize linter
...
#### Description
fix modernize linter in pkg/chart/v2/lint/rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
ba38159313
chore(pkg): fix modernize linter
...
#### Description
fix modernize linter in pkg/strvals
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
e2d184c79e
chore(internal): fix modernize linter
...
#### Description
fix modernize linter in internal/chart/v3/lint/rules
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Matthieu MOREL
111d4e6e0e
chore(pkg): fix modernize linter
...
#### Description
fix modernize linter in pkg/chart/common/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 months ago
Robert Sirchia
fbb8de54be
Merge pull request #31773 from helm/dependabot/go_modules/main/github.com/lib/pq-1.11.1
...
chore(deps): bump github.com/lib/pq from 1.10.9 to 1.11.1
3 months ago
Evans Mungai
5b78ee8dff
Merge pull request #31644 from banjoh/em/fix-nil-values
...
fix(values): preserve nil values when chart default is empty map
3 months ago
Pedro Tôrres
e8f386b5aa
add image index test
...
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
3 months ago
Pedro Tôrres
d983696e35
fix pulling charts from OCI indices
...
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
3 months ago
dependabot[bot]
9c9c3a6b5c
chore(deps): bump github.com/lib/pq from 1.10.9 to 1.11.1
...
Bumps [github.com/lib/pq](https://github.com/lib/pq ) from 1.10.9 to 1.11.1.
- [Release notes](https://github.com/lib/pq/releases )
- [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lib/pq/compare/v1.10.9...v1.11.1 )
---
updated-dependencies:
- dependency-name: github.com/lib/pq
dependency-version: 1.11.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
George Jenkins
e685076bc0
Merge pull request #31772 from matheuscscp/revert-12581
...
Revert "Consider GroupVersionKind when matching resources"
3 months ago
Matheus Pimenta
787b61cedb
Revert "Consider GroupVersionKind when matching resources"
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
Matt Farina
75880fa498
Merge pull request #31751 from gitgrave/fix-31750
...
fix(copystructure): handle nil elements in slice copying
3 months ago
Matt Farina
72c0c28207
Merge pull request #31753 from helm/dependabot/github_actions/main/actions/checkout-6.0.2
...
chore(deps): bump actions/checkout from 6.0.1 to 6.0.2
3 months ago
Matt Farina
a586a05474
Merge pull request #31754 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-0.37.1-flux.1
...
chore(deps): bump github.com/fluxcd/cli-utils from 0.37.0-flux.1 to 0.37.1-flux.1
3 months ago
Matt Farina
1650c26f5d
Merge pull request #31765 from helm/dependabot/go_modules/main/sigs.k8s.io/controller-runtime-0.23.1
...
chore(deps): bump sigs.k8s.io/controller-runtime from 0.23.0 to 0.23.1
3 months ago
dependabot[bot]
becf9bf7e3
chore(deps): bump sigs.k8s.io/controller-runtime from 0.23.0 to 0.23.1
...
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime ) from 0.23.0 to 0.23.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases )
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.23.0...v0.23.1 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
dependency-version: 0.23.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Scott Rigby
f928025cdb
Merge pull request #31717 from AustinAbro321/use-logger-with-waiter
...
fix: use kube logger with status waiter
3 months ago
Evans Mungai
9211dfef6a
Merge pull request #31743 from banjoh/em/document-uninstall-using-cascade
...
docs: document uninstall using cascade foreground flag
3 months ago
dependabot[bot]
b53198e7ee
chore(deps): bump github.com/fluxcd/cli-utils
...
Bumps [github.com/fluxcd/cli-utils](https://github.com/fluxcd/cli-utils ) from 0.37.0-flux.1 to 0.37.1-flux.1.
- [Commits](https://github.com/fluxcd/cli-utils/compare/v0.37.0-flux.1...v0.37.1-flux.1 )
---
updated-dependencies:
- dependency-name: github.com/fluxcd/cli-utils
dependency-version: 0.37.1-flux.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
dependabot[bot]
b59e533b76
chore(deps): bump actions/checkout from 6.0.1 to 6.0.2
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](8e8c483db8...de0fac2e45 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Austin Abro
ec0726523e
whitespace
...
Signed-off-by: Austin Abro <austinabro321@gmail.com>
3 months ago
Philipp Born
e3829ebbbb
fix(copystructure): handle nil elements in slice copying
...
When copying slices containing nil interface{} elements, the copyValue
function would panic with 'reflect: call of reflect.Value.Set on zero
Value'. This occurred because reflect.ValueOf(nil) returns a zero Value
that cannot be set.
This issue was introduced in v4.1.0 when replacing mitchellh/copystructure
with an internal implementation. The fix mirrors the existing nil handling
logic used for map values.
Fixes helm template panic when processing charts with YAML like:
extraArgs:
-
Added test case to verify slice elements with nil values are properly
handled during deep copy operations.
Signed-off-by: Philipp Born <git@pborn.eu>
3 months ago
Austin Abro
63b40a7a5e
use logger with waiter
...
Signed-off-by: Austin Abro <austinabro321@gmail.com>
3 months ago
George Jenkins
340b06d8f3
Merge pull request #31739 from gjenkins8/gjenkins/tidy_helmv3_contributing
...
Modernize Helm v3 CONTRIBUTING.md
3 months ago
Matt Farina
83e1f2f547
Merge pull request #31742 from JeevanYewale/remove-legacy-sync-script
...
Remove legacy sync-repo.sh script
3 months ago
George Jenkins
f9db0ca185
Merge pull request #31735 from matheuscscp/fine-grained-wait-ctx
...
feat(kstatus): fine-grained context options for waiting
3 months ago
Matheus Pimenta
b0b35f1231
feat(kstatus): fine-grained context options for waiting
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
3 months ago
George Jenkins
26e28e846a
Apply suggestions from code review
...
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
Robert Sirchia
11dd6ec0c4
Merge pull request #31744 from helm/dependabot/go_modules/main/sigs.k8s.io/controller-runtime-0.23.0
...
chore(deps): bump sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.0
3 months ago
Jeevan Yewale
97fd00786f
Remove legacy sync-repo.sh script
...
Signed-off-by: Jeevan Yewale <jeevanyewale4@gmial.com>
3 months ago
dependabot[bot]
52620076e2
chore(deps): bump sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.0
...
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime ) from 0.22.4 to 0.23.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases )
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.22.4...v0.23.0 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
dependency-version: 0.23.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
3 months ago
Scott Rigby
6e38e303c3
Merge pull request #31730 from matheuscscp/fix-kstatus-failed
...
bugfix(kstatus): do not wait forever on failed resources
3 months ago
Evans Mungai
e70d59de7c
docs: document uninstall using cascade foreground flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
3 months ago