Josh Dolitsky
4884ca0059
revert change related to reading prov file
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
ec84339d44
return errors directly, less lines of code
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
fc98f2e6a3
add checkOCI helper method
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
a38f56c692
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Matt Farina
eb99434597
Merge pull request #9871 from mattfarina/logging-for-creds
...
Fix the url being set by WithURL on the getters
4 years ago
Josh Dolitsky
230e37ca52
remove hardcoded oci strings, add constant/util
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Matt Farina
385fcae1ba
Adding test for user/pass without repo on Helm install
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 years ago
Josh Dolitsky
bfa5036a1a
consolidate registry source files
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
4d948b4a06
return err directly from pusher.Push
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
faf7fc5efd
use version.GetUserAgent
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
31588e7908
do not re-use err
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
1809cc0509
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Matt Farina
4e2e4084ed
Fix the url being set by WithURL on the getters
...
The URL passed to the getter for WithURL needs to be a full URL
rather than a chart reference used at the CLI. For example,
bitnami/wordpress can point to the wordpress chart in the bitnami
repo where the bitnami repo is at https://charts.bitnami.com .
WithURL needs the full URL to the repo and not bitnami/wordpress.
This is important because getters use the full URL information.
In this case the http getter uses the host name for SNI handling.
Before this change WithURL was being set to the chart reference
instead of the URL. This was a silent bug.
This change sets WithURL using a URL after for the repo is
available when a reference is used instead of a full url.
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 years ago
Martin Hickey
ae8e88e0d9
Merge pull request #9862 from longkai/refine-http-req
...
refactor(getter): refine http GET request
4 years ago
longkai
0d9ebc7885
refactor(getter): refine http GET request
...
It just makes the code better, I suppose the following is rational:
- use standard libaray common constants instead of hardcode though it's
really common
- close the response body even if the http status code is not 200 OK.
The doc says *It is the caller's responsibility to close Body*.
- move the `bytes.Buffer` return value declaration where it gets used.
Signed-off-by: longkai <im.longkai@gmail.com>
4 years ago
Josh Dolitsky
56028e8d0d
modify helm push help text
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
1fe2024be3
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Adam Reese
fa558f7843
Merge pull request #9828 from cvila84/dep-tls-config
...
use TLS client information from repo config when downloading a chart
4 years ago
Josh Dolitsky
4ed8e77026
remove tmp path in case it exists
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
e5b03c73f0
do not update oci-based repos
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
e856df8a54
provide hint if attempting to push directory
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
04d2da3637
return friendly error if missing scheme
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
3e17c1a7ef
remove action errors assuming CLI
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
35fdc688cd
remove the --with-prov option
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
eba63beab1
move experimental actions to new internal package
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
8f60ee76a5
resolve golint errors
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
24a216d3b2
move pkg/uploader, pkg/pusher to internal
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
4073e4d118
inline data fetching for pull result
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
dd7bc40bc4
one-line JSON unmarshall
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
817ac8ff9f
do not wrap single imports/vars
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Christophe VILA
8232a76aef
use TLS client information from repo config when downloading a chart
...
Signed-off-by: Christophe VILA <christophe.vila@thalesgroup.com>
4 years ago
Josh Dolitsky
cd27cf660f
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Matt Farina
179f90151d
Merge pull request from GHSA-56hp-xqp3-w2jf
...
tweak basic handling
4 years ago
Matt Farina
17ed9c4cd3
tweak basic handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 years ago
Martin Hickey
3e1da5f39c
Merge pull request #9795 from helm/release-3.6
...
Cherry-pick off the current PRs merged for 3.6.1 release
4 years ago
Mike Ng
877276ceda
keep existing behavior of returning ErrReleaseNotFound when release(s) failed to decode
...
Signed-off-by: Mike Ng <ming@redhat.com>
(cherry picked from commit 3be333b73b
)
4 years ago
Mike Ng
f2d7ed8d80
fix(sql storage): Query() should return ErrReleaseNotFound immediately when no records are found
...
Signed-off-by: Mike Ng <ming@redhat.com>
(cherry picked from commit b86105aebc
)
4 years ago
Leon Bentrup
c084ca0259
Add Test cases for repository-config without file extension
...
Signed-off-by: Leon Bentrup <4458913+xanecs@users.noreply.github.com>
(cherry picked from commit ccada716ee
)
4 years ago
Leon Bentrup
7d81733af7
Correctly determine repository-config lockfile path
...
helm repo add automatically creates a lockfile based on the repository config file path
When the given filepath did not include a file extension, a lockfile in a nonexistent directory
would have been created.
Signed-off-by: Leon Bentrup <4458913+xanecs@users.noreply.github.com>
(cherry picked from commit f091b9cc01
)
4 years ago
Marcus Speight
cbd2868ac2
Fixed Test
...
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
Signed-off-by: Marcus Speight <marcus@pmconnect.co.uk>
(cherry picked from commit 7a663a56c2
)
4 years ago
Marcus Speight
9fbf594b80
Added test for lint mode
...
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
(cherry picked from commit 8aa42824f9
)
4 years ago
Marcus Speight
bcee7a30fe
Fail message is now the same as the required message.
...
Fixed #8973 Helm function 'fail' should not fail when doing 'helm lint'
Signed-off-by: Marcus Speight <marcus.speight@hotmail.co.uk>
(cherry picked from commit 7a0739a863
)
4 years ago
yxxhero
80402dc078
fix helm dep build/update doesn't inherit --insecure-skip-tls-verify from helm repo add
...
Signed-off-by: yxxhero <aiopsclub@163.com>
(cherry picked from commit f735a240b6
)
4 years ago
Josh Dolitsky
f7247c40ee
Upgrade to oras-go v0.4.0
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
866e7e80b6
Upgrade to oras-go v0.3.0
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Josh Dolitsky
4e7a01fa7a
Merge branch 'main' of github.com:helm/helm into hip-6
4 years ago
Martin Hickey
281380f31c
Merge pull request #9659 from mladedav/feature/upgrade-dep-up
...
Feature/upgrade dep up
4 years ago
Martin Hickey
ed7b6c4761
Merge pull request #8470 from mikeshng/sql-query-fix
...
fix(sql storage): Query() should return ErrReleaseNotFound immediately when no records are found
4 years ago
Josh Dolitsky
00985cad6b
Implement changes proposed in HIP 6
...
For more information, please see the following URL:
https://github.com/helm/community/blob/main/hips/hip-0006.md
Note: OCI support remains experimental, and you are still
required to set HELM_EXPERIMENTAL_OCI=1 in your environment.
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
4 years ago
Martin Hickey
bf486a25cd
Merge pull request #8853 from xanecs/master
...
Correctly determine lockfile path in helm repo add
4 years ago