mirror of https://github.com/helm/helm
The URL passed to the getter for WithURL needs to be a full URL rather than a chart reference used at the CLI. For example, bitnami/wordpress can point to the wordpress chart in the bitnami repo where the bitnami repo is at https://charts.bitnami.com. WithURL needs the full URL to the repo and not bitnami/wordpress. This is important because getters use the full URL information. In this case the http getter uses the host name for SNI handling. Before this change WithURL was being set to the chart reference instead of the URL. This was a silent bug. This change sets WithURL using a URL after for the repo is available when a reference is used instead of a full url. Signed-off-by: Matt Farina <matt.farina@suse.com>pull/9871/head
parent
ae8e88e0d9
commit
4e2e4084ed
Loading…
Reference in new issue