8 Commits (release-4.3)

Author	SHA1	Message	Date
Ilya Kiselev	3c3be926aa	fix(chart): normalize StampModTimes timestamp + Chart.lock test ... Closes #32396. StampModTimes now normalizes the supplied time to UTC and truncates to whole seconds before stamping. Without this, an SDK caller passing a local-timezone or sub-second time.Time would produce a Chart.lock generated: field with a timezone offset or fractional seconds, making the lock file content non-reproducible across machines even when the same SOURCE_DATE_EPOCH value is used — defeating the purpose of the feature. Also add: - testdata/charts/chart-with-lock fixture: a minimal chart with a Chart.lock whose generated: timestamp predates SOURCE_DATE_EPOCH. - TestRunWithSourceDateEpochStampsLockGenerated: packages the fixture with SourceDateEpoch set to a non-UTC, sub-second time.Time and asserts that the resulting archive's Chart.lock entry has both the correct tar modtime and the correct (normalized) generated: value in the marshaled YAML. Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>	1 month ago
Lohit Kolluri	ad93b7df63	feat: honor SOURCE_DATE_EPOCH for chart archives (#32162) ... * feat: honor SOURCE_DATE_EPOCH for chart archives Add StampModTimes() on Chart struct to recursively set ModTime on all chart file entries. CLI reads SOURCE_DATE_EPOCH env var and wires through all 5 commands: package, install, upgrade, dep build, dep update. Removes unused v3 duplicate source_date_epoch.go (YAGNI). Inlines env var parsing to CLI layer from chart util. Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com> * docs: document SOURCE_DATE_EPOCH in environment variables help Add a short entry for $SOURCE_DATE_EPOCH to the env var table shown in 'helm help'. The variable is honored by 'helm package', 'install', 'upgrade', 'dep build', and 'dep update' to produce reproducible chart archives. Full documentation belongs in helm-www. Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com> * fix: adapt SourceDateEpoch to upstream refactored dep check Upstream/main restructured the dependency error handling in install.go and upgrade.go from a nested-if block (if DependencyUpdate) to an early-return pattern (if !DependencyUpdate). Adapt the feature's Manager construction to match the new code structure. Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com> --------- Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>	2 months ago
Matthieu MOREL	83a0138172	chore: fix deprecatedComment issues from gocritic ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	6 months ago
George Jenkins	92b64e87ad	chore: fixes ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	7 months ago
Matt Farina	ca8eae9361	Reproducible chart archive builds ... Building the same chart into an archive multiple times will have the same sha256 hash. Perviously, the time in the headers for a file was time.Now() which changed each time. The time is now collected from the operating system when the file is loaded and this time is used. Fixes: #3612 Signed-off-by: Matt Farina <matt.farina@suse.com>	11 months ago
Matt Farina	9dcc49cbd5	Move lint pkg to be part of each chart version ... Linting is specific to the chart versions. A v2 and v3 chart will lint differently. To accomplish this, packages like engine need to be able to handle different chart versions. This was accomplished by some changes: 1. The introduction of a Charter interface for charts 2. The ChartAccessor which is able to accept a chart and then provide access to its data via an interface. There is an interface, factory, and implementation for each version of chart. 3. Common packages were moved to a common and util packages. Due to some package loops, there are 2 packages which may get some consolidation in the future. The new interfaces provide the foundation to move the actions and cmd packages to be able to handle multiple apiVersions of charts. Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Daniel Strobusch	df7befd208	copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies ... Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases. By copying the dependencies, parent information can be set correctly to render the templates as expected later on. Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level. Closes #9150 Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>	1 year ago
Matt Farina	61d3eca55c	Move pkg/chart to pkg/chart/v2 to prepare for v3 charts ... This change moves the code, updates the import locations, and adds a doc.go file to document what the v2 package is for. This is part of HIP 20 for v3 charts Signed-off-by: Matt Farina <matt.farina@suse.com>	2 years ago