4019 Commits (main)

Author	SHA1	Message	Date
Benoit Tigeot	8535e9f4ab	Avoid confusion between `--wait` (watcher) and no --wait (hookOnly) ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	9 months ago
Benoit Tigeot	1836f37f4d	The default is not HookOnlyStrategy but WaitStrategy ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	9 months ago
Benoit Tigeot	a5e110fccd	Make wait strategy selection more obvious ... It is not clear enough that you need to set --wait=false for a hook only strategy. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	9 months ago
Benoit Tigeot	e8b0cff45a	Update pkg/cmd/flags.go ... Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com> Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	9 months ago
Benoit Tigeot	95e1ee1089	Increase documentation of --wait flag ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	9 months ago
Benoit Tigeot	5cbd9b3035	While testing SDK features for v4. I was surprised with the error: ... > "reporter failed to start: event funnel closed: context deadline exceeded" It happens when you forget to set a minimal timeout: ```go upgradeClient := action.NewUpgrade(actionConfig) upgradeClient.WaitStrategy = kube.StatusWatcherStrategy // When Timeout is zero, the status wait uses a context with zero timeout which // immediately expires causing "context deadline exceeded" errors. upgradeClient.Timeout = 2 * time.Minute ``` Also maybe it might be worth documenting this more clearly. Initial [PR](https://github.com/helm/helm/pull/13604) say: > I have not written any docs, I assume that can be done when we are closer to Helm 4, a lot of it is covered by linking to - https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/kstatus/README.md Related: - https://github.com/helm/helm/pull/31411#issuecomment-3443925663 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	9 months ago
saimanojk1	6de83c5f60	Convert pkg/cmd/load_plugins.go to slog ... Signed-off-by: saimanojk1 <saimanojk1@hotmail.com>	9 months ago
Hidde Beydals	d158708fbf	fix(rollback): `errors.Is` instead of string comp ... Signed-off-by: Hidde Beydals <hidde@hhh.computer>	9 months ago
Hidde Beydals	2f1ecc7100	fix(uninstall): supersede deployed releases ... This ensures that when `helm uninstall` is run with `--keep-history` any release in a `deployed` state other than the last release (e.g. due to a failed upgrade) is being marked as `superseded`. As a by-effect, running `helm upgrade` on a release which has been uninstalled after an upgrade failure now no longer works. But instead fails with a `"<name>" has no deployed releases` error. Which is the (likely) intended behavior, and prevents other side-effects like rolling back to a release version which happened before the uninstall if `--atomic` (or `--rollback-on-failure`) was provided. Signed-off-by: Hidde Beydals <hidde@hhh.computer>	9 months ago
George Jenkins	cdb48b88fb	Merge pull request #31240 from benoittgt/fix-31170-URN ... jsonschema: warn and ignore unresolved URN $ref to match v3.18.4	9 months ago
tison	4576a81a00	for remaining local variable case inconsistency ... Signed-off-by: tison <wander4096@gmail.com>	9 months ago
Benoit Tigeot	ed6cf0e8a1	Properly test error messages on pull command's test ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	9 months ago
Matt Farina	0f5eda74c1	Adding a LoadArchive to common loader ... LoadArchive is in the individual loaders for the chart versions. It is used by SDK users to load a stream rather than a file on the filesystem. Adding to support SDK users like Flux. Signed-off-by: Matt Farina <matt.farina@suse.com>	9 months ago
George Jenkins	384a3f0ff8	Merge pull request #31385 from porridge/test-unknown-policy ... test: protect unknown hook delete policies	9 months ago
tison	90d01915f9	for all other similar cases ... Signed-off-by: tison <wander4096@gmail.com>	9 months ago
Scott Rigby	99cd196435	Merge pull request #31435 from matheuscscp/cancel-health-checks ... Introduce a context for canceling wait operations	9 months ago
Matheus Pimenta	efc1702657	Introduce a context for canceling wait operations ... Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	9 months ago
laervn	36aaa9aab9	Merge branch 'helm:main' into feat/add-no-headers-option	9 months ago
George Jenkins	bdc459d73c	Merge pull request #31389 from TerryHowe/chore-more-registry-clean-up ... chore: fix pkg/registry warnings to reduce noise	10 months ago
Paul Van Laer	6ef79bb8d5	feat(repo): add --no-headers option to 'helm repo list' ... This adds a --no-headers flag to the 'helm repo list' command, allowing users to suppress table headers in the output. Useful for scripting and automation. Signed-off-by: Paul Van Laer <paul.van.laer1@gmail.com>	10 months ago
Benoit Tigeot	97b7a1c9ae	Merge branch 'main' into fix-31170-URN ... Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com> Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	10 months ago
Matt Farina	15300549f0	When time not available, using time.Now ... Note, when time is not available, the builds are not reproducible. This problem would only happen when an SDK user is using parts of the API to build their own tooling. Helm will consistently inject the dates through the higher level APIs. Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	ca8eae9361	Reproducible chart archive builds ... Building the same chart into an archive multiple times will have the same sha256 hash. Perviously, the time in the headers for a file was time.Now() which changed each time. The time is now collected from the operating system when the file is loaded and this time is used. Fixes: #3612 Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Scott Rigby	f4c5220d99	Merge pull request #31411 from banjoh/em/reinstate-logger-param ... feat: reinstate logger parameter to actions package	10 months ago
tison	0d6de28bf4	chore: fix typo of public field ... Signed-off-by: tison <wander4096@gmail.com>	10 months ago
Evans Mungai	2ddeb50fa6	Set default logger in Configuration constructor ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	10 months ago
Evans Mungai	a112bf5aa6	Remove non-reachable code ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	10 months ago
Matt Farina	1da2b0a6d4	Merge pull request #31204 from benoittgt/fix-31202 ... Avoid panic in helm.sh/helm/v3/pkg/chartutil.ValidateAgainstSchema	10 months ago
Robert Sirchia	25ad74f5a7	Merge pull request #31337 from rachelvweber/rawo/fixingWaitStrategy ... Fixing rollback and uninstall client WaitStrategy	10 months ago
Evans Mungai	aed687eaa1	Add config options to NewConfiguration() ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	10 months ago
Evans Mungai	b6eca1c0f1	Refactor logging functionality to use slog.Handler ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	10 months ago
Evans Mungai	5ab4ca5490	Embed logging functionality to DRY code ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	10 months ago
Evans Mungai	9c32e34d60	Add logger to sql driver and ensure storage has logger ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	10 months ago
Evans Mungai	50e43f4017	nil logger should be handled by discard handler ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	10 months ago
Evans Mungai	7a5816b106	Self review changes ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	10 months ago
Evans Mungai	0f90c83118	Merge remote-tracking branch 'upstream/main' into em/reinstate-logger-param	10 months ago
Evans Mungai	b1d4dc680d	feat: reinstate logger parameter to actions package ... Fixes: #31399 Signed-off-by: Evans Mungai <mbuevans@gmail.com>	10 months ago
Matt Farina	76e6b7a6fe	Merge pull request #31390 from TerryHowe/chore-increase-helm-list-test-coverage ... fix: improve pkg/cmd/list test coverage	10 months ago
Matt Farina	2cfd41ec28	Merge pull request #31351 from gjenkins8/gjenkins/helm_version_kubeversion ... feat: `helm version` print Kubernetes (client-go) version	10 months ago
Matt Farina	752354074c	Merge pull request #31393 from benoittgt/12299 ... Return errors during upgrade when the deletion of resources fails	10 months ago
Matt Farina	37de51428c	Merge pull request #31376 from benoittgt/accept-yaml-yml ... Do not ignore *.yml file on linting while accepting *.yaml	10 months ago
Matt Farina	b0247ce8bf	Merge pull request #31395 from wyrapeseed/main ... chore: fix some comment format	10 months ago
Terry Howe	0f6e14dfd3	chore: fix various warnings to reduce noise ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
Jesse Simpson	3f860e83fb	fix: use empty results instead of nil ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	10 months ago
Jesse Simpson	96b4c363c8	fix: Update returns nil on error, test should reflect this ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	10 months ago
Terry Howe	917822cfca	refactor: remove unused err from pkg/registry/client.go ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
wyrapeseed	b9eadd3186	chore: fix some comment format ... Signed-off-by: wyrapeseed <wyrapeseed@outlook.com>	10 months ago
Benoit Tigeot	7097c8e2e5	Replicate as unit test case where we fail once a resource deletion ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	10 months ago
Benoit Tigeot	054eabddd7	Return errors on upgrade when deletion fails ... This is a rebase of https://github.com/helm/helm/pull/12299 as the pull request was tagged for Helm v4. Closes: https://github.com/helm/helm/issues/11375 Related: https://github.com/helm/helm/pull/7929 It was a pain to reproduce, here is a script: ``` set -u NS=default RELEASE=test-release CHART=./test-chart SA=limited-helm-sa HELM=${HELM:-./bin/helm} echo "Helm: $($HELM version)" echo "Cleaning…" $HELM uninstall "$RELEASE" -n "$NS" >/dev/null 2>&1 || true kubectl -n "$NS" delete sa "$SA" role "${SA}-role" rolebinding "${SA}-rb" >/dev/null 2>&1 || true kubectl -n "$NS" delete cronjob "$RELEASE-test-chart-cronjob" >/dev/null 2>&1 || true rm -rf "$CHART" /tmp/limited-helm-kubeconfig echo "Create minimal chart with only a CronJob" $HELM create "$CHART" >/dev/null rm -f "$CHART"/templates/{deployment.yaml,service.yaml,hpa.yaml,tests/test-connection.yaml,serviceaccount.yaml} cat > "$CHART/templates/cronjob.yaml" <<'YAML' apiVersion: batch/v1 kind: CronJob metadata: name: {{ include "test-chart.fullname" . }}-cronjob spec: schedule: "*/5 * * * *" jobTemplate: spec: template: spec: restartPolicy: OnFailure containers: - name: hello image: busybox command: ["/bin/sh","-c","date; echo Hello from CronJob"] YAML echo "RBAC: allow Helm storage, basic reads/creates, but NO delete on cronjobs" kubectl -n "$NS" apply -f - >/dev/null <<EOF apiVersion: v1 kind: ServiceAccount metadata: name: $SA --- apiVersion: rbac.authorization.k8s.io/v1 kind: Role metadata: name: ${SA}-role rules: - apiGroups: [""] resources: ["secrets","configmaps"] verbs: ["get","list","watch","create","patch","update","delete"] - apiGroups: [""] resources: ["pods","events"] verbs: ["get","list","watch"] - apiGroups: ["batch"] resources: ["cronjobs"] verbs: ["get","list","watch","create","patch","update"] EOF kubectl -n "$NS" apply -f - >/dev/null <<EOF apiVersion: rbac.authorization.k8s.io/v1 kind: RoleBinding metadata: name: ${SA}-rb subjects: - kind: ServiceAccount name: $SA roleRef: apiGroup: rbac.authorization.k8s.io kind: Role name: ${SA}-role EOF echo "Create kubeconfig for that SA" TOKEN=$(kubectl -n "$NS" create token "$SA") SERVER=$(kubectl config view --minify -o jsonpath='{.clusters[0].cluster.server}') CA_DATA=$(kubectl config view --minify --raw -o jsonpath='{.clusters[0].cluster.certificate-authority-data}') KCFG=/tmp/limited-helm-kubeconfig cat > "$KCFG" <<EOF apiVersion: v1 kind: Config clusters: - name: local cluster: server: $SERVER certificate-authority-data: $CA_DATA contexts: - name: limited context: cluster: local namespace: $NS user: $SA current-context: limited users: - name: $SA user: token: $TOKEN EOF set +e echo "Install (as limited SA)" KUBECONFIG="$KCFG" $HELM upgrade --install "$RELEASE" "$CHART" -n "$NS" --wait echo "CronJob after install:" kubectl -n "$NS" get cronjob "$RELEASE-test-chart-cronjob" || true echo "Remove CronJob from chart and add a small ConfigMap to force an upgrade" rm -f "$CHART/templates/cronjob.yaml" cat > "$CHART/templates/configmap.yaml" <<'YAML' apiVersion: v1 kind: ConfigMap metadata: name: {{ include "test-chart.fullname" . }}-config data: hello: world YAML echo "Upgrade without CronJob (as limited SA)" KUBECONFIG="$KCFG" $HELM upgrade --install "$RELEASE" "$CHART" -n "$NS" RC=$? echo "Post-upgrade verification" if kubectl -n "$NS" get cronjob "$RELEASE-test-chart-cronjob" >/dev/null 2>&1; then echo "OK: Stale CronJob still present: $RELEASE-test-chart-cronjob" else echo "NO_OK: CronJob deleted" fi echo "Helm exit code: $RC" exit 0 ``` With the current build: ```sh ./reproduce-helm-issue.sh Helm: version.BuildInfo{Version:"v4.0+unreleased", GitCommit:"f19bb9cd4c99943f7a4980d6670de44affe3e472", GitTreeState:"dirty", GoVersion:"go1.24.0"} Cleaning… Create minimal chart with CronJob + ConfigMap (we will remove both in v2) RBAC: allow Helm storage + delete for configmaps, but NO delete on cronjobs Create kubeconfig for that SA Install v1 (as limited SA) Release "test-release" does not exist. Installing it now. NAME: test-release LAST DEPLOYED: Tue Oct 14 18:55:57 2025 NAMESPACE: default STATUS: deployed REVISION: 1 DESCRIPTION: Install complete TEST SUITE: None NOTES: 1. Get the application URL by running these commands: export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=test-chart,app.kubernetes.io/instance=test-release" -o jsonpath="{.items[0].metadata.name}") export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}") echo "Visit http://127.0.0.1:8080 to use your application" kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT Verify v1 objects exist NAME SCHEDULE TIMEZONE SUSPEND ACTIVE LAST SCHEDULE AGE test-release-test-chart-cronjob */5 * * * * <none> False 0 <none> 0s NAME DATA AGE test-release-test-chart-config 1 0s Prepare v2: remove BOTH CronJob and ConfigMap from the chart Upgrade to v2 (as limited SA) — expecting CronJob delete first, then ConfigMap - CronJob delete should FAIL (no delete permission) - ConfigMap delete should SUCCEED (delete allowed) — proves 'continue on error' and inverted order level=DEBUG msg="getting history for release" release=test-release level=DEBUG msg="getting release history" name=test-release level=DEBUG msg="preparing upgrade" name=test-release level=DEBUG msg="getting last revision" name=test-release level=DEBUG msg="getting release history" name=test-release level=DEBUG msg="number of dependencies in the chart" dependencies=0 level=DEBUG msg="determined release apply method" server_side_apply=true previous_release_apply_method=ssa level=DEBUG msg="performing update" name=test-release level=DEBUG msg="creating upgraded release" name=test-release level=DEBUG msg="creating release" key=sh.helm.release.v1.test-release.v2 level=DEBUG msg="getting release history" name=test-release level=DEBUG msg="using server-side apply for resource update" forceConflicts=false dryRun=false fieldValidationDirective=Strict upgradeClientSideFieldManager=false level=DEBUG msg="checking resources for changes" resources=0 level=DEBUG msg="deleting resource" namespace=default name=test-release-test-chart-config kind=ConfigMap level=DEBUG msg="deleting resource" namespace=default name=test-release-test-chart-cronjob kind=CronJob level=DEBUG msg="failed to delete resource" namespace=default name=test-release-test-chart-cronjob kind=CronJob error="cronjobs.batch \"test-release-test-chart-cronjob\" is forbidden: User \"system:serviceaccount:default:limited-helm-sa\" cannot delete resource \"cronjobs\" in API group \"batch\" in the namespace \"default\"" level=INFO msg="update completed" created=0 updated=0 deleted=1 level=WARN msg="update completed with errors" errors=1 level=DEBUG msg="updating release" key=sh.helm.release.v1.test-release.v1 level=WARN msg="upgrade failed" name=test-release error="failed to delete resource test-release-test-chart-cronjob: cronjobs.batch \"test-release-test-chart-cronjob\" is forbidden: User \"system:serviceaccount:default:limited-helm-sa\" cannot delete resource \"cronjobs\" in API group \"batch\" in the namespace \"default\"" level=DEBUG msg="updating release" key=sh.helm.release.v1.test-release.v2 Error: UPGRADE FAILED: failed to delete resource test-release-test-chart-cronjob: cronjobs.batch "test-release-test-chart-cronjob" is forbidden: User "system:serviceaccount:default:limited-helm-sa" cannot delete resource "cronjobs" in API group "batch" in the namespace "default" Post-upgrade verification Stale CronJob still present: test-release-test-chart-cronjob (expected if delete is forbidden) ConfigMap deleted as expected: test-release-test-chart-config (and after CronJob attempt) Helm exit code: 1 ``` With last version v3.19: ``` HELM=/usr/local/bin/helm ./reproduce-helm-issue.sh Helm: version.BuildInfo{Version:"v3.19.0", GitCommit:"3d8990f0836691f0229297773f3524598f46bda6", GitTreeState:"clean", GoVersion:"go1.24.7"} Cleaning… Create minimal chart with only a CronJob RBAC: allow Helm storage, basic reads/creates, but NO delete on cronjobs Create kubeconfig for that SA Install (as limited SA) Release "test-release" does not exist. Installing it now. NAME: test-release LAST DEPLOYED: Tue Oct 14 19:07:01 2025 NAMESPACE: default STATUS: deployed REVISION: 1 TEST SUITE: None NOTES: 1. Get the application URL by running these commands: export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=test-chart,app.kubernetes.io/instance=test-release" -o jsonpath="{.items[0].metadata.name}") export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}") echo "Visit http://127.0.0.1:8080 to use your application" kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT CronJob after install: NAME SCHEDULE TIMEZONE SUSPEND ACTIVE LAST SCHEDULE AGE test-release-test-chart-cronjob */5 * * * * <none> False 0 <none> 0s Remove CronJob from chart and add a small ConfigMap to force an upgrade Upgrade without CronJob (as limited SA) Release "test-release" has been upgraded. Happy Helming! NAME: test-release LAST DEPLOYED: Tue Oct 14 19:07:01 2025 NAMESPACE: default STATUS: deployed REVISION: 2 TEST SUITE: None NOTES: 1. Get the application URL by running these commands: export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=test-chart,app.kubernetes.io/instance=test-release" -o jsonpath="{.items[0].metadata.name}") export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}") echo "Visit http://127.0.0.1:8080 to use your application" kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT Post-upgrade verification OK: Stale CronJob still present: test-release-test-chart-cronjob Helm exit code: 0 ``` Co-authored-by: dayeguilaiye <979014041@qq.com> Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	10 months ago
Terry Howe	3b2fd17799	chore: rename test registry ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
Terry Howe	379b0899b3	fix: increase helm list test coverage ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
George Jenkins	7dd2484aed	Merge pull request #31295 from TerryHowe/fix-make-helm-list-show-all-by-default ... Fix make helm list show all by default	10 months ago
Scott Rigby	f0530309f0	Merge pull request #31302 from TerryHowe/fix-helm-verify-signature ... fix: helm verify Run signature	10 months ago
Scott Rigby	f9d4373ea4	Merge pull request #31270 from TerryHowe/chore-registry-clean-up ... chore: registry utils clean up	10 months ago
Terry Howe	abdf6603c0	fix test for rebase ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
Matt Farina	a03e8c9541	Merge pull request #31375 from TerryHowe/fix-release-info-time ... fix: release info time parsing	10 months ago
Terry Howe	f6e60138e8	Update pkg/cmd/list.go ... Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
Terry Howe	c3aa5c51e6	chore: clean up for comments ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
copilot-swe-agent[bot]	b4f932a715	Fix test by making date sorting stable and updating golden files ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
Terry Howe	8a73d97984	fix: make helm list show all by default ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
Marcin Owsiany	269a32a6d2	test: protect unknown hook delete policies ... Signed-off-by: Marcin Owsiany <porridge@redhat.com>	10 months ago
Dirk Müller	9cd40c612a	Avoid accessing .Items on nil object ... When listing fails for whatever reason, the return value is nil, err. so handle err explicitly. Signed-off-by: Dirk Müller <dirk@dmllr.de>	10 months ago
Benoit Tigeot	06188f9dfe	Add test for isYamlFileExtension functions ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	10 months ago
Terry Howe	20eb6e9b04	fix: empty time values ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
Matt Farina	fbf02e494e	Merge pull request #30980 from gjenkins8/gjenkins/cleanup_kubeclient_interfaces ... cleanup: Remove/consolidate redundant kube client Interfaces	10 months ago
Matt Farina	78cd44bd75	Merge pull request #30712 from gjenkins8/gjenkins/cleanup_lint_template ... cleanup: Remove extra lint/rules.Template functions	10 months ago
Matt Farina	24159ec8b6	Moving new default accessor functions to internal per feedback ... Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	fb20e96a56	Adding a test/example for the release accessor ... Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	ab6e7fa58b	Removing debug statement ... Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	a229bf6529	Ensure the release interface is used in actions instead of the type ... Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	9c958dec76	Making uninstall response generic ... Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	f80cbe43d0	Moved release objects to enable versioning ... Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	2247a0074b	Move all the get commands to the new release interface ... Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Matt Farina	94bfe9ba12	Move action get metadata to chart interfaces ... Signed-off-by: Matt Farina <matt.farina@suse.com>	10 months ago
Benoit Tigeot	4a944230ea	Do not ignore *.yml file on linting while accepting *.yaml ... From : https://github.com/helm/helm/pull/30712/files#r2417446037 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	10 months ago
George Jenkins	4877e2d7e9	Merge pull request #30833 from gjenkins8/gjenkins/refactor_dry_run_flag ... refactor/cleanup: Replace action 'DryRun' string with DryRunStrategy type + deprecations	10 months ago
George Jenkins	c75026c318	doc string ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	10 months ago
George Jenkins	1581eaa034	Apply suggestions from code review ... Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: George Jenkins <gvjenkins@gmail.com>	10 months ago
George Jenkins	b861de5696	Update pkg/kube/interface.go ... Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: George Jenkins <gvjenkins@gmail.com>	10 months ago
Robert Sirchia	600eb487f1	Merge pull request #31349 from TerryHowe/fix-shuffle-lint-test ... fix: flakey lint test on shuffle	10 months ago
Robert Sirchia	788087a821	Merge pull request #31326 from TerryHowe/sign-31181 ... Update sign tests to use testify	10 months ago
Robert Sirchia	acb1b2c651	Merge pull request #31354 from TerryHowe/fix-flake-upgrade-test ... fix: flake upgrade test	10 months ago
George Jenkins	0adfe83ff8	Merge pull request #31227 from evankanderson/windows-filepath ... Use filepath.Path when handling directory names	10 months ago
Joe Julian	9590d4214a	Merge pull request #31307 from TerryHowe/fix-ignore-local-path-when-repo-provided ... fix: Ignore absolute path when RepoUrl is provided	10 months ago
Terry Howe	a24318c7f1	fix: flake upgrade test ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	10 months ago
George Jenkins	7761d937ca	testfix ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	11 months ago
George Jenkins	a7a6a5e3b0	Merge pull request #31312 from gjenkins8/gjenkins/rm_plugin_schema_settings ... Remove unused 'Settings' from plugin schema	11 months ago
Terry Howe	ee322a9671	fix: flakey lint test on shuffle ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
Terry Howe	bee9c1a108	chore: replace github.com/mitchellh/copystructure ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
Rachel Weber	472f8b2628	Fixing rollback and uninstall client WaitStrategy. ... Signed-off-by: Rachel Weber <rawo@microsoft.com>	11 months ago
George Jenkins	61e3d95a94	Merge pull request #31143 from TerryHowe/fix-remove-redundant-error-check ... fix: remove redundant error check	11 months ago
Terry Howe	f9152dc048	chore: update sign tests to use testify ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
George Jenkins	900cf2a93d	Merge pull request #31320 from kosiew/sign-31181 ... provenance: allow RSA signing when ed25519 keys are present (switch to ProtonMail/go-crypto)	11 months ago
Terry Howe	9c7bf37c6f	fix: Ignore absolute path when RepoUrl is provided ... Signed-off-by: Terry Howe <terrylhowe@gmail.com> Co-authored-by: Mohammad Forutan <mforutan@users.noreply.github.com>	11 months ago
Terry Howe	cf811bb11f	chore: registry utils clean up ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
juejinyuxitu	69dbd6115e	chore: fix some typos in comment ... Signed-off-by: juejinyuxitu <juejinyuxitu@outlook.com>	11 months ago
Siew Kam Onn	1c8d5804e2	Refactor SQL tests to use recentUnixTimestamp for time arguments ... Signed-off-by: Siew Kam Onn <kosiew@gmail.com>	11 months ago
Siew Kam Onn	0b5d8033b9	Add Ed25519 key presence check in mixed keyring signing test ... Signed-off-by: Siew Kam Onn <kosiew@gmail.com>	11 months ago
Siew Kam Onn	7c9176ae35	Update dependencies and refactor crypto imports to use ProtonMail's go-crypto package ... Signed-off-by: Siew Kam Onn <kosiew@gmail.com>	11 months ago
George Jenkins	23c5662019	Merge pull request #31254 from benoittgt/fix-31253-closest-version ... Warn when we fallback to a different version on `helm pull`	11 months ago
George Jenkins	561a7da61c	Merge pull request #31297 from TerryHowe/fix-hide-notes-in-helm-test ... fix: hide notes in helm test command	11 months ago
George Jenkins	efcb5735e5	cleanup: Remove extra lint/rules.Template functions ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	11 months ago
George Jenkins	b5de5b1591	chore: Cleanup additional/redundant kube client Interfaces ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	11 months ago
George Jenkins	f21b143bef	refactor: Replace action 'DryRun' string with DryRunStrategy type + deprecations ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	11 months ago
George Jenkins	6bc6231bcc	Remove unused 'Settings' from plugin schema ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	11 months ago
Robert Sirchia	5b43b744b8	Merge pull request #31294 from TerryHowe/feature-remove-implicit-directory-from-helm-lint ... Remove implicit support for helm lint current directory	11 months ago
Robert Sirchia	fdb5e1a97a	Merge pull request #31301 from TerryHowe/chore-remove-helm-version-client ... chore: remove helm version `--client` option	11 months ago
Matt Farina	d2236e95ed	Merge pull request #31303 from mattfarina/unified-loader ... Update the action interfaces for chart apiversions	11 months ago
Matt Farina	8dc7c57f50	Update the action interfaces for chart apiversions ... This change is about handling the interfaces to public functions for different chart apiVersions. The internals are still focused on v2. This enables v3 to be layered in layer. Signed-off-by: Matt Farina <matt.farina@suse.com>	11 months ago
Terry Howe	020a8eccfd	fix: helm verify run signature ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
zyfy29	b24bfe4168	Merge branch 'main' into delete-unused-var ... Signed-off-by: zyfy29 <wasuremono127@gmail.com>	11 months ago
Terry Howe	469f4b457c	chore: remove helm version client option ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
Matt Farina	90a91e097f	Merge pull request #31198 from TerryHowe/fix-pkg-engine-error-parsing ... fix: replace pkg/engine regular expressions with parser	11 months ago
Matt Farina	da595e0e71	Merge pull request #31293 from TerryHowe/copilot/fix-8 ... chore: remove pkg/time which is no longer needed	11 months ago
Terry Howe	dab4fd2909	fix: hide notes in helm test command ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
copilot-swe-agent[bot]	838c36a0f6	Remove implicit support for helm lint current directory ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
Terry Howe	3e1dd9a5dc	chore: remove pkg/time which is no longer needed ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
reddaisyy	1c67fbf108	refactor: use strings.builder ... Signed-off-by: reddaisyy <reddaisy@outlook.jp>	11 months ago
Artem Vdovin	ae4af69b9d	fix test ... Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>	11 months ago
Artem Vdovin	aaaa457f04	Merge branch 'main' into bug/index-concurrency	11 months ago
Terry Howe	b2870379c8	Update pkg/engine/engine.go ... Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
Terry Howe	91a65234ac	Update pkg/engine/engine.go ... Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
Terry Howe	9112687a7e	Update pkg/engine/engine.go ... Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>	11 months ago
Tom Wieczorek	6181e0a873	Make test scripts run without /bin/bash ... The test scripts hardcoded #!/bin/bash while they are not really requiring bash. Use the more portable #!/usr/bin/env sh instead, so that they use the default shell. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>	11 months ago
bennsimon	db50c37eda	remove metadata output on helm template ... Signed-off-by: bennsimon <bennsimonotieno@gmail.com>	11 months ago
Robert Sirchia	5534c01cdb	Merge pull request #31277 from benoittgt/31234-fix ... Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10	11 months ago
Evan Anderson	20f4e1f12d	Use filepath.Path when handling directory names ... Signed-off-by: Evan Anderson <evan.k.anderson@gmail.com>	11 months ago
Benoit Tigeot	99e5fce71a	Fix deprecation warning for spf13/pflag from 1.0.7 to 1.0.10 ... Close: #31231 ``` Error: cmd/helm/root.go:165:2: SA1019: flags.ParseErrorsWhitelist is deprecated: use [FlagSet.ParseErrorsAllowlist] instead. This field will be removed in a future release. (staticcheck) ``` Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	11 months ago
Matt Farina	1a06fe9901	Merge pull request #31275 from benoittgt/13414-v2 ... Extend --skip-schema-validation for lint command	11 months ago
Benoit Tigeot	072e2a689a	Extend --skip-schema-validation for lint command ... When --skip-schema-validation is enabled, the lint command will now skip JSON schema validation for values.yaml files, allowing charts with schema validation errors to pass linting when the flag is used. This addresses the gap where --skip-schema-validation only applied to templates but not to values files, providing complete schema validation bypass when needed. Fixes: #13413 Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	11 months ago
Scott Rigby	315b13334c	Merge pull request #31258 from StephanieHhnbrg/test-unreachable-client ... Refactor unreachableKubeClient for testing into failingKubeClient	11 months ago
Stephanie Hohenberg	e19d9fb6ee	Refactor unreachableKubeClient for testing into failingKubeClient ... Signed-off-by: Stephanie Hohenberg <stephanie.hohenberg@gmail.com>	11 months ago
Benoit Tigeot	939fff9cb9	Avoid "panic: interface conversion: interface {} is nil" ... Closes: #31202 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	11 months ago
Jesse Simpson	712cde4624	test: passes now ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	11 months ago
Jesse Simpson	b060911075	refactor: break out into functions and draft tests ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	11 months ago
Benoit Tigeot	9e2d4680e1	Warn when we fallback to a different version on `helm pull` ... Close: https://github.com/helm/helm/issues/31253 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	11 months ago
Kamil Swiechowski	a645dfb7f8	fix:semverv2 lint test error message ... Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>	11 months ago
Scott Rigby	78cf5470d1	Merge pull request #31199 from TerryHowe/fix-flaky-registry-data-race ... fix: flaky registry data race on mockdns close	11 months ago
Scott Rigby	8602422b7a	Merge pull request #31064 from kamilswiec/main ... lint: throw warning when chart version is not semverv2	11 months ago
Scott Rigby	50358d7ffd	Merge pull request #31200 from TerryHowe/fix-install-tests ... fix: installer action goroutine count	11 months ago
Benoit Tigeot	8025a397e6	Ignore duplicated URN in logs ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	11 months ago
Benoit Tigeot	03bb62f63d	jsonschema: warn and ignore unresolved URN $ref to match v3.18.4 ... - v3.18.5 switched jsonschema and began resolving external $ref at compile-time, exposing missing urn handling (“no URLLoader registered for urn:…”). - Add urn scheme loader and pluggable URNResolver. If unresolved, log a warning and return a permissive true schema (back-compat). - Apply to pkg/chart/v2 and internal/chart/v3 validators. Not sure about that Note: external URNs need AddResource/Resolver (the CLI uses --map for this). Warning may appear twice since both validators run. Another strategy could be to add the option to import more "external schema" explicitly but it is another PR. Something similar to `--map` from jsonschema package (santhosh-tekuri/jsonschema@ed65924). Close: #31170 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	11 months ago
Matt Farina	fc22b6df31	Merge pull request #31222 from benoittgt/30987-ghcr-io ... Prevent failing `helm push` on ghcr.io using standard GET auth token flow	11 months ago
Robert Sirchia	191154640f	Merge pull request #31197 from tzchenxixi/main ... chore: fix function name	11 months ago
Kamil Swiechowski	38d1a7376f	fix: throw warning when chart version is not semverv2 ... Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>	11 months ago
Matt Farina	618b14a772	Merge pull request #31225 from mattfarina/move-lint-to-chart ... Move lint pkg to be part of each chart version	11 months ago
George Jenkins	a8151ef4fe	Cleanup plugin config ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	11 months ago
Scott Rigby	ed6cab39c6	Merge pull request #31219 from gjenkins8/gjenkins/plugin-integration/rm_setup_plugin_env	11 months ago
Matt Farina	9dcc49cbd5	Move lint pkg to be part of each chart version ... Linting is specific to the chart versions. A v2 and v3 chart will lint differently. To accomplish this, packages like engine need to be able to handle different chart versions. This was accomplished by some changes: 1. The introduction of a Charter interface for charts 2. The ChartAccessor which is able to accept a chart and then provide access to its data via an interface. There is an interface, factory, and implementation for each version of chart. 3. Common packages were moved to a common and util packages. Due to some package loops, there are 2 packages which may get some consolidation in the future. The new interfaces provide the foundation to move the actions and cmd packages to be able to handle multiple apiVersions of charts. Signed-off-by: Matt Farina <matt.farina@suse.com>	11 months ago
Matt Farina	52267ee74b	Move repo package to versioned directory ... The repo package is internally versioned at v1. Repos were designed to be versioned. This change moves it to a versioned directory the same way other packages are now being handled. Signed-off-by: Matt Farina <matt.farina@suse.com>	11 months ago
Matt Farina	6f957f4922	Move the release util to the versioned directory ... The release util package is directly related to the v1 of releases and uses the v1 of releases. Signed-off-by: Matt Farina <matt.farina@suse.com>	11 months ago
George Jenkins	5926ec83dd	Remove SetupPluginEnv ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	12 months ago
George Jenkins	665c5a1fc9	Merge pull request #31224 from gjenkins8/gjenkins/postrenderer_plugin_message_value ... fix: Adjust PostRenderer plugin output to value	12 months ago
George Jenkins	d99d732542	fix: Adjust PostRenderer plugin output to value ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	12 months ago
Benoit Tigeot	5595c0d005	Prevent failing helm push on ghcr.io using standard GET auth token flow ... Fix GHCR auth by not forcing OAuth2 POST but also reset ForceAttemptOAuth2 after login. - Remove ForceAttemptOAuth2 in NewClient and only enable during Login ping and always restore to false. - Aligns with OCI Distribution auth (token via GET), avoiding GHCR 405 on POST /token. - Some tests Failures logs: ```sh ~/p/lifen/test/helm-f/quicktest ❯ ../../../helm/bin/helm push quicktest-0.1.0.tgz oci://ghcr.io/benoittgt/helm-charts --debug level=DEBUG msg=HEAD id=0 url=https://ghcr.io/v2/benoittgt/helm-charts/quicktest/manifests/sha256:af359fd8fb968ec1097afbd6e8e1dac9ee130861082e54dc2340d0c019407873 header=" \"Accept\": \"application/vnd.docker.distribution.manifest.v2+json, application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.manifest.v1+json, application/vnd.oci.image.index.v1+json, application/vnd.oci.artifact.manifest.v1+json\"\n \"User-Agent\": \"Helm/4.0+unreleased\"" level=DEBUG msg=Resp id=0 status="401 Unauthorized" header=" \"Www-Authenticate\": \"Bearer realm=\\\"https://ghcr.io/token\\\",service=\\\"ghcr.io\\\",scope=\\\"repository:benoittgt/helm-charts/quicktest:pull\\\"\"\n \"Date\": \"Mon, 01 Sep 2025 13:56:35 GMT\"\n \"Content-Length\": \"73\"\n \"X-Github-Request-Id\": \"DC73:115F:2B40F2C:2BAB567:68B5A613\"\n \"Content-Type\": \"application/json\"" body=" Response body is empty" level=DEBUG msg=POST id=1 url=https://ghcr.io/token header=" \"Content-Type\": \"application/x-www-form-urlencoded\"\n \"User-Agent\": \"Helm/4.0+unreleased\"" level=DEBUG msg=Resp id=1 status="405 Method Not Allowed" header=" \"Docker-Distribution-Api-Version\": \"registry/2.0\"\n \"Strict-Transport-Security\": \"max-age=63072000; includeSubDomains; preload\"\n \"Date\": \"Mon, 01 Sep 2025 13:56:35 GMT\"\n \"Content-Length\": \"78\"\n \"X-Github-Request-Id\": \"DC73:115F:2B40F75:2BAB5C2:68B5A613\"\n \"Content-Type\": \"application/json\"" body="{\"errors\":[{\"code\":\"UNSUPPORTED\",\"message\":\"The operation is unsupported.\"}]}\n" Error: failed to perform "Exists" on destination: HEAD "https://ghcr.io/v2/benoittgt/helm-charts/quicktest/manifests/sha256:af359fd8fb968ec1097afbd6e8e1dac9ee130861082e54dc2340d0c019407873": POST "https://ghcr.io/token": response status code 405: unsupported: The operation is unsupported. ``` Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	12 months ago
tzchenxixi	89aca09e5e	chore: fix function name ... Signed-off-by: tzchenxixi <tzchenxixi@icloud.com>	12 months ago
George Jenkins	c35755a197	Remove legacy Command/Hooks from v1 Subprocess (#23) ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	12 months ago
Scott Rigby	591d863df5	Move Postrenderer to a plugin type ... Fix/add back postrenderer args unit tests Signed-off-by: Scott Rigby <scott@r6by.com>	12 months ago
Scott Rigby	e814ff3c38	Remove unnecessary file i/o operations from signing and verifying ... Signed-off-by: Scott Rigby <scott@r6by.com>	12 months ago
Scott Rigby	9ea35da0d0	[HIP-0026] Plugin packaging, signing, and verification (#31176) ... * Plugin packaging, signing and verification Signed-off-by: Scott Rigby <scott@r6by.com> * wrap keyring read error with more explicit message Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> * skip unnecessary check Co-authored-by: Evans Mungai <mbuevans@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> * Change behavior for installing plugin with missing .prov file (now warns and continues instead of failing) Signed-off-by: Scott Rigby <scott@r6by.com> * Add comprehensive plugin verification tests - Test missing .prov files (warns but continues) - Test invalid .prov file formats (fails verification) - Test hash mismatches in .prov files (fails verification) - Test .prov file access errors (fails appropriately) - Test directory plugins don't support verification - Test installation without verification enabled (succeeds) - Test with valid .prov files (fails on empty keyring as expected) --------- Signed-off-by: Scott Rigby <scott@r6by.com> Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com> Co-authored-by: Evans Mungai <mbuevans@gmail.com>	12 months ago
Terry Howe	b12cd28503	fix: installer action goroutine count ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	12 months ago
George Jenkins	892e86182f	Merge pull request #31194 from gjenkins8/gjenkins/plugin-integration/wasm_runtime ... [HIP-0026] Plugin extism/v1 runtime	12 months ago
George Jenkins	80f659ce8b	Merge pull request #31178 from mattfarina/env-content-cache ... Add content cache to helm env	12 months ago
zyfy29	8068578266	chore: delete unused var in installer.go ... Signed-off-by: zyfy29 <wasuremono127@gmail.com>	12 months ago
George Jenkins	2658a00863	fix output message value ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	12 months ago
Terry Howe	ce97a2449e	fix: move mockdns to packge level ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	12 months ago
Terry Howe	6273f9b38e	fix: flaky registry data race on mockdns close ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	12 months ago
Terry Howe	284bd980b6	fix: replace pkg/engine regular expressions with parser ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	12 months ago
George Jenkins	b6545e903a	code review + bug fixes ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	12 months ago
Andreas Sommer	1836c598f0	Make error message instructional for the case of lock file being out of date ... Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>	12 months ago
George Jenkins	934f761e08	Merge pull request #30812 from gjenkins8/gjenkins/chartrelease_server_side_apply ... HIP-0023: Helm support server-side apply	12 months ago
Scott Rigby	fd41fdd9c9	New registry plugin func GetPluginName. Re-use regsitry.reference ... Signed-off-by: Scott Rigby <scott@r6by.com>	12 months ago
Scott Rigby	7d22bb25fa	Plugin OCI installer ... Signed-off-by: Scott Rigby <scott@r6by.com>	12 months ago
Matt Farina	533eddc57d	Add content cache to helm env ... Signed-off-by: Matt Farina <matt.farina@suse.com>	12 months ago
Scott Rigby	a7578fec74	Plugin types and plugin apiVersion v1 ... Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com>	12 months ago
Scott Rigby	be74ab72a0	[HIP-0026] Plugin runtime interface (#31145) ... * Runtime abstraction to encapsulate subprocess code and enable future runtimes Also fix race condition in TestPrepareCommandExtraArgs by replacing the shared variable modification with a local copy Co-authored-by: George Jenkins <gvjenkins@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> * Remove commented out code Co-authored-by: Joe Julian <me@joejulian.name> Signed-off-by: Scott Rigby <scott@r6by.com> * Check test failure string Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com> Signed-off-by: Scott Rigby <scott@r6by.com> --------- Signed-off-by: Scott Rigby <scott@r6by.com> Co-authored-by: George Jenkins <gvjenkins@gmail.com> Co-authored-by: Joe Julian <me@joejulian.name> Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>	12 months ago
Matt Farina	0f1b410f14	Merge pull request #31165 from mattfarina/content-cache ... Initial addition of content based cache	12 months ago
George Jenkins	a0d6b0d383	Merge pull request #13629 from gjenkins8/rename_atomic_rollbackonfailure ... Rename 'atomic' -> 'rollback-on-failure'	12 months ago
Scott Rigby	29d12ba09e	Merge pull request #31156 from estroz/fix-resolve-client ... fix: set repo authorizer in registry.Client.Resolve()	12 months ago
Robert Sirchia	fc5bd02a1b	Merge pull request #31175 from cuiweixie/atomic.Uint64 ... pkg/register: refactor to use atomic.Uint64	12 months ago
Matt Farina	fea6d8eb04	Updating to tested content cache ... A few things are added here: 1. The cache is made to be more generic as a content based cache. It could be used for other things such as plugins 2. Flags were added to specify the content cache locaiton rather than rely on the repository cache. Keeping the 2 the same hid bugs and errors. 3. Tests were added and updated to ensure the cache is used and tested Signed-off-by: Matt Farina <matt.farina@suse.com>	12 months ago
George Jenkins	4596c0e062	Merge pull request #31142 from helm/gjenkins/main/mv_plugin_internal ... [HIP-0026] Move pkg/plugin -> internal/plugin	12 months ago
cuiweixie	04cb1bad67	pkg/register: refactor to use atomic.Uint64 ... Signed-off-by: cuiweixie <cuiweixie@gmail.com>	12 months ago
George Jenkins	ebc874ef84	fix client-side to server-side field manager migration ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	12 months ago
Robert Sirchia	30404b4173	Merge pull request #31138 from islewis/release-3.18 ... fix(helm-lint): Add HTTP/HTTPS URL support for json schema references	12 months ago
Isaiah Lewis	62e0c78ef8	fix(helm-lint): fmt ... Signed-off-by: Isaiah Lewis <isaiah@roof12.com>	12 months ago
Matt Farina	6ac2c34689	Initial addition of content based cache ... The previous cache was based on chart name and version. If 2 charts with different content had the same name and version they would collide. Helm did not trust the cache because of this and always downloaded content. It was a short lived cache. This commit introduces a content based cache which is based on the content rather than file name. Charts with the same name but different content are no longer an issue. While the system assumes a file based interface, the cache system is pluggable. In the future, it should return bytes for the content instead of paths to it. That would requie a larger change for Helm 5 or later. Signed-off-by: Matt Farina <matt.farina@suse.com>	12 months ago
Matt Farina	3726d01c5c	Merge pull request #31132 from joemicky/main ... refactor: replace []byte(fmt.Sprintf) with fmt.Appendf	12 months ago
Eric Stroczynski	e1e23d2af1	fix: set repo authorizer in registry.Client.Resolve() ... Signed-off-by: Eric Stroczynski <estroczynski@nvidia.com>	12 months ago
George Jenkins	b4b2392f7e	mergefix ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	12 months ago
Isaiah Lewis	fb12b44493	fix(helm-lint): Add TLSClientConfig ... Signed-off-by: Isaiah Lewis <isaiah@roof12.com>	12 months ago
Matt Farina	de9ea4d1e3	Merge pull request #30992 from TerryHowe/force-oath-v4 ... fix: force bearer oauth for if registry requests bearer auth	12 months ago
George Jenkins	e2dcbe28bf	Helm client/SDK support server-side apply ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	12 months ago
Evans Mungai	0943d032a7	Merge branch 'main' into em/fix-username-password ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	12 months ago
George Jenkins	a1c84f9a4c	Move pkg/plugin -> internal/plugin ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
Terry Howe	1e22b2fe7c	fix: remove redundant error check ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Isaiah Lewis	fa73b6743b	fix(helm-lint): Add HTTP/HTTPS URL support for json schema references ... Signed-off-by: Isaiah Lewis <isaiah@roof12.com>	1 year ago
George Jenkins	36e52c828d	Merge pull request #31030 from gjenkins8/gjenkins/kubeclient_ssa ... HIP-0023: Kube client support server-side apply	1 year ago
Robert Sirchia	47529bbffb	Merge pull request #31133 from joemicky/use_CutPrefix ... refactor: replace HasPrefix+TrimPrefix with CutPrefix	1 year ago
joemicky	762ef3ee80	refactor: omit unnecessary reassignment ... Signed-off-by: joemicky <joemickychang@outlook.com>	1 year ago
joemicky	a3d2da4d2e	refactor: replace HasPrefix+TrimPrefix with CutPrefix ... Signed-off-by: joemicky <joemickychang@outlook.com>	1 year ago
joemicky	fab70472af	refactor: replace []byte(fmt.Sprintf) with fmt.Appendf ... Signed-off-by: joemicky <joemickychang@outlook.com>	1 year ago
Joe Julian	e1b9173812	Merge pull request #12624 from papdaniel/main ... show crds command output separated by document separator	1 year ago
George Jenkins	36532f36b1	Merge pull request #11700 from suzaku/use-sort-slice ... Refactor, use sort.Slice to reduce boilerplate code	1 year ago
Joe Julian	4b493f036c	Merge remote-tracking branch 'upstream/main' into papdaniel/main	1 year ago
Joe Julian	6ecf033700	Merge pull request #13111 from rawtaz/style-cosmetics ... style(pkg/chartutil): add missing dots and indentation to defaultValues	1 year ago
Joe Julian	3fe1cb6f02	Merge remote-tracking branch 'upstream/main' into style-cosmetics	1 year ago
Joe Julian	92bc614fbf	Merge remote-tracking branch 'upstream/main' into use-sort-slice	1 year ago
Scott Rigby	943ca1d0ca	Merge pull request #30891 from gjenkins8/gjenkins/port_plugin_warn ... fix: Port pluginCommand & command warning	1 year ago
Robert Sirchia	d7d072b7f6	Merge commit from fork ... Advisory fix 1	1 year ago
George Jenkins	ba53075a9d	Merge pull request #12968 from sjeandeaux/helm-uninstall-dry-run ... helm uninstall dry run support `--ignore-not-found`	1 year ago
George Jenkins	b2dc411f9d	code review (error checks, collapse forceConflicts, UpdateApplyFunc) ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
George Jenkins	99dc23f00b	switch target<->original ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
George Jenkins	741facca43	Update pkg/kube/client_test.go ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
George Jenkins	45141451b4	Kube client support server-side apply ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
Matt Farina	8affd6178f	Merge pull request #31126 from paologallinaharbur/fix/leverageSameTLSconfig ... fix(transport): leverage same tls config	1 year ago
Matt Farina	523d0b305e	Merge pull request #31076 from matheuscscp/registry-tls-memory ... pkg/registry: Login option for passing TLS config in memory	1 year ago
Stephane Jeandeaux	44a594fef5	review ... Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>	1 year ago
Robert Sirchia	c5901abba6	Merge pull request #31050 from spreadshirt/fix-helm-pull-ud-check ... Fix `helm pull` untar dir check with repo urls	1 year ago
Paolo Gallina	f3c9407052	fix(transport): leverage same tls config ... Signed-off-by: Paolo Gallina <paologallina1992@gmail.com>	1 year ago
Stephane Jeandeaux	8434935a3d	fix fallthrough ... Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>	1 year ago
Stephane Jeandeaux	65209bed54	Update pkg/action/uninstall.go ... Co-authored-by: Eddy Moulton <eddy@moulton.com.au> Signed-off-by: Stephane Jeandeaux <sjeandeaux@users.noreply.github.com>	1 year ago
Stephane Jeandeaux	b3568a67a8	helm uninstall ... The goal is to have the same behaviour with or without dry-run with --ignore-not-found close #12970 Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>	1 year ago
Joe Julian	ae0fe82bc3	Merge remote-tracking branch 'upstream/main' into get-values-test	1 year ago
Khwaja Faraz Ahmed	85164e5705	fix lint errors ... Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>	1 year ago
Khwaja Faraz Ahmed	ded25c1908	Add tests for alias ... Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>	1 year ago
Evans Mungai	97af5a5e85	Fix linter warning ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	1 year ago
Evans Mungai	5e86e43eda	Add tests for pull command using OCI registry ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	1 year ago
Evans Mungai	9e1cbbebcb	fix linting warning ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	1 year ago
Evans Mungai	5e6a411c1f	fix: use username and password if provided ... Ref: #31114 Signed-off-by: Evans Mungai <mbuevans@gmail.com>	1 year ago
Pavani Pogula	6597fecce3	test(pkg/kube/wait): Add unit tests for waitForPodSuccess, waitForJob and SelectorsForObject. ... Signed-off-by: Pavani Pogula <pogulapavani@gmail.com>	1 year ago
Pavani Pogula	d4ed9210df	test(pkg/kube/roundtripper): Add unit tests for roundtripper.go ... Signed-off-by: Pavani Pogula <pogulapavani@gmail.com>	1 year ago
Robert Sirchia	3c5d68d62e	Merge pull request #31109 from carlossg/panic3 ... fix: prevent panic when ChartDownloader.getOciURI	1 year ago
George Jenkins	18b7d45999	Merge pull request #31034 from Mazafard/feat/color-output-and-test-fixes ... Feat: Add color output functionality and tests for release statuses	1 year ago
Robert Sirchia	9b217506bd	Merge pull request #31106 from irikeish/test/pkg_kube_client ... test(pkg/kube): add test for Client.isReachable	1 year ago
George Jenkins	93106ba2b6	Merge pull request #30982 from gjenkins8/gjenkins/force_replace_flag ... Rename 'force' to 'force-replace'	1 year ago
Carlos Sanchez	4e483d36bd	fix: prevent panic when ChartDownloader.getOciURI ... needs to lookup tags because no version is provided but no RegistryClient is provided Signed-off-by: Carlos Sanchez <carlos@apache.org>	1 year ago
Robert Sirchia	6007d5773e	Merge pull request #31094 from mikelolasagasti/drop-freeport ... chore(deps): remove phayes/freeport module	1 year ago
Atish Kumar	008bd7fc82	test(pkg/kube/client): add test for isReachable ... Signed-off-by: Atish Kumar <allolro@gmail.com>	1 year ago
LinPr	b25fa862d5	fix: assign KUBECONFIG environment variable value to env.Kubeconfig ... Signed-off-by: LinPr <314573849@qq.com>	1 year ago
Evans Mungai	85243914a4	feat: switch yaml library to go.yaml.in/yaml/v3 ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	1 year ago
Matt Farina	69efc0d4fb	Handle messy index files ... Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Matt Farina	0c64ad1c97	fix Chart.yaml handling ... Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Mikel Olasagasti Uranga	7007d4d485	chore(deps): remove phayes/freeport module ... Replaces the `phayes/freeport` module with the standard library's `net.Listen("tcp", "127.0.0.1:0")` idiom. This removes an unnecessary dependency and simplifies the codebase. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>	1 year ago
Khwaja Faraz Ahmed	a37934a892	fix linting issue ... Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>	1 year ago
Faraz Khawaja	2d2d4a868d	Fix struct declaration ... Signed-off-by: Faraz Khawaja <khwajafarazahmed@yahoo.com> Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>	1 year ago
Matheus Pimenta	802e09038c	pkg/registry: Login option for passing TLS config in memory ... Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	1 year ago
Robert Sirchia	a42b76421b	Merge pull request #31078 from 8tomat8/master ... fix: k8s version parsing to match original	1 year ago
Mohammadreza Asadollahifard	0865d70304	refactor: change default color output setting to auto and remove ColorEnabled method ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	1 year ago
Mohammadreza Asadollahifard	4ef0f3d5e2	Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes	1 year ago
George Jenkins	f3065ff1ba	Remove plugin deprecated 'UseTunnelDeprecated' ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
George Jenkins	08840f042c	Rename 'atomic' -> 'rollback-on-failure' ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
Borys Hulii	9f6beaad48	fix: k8s version parsing to match original ... Signed-off-by: Borys Hulii <borys.hulii@bitvavo.com>	1 year ago
Luna Stadler	1031b67fff	Fix `helm pull` untar dir check with repo urls ... The existing check worked for `helm pull downloaded-repo/chart-name`, but often does not work when using `--repo-url`, depending on the urls used by the charts. Signed-off-by: Luna Stadler <luc@spreadshirt.net>	1 year ago
Artem Vdovin	118d0eb697	add concurrency test on write & load index file ... Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>	1 year ago
Faraz Khawaja	f75100266b	Resolve conflicts	1 year ago
George Jenkins	8face0e596	Merge pull request #31060 from yumeiyin/main ... refactor: replace Split in loops with more efficient SplitSeq	1 year ago
Robert Sirchia	619035d789	Merge pull request #31057 from danilobuerger/db/thick-lark ... Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme	1 year ago
Joe Julian	7f4eb407c6	add missing template directory to badcrdfile testdata ... Signed-off-by: Joe Julian <me@joejulian.name>	1 year ago
Joe Julian	08909e030b	Merge pull request #31019 from zachburg/templates_lint ... Return early when linting if the `templates/` directory does not exist	1 year ago
Joe Julian	1f3e4ad12a	Merge pull request #31011 from yalosev/feature/add-labels-to-metadata ... feature: add labels to metadata	1 year ago
Joe Julian	cd5ae5b19e	Merge pull request #31015 from zachburg/crds_lint ... Add linter support for the `crds/` directory	1 year ago
Terry Howe	250ce7b5dc	chore: improve OCI debug logging ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Matt Farina	1a73633908	Merge pull request #31033 from navinag1989/test-cov-cli-options ... test: increase test coverage for pkg/cli/options.go file	1 year ago
George Jenkins	74f2805f01	Rename 'force' to 'force-replace' ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
yumeiyin	8c22fbfe4a	refactor: replace Split in loops with more efficient SplitSeq ... Signed-off-by: yumeiyin <yin.yumei@qq.com>	1 year ago
Artem Vdovin	314bd19d11	update writing index files to writeAtomicFile ... Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>	1 year ago
Danilo Bürger	055c4e2bec	Moved url comparison to own function ... Signed-off-by: Danilo Bürger <info@danilobuerger.de>	1 year ago
Mohammadreza Asadollahifard	c1b3a83514	refactor: clean up color output imports in list, root, and status files ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	1 year ago
Mohammadreza Asadollahifard	d28343550f	feat: make color output opt-in by default ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	1 year ago
Mohammadreza Asadollahifard	ba8f70ae0b	refactor: move color package to internal/cli/output ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	1 year ago
Mohammadreza Asadollahifard	b72db06c49	refactor: replace NoColor with ColorMode for improved color output control ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	1 year ago
Mohammadreza Asadollahifard	96c54a2963	refactor color output functions to simplify noColor checks ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	1 year ago
Mohammadreza Asadollahifard	b630ae30a5	Merge remote-tracking branch 'upstream/main' into feat/color-output-and-test-fixes	1 year ago
Khwaja Faraz Ahmed	d50d22c970	Add test coverage for get_values/metadata.go ... Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai> Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>	1 year ago
Danilo Bürger	8096f09370	Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme ... Signed-off-by: Danilo Bürger <danilo.buerger@helsing.ai>	1 year ago
Scott Rigby	091f9a24fe	Merge pull request #13154 from carloslima/post-render-everything ... Allow post-renderer to process hooks	1 year ago
Robert Sirchia	49e82c1fe9	Merge pull request #31042 from TerryHowe/fix-test-teardown-dns-data-race ... fix: test teardown dns data race	1 year ago
jingchanglu	2da734d0b2	chore: fix typo in pkg/repo/chartrepo.go ... Signed-off-by: jingchanglu <jingchanglu@outlook.com>	1 year ago
Terry Howe	82bc9adcc2	fix: test teardown dns data race ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Yuriy Losev	46b1a41631	Add release labels to the release Metadata ... Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>	1 year ago
Robert Sirchia	4b8e61093d	Merge commit from fork ... Updating link handling	1 year ago
naving1989	4310b2bc36	Fixed linting issues ... Signed-off-by: naving1989 <navinag1989@gmail.com>	1 year ago
Zach Burgess	1002ec5ae9	Update tests in lint_test.go ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	35434947a3	Return a lint warning if `templates/` does not exist. ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	b6e3301bef	Merge branch 'helm:main' into templates_lint	1 year ago
Zach Burgess	fe11438715	Raise error instead of warning if `crds/` is not a valid directory ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	eea2d4577b	Raise an error if the `templates/` dir is not valid and return early. ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Mohammadreza Asadollahifard	1e00790b8c	refactor tests to use t.Setenv for NO_COLOR environment variable ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	1 year ago
Mohammadreza Asadollahifard	c547d1f2ae	add color output functionality and tests for release statuses ... Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>	1 year ago
Zach Burgess	3a318c2fa3	Update crds.go after https://github.com/helm/helm/pull/31029 ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	81af3c9570	Merge branch 'helm:main' into crds_lint	1 year ago
George Jenkins	d21a8a04cb	Merge pull request #31029 from gjenkins8/gjenkins/k8s_yaml_struct ... chore(refactor): Privatize 'k8sYamlStruct'	1 year ago
Zach Burgess	cc85352a0e	Use `assert.Len` instead of `assert.Lenf` ... The default message from testify is descriptive enough. Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	c59a097209	Remove duplicate test case from crds_test.go ... The "good" test case for CRDs is done in `TestGoodChart` in lint_test.go. Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
naving1989	3b2f9e7d6f	test: increase test coverage for pkg/cli/options.go file ... Signed-off-by: naving1989 <navinag1989@gmail.com>	1 year ago
Zach Burgess	bf9084a16a	Rename `validateCrdApiVersion` to `validateCrdAPIVersion` ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	357957b0d3	Use testify and add a CRD to the `goodone` test case. ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	dadaff716a	Merge branch 'helm:main' into crds_lint	1 year ago
Zach Burgess	6e30619d8f	Merge branch 'helm:main' into templates_lint	1 year ago
Matt Farina	76fdba4c8c	Updating link handling ... Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
George Jenkins	bbea98ed6b	Merge pull request #30898 from fidelity-contributions/fix-issue-13198 ... Fix issue 13198	1 year ago
George Jenkins	4c674728d2	Privatize 'k8sYamlStruct' ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
George Jenkins	edd0dabe02	Merge pull request #31021 from zachburg/test_temp_dir ... Update tests in create_test.go and package_test.go to work in a temp directory	1 year ago
Matt Farina	e8be2e540d	Merge pull request #31023 from gjenkins8/gjenkins/rm_recreate_pods ... Remove deprecated '--create-pods' flag	1 year ago
George Jenkins	a3bcc5b184	fix: 'TestRunLinterRule' stateful test ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
George Jenkins	5283915c57	Remove deprecated '--create-pods' flag ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
George Jenkins	de1bdf5820	switch to slog ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
George Jenkins	62ca98f521	fix up verbiage ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
George Jenkins	5f9cbe6f4a	fix: Port pluginCommand & command warning ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
Zach Burgess	eaf40b4b4f	Call `ensure.HelmHome()` in package_test.go ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Matt Farina	9517cfc5ce	Merge pull request #31009 from tpresa/test-coverage-pusher ... test: increase test coverage for pkg/pusher	1 year ago
Zach Burgess	c48a3435f5	Remove unnecessary calls for changing directory to `helmpath.CachePath`. ... This was only set on some tests in create_test.go and isn't affecting the test. Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Carlos Lima	6991a0a531	Make annotateAndMerge deterministic ... Signed-off-by: Carlos Lima <carlos@cpan.org>	1 year ago
Carlos Lima	c01e76b5c3	review: change annotation name to postrenderer.helm.sh/postrender-filename ... Signed-off-by: Carlos Lima <carlos@cpan.org>	1 year ago
Carlos Lima	a1416cf225	review: style changes ... Signed-off-by: Carlos Lima <carlos@cpan.org>	1 year ago
Carlos Lima	859721bd77	review: rewrite error messages from the end-user perspective ... Signed-off-by: Carlos Lima <carlos@cpan.org>	1 year ago
Carlos Lima	b26b473bf6	review: make splitAndDeannotate private ... Signed-off-by: Carlos Lima <carlos@cpan.org>	1 year ago
Carlos Lima	855b5a44b7	review: make annotateAndMerge private ... Signed-off-by: Carlos Lima <carlos@cpan.org>	1 year ago
Carlos Lima	1d993f9e2d	review: make filenameAnnotation private ... Signed-off-by: Carlos Lima <carlos@cpan.org>	1 year ago
Carlos Lima	e6362d74c8	Allow post-renderer to process hooks ... This annotates and merges all manifests before sending to the postrender, reversing the process and recovering the filenames afterwards. closes #7891 Signed-off-by: Carlos Lima <carlos@cpan.org>	1 year ago
Zach Burgess	3b26ddc22b	Update tests in create_test.go and package_test.go to work in a temp dir. ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	b703d5b4bb	Return early when linting if the `templates/` dir does not exist ... The `vaildateTemplatesDir` function would still return `nil` if the directory doesn't exist, so the early return that was documented never occurs. Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	a99c3700f0	Return early if the `/crds` directory does not exist. ... Don't silently discard the error from `os.Stat`. Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	562ff982cb	Early return if the `/crds` directory does not exist and don't silently discard the error from `os.Stat`. ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	d6ddd8e661	Document that attempting to parse YAML checks that the CRD is not a ... template Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	e4c88faeff	Update test assertions ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	bc35ea5ad7	Fix comment in pkg/lint/rules/testdata/invalidcrdsdir/values.yaml ... Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Zach Burgess	21b9aa3d94	Lint the `crds/` directory. ... This checks that the `crds/` dir only contains YAML files that define K8s resources with `kind: CustomResourceDefinition`. Checking that the YAML files are not templates will be done in a separate commit. Signed-off-by: Zach Burgess <zachburg@google.com>	1 year ago
Thiago Presa	afd63fed77	test: increase test coverage for pkg/pusher ... Signed-off-by: Thiago Presa <thiago.addevico@gmail.com>	1 year ago
Matt Farina	f0cf9c28f0	Move logging setup to be configurable ... Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
curlwget	bfc1af68fb	chore: fix function in comment ... Signed-off-by: curlwget <curlwget@icloud.com>	1 year ago
George Jenkins	a2a0935cba	Merge pull request #30900 from unguiculus/issue-12952 ... Add timeout flag to repo add and update commands	1 year ago
Terry Howe	f55c462a79	fix: force bearer oauth for everything ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Robert Sirchia	ba0fbdeb57	Merge pull request #30979 from TerryHowe/oras-v2-login-for-v4 ... fix: OAuth username password login for v4	1 year ago
Artem Vdovin	351bb78ee5	fix index concurrency ... Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>	1 year ago
Terry Howe	df482346db	fix: lint test SetEnv errors ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Terry Howe	47980159b3	fix: user username password for login ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
manslaughter03	bc44614a78	fix: wrap run release test error in case GetPodLogs failed. ... Signed-off-by: manslaughter03 <manslaughter03@gmail.com>	1 year ago
Terry Howe	744c6b5a97	fix: kube client create mutex ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Ashmit Bhardwaj	e060fbe185	updated docs ... Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>	1 year ago
Ashmit Bhardwaj	0389407cbc	removed unnecessary binary file ... Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>	1 year ago
Ashmit Bhardwaj	b305a501e8	added documentation and test cases for api-versions flag ... Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>	1 year ago
Terry Howe	93ec064640	fix: repo update cmd mutex ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
acceptacross	9623fb80f1	chore: fix some function names in comment ... Signed-off-by: acceptacross <csqcqs@gmail.com>	1 year ago
Matt Farina	7031000b7d	Merge pull request #30955 from carloslima/fix-test-deleting-local-directories ... Fix tests deleting XDG_DATA_HOME	1 year ago
Scott Rigby	069b525332	Merge pull request #13586 from jessesimpson36/cleaner-stacktraces ... fix: add formatting for errors to make multiline stacktraces in helm templates	1 year ago
Carlos Lima	f8204031f1	Fix tests deleting XDG_DATA_HOME ... That includes ~/.local/share/keyrings which was the most immediatelly visible effect. Signed-off-by: Carlos Lima <carlos@cpan.org>	1 year ago
Robert Sirchia	c0aa690c90	Merge pull request #30909 from jinjiadu/main ... refactor: replace HasPrefix+TrimPrefix with CutPrefix	1 year ago
Scott Rigby	e2630d1aba	Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex ... fix: action hooks delete policy mutex	1 year ago
Scott Rigby	de745ea34b	Merge pull request #12581 from Nordix/considerAllGroupVersionKind ... Consider full GroupVersionKind when matching resources	1 year ago
Scott Rigby	e8c1acf228	Merge pull request #30809 from mmorel-35/usetesting ... chore: enable usetesting linter	1 year ago
Scott Rigby	4023c3b5ff	Merge pull request #30917 from TerryHowe/oci-transport-debugging ... fix: add debug logging to oci transport	1 year ago
Terry Howe	a8cbf3aa51	fix: action hooks delete policy mutex ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Matthieu MOREL	56a2bb4188	chore: enable usetesting linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Terry Howe	6ab7aa3612	fix: legacy docker support broken for login ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Terry Howe	5fe7a87138	fix: add debug logging to oci transport ... Signed-off-by: Terry Howe <terrylhowe@gmail.com> Co-authored-by: Billy Zha <jinzha1@microsoft.com>	1 year ago
Benoit Tigeot	6df8eb3b3b	Fix flaky TestFindChartURL due to non-deterministic map iteration ... The test was failing intermittently because Go's map iteration order is randomized (see `range repos` in `findChartUrl`). When looking up the `baz` chart with repository URL http://example.com/helm, two repositories match due to trailing slash equivalence: - testing-relative (URL: http://example.com/helm) - contains baz chart GOOD - testing-relative-trailing-slash (URL: http://example.com/helm/) - does not contain baz chart.. NOT GOOD The urlutil.Equal() function treats these URLs as equivalent, but depending on which repository the random map iterator encounters first, the test would either pass or fail with "entry not found". So I changed the third test case from baz to foo chart, since foo exists in both matching repositories. This eliminates the race condition while preserving all test expectations and logic. `findChartURL()` iterates over a map without deterministic ordering, causing the first-match-wins behavior to be non-deterministic when multiple repositories match the same URL pattern. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Scott Rigby	d4e58c54ba	Merge pull request #30928 from TerryHowe/fix-plugin-install-no-internet ... fix: plugin installer test with no Internet	1 year ago
Terry Howe	cc39d2428f	fix: plugin installer test with no Internet ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Benoit Tigeot	b2fd91b8d0	Adapt error of invalid json schema with the new expected output ... Closes: https://github.com/helm/helm/pull/30907 To be able to upgrade to v6.0.2 for jsonschema lib we need to upgrade this test. I am wondering if it's related to this commit: 86cca28795 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Reinhard Nägele	d448cf1943	Add timeout flag to repo add and update flags ... Signed-off-by: Reinhard Nägele <unguiculus@gmail.com> # Conflicts: # pkg/cmd/repo_update.go	1 year ago
jinjiadu	6f8e9e09a4	refactor: replace HasPrefix+TrimPrefix with CutPrefix ... Signed-off-by: jinjiadu <jinjiadu@aliyun.com>	1 year ago
Robert Sirchia	b7e127dd6b	amending missed line to delete ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	1 year ago
Robert Sirchia	937c533e37	forward porting 30902 ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	1 year ago
Robert Sirchia	52dddba759	Merge pull request #30894 from benoittgt/fix-#30881-main ... Prevent push cmd failure in 3.18 by handling version tag resolution in ORAS memory store	1 year ago
Robert Sirchia	83c26845ad	Merge pull request #30904 from benoittgt/document-ideal-registry-login-command ... [Doc] Help users avoid specifying URL scheme and path with `helm registry`	1 year ago
Benoit Tigeot	f939f6145f	Prevent fetching newReference again as we have in calling method ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	cb730c94b5	Help users avoid specifying URL scheme an path ... We’ve noticed that some users still include the URL scheme and full path when logging into an OCI registry, for example: ```sh helm registry login -u $OCI_REGISTRY_USER --password-stdin oci://ghcr.io/org/repo ``` This is no longer necessary and will not be supported in Helm v4. To guide users toward the correct usage, we should show an example of the ideal command. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Robert Sirchia	1b21f04b3b	Merge pull request #30865 from mmorel-35/github.com/evanphx/json-patch/v5 ... fix: update json-patch import path and add gomodguard settings	1 year ago
Benoit Tigeot	875e149d6b	Prevent failure when resolving version tags in oras memory store ... - The newReference() function transforms version tags by replacing + with _ for OCI compatibility - But the code was using the original ref (with +) for TagBytes() - Then it tries to find the tagged reference using parsedRef.String() (with _) - This mismatch causes the Resolve method to fail with "not found" - By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed. I extracted the TagBytes function to improve testability. Push() includes several external calls that are hard to mock, so isolating this logic makes testing more manageable. Close: #30881 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Matt Farina	cf7613ba6b	Reverting fix "renders int as float" ... This reverts #13533 This change has caused issues with numerous charts around things unrelated to toml. This is because of functions like typeIs/typeOf being used and acted upon. The change caused a significant regression. Note: This kind of change can be put into v3 charts, that are in active development, without causing a regression. Closes #30880 Signed-off-by: Matt Farina <matt@mattfarina.com>	1 year ago
Matt Farina	0c91649ec8	Merge pull request #30871 from gjenkins8/gjenkins/test_registry_localhost ... Run test OCI registry localhost	1 year ago
Matt Farina	f043faf0a3	Merge pull request #30862 from OmriSteiner/fix-absolute-uri ... fix: correctly concat absolute URIs in repo cache	1 year ago
Matt Farina	ab56ac62ba	Merge pull request #30866 from mmorel-35/thelper ... chore: enable thelper linter	1 year ago
George Jenkins	8ba181c343	Run test OCI registry localhost ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 year ago
Matthieu MOREL	157f0ba10a	chore: enable thelper ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Matthieu MOREL	706392fabb	fix: update json-patch import path and add gomodguard settings ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Matt Farina	b5a4781099	Adding test for list command ... Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Omri Steiner	c47c8fc868	fix: correctly concat absolute URIs in repo cache ... There used to be two implemenations for concatenating the repo URL with the chart URI / URL. In case the chart specified an absolute URI, one of the implementations performed an incorrect concatenation between the two, resulting in a URL which looks like <repo-URL><absolute-chart-URI>. This commit removes the faulty implementation and uses the other correct one instead. Signed-off-by: Omri Steiner <omri@steiners.co.il>	1 year ago
Matt Farina	dd40316660	Merge pull request #30842 from ayushontop/main ... Fix : No repository is not an error,use the helm repo list command ,if there is no repository,it should not be an error #30606	1 year ago
MichaelMorris	1460ebd14a	Added test case to resource_test.go ... Signed-off-by: MichaelMorris <michael.morris@est.tech>	1 year ago
MichaelMorris	9a2ac85077	Consider GroupVersionKind when matching resources ... This change shall take Group, Version and Kind from GroupVersionKind into consideration instead of the current behavior of only considering the Kind Closes: #12578 Signed-off-by: MichaelMorris <michael.morris@est.tech>	1 year ago
Ayush Tiwari	56b688145f	added cmd in repo_list.go for pipeline ... Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>	1 year ago
Robert Sirchia	b2456202ae	Merge pull request #30850 from yetyear/main ... refactor: use maps.Copy for cleaner map handling	1 year ago
George Jenkins	2c1257537c	Merge pull request #30829 from TerryHowe/increase-time-pkg-test-coverage ... Increase pkg/time test coverage	1 year ago
yetyear	03448d1d79	refactor: use maps.Copy for cleaner map handling ... Signed-off-by: yetyear <flite@outlook.com>	1 year ago
Robert Sirchia	4d580c6b95	Merge pull request #30810 from mmorel-35/usestdlibvars ... chore: enable usestdlibvars linter	1 year ago
Terry Howe	71787cca60	fix: rename slave replica ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
George Jenkins	a1f8802de9	Merge pull request #30553 from Zhanweelee/add_mustToYaml_support ... feat: Add mustToYaml and mustToJson template functions	1 year ago
Ayush Tiwari	e63cbae886	added cmd.ErrOrStderr() ... Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>	1 year ago
Ayush Tiwari	95328ea0a6	removed error import ... Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>	1 year ago
Ayush Tiwari	058bc083a8	changed Error to print ... Signed-off-by: Ayush Tiwari <55987406+ayushontop@users.noreply.github.com>	1 year ago
Terry Howe	da579a7aa6	chore: add test coverage for time package ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
findnature	ac8d2f9aed	refactor: use slices.Contains to simplify code ... Signed-off-by: findnature <cricis@aliyun.com>	1 year ago
Terry Howe	f754e6a23b	chore: increase test coverage of time pkg ... Signed-off-by: Terry Howe <terrylhowe@gmail.com>	1 year ago
Matthieu MOREL	77a267dacf	chore: enable usestdlibvars linter ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Jesse Simpson	e0a67b1028	test: use more realistic unit-test scenario by not relying on Release.Name ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	d10c5f6429	style: trim space from formatted error messages ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	0e0a8cc765	fix: address no-template-associated type of error ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	013f27c294	fix: use errors.New instead of fmt.Errorf ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	868cdc261f	refactor: reduce flow-control operations ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	48922e21d1	refactor: use struct equality instead of comparing each composition ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	ac98e977c3	refactor: switch to while loop instead of for to reduce unnecessary variables ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	65084371c9	refactor: replace if MatchString with FindStringSubMatch ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	782f6c6409	refactor: shorten regex subexp syntax ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	4b9a9ecaf6	refactor: rename function and add doc-string ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	4f63c73353	refactor: remove impractical safety check ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	5202820f2f	refactor: define regexs at package scope ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	cbdc22128e	refactor: use strings.Builder instead of string concatenation ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	cdcf1bc601	style: remove unnecessary break ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	3cc4cb60ba	refactor: prevent duplicates being inserted rather than post-filtering ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	deea4a0d0e	refactor: remove more unnecessary format calls ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	0a7dd4b269	test: adjust failing test on extra whitespace ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	13b232e061	refactor: make use of regexs for err parsing ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	daf4c34879	fix: use originalErr instead of formatting original error ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	98da3e28b6	fix: add some index checking and fixed a test that relied on type-checking ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	80d7a1b33f	style: make format ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	edf0f7be59	test: adjust formatting for error in test ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	487f72b822	fix: added protection against while-true condition in unbounded for loop ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	6bb836374b	test: adjusted to make it more meaningful and to pass ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	383a758aec	fix: add quality checks to ensure formatted error doesnt remove important info ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	d8bec4e30f	fix: remove comparison from old error message to new ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	c481470985	style: renamed i variable for consistency ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	2e3f6dce28	fix: save to fileLocation rather than fileLocations[i] which gets overwritten ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	f09bbb8ab8	style: consolidate for loops ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	1357db4db1	style: removed variable only used once ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	a56daca82b	style: use interface functions instead of inline logic ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	87f9e2dc45	style: create String function for TraceableError representing one chunk of a stacktrace ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	6cd0c0082a	fix: split up the multiline errors to be more vertical ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	cc477e9f79	fix: adjust test to not require external chart ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
Jesse Simpson	14f902c245	wip: draft at making cleaner stacktraces ... Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>	1 year ago
George Jenkins	ecf1730689	Merge pull request #13460 from justenstall/stdlib-errors-2 ... fix: replace "github.com/pkg/errors" with stdlib "errors" package	1 year ago
Justen Stall	4905a61026	Merge branch 'main' into stdlib-errors-2 ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Matt Farina	fcd37bcea7	Merge pull request #30783 from rpolishchuk/investigate-TestValidateChartIconPresence ... fix: chart icon presence test	1 year ago
Robert Sirchia	d9bc0a948c	Merge pull request #30777 from ryanhockstad/merge-fix ... fix: null merge. closes #30587	1 year ago
Scott Rigby	a911aa2112	Merge pull request #9175 from dastrobu/copy-dependencies-on-aliasing ... fix: copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies	1 year ago
Daniel Strobusch	b183eccfc4	copy dependency metadata on aliasing to avoid sharing imported values ... imported values are stored in dependency objects, which breaks if a chart dependency is shared among multiple aliases. By copying the dependency objects in the metadata values can be imported correctly. Supersedes #10174 Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>	1 year ago
Daniel Strobusch	df7befd208	copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies ... Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases. By copying the dependencies, parent information can be set correctly to render the templates as expected later on. Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level. Closes #9150 Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>	1 year ago
Stephen Murray	1682895636	ref(helm): Export Chart Not Found error ... Closes #30746 Signed-off-by: Stephen Murray <stephenmurrayengineer@gmail.com>	1 year ago
Rostyslav Polishchuk	1c8d1e375f	fix: chart icon presence test ... The `TestValidateChartIconPresence` test fails when run after `TestValidateChartIconURL` as they both are using a global variable `badChart.Icon` ``` : go test -v -test.shuffle 1 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/ -test.shuffle 1 === RUN TestValidateChartIconURL --- PASS: TestValidateChartIconURL (0.00s) === RUN TestValidateChartIconPresence chartfile_test.go:171: validateChartIconPresence to return a linter error, got no error --- FAIL: TestValidateChartIconPresence (0.00s) FAIL FAIL helm.sh/helm/v4/pkg/lint/rules 0.051s FAIL : go test -v -test.shuffle 2 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/ -test.shuffle 2 === RUN TestValidateChartIconPresence --- PASS: TestValidateChartIconPresence (0.00s) === RUN TestValidateChartIconURL --- PASS: TestValidateChartIconURL (0.00s) PASS ok helm.sh/helm/v4/pkg/lint/rules 0.050s ``` This commit: 1. Remove dependency on global variable 2. Explicitly set the state of the test object. Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>	1 year ago
Justen Stall	fc6c5e5edb	remove WaitAndGetCompletedPodPhase function ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Justen Stall	73545f9a3e	one more test output ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Justen Stall	4a6092bd6c	update another test output ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Justen Stall	7a316c8d51	update expected error message in install test ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Matthieu MOREL	d3eeb2c942	chore: remove github.com/hashicorp/go-multierror dependency ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Justen Stall	3877ec9049	fix golangci-lint issues ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Justen Stall	065e2eb3eb	updates after merge conflict resolution ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Justen Stall	280a9ddbdb	Merge branch 'main' into stdlib-errors-2 ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	1 year ago
Scott Rigby	eb6e240cfe	Merge pull request #30734 from ipaqsa/feature/add-custom-template-funcs ... feat(pkg/engine): add support for custom template funcs	1 year ago
Scott Rigby	8255300280	Merge pull request #12382 from edbmiller/ed-dot-miller/parse-chartfile-yaml-strictly ... fix(pkg/lint): unmarshals Chart.yaml strictly	1 year ago
Ryan Hockstad	c1175a4106	fix null merge ... Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>	1 year ago
Edward Miller	e414695a5b	fix ... Signed-off-by: Edward Miller <edmiller287@gmail.com>	1 year ago
Benoit Tigeot	e2461de3c2	Fix test with toml bump ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Matt Farina	a842140ef6	Merge pull request #13578 from gjenkins8/rm_chart_repo_load_func ... refactor: Remove ChartRepository `[]ChartPaths`	1 year ago
Edward Miller	629780a34a	fix: reapply error message fix ... Signed-off-by: Edward Miller <edmiller287@gmail.com>	1 year ago
Edward Miller	9d43f70643	Update error message ... Co-authored-by: Andrew Block <andy.block@gmail.com> Signed-off-by: Edward Miller <55854159+edbmiller@users.noreply.github.com>	1 year ago
Edward Miller	14a468f24d	Add chartutil.StrictLoadChartfile for strict (WARNING-level) lint ... Signed-off-by: Edward Miller <edmiller287@gmail.com>	1 year ago
Edward Miller	00f8561ad4	fix(pkg/lint): unmarshals Chart.yaml strictly ... When "helm lint" is run, it now errors on invalid chartfiles, e.g. those with duplicate keys Closes #12381 Signed-off-by: Edward Miller <edmiller287@gmail.com>	1 year ago
wangcundashang	7bb0c85441	chore: fix function name in comment ... Signed-off-by: wangcundashang <wangcundashang@qq.com>	1 year ago
Stepan Paksashvili	b54349d9b2	fix(pkg/engine): allow to override all functions ... Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>	1 year ago
Stepan Paksashvili	5c2f89307d	feat(pkg/engine): and custom funcs to action config ... Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>	1 year ago
Stepan Paksashvili	8982b57e5e	feat(pkg/engine): and custom funcs overriding test ... Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>	1 year ago
Stepan Paksashvili	9073bcf53e	feat(pkg/engine): add support for custom template funcs ... Enhances the template engine and action config to allow users to inject custom template functions via an action config when using Helm as a library. Closes #30733 Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>	1 year ago
Scott Rigby	599fad1864	Merge pull request #30697 from p-se/fix-take-ownership ... Fix --take-ownership for custom resources - closes #30622	1 year ago
Evans Mungai	1f5605a405	fix formatting errors ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	1 year ago
Benoit Tigeot	d33e2896f0	Prevent failures with method signatures on hooks ... changes on wait strategy. This PR try to fix linting and tests. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Scott Rigby	e397f44840	Merge pull request #30673 from nvanthao/process-all-hook-deletions-on-failure ... fix: Process all hook deletions on failure	1 year ago
Matt Farina	01590a59b2	Merge pull request #30760 from robertsirc/add-debuging-to-jsonschema ... adding slog debug to a few points	1 year ago
Robert Sirchia	8733103743	Merge pull request #30718 from klihub/fixes/package/multiple-charts-single-passwd-from-stdin ... Allow signing multiple charts with a single passphrase from stdin.	1 year ago
Robert Sirchia	da096e1b7a	Merge pull request #30752 from benoittgt/bump-golangci-lint-action ... Bump golangci lint to last major version and fix static-check errors	1 year ago
Robert Sirchia	ef0361de21	fixing as per review ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	1 year ago
Robert Sirchia	9b9ff12c6d	adding slog debug to a few points ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	1 year ago
Krisztian Litkey	3102c28804	fix: allow signing multiple charts with passphrase from stdin. ... Cache the signing key passphrase. When signing multiple charts with the passphrase from stdin, this allows signing all charts instead of all but the first failing with an error about stdin already having been closed. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>	1 year ago
Evans Mungai	e8e79cc4b4	Merge branch 'main' into fix-take-ownership ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	1 year ago
Evans Mungai	7c37a109f2	Add install test for TakeOwnership flag ... Signed-off-by: Evans Mungai <mbuevans@gmail.com>	1 year ago
Matt Farina	0dffc580b0	Simpligy the JSON Schema checking ... A new library was introduced that provides JSON Schema checking for newer versions of the schema. In Helm v4, there is no need to have two packages doing the JSON schema validation. The message output can have breaking changes. This change moves everything to the newer library. It also uses a wrapper error to enable a clean Helm only interface for the public Go API validation functions. This would enable the replacement of the Schema validation library, if needed, without breaking the Go API contract. Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Matt Farina	55a4fc121b	Merge pull request #13283 from win-t/jsonschema ... adding support for JSON Schema 2020	1 year ago
Benoit Tigeot	a1c2f47c08	avoid using reflect.DeepEqual with errors ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	eb65ce280b	could apply De Morgan's law ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	374805deb4	error strings should not be capitalized ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	1654664b78	could use strings.ReplaceAll instead ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	a6d0335bbb	Use fmt.Fprintf(...) instead of ... ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	a9b7732367	could remove embedded field X from selector ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Kurnia D Win	6c54351c01	Merge remote-tracking branch 'upstream/main' into jsonschema	1 year ago
Benoit Tigeot	f5aec508f5	Add detailed debug logging for resource readiness states ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Scott Rigby	9a670ae920	Merge pull request #30701 from zanuka/30617-request-for-helm-install-order-doc-update ... updates mutate and validate web hook configs	1 year ago
Scott Rigby	0cecd910e5	Merge pull request #30713 from gjenkins8/gjenkins/rm_helmv2_template_lint_rules ... cleanup: Remove Helm v2 template lint rules	1 year ago
Matt Farina	a536832714	Merge pull request #30749 from mattfarina/fix-alpine-chart ... Removing the alpine test chart	1 year ago
Robert Sirchia	f5decfc28d	Merge pull request #30737 from rpolishchuk/investigation-pr-30610 ... fix: order dependent test	1 year ago
Matt Farina	91ecb56355	Removing the alpine test chart ... A .gitignore was previously setup to ignore this file. When pkg/cmd was setup the .gitignore was not updated. The change adds the new location to continue to ignore this file. Note, the previous location is still included in the .gitignore because developers will have a file there and we do not want that accidently included in a commit. Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Matt Farina	7a1eb77e77	Merge pull request #30708 from benoittgt/migrate-kube-pkg-to-slog ... Migrate pkg to slog	1 year ago
Matt Farina	ed005f5c32	Removing deprecation notice for this function. ... While the constructor is not used by Helm itself, it is used by SDK users and there is currently no alternative way to expose this. Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Matt Farina	7938662f95	Remove ValidName regex ... This regex was already deprecated. Validation happens inside the Metadata Validate function for the name instead of using this regex. Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago
Benoit Tigeot	68440d7b29	Prefer using slog.Any when displaying errors ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	c05bcbd498	Fix nil pointer dereference in ready test ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	e7eedae97c	Use the logger with proper handling of dynamic debug on 2 locations ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	cbaac7652d	Call slog directly instead of using a wrapper ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	6b5fa33633	debug log level is dynamic and set after Logger creation ... So we should use dynamic handler to set the log level after. With this patch we can clearly see the output. Before we were always stuck in log level "info" and not seeing debug log level ``` bin/helm upgrade --install --debug --wait frontend \ --namespace test \ --set replicaCount=2 \ --set backend=http://backend-podinfo:9898/echo \ podinfo/podinfo level=DEBUG msg="getting history for release" release=frontend level=DEBUG msg="preparing upgrade" name=frontend level=DEBUG msg="performing update" name=frontend level=DEBUG msg="creating upgraded release" name=frontend level=DEBUG msg="checking resources for changes" resources=2 level=DEBUG msg="no changes detected" kind=Service name=frontend-podinfo level=DEBUG msg="patching resource" kind=Deployment name=frontend-podinfo namespace=test level=DEBUG msg="waiting for resources" count=2 timeout=5m0s level=DEBUG msg="waiting for resource" name=frontend-podinfo kind=Deployment expectedStatus=Current actualStatus=Unknown level=DEBUG msg="updating status for upgraded release" name=frontend Release "frontend" has been upgraded. Happy Helming! NAME: frontend LAST DEPLOYED: Thu Apr 10 09:56:25 2025 NAMESPACE: test STATUS: deployed REVISION: 6 DESCRIPTION: Upgrade complete ``` Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Rostyslav Polishchuk	55eb53e3a0	fix: order dependent test ... TestInstallRelease_Atomic_Interrupted needs the same wait as TestInstallRelease_Wait_Interrupted (see helm/helm#12088). The installation goroutine started by TestInstallRelease_Atomic_Interrupted proceeds in the background and may interfere with other tests (see helm/helm#30610) Also see helm/helm#12086 and helm/helm#12109 which are describe and address the root cause. Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>	1 year ago