Matthieu MOREL
24bbb46c62
chore: fix gofumpt issues
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 days ago
Terry Howe
8eb65528be
Merge pull request #32467 from mmorel-35/testify-assertions-pkg-3
...
chore(pkg): refactor: finer tests conversions to testify part 3
6 days ago
Matthieu MOREL
61d99a8bdb
Update labels_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 days ago
Matthieu MOREL
9a2be11e6f
chore(pkg): refactor: finer tests conversions to testify part 3
...
refactor: finer tests conversions to testify in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 days ago
Matthieu MOREL
4d9c03f51c
chore(pkg): refactor: finer tests conversions to testify part 2
...
#### Description
refactor: finer tests conversions to testify in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 days ago
Robert Sirchia
39231d01e1
Merge pull request #32435 from mmorel-35/testifylint-manual-assert-pkg-19
...
chore(pkg): refactor: convert tests to testify assert/require part 19
1 week ago
Terry Howe
e5378ad47e
Merge pull request #32437 from mmorel-35/testifylint-manual-assert-pkg-21
...
chore(pkg): refactor: convert tests to testify assert/require part 21
1 week ago
Terry Howe
ea9e38035d
Merge pull request #32429 from mmorel-35/testifylint-manual-assert-pkg-14
...
chore(pkg): refactor: convert tests to testify assert/require part 14
1 week ago
Terry Howe
5d4165bfaf
Merge pull request #32425 from mmorel-35/testifylint-manual-assert-pkg-10
...
chore(pkg): refactor: convert tests to testify assert/require part 10
1 week ago
Matthieu MOREL
33c2839569
chore(pkg): refactor: convert tests to testify assert/require part 19
...
refactor: convert tests to testify assert/require in pkg/action
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
Matthieu MOREL
a934b827fa
chore(pkg): refactor: convert tests to testify assert/require part 21
...
#### Description
refactor: convert tests to testify assert/require in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
Matthieu MOREL
dc66ee7be7
chore(pkg): refactor: convert tests to testify assert/require part 14
...
refactor: convert tests to testify assert/require in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
Matthieu MOREL
2f5a33fb77
chore(pkg): refactor: convert tests to testify assert/require part 10
...
#### Description
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
Matthieu MOREL
e5f0e07b96
chore(pkg): refactor: convert tests to testify assert/require part 8
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
Matthieu MOREL
658a8fac15
chore(pkg): refactor: convert tests to testify assert/require part 4
...
refactor: convert tests to testify assert/require in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 week ago
Abhay Chaurasiya
82be04d7f2
remove legacy import comments from remaining packages ( #31933 )
...
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`)
are obsolete since Go 1.11 where go.mod is the authoritative module path.
These stale comments cause issues with downstream tooling such as Kythe.
Removes the legacy import comments from 64 files across 20 packages:
- cmd/helm
- internal/chart/v3/lint and sub-packages
- internal/plugin and sub-packages
- internal/release/v2/util
- pkg/chart/v2/lint and sub-packages
- pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance
- pkg/registry
- pkg/release/v1/util
- pkg/repo/v1
- pkg/storage and pkg/storage/driver
Follows up on #31931 and #31932 which addressed pkg/kube.
Fixes #31846
Signed-off-by: abhay1999 <abhay.chaurasiya@example.com>
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
2 weeks ago
Matthieu MOREL
a02a5713de
chore: fix elseif and ifElseChain issues from gocritic ( #32289 )
...
* chore: fix elseif and ifElseChain issues from gocritic
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
* test: enhance assertions in OCIInstaller and list tests using testify
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 weeks ago
George Jenkins
7a7b328ba5
Merge pull request #32319 from mmorel-35/revive
...
feat(linters): add new revive rules for better code quality
2 weeks ago
Matthieu MOREL
16787d65f5
feat(linters): add new revive rules for better code quality
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
Matthieu MOREL
9662fdd73b
refactor: enable several checks from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
Matthieu MOREL
f34ad6c337
chore: fix several checks issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3 weeks ago
Matthieu MOREL
07259ecc86
chore: fix several checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 weeks ago
George Jenkins
fb9791f492
Merge pull request #32136 from SebTardif/fix-digest-error-swallow
...
fix(provenance): check error return in Digest and encodeRelease
1 month ago
Terry Howe
b3fbf8d0f7
Merge pull request #30808 from mmorel-35/errorlint
...
chore: enable errorlint
2 months ago
Terry Howe
59b57c5c31
Merge pull request #31885 from mmorel-35/whitespace
...
chore: fix whitespace linter
2 months ago
Sebastien Tardif
e095e690a8
fix(provenance): check error return in Digest
...
Return the actual error from io.Copy in Digest() instead of nil.
The previous code swallowed the error and returned an empty string
as a valid SHA-256 digest, which could silently break chart
provenance verification.
Also fix encodeRelease() in pkg/storage/driver/util.go:
- Close the gzip writer on the w.Write() error path to avoid
leaking resources.
- Check the error return from gzip.Writer.Close(), which flushes
remaining compressed data and can fail.
Assisted-by: Grok/xAI
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
2 months ago
Matthieu MOREL
7edfff33eb
chore: fix unnecessary-format issues from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
Matthieu MOREL
af31a67924
chore: enable errorlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Matthieu MOREL
1e0f702f00
chore: fix whitespace linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
George Jenkins
df8e0301ed
Merge pull request #31878 from mmorel-35/perfsprint-pkg-3-39f7a9f
...
chore(pkg): fix perfsprint linter issues part 3
5 months ago
George Jenkins
c4392033cc
Merge pull request #31853 from atombrella/feature/fmt_unneeded
...
Replace non-format use of t.Fatalf with t.Fatal
5 months ago
Matthieu MOREL
e3c74fd9fa
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Matthieu MOREL
1d2d63cc43
chore(pkg): enable perfsprint linter
...
#### Description
enable perfsprint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
Mads Jensen
36cb3a2fe9
Replace unneeded use of t.Fatalf with t.Fatal
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
5 months ago
George Jenkins
be7cdb69e5
Merge pull request #31806 from mmorel-35/errorlint-pkg-4-15f432a
...
fix(pkg): errorlint linter
5 months ago
George Jenkins
92b64e87ad
chore: fixes
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
Joe Julian
56d0d9374a
Merge pull request #31810 from mmorel-35/errorlint-pkg-5-dda0145
...
fix(pkg): errorlint linter
6 months ago
Matthieu MOREL
259f76a849
fix(pkg): errorlint linter
...
errorlint linter in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
4d0ae7f33a
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matthieu MOREL
c8989d984f
fix(pkg): errorlint linter
...
#### Description
errorlint linter in pkg
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
Matheus Pimenta
a8eb527847
bugfix(storage): fix storage not getting logger from driver
...
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
7 months ago
Mads Jensen
a18e59e465
Enable the sloglint linter
...
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
8 months ago
Mads Jensen
6cceead399
Use modernize to use newer Golang features.
...
The rangeint suggestion is faster.
The maps.Copy and slices.Contains are just syntatic sugar.
Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>
8 months ago
Evans Mungai
b6eca1c0f1
Refactor logging functionality to use slog.Handler
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
Evans Mungai
5ab4ca5490
Embed logging functionality to DRY code
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
Evans Mungai
9c32e34d60
Add logger to sql driver and ensure storage has logger
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
Evans Mungai
50e43f4017
nil logger should be handled by discard handler
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
Evans Mungai
7a5816b106
Self review changes
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
Evans Mungai
b1d4dc680d
feat: reinstate logger parameter to actions package
...
Fixes : #31399
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
9 months ago
Matt Farina
9c958dec76
Making uninstall response generic
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago