Khwaja Faraz Ahmed
d50d22c970
Add test coverage for get_values/metadata.go
...
Signed-off-by: Khwaja Faraz Ahmed <khwaja.ahmed@securiti.ai>
Signed-off-by: Khwaja Faraz Ahmed <khwajafarazahmed@gmail.com>
2 months ago
Danilo Bürger
8096f09370
Pass credentials when either chart repo or repo dont specify a port but it matches the default port of that scheme
...
Signed-off-by: Danilo Bürger <danilo.buerger@helsing.ai>
2 months ago
Scott Rigby
091f9a24fe
Merge pull request #13154 from carloslima/post-render-everything
...
Allow post-renderer to process hooks
2 months ago
Yuriy Losev
46b1a41631
Add release labels to the release Metadata
...
Signed-off-by: Yuriy Losev <yuriy.losev@flant.com>
2 months ago
Zach Burgess
35434947a3
Return a lint warning if `templates/` does not exist.
...
Signed-off-by: Zach Burgess <zachburg@google.com>
2 months ago
George Jenkins
5283915c57
Remove deprecated '--create-pods' flag
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
3 months ago
Carlos Lima
6991a0a531
Make annotateAndMerge deterministic
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
c01e76b5c3
review: change annotation name to postrenderer.helm.sh/postrender-filename
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
a1416cf225
review: style changes
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
859721bd77
review: rewrite error messages from the end-user perspective
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
b26b473bf6
review: make splitAndDeannotate private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
855b5a44b7
review: make annotateAndMerge private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
1d993f9e2d
review: make filenameAnnotation private
...
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
Carlos Lima
e6362d74c8
Allow post-renderer to process hooks
...
This annotates and merges all manifests before sending to the
postrender, reversing the process and recovering the filenames
afterwards.
closes #7891
Signed-off-by: Carlos Lima <carlos@cpan.org>
3 months ago
acceptacross
9623fb80f1
chore: fix some function names in comment
...
Signed-off-by: acceptacross <csqcqs@gmail.com>
4 months ago
Scott Rigby
069b525332
Merge pull request #13586 from jessesimpson36/cleaner-stacktraces
...
fix: add formatting for errors to make multiline stacktraces in helm templates
4 months ago
Scott Rigby
e2630d1aba
Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex
...
fix: action hooks delete policy mutex
4 months ago
Terry Howe
a8cbf3aa51
fix: action hooks delete policy mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
4 months ago
yetyear
03448d1d79
refactor: use maps.Copy for cleaner map handling
...
Signed-off-by: yetyear <flite@outlook.com>
4 months ago
findnature
ac8d2f9aed
refactor: use slices.Contains to simplify code
...
Signed-off-by: findnature <cricis@aliyun.com>
5 months ago
Jesse Simpson
0a7dd4b269
test: adjust failing test on extra whitespace
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Jesse Simpson
edf0f7be59
test: adjust formatting for error in test
...
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
5 months ago
Justen Stall
7a316c8d51
update expected error message in install test
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
3877ec9049
fix golangci-lint issues
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
065e2eb3eb
updates after merge conflict resolution
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
5 months ago
Stepan Paksashvili
5c2f89307d
feat(pkg/engine): and custom funcs to action config
...
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
5 months ago
Stepan Paksashvili
9073bcf53e
feat(pkg/engine): add support for custom template funcs
...
Enhances the template engine and action config to allow users to inject custom template functions via an action config when using Helm as a library.
Closes #30733
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
5 months ago
Scott Rigby
599fad1864
Merge pull request #30697 from p-se/fix-take-ownership
...
Fix --take-ownership for custom resources - closes #30622
5 months ago
Benoit Tigeot
d33e2896f0
Prevent failures with method signatures on hooks
...
changes on wait strategy. This PR try to fix linting and tests.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Scott Rigby
e397f44840
Merge pull request #30673 from nvanthao/process-all-hook-deletions-on-failure
...
fix: Process all hook deletions on failure
5 months ago
Robert Sirchia
8733103743
Merge pull request #30718 from klihub/fixes/package/multiple-charts-single-passwd-from-stdin
...
Allow signing multiple charts with a single passphrase from stdin.
5 months ago
Krisztian Litkey
3102c28804
fix: allow signing multiple charts with passphrase from stdin.
...
Cache the signing key passphrase. When signing multiple charts
with the passphrase from stdin, this allows signing all charts
instead of all but the first failing with an error about stdin
already having been closed.
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
5 months ago
Evans Mungai
e8e79cc4b4
Merge branch 'main' into fix-take-ownership
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Evans Mungai
7c37a109f2
Add install test for TakeOwnership flag
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
5 months ago
Benoit Tigeot
a6d0335bbb
Use fmt.Fprintf(...) instead of ...
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
a9b7732367
could remove embedded field X from selector
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Robert Sirchia
f5decfc28d
Merge pull request #30737 from rpolishchuk/investigation-pr-30610
...
fix: order dependent test
5 months ago
Matt Farina
7a1eb77e77
Merge pull request #30708 from benoittgt/migrate-kube-pkg-to-slog
...
Migrate pkg to slog
5 months ago
Matt Farina
7938662f95
Remove ValidName regex
...
This regex was already deprecated.
Validation happens inside the Metadata Validate function for the
name instead of using this regex.
Signed-off-by: Matt Farina <matt.farina@suse.com>
5 months ago
Benoit Tigeot
68440d7b29
Prefer using slog.Any when displaying errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
e7eedae97c
Use the logger with proper handling of dynamic debug on 2 locations
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
cbaac7652d
Call slog directly instead of using a wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Rostyslav Polishchuk
55eb53e3a0
fix: order dependent test
...
TestInstallRelease_Atomic_Interrupted needs the same wait
as TestInstallRelease_Wait_Interrupted (see helm/helm#12088 ).
The installation goroutine started by
TestInstallRelease_Atomic_Interrupted proceeds in the background and
may interfere with other tests (see helm/helm#30610 )
Also see helm/helm#12086 and helm/helm#12109 which are describe and address the root
cause.
Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>
5 months ago
Benoit Tigeot
0c85456788
Leverage slog.Any for errors
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
5c746037b3
Prevent redefining verbose flags
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
710770eed4
Linting
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
baa597c567
Do not remove the functionality to print log in test
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b6adbbb227
Enforce error style with others
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b2380720eb
Migrate to pure slog without a custom wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
15de13f9d2
Fix linting issue and temporary removing logging in test acion
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b42767be40
Migrate more code to log adapter
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
83cdffe4ae
Migrate to a dedicated internal package for slog adapter + migrate more
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
fae2345edf
Demonstrate the impact of having Logger defined in kube package
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
ede73860c1
Fix call to kube log
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
f4631bf3d8
Migrate kube package to slog
...
As for helm v4. We want to migrate logs to slog.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Patrick Seidensal
e55707b09d
Fix --take-ownership
...
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.
This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.
By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.
Fixes #30622
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
6 months ago
Scott Rigby
985f5af538
Merge pull request #13604 from AustinAbro321/refactor-wait
...
Introduce kstatus watcher
6 months ago
Scott Rigby
122e7b441a
Merge pull request #13458 from thudi/main
...
#13449 Resolves: Replacing NewSimpleClientSet to NewClientSet due to deprecation
6 months ago
Austin Abro
386523bdbc
update to get waiter instead of set
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Gerard Nguyen
aa9e4bb42d
rebase
...
Signed-off-by: Gerard Nguyen <gerard@replicated.com>
6 months ago
Laszlo Uveges
63b6153163
More formatting
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
acca1b04eb
Add missing license header
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
d03981b82c
Fix go imports
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
940966d9c8
Fix formatting issues
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
2eea520ba4
Delete previously successful hooks when a later hook fails
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
0a28223ae5
Restructure hooks tests to be reusable
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Laszlo Uveges
788652fd27
Add dummy test case to prove that not all hooks are delted on failure
...
Signed-off-by: Laszlo Uveges <laszlo@giantswarm.io>
6 months ago
Austin Abro
2948279fb9
cleanup if statement
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
1a3fb75b34
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Matt Farina
e711488970
Move pkg/release to pkg/release/v1 to support v3 charts
...
This is part of HIP 20 which provides a means to have v3 charts
that live alongside v2 charts while having breaking changes.
The plan is to have a different release object for v3 chart
instances for at least a couple reasons:
1. So that the chart object on the release can be fundamentally
different.
2. So that Helm v3 does not detect or try to work with instances
of charts whose apiVersion it does not know about.
Note: it is expected that Helm v3 usage will be used long after
the Helm project no longer supports it. 5 years after Helm v2
had reached end-of-life there was still usage of it.
Note: The release util package is separate from the versioned
elements as it is planned to use generics to handle multiple
release object versions.
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
Austin Abro
09faaac273
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Matt Farina
61d3eca55c
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
...
This change moves the code, updates the import locations, and
adds a doc.go file to document what the v2 package is for.
This is part of HIP 20 for v3 charts
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
Austin Abro
11eeb4a6b1
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Matt Farina
18ca7c1002
Move pkg/releaseutil to pkg/release/util
...
The releaseutil package was originally designed to work against a
generated codebase from a protobuf in Helm v2. This is when Helm
used gRPC to communicate to a server side component named Tiller.
When Helm moved everything client side, this package remained and
it supported the release package.
This change moves releaseutil to be a sub-packge of release. This
is part of the change to support apiVersion v3 charts which is
documented in HIP 20
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
Scott Rigby
2cda65d444
Merge pull request #10309 from Bez625/main
...
Add hook annotation to output hook logs to client on error
7 months ago
Matt Farina
5c0deec327
Moving chartutil to chart/util
...
chartutil was originally created to operate on protobufs which are
no longer part of Helm. The util package makes more sense to be
part of the chart package.
This change is part of the HIP 20 to create v3 charts and
explicitly call out v2 charts. The changes for this are in smaller
bite size changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
Chris Berry
e5bc21c56b
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
9791767baa
Refactor based on review comment
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
6d30fa5990
Add HookOutputFunc and generic yaml unmarshaller
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Scott Rigby
52ac92fb69
clarify fix error message
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
e8a76bc3eb
fix err check
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
3796c1f4a1
remove comments about previous functionality
...
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Scott Rigby
f729b9ade0
add short circuit return
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
7 months ago
Chris Berry
243cb2e21f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
3d4e679d9f
Update based on review comments
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris Berry
a55a477069
Fix lint
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
Chris
3964f84ac8
Tidy up imports
...
Signed-off-by: Chris <bez625@gmail.com>
7 months ago
Chris Berry
cde407b7d1
Add hook annotations to output pod logs to client on success and fail
...
Signed-off-by: Chris Berry <bez625@gmail.com>
7 months ago
hugehope
001d2978b6
refactor: using slices.Contains to simplify the code
...
Signed-off-by: hugehope <cmm7@sina.cn>
7 months ago
Austin Abro
5d12255497
wait for delete
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
7fde4962a8
set waiter in functions
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
f2dd2c9109
add hook only waiter
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
2b03c527f1
set command line flags
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
fc10174fa0
merge main
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
8 months ago
George Jenkins
547f49abf6
Merge pull request #13579 from gjenkins8/rm_chart_repo_find_repo_dups
...
refactor: Remove duplicate `FindChartIn*RepoURL` functions
8 months ago
Terry Howe
5a7046b9bf
chore(oci): upgrade to ORAS v2
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
8 months ago
Austin Abro
916aecf1f1
Merge remote-tracking branch 'origin/main' into refactor-wait
8 months ago