Matt Farina
f80cbe43d0
Moved release objects to enable versioning
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
10 months ago
Benoit Tigeot
4a944230ea
Do not ignore *.yml file on linting while accepting *.yaml
...
From : https://github.com/helm/helm/pull/30712/files#r2417446037
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
10 months ago
reddaisyy
e69a12dad3
refactor: use reflect.TypeFor
...
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
10 months ago
Robert Sirchia
600eb487f1
Merge pull request #31349 from TerryHowe/fix-shuffle-lint-test
...
fix: flakey lint test on shuffle
10 months ago
Fábio Carneiro
1477d3793f
Clarify the intent of the resource instructions
...
Signed-off-by: Fábio Carneiro <fahecs@gmail.com>
10 months ago
George Jenkins
b97452d0e7
feat: `helm version` print Kubernetes (client-go) version
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
George Jenkins
a7a6a5e3b0
Merge pull request #31312 from gjenkins8/gjenkins/rm_plugin_schema_settings
...
Remove unused 'Settings' from plugin schema
11 months ago
Terry Howe
ee322a9671
fix: flakey lint test on shuffle
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
11 months ago
Terry Howe
bee9c1a108
chore: replace github.com/mitchellh/copystructure
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
11 months ago
George Jenkins
93c02523bb
Merge pull request #31249 from banjoh/em/additional-logging
...
chore: add additional logging to plugin installer
11 months ago
George Jenkins
900cf2a93d
Merge pull request #31320 from kosiew/sign-31181
...
provenance: allow RSA signing when ed25519 keys are present (switch to ProtonMail/go-crypto)
11 months ago
juejinyuxitu
69dbd6115e
chore: fix some typos in comment
...
Signed-off-by: juejinyuxitu <juejinyuxitu@outlook.com>
11 months ago
Siew Kam Onn
7c9176ae35
Update dependencies and refactor crypto imports to use ProtonMail's go-crypto package
...
Signed-off-by: Siew Kam Onn <kosiew@gmail.com>
11 months ago
George Jenkins
6bc6231bcc
Remove unused 'Settings' from plugin schema
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
Matt Farina
d2236e95ed
Merge pull request #31303 from mattfarina/unified-loader
...
Update the action interfaces for chart apiversions
11 months ago
Matt Farina
8dc7c57f50
Update the action interfaces for chart apiversions
...
This change is about handling the interfaces to public functions for
different chart apiVersions. The internals are still focused on v2.
This enables v3 to be layered in layer.
Signed-off-by: Matt Farina <matt.farina@suse.com>
11 months ago
zyfy29
b24bfe4168
Merge branch 'main' into delete-unused-var
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
11 months ago
Matt Farina
0befdb90a1
Merge pull request #31287 from miledxz/fileutil-tests-improvements
...
improve fileutil test coverage
11 months ago
Mile Druzijanic
934b4550d9
improve fileutil test coverage
...
Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>
11 months ago
Tom Wieczorek
6181e0a873
Make test scripts run without /bin/bash
...
The test scripts hardcoded #!/bin/bash while they are not really
requiring bash. Use the more portable #!/usr/bin/env sh instead, so that
they use the default shell.
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
11 months ago
yajianggroup
cfaf30083a
refactor: use strings.CutPrefix
...
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
11 months ago
Benoit Tigeot
072e2a689a
Extend --skip-schema-validation for lint command
...
When --skip-schema-validation is enabled, the lint command will now skip
JSON schema validation for values.yaml files, allowing charts with schema
validation errors to pass linting when the flag is used.
This addresses the gap where --skip-schema-validation only applied to
templates but not to values files, providing complete schema validation
bypass when needed.
Fixes : #13413
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
11 months ago
Evans Mungai
3d23230ef8
chore: add additional logging to plugin installer
...
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
11 months ago
Kamil Swiechowski
cd76ae1c93
feat:strict compliance with semverv2 for chart/v3/linter
...
Signed-off-by: Kamil Swiechowski <kamil.swiechowski@iprally.com>
11 months ago
Matt Farina
618b14a772
Merge pull request #31225 from mattfarina/move-lint-to-chart
...
Move lint pkg to be part of each chart version
11 months ago
George Jenkins
a8151ef4fe
Cleanup plugin config
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
11 months ago
Scott Rigby
ed6cab39c6
Merge pull request #31219 from gjenkins8/gjenkins/plugin-integration/rm_setup_plugin_env
11 months ago
Matt Farina
9dcc49cbd5
Move lint pkg to be part of each chart version
...
Linting is specific to the chart versions. A v2 and v3 chart will
lint differently.
To accomplish this, packages like engine need to be able to handle
different chart versions. This was accomplished by some changes:
1. The introduction of a Charter interface for charts
2. The ChartAccessor which is able to accept a chart and then
provide access to its data via an interface. There is an
interface, factory, and implementation for each version of
chart.
3. Common packages were moved to a common and util packages.
Due to some package loops, there are 2 packages which may
get some consolidation in the future.
The new interfaces provide the foundation to move the actions
and cmd packages to be able to handle multiple apiVersions of
charts.
Signed-off-by: Matt Farina <matt.farina@suse.com>
11 months ago
Matt Farina
52267ee74b
Move repo package to versioned directory
...
The repo package is internally versioned at v1. Repos were designed
to be versioned. This change moves it to a versioned directory the
same way other packages are now being handled.
Signed-off-by: Matt Farina <matt.farina@suse.com>
12 months ago
George Jenkins
5926ec83dd
Remove SetupPluginEnv
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
12 months ago
George Jenkins
665c5a1fc9
Merge pull request #31224 from gjenkins8/gjenkins/postrenderer_plugin_message_value
...
fix: Adjust PostRenderer plugin output to value
12 months ago
George Jenkins
d99d732542
fix: Adjust PostRenderer plugin output to value
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
12 months ago
George Jenkins
c35755a197
Remove legacy Command/Hooks from v1 Subprocess ( #23 )
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
12 months ago
Scott Rigby
591d863df5
Move Postrenderer to a plugin type
...
Fix/add back postrenderer args unit tests
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
e814ff3c38
Remove unnecessary file i/o operations from signing and verifying
...
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
9ea35da0d0
[HIP-0026] Plugin packaging, signing, and verification ( #31176 )
...
* Plugin packaging, signing and verification
Signed-off-by: Scott Rigby <scott@r6by.com>
* wrap keyring read error with more explicit message
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* skip unnecessary check
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Change behavior for installing plugin with missing .prov file (now warns and continues instead of failing)
Signed-off-by: Scott Rigby <scott@r6by.com>
* Add comprehensive plugin verification tests
- Test missing .prov files (warns but continues)
- Test invalid .prov file formats (fails verification)
- Test hash mismatches in .prov files (fails verification)
- Test .prov file access errors (fails appropriately)
- Test directory plugins don't support verification
- Test installation without verification enabled (succeeds)
- Test with valid .prov files (fails on empty keyring as expected)
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Co-authored-by: Evans Mungai <mbuevans@gmail.com>
12 months ago
zyfy29
8068578266
chore: delete unused var in installer.go
...
Signed-off-by: zyfy29 <wasuremono127@gmail.com>
12 months ago
George Jenkins
2658a00863
fix output message value
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
12 months ago
George Jenkins
e5b612626e
fixup slog tmpDirInner
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
12 months ago
George Jenkins
b6545e903a
code review + bug fixes
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
12 months ago
George Jenkins
c8e51b40c2
Plugin extism/v1 runtime
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
12 months ago
Matt Farina
4ae80c0399
Merge pull request #31191 from TerryHowe/stderr-logging
...
fix: send logging to stderr
12 months ago
Terry Howe
389646ffd1
fix: send logging to stderr
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
12 months ago
Scott Rigby
3d30112468
Fix LocalInstaller Path() to strip version from tarball filenames
...
Override Path() method to use existing stripPluginName function for archives
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
16924a51db
Fix: Removed unsafe umask manipulation in tests
...
Problem: Tests used syscall.Umask(0000) which could leave your shell creating
files with 777 permissions if interrupted.
Solution: Instead of changing umask, tests now detect the current umask and
calculate expected permissions after it's applied.
Result: Same test coverage, but safe from system-wide side effects.
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
5c663db853
Plugin tarball installer support for HTTP (fix) and local (feat)
...
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
d19130f69e
Fix file handle management in tar extractors
...
Use defer outFile.Close() to avoid multiple close calls and ensure proper resource cleanup
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
fd41fdd9c9
New registry plugin func GetPluginName. Re-use regsitry.reference
...
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
7d22bb25fa
Plugin OCI installer
...
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
a7578fec74
Plugin types and plugin apiVersion v1
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
12 months ago
Scott Rigby
be74ab72a0
[HIP-0026] Plugin runtime interface ( #31145 )
...
* Runtime abstraction to encapsulate subprocess code and enable future runtimes
Also fix race condition in TestPrepareCommandExtraArgs by replacing the shared variable modification with a local copy
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Remove commented out code
Co-authored-by: Joe Julian <me@joejulian.name>
Signed-off-by: Scott Rigby <scott@r6by.com>
* Check test failure string
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
---------
Signed-off-by: Scott Rigby <scott@r6by.com>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Co-authored-by: Joe Julian <me@joejulian.name>
Co-authored-by: Jesse Simpson <jesse.simpson36@gmail.com>
12 months ago
Matt Farina
0f1b410f14
Merge pull request #31165 from mattfarina/content-cache
...
Initial addition of content based cache
12 months ago
Matt Farina
fea6d8eb04
Updating to tested content cache
...
A few things are added here:
1. The cache is made to be more generic as a content based cache.
It could be used for other things such as plugins
2. Flags were added to specify the content cache locaiton rather
than rely on the repository cache. Keeping the 2 the same
hid bugs and errors.
3. Tests were added and updated to ensure the cache is used and
tested
Signed-off-by: Matt Farina <matt.farina@suse.com>
12 months ago
George Jenkins
4596c0e062
Merge pull request #31142 from helm/gjenkins/main/mv_plugin_internal
...
[HIP-0026] Move pkg/plugin -> internal/plugin
12 months ago
George Jenkins
a1c84f9a4c
Move pkg/plugin -> internal/plugin
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
1 year ago
joemicky
fab70472af
refactor: replace []byte(fmt.Sprintf) with fmt.Appendf
...
Signed-off-by: joemicky <joemickychang@outlook.com>
1 year ago
Robert Sirchia
d7d072b7f6
Merge commit from fork
...
Advisory fix 1
1 year ago
George Jenkins
18b7d45999
Merge pull request #31034 from Mazafard/feat/color-output-and-test-fixes
...
Feat: Add color output functionality and tests for release statuses
1 year ago
Matt Farina
0c64ad1c97
fix Chart.yaml handling
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Matt Farina
70257f5cd6
Initial addition of v3 charts
...
This change adds v3 charts. The code for the chart, including a
loader, is present. It is based on v2 charts as a starting point.
Note, this change does not make the charts available for use with
Helm CLI commands or the action package. That will be in follow-up
changes.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Mohammadreza Asadollahifard
ba8f70ae0b
refactor: move color package to internal/cli/output
...
Signed-off-by: Mohammadreza Asadollahifard <mazafard@gmail.com>
1 year ago
Matthieu MOREL
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Matthieu MOREL
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Matthieu MOREL
77a267dacf
chore: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Matthieu MOREL
15b83a9959
fix: dep fs errors
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 year ago
Matt Farina
ed356cfca8
Fixing windows build
...
The package github.com/pkg/errors was removed via the pull request #13460 .
This change did not correctly handle the case in the windows code and CI
did not exercise this to find the error.
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
1 year ago
Benoit Tigeot
1654664b78
could use strings.ReplaceAll instead
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
b2ac216763
func cleanUpDir is unused
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
a23b96276a
var mu is unused (unused)
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
7fe554e7a8
Fix naked return errors
...
> xinternal/third_party/dep/fs/fs.go:175:3: naked return in func `copyFile` with 59 lines of code (nakedret)
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
e7eedae97c
Use the logger with proper handling of dynamic debug on 2 locations
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
cbaac7652d
Call slog directly instead of using a wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
83a5a14826
Properly discard by default logs
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
b2380720eb
Migrate to pure slog without a custom wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
947658a96e
Explain why we ignore the timestamp
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
15de13f9d2
Fix linting issue and temporary removing logging in test acion
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Benoit Tigeot
83cdffe4ae
Migrate to a dedicated internal package for slog adapter + migrate more
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 year ago
Austin Abro
8efd428e5d
switch back to k8s rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
83266254f0
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
600947b32e
client->restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
ddc7baaaca
copyright things
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
3a296aacad
rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
24dc643822
restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Austin Abro
8d964588cd
Update internal/statusreaders/job_status_reader.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
1 year ago
Austin Abro
5ecca2ed14
Apply suggestions from code review
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
1 year ago
Robert Sirchia
848c134e0c
fixing error messages
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Robert Sirchia
1ad79a2bb7
converting inline log to slog
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Austin Abro
09faaac273
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
1 year ago
Matt Farina
61d3eca55c
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
...
This change moves the code, updates the import locations, and
adds a doc.go file to document what the v2 package is for.
This is part of HIP 20 for v3 charts
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Austin Abro
f866409c50
move statusreaders to it's own package
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
2 years ago
George Jenkins
3253059438
Merge pull request #13535 from helm/refactor_tlsutil
...
refactor: tlsutil use options pattern
2 years ago
George Jenkins
415c7e10fd
Merge pull request #13516 from TerryHowe/new-lint
...
chore: fix problems with latest lint
2 years ago
Matt Farina
27bcda42dd
Updating the internal version to v4
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Matt Farina
2236294119
Updating to helm.sh/helm/v4
...
Since Helm is going through breaking changes with Helm v4, the version path to
Helm needs to be updated.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
George Jenkins
e3e84343d2
refactor: tlsutil use options pattern
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 years ago
Terry Howe
569f62e58b
chore: fix problems with latest lint
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2 years ago
Justen Stall
8549a257d9
Update internal/third_party/dep/fs/fs.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2 years ago
Justen Stall
6aa19b8c92
more error wrapping uses
...
- replace os.IsNotExist with errors.Is and fs.ErrNotExist
- use %w directive
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2 years ago
Justen Stall
63cf42a843
fix: replace "github.com/pkg/errors" with stdlib "errors" package
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
2 years ago
Nathan Baulch
ef85fa7f2d
Grammar fixes
...
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
2 years ago
Matt Farina
c81bd8912e
Revert "Improve helm dependency update performance"
...
The change in #11726 caused a regression where `helm dependency udpate`
stopped working. The format of the internal representation of the data
changed causing errors of "non-absolute URLs should be in form of
repo_name/path_to_chart". See #13324 for more details.
Since this change is in released Helm and it's a regression, reverting
the original change was the fastest and safest route to deliver a
fix as quickly as possible.
Closes #13324
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
Matt Farina
d644da6205
bump version to v3.16.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 0d439e1a09 )
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
MichaelMorris
9e5f465499
Merge branch 'helm:main' into fixDepUpPerformance
...
Signed-off-by: MichaelMorris <michael.morris@est.tech>
2 years ago
Matt Farina
79cad1a133
Merge pull request #12934 from AndiDog/error-message-chart-version
...
Add error details when a dependent chart's version cannot be found in a repo
2 years ago
Robert Sirchia
30a5598f2b
Update walk.go
...
Putting a comment on why we are logging a found symlink.
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Matt Farina
886e626636
bump version to v3.15.0
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit d7afa3b6b4 )
2 years ago
Matt Farina
7b70fdf2a2
Merge pull request #12701 from mattfarina/bump-version-3.14
...
bump version to 3.14
2 years ago
Jeff van Dam
dc761caf00
Merge branch 'helm:main' into fixDepUpPerformance
2 years ago
Andreas Sommer
ac75eae98c
Add error details when a dependent chart's version cannot be found in a repo
...
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
2 years ago
Robert Sirchia
d58d7b3762
Fixing all the linting errors
...
Cleaned up all the linting errors we are getting.
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Matt Farina
f4c37e7db5
bump version to
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 69dcc92c56 )
3 years ago
Ismail Alidzhikov
5586760133
Make the `ignore` pkg public again
...
Signed-off-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
3 years ago
Matt Farina
c372b15022
bump version to v3.13.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 825e86f6a7 )
3 years ago
Jeff van Dam
183f01b32c
Made urls key more specific
...
Signed-off-by: Jeff van Dam <jeff.van.dam@est.tech>
3 years ago
Eng Zer Jun
2ceebffc77
test: replace `ensure.TempDir` with `t.TempDir`
...
This commit replaces `ensure.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ensure.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
3 years ago
Matt Farina
1800554452
bump version to v3.12.0
...
(cherry picked from commit 54a0fac9b5e243d9922dbfb412bff17eb161e361)
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
JvD_Ericsson
1ce7939838
Improve helm dependency update performance
...
What this PR does / why we need it:
This PR was created to improve performance of the dependency update command by
skipping unnecessary downloading and loading of index files that have already
been downloaded and loaded
I believe this would close refs #9865
Signed-off-by: Jeff van Dam <jeff.van.dam@est.tech>
3 years ago
Matt Farina
8c4c635e9e
Merge pull request #11832 from my-git9/chore-httpstatus
...
chore:Use http constants as http.request parameters
3 years ago
Matt Farina
4e7e939f19
Updating the Go version in go.mod
...
At this time both Go 1.19 and 1.20 are supported. The version
specified in the go.mod file is the minimum version we expect Helm
to be compiled against. This is the oldest supported version to
support environments where others compile Helm. The Helm project
is using Go 1.20 to build Helm itself.
Updating to Go 1.19 also includes dealing with io/ioutil
deprecation and some additional linting issues around staticcheck.
All the staticcheck issues were in test files so linting was
skipped for those.
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
50c22ed7f9
Bump the Go version
...
Needed to gofmt source to meet changes in style
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Andrew Block
08593c8dd6
Added support for insecure OCI registries
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
xin.li
8a310c5a98
chore:Use http constants as http.request parameters
...
Signed-off-by: xin.li <xin.li@daocloud.io>
4 years ago
Matt Farina
6facbada26
bump version to v3.11.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 9d8fee155b )
4 years ago
Matt Farina
cd809f9b19
bump version to v3.10.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit ce66412a72 )
4 years ago
yxxhero
39b0a82365
bump Go 1.18
...
Signed-off-by: yxxhero <aiopsclub@163.com>
4 years ago
Matt Farina
1db28a2311
bump version to v3.9.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 7ceeda6c58 )
4 years ago
Matt Farina
2e6b5e1374
Updating symlink log message
...
The symlink message did not tell anyone what Helm does with the contents
of the linked file. These are used in 2 places:
1. When loading a chart as a directory
2. When creating a chart archive (the linked files contents are
included)
Signed-off-by: Matt Farina <matt.farina@suse.com>
4 years ago
Martin Hickey
c477d697ec
Merge pull request #10458 from SimonAlling/remove-AssertGoldenBytes
...
Remove AssertGoldenBytes test helper
4 years ago
Matthew Fisher
2878cc8079
replace +build with go:build
...
go:build is the new conditional compilation directive used to specify build constraints. It was introduced in Go 1.17. It is meant to replace the old +build directives.
Now that go.mod points to Go 1.17 we no longer need to support both
build flags.
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
4 years ago
Josh Dolitsky
65d8e72504
Merge pull request #10628 from sabre1041/oci-dependencies-tag
...
Avoid querying for OCI tags can explicit version provided in chart dependencies
5 years ago
Eng Zer Jun
2e3e22a003
test: use `T.TempDir` to create temporary test directory
...
The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
5 years ago
Andrew Block
01ff5bb00d
Avoid querying for OCI tags can explicit version provided in chart dependencies
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
5 years ago
Matt Farina
0c8320b685
bump version to v3.8.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit d493f29c32 )
5 years ago
David Peraza
7cab1a09e3
Move all the remainder module out of experimental.
...
All the experimental modules were moved to pkg/action
Signed-off-by: David Peraza <dperaza@redhat.com>
5 years ago
David Peraza
9f869c6b21
Removing all the checks for oci experimental flag
...
Signed-off-by: David Peraza <dperaza@redhat.com>
5 years ago
Thomas Runyon
353d74e967
refactor internal/experimental/registry to pkg/registry
...
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
5 years ago
Scott Rigby
808a2d1908
Change underscore (_) back to plus (+) for Helm
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Scott Rigby
bd754a054c
Bring exact version check logic from IndexFile.Get into registry tag check
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Andrew Block
9c3b000889
Fixed bad commit
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
5 years ago
Andrew Block
828941b273
Readded resolver OCI logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
5 years ago
Andrew Block
291c17fcc5
Enabled auth and support http registries for OCI
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
5 years ago
Scott Rigby
4c8a3faaa2
Fix import
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Scott Rigby
b6bf3905f3
Implement reusable GetTagMatchingVersionOrConstraint
...
Largely borrowed from (IndexFile).Get. However there is not currently a nice
way to make this code also usable to the repo package, as IndexFile depends on
a list of index Entries containing a nexted version.
We could refactor this later to somehow use the same shared function, but for
now keeping separate.
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Andrew Block
4f62d3dc1b
Started work on 'helm pull'
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
5 years ago
Andrew Block
df98e18eb7
Working oci code without providing versions
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
5 years ago
Andrew Block
0fae7f5008
Updated tag resolver logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
5 years ago
Andrew Block
834a11db56
Added registryClient to resolver
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
5 years ago
Scott Rigby
e3f2fb4235
Add OCI tag verions to the Dependency object before Resolve. TODO: fix HTTP HTTPS error for local registries
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Andrew Block
9a7c362dd1
Initial tag listing support
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
5 years ago
Scott Rigby
3dc9930488
Revert "hack in progress"
...
This reverts commit c0be414e4b8d2928018504c010cb04b1b2450bf3.
Taking a different approach, but keep this work in git history for now until we
know the new approach works.
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Scott Rigby
0d2f0116ea
hack in progress
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Allen Bai
e3897ad6b1
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
...
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.
Ref:
- https://github.com/helm/helm/pull/10536#issuecomment-1010144075
- https://github.com/oras-project/oras-go/pull/92
Signed-off-by: Allen Bai <abai@redhat.com>
5 years ago
Allen Bai
e08a9270be
HELM_REGISTRY_CONFIG: change default file of registry config to config.json
...
Changes default registry config file from `registry.json` to
`config.json`. This aligns with the `config.json` that is widely used in docker.
Closes: https://github.com/helm/helm/issues/10156
Related: https://github.com/helm/helm/issues/10122
Signed-off-by: Allen Bai <abai@redhat.com>
5 years ago
Josh Wolf
fed0d31bf5
ensure consistency in registry client Push/Pull function signatures. ensure message is only printed when tags contain a replaced character
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
5 years ago
Scott Rigby
157ac85ab7
Fix typo. Thanks buildbot. Also comments at 80 chars
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Josh Wolf
fb0eeebf66
add oci reference validation and tag scoped (+) replacement to registry client Push/Pull
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
5 years ago
Scott Rigby
8424bc2b60
Update registry underscore message with semver note for extra clarity
...
Add newline to registry underscore message
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Scott Rigby
4aacbc44e0
Move plus/underscore change to inside Client. Compare original ref for strict mode
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Scott Rigby
472eb6f096
For OCI, convert + to _ before pull, and + to _ before push
...
Signed-off-by: Scott Rigby <scott@r6by.com>
5 years ago
Simon Alling
dd5db7bc40
Remove AssertGoldenBytes test helper
...
The test suite is thereby simplified somewhat.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
5 years ago
Josh Wolf
fae5009382
ensure error is correctly handled when generating chart's oci manifest
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
5 years ago
Josh Wolf
d2d8e52401
modify oci chart push/pull manifest test values to represent new order sorted by oras
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
5 years ago
Josh Wolf
7cec93d9fb
upgrade oras to 0.5.0, refactor client oci logic to use new oras.Copy()
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
5 years ago
Matt Farina
81f0df0ea6
Merge pull request #10182 from spectrocloud/oci-allow-any-media-type
...
changes to support any mediatype for layers on download
5 years ago
Kai Takac
52cbc2f49c
Fix default registry config path of oci protocol provider
...
Signed-off-by: Kai Takac <kai.takac@gmail.com>
5 years ago
LochanRn
9e29f1619b
changes to support any mediatype for layers on download
...
Signed-off-by: LochanRn <rajanaga_ra@srmuniv.edu.in>
5 years ago
Matt Farina
e6a92c4b62
bump version to 3.7
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 7048ef6b30aa23abdcfcaf523cb4c42dff85add9)
5 years ago
Josh Dolitsky
caa97158d0
Revert moving registry actions back to pkg/
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
77750962d5
Move registry actions back to pkg/
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
0121f6a328
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
John Howard
82a2abf512
Update oras-go to v0.4.0
...
Signed-off-by: John Howard <howardjohn@google.com>
5 years ago
Matthew Fisher
92bd9558e5
Merge pull request #9998 from bacongobbler/distribution-v3
...
Switch to distribution v3
5 years ago
Josh Dolitsky
82cdb0b793
modify registry test to only listen on loopback
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
f0a528ec05
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Matthew Fisher
4801818f7c
Switch to distribution v3
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
5 years ago
Víctor Cuadrado Juan
84a07a4774
test: Make internal/resolver/resolver_test.go pass on Win
...
TestGetLocalPath() needs Windows-specific expected strings.
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
5 years ago
Nicolas De Loof
663c569887
Migrate to oras-go library
...
see https://github.com/deislabs/oras/pull/265
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
5 years ago
Josh Dolitsky
241f23d72a
Better NewOCIPusher test, add ORAS link
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
d296ddf026
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Kally Fox
f9b1445b63
refactor: use os instead of ioutil's ReadDir
...
Signed-off-by: Kally Fox <kallydev@gmail.com>
5 years ago
Josh Dolitsky
8202ccd699
Remove LoginResult/LogoutResult types
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
593eac8876
Merge branch 'main' of github.com:helm/helm into hip-6
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Matt Farina
8855488272
Merge pull request #9736 from cndoit18/fix-issue-9348
...
fix(dep update): helm dep update is not respecting the "version" stip…
5 years ago
Josh Dolitsky
4884ca0059
revert change related to reading prov file
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
ec84339d44
return errors directly, less lines of code
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
230e37ca52
remove hardcoded oci strings, add constant/util
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
bfa5036a1a
consolidate registry source files
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
4d948b4a06
return err directly from pusher.Push
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
faf7fc5efd
use version.GetUserAgent
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
e856df8a54
provide hint if attempting to push directory
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
04d2da3637
return friendly error if missing scheme
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
35fdc688cd
remove the --with-prov option
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
eba63beab1
move experimental actions to new internal package
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
8f60ee76a5
resolve golint errors
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
24a216d3b2
move pkg/uploader, pkg/pusher to internal
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
4073e4d118
inline data fetching for pull result
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
dd7bc40bc4
one-line JSON unmarshall
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
817ac8ff9f
do not wrap single imports/vars
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago
Josh Dolitsky
f7247c40ee
Upgrade to oras-go v0.4.0
...
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
5 years ago