Benoit Tigeot
b2ac216763
func cleanUpDir is unused
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
a23b96276a
var mu is unused (unused)
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
7fe554e7a8
Fix naked return errors
...
> xinternal/third_party/dep/fs/fs.go:175:3: naked return in func `copyFile` with 59 lines of code (nakedret)
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
e7eedae97c
Use the logger with proper handling of dynamic debug on 2 locations
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
cbaac7652d
Call slog directly instead of using a wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
5 months ago
Benoit Tigeot
83a5a14826
Properly discard by default logs
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
b2380720eb
Migrate to pure slog without a custom wrapper
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
947658a96e
Explain why we ignore the timestamp
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
15de13f9d2
Fix linting issue and temporary removing logging in test acion
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Benoit Tigeot
83cdffe4ae
Migrate to a dedicated internal package for slog adapter + migrate more
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
Austin Abro
8efd428e5d
switch back to k8s rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Austin Abro
83266254f0
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
6 months ago
Austin Abro
600947b32e
client->restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
ddc7baaaca
copyright things
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
3a296aacad
rest mapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
24dc643822
restmapper
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Austin Abro
8d964588cd
Update internal/statusreaders/job_status_reader.go
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
7 months ago
Austin Abro
5ecca2ed14
Apply suggestions from code review
...
Co-authored-by: Scott Rigby <scott@r6by.com>
Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
7 months ago
Robert Sirchia
848c134e0c
fixing error messages
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Robert Sirchia
1ad79a2bb7
converting inline log to slog
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
7 months ago
Austin Abro
09faaac273
merge
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
Matt Farina
61d3eca55c
Move pkg/chart to pkg/chart/v2 to prepare for v3 charts
...
This change moves the code, updates the import locations, and
adds a doc.go file to document what the v2 package is for.
This is part of HIP 20 for v3 charts
Signed-off-by: Matt Farina <matt.farina@suse.com>
7 months ago
Austin Abro
f866409c50
move statusreaders to it's own package
...
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
7 months ago
George Jenkins
3253059438
Merge pull request #13535 from helm/refactor_tlsutil
...
refactor: tlsutil use options pattern
8 months ago
George Jenkins
415c7e10fd
Merge pull request #13516 from TerryHowe/new-lint
...
chore: fix problems with latest lint
8 months ago
Matt Farina
27bcda42dd
Updating the internal version to v4
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
Matt Farina
2236294119
Updating to helm.sh/helm/v4
...
Since Helm is going through breaking changes with Helm v4, the version path to
Helm needs to be updated.
Signed-off-by: Matt Farina <matt.farina@suse.com>
9 months ago
George Jenkins
e3e84343d2
refactor: tlsutil use options pattern
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
9 months ago
Terry Howe
569f62e58b
chore: fix problems with latest lint
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9 months ago
Justen Stall
8549a257d9
Update internal/third_party/dep/fs/fs.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
10 months ago
Justen Stall
6aa19b8c92
more error wrapping uses
...
- replace os.IsNotExist with errors.Is and fs.ErrNotExist
- use %w directive
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
10 months ago
Justen Stall
63cf42a843
fix: replace "github.com/pkg/errors" with stdlib "errors" package
...
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
10 months ago
Nathan Baulch
ef85fa7f2d
Grammar fixes
...
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
1 year ago
Matt Farina
c81bd8912e
Revert "Improve helm dependency update performance"
...
The change in #11726 caused a regression where `helm dependency udpate`
stopped working. The format of the internal representation of the data
changed causing errors of "non-absolute URLs should be in form of
repo_name/path_to_chart". See #13324 for more details.
Since this change is in released Helm and it's a regression, reverting
the original change was the fastest and safest route to deliver a
fix as quickly as possible.
Closes #13324
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
Matt Farina
d644da6205
bump version to v3.16.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 0d439e1a09
)
Signed-off-by: Matt Farina <matt.farina@suse.com>
1 year ago
MichaelMorris
9e5f465499
Merge branch 'helm:main' into fixDepUpPerformance
...
Signed-off-by: MichaelMorris <michael.morris@est.tech>
1 year ago
Matt Farina
79cad1a133
Merge pull request #12934 from AndiDog/error-message-chart-version
...
Add error details when a dependent chart's version cannot be found in a repo
1 year ago
Robert Sirchia
30a5598f2b
Update walk.go
...
Putting a comment on why we are logging a found symlink.
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
1 year ago
Matt Farina
886e626636
bump version to v3.15.0
...
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit d7afa3b6b4
)
1 year ago
Matt Farina
7b70fdf2a2
Merge pull request #12701 from mattfarina/bump-version-3.14
...
bump version to 3.14
1 year ago
Jeff van Dam
dc761caf00
Merge branch 'helm:main' into fixDepUpPerformance
1 year ago
Andreas Sommer
ac75eae98c
Add error details when a dependent chart's version cannot be found in a repo
...
Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
1 year ago
Robert Sirchia
d58d7b3762
Fixing all the linting errors
...
Cleaned up all the linting errors we are getting.
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2 years ago
Matt Farina
f4c37e7db5
bump version to
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 69dcc92c56
)
2 years ago
Ismail Alidzhikov
5586760133
Make the `ignore` pkg public again
...
Signed-off-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
2 years ago
Matt Farina
c372b15022
bump version to v3.13.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 825e86f6a7
)
2 years ago
Jeff van Dam
183f01b32c
Made urls key more specific
...
Signed-off-by: Jeff van Dam <jeff.van.dam@est.tech>
2 years ago
Eng Zer Jun
2ceebffc77
test: replace `ensure.TempDir` with `t.TempDir`
...
This commit replaces `ensure.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ensure.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2 years ago
Matt Farina
1800554452
bump version to v3.12.0
...
(cherry picked from commit 54a0fac9b5e243d9922dbfb412bff17eb161e361)
Signed-off-by: Matt Farina <matt.farina@suse.com>
2 years ago
JvD_Ericsson
1ce7939838
Improve helm dependency update performance
...
What this PR does / why we need it:
This PR was created to improve performance of the dependency update command by
skipping unnecessary downloading and loading of index files that have already
been downloaded and loaded
I believe this would close refs #9865
Signed-off-by: Jeff van Dam <jeff.van.dam@est.tech>
2 years ago
Matt Farina
8c4c635e9e
Merge pull request #11832 from my-git9/chore-httpstatus
...
chore:Use http constants as http.request parameters
2 years ago
Matt Farina
4e7e939f19
Updating the Go version in go.mod
...
At this time both Go 1.19 and 1.20 are supported. The version
specified in the go.mod file is the minimum version we expect Helm
to be compiled against. This is the oldest supported version to
support environments where others compile Helm. The Helm project
is using Go 1.20 to build Helm itself.
Updating to Go 1.19 also includes dealing with io/ioutil
deprecation and some additional linting issues around staticcheck.
All the staticcheck issues were in test files so linting was
skipped for those.
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Matt Farina
50c22ed7f9
Bump the Go version
...
Needed to gofmt source to meet changes in style
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Andrew Block
08593c8dd6
Added support for insecure OCI registries
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
3 years ago
xin.li
8a310c5a98
chore:Use http constants as http.request parameters
...
Signed-off-by: xin.li <xin.li@daocloud.io>
3 years ago
Matt Farina
6facbada26
bump version to v3.11.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 9d8fee155b
)
3 years ago
Matt Farina
cd809f9b19
bump version to v3.10.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit ce66412a72
)
3 years ago
yxxhero
39b0a82365
bump Go 1.18
...
Signed-off-by: yxxhero <aiopsclub@163.com>
3 years ago
Matt Farina
1db28a2311
bump version to v3.9.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 7ceeda6c58
)
3 years ago
Matt Farina
2e6b5e1374
Updating symlink log message
...
The symlink message did not tell anyone what Helm does with the contents
of the linked file. These are used in 2 places:
1. When loading a chart as a directory
2. When creating a chart archive (the linked files contents are
included)
Signed-off-by: Matt Farina <matt.farina@suse.com>
3 years ago
Martin Hickey
c477d697ec
Merge pull request #10458 from SimonAlling/remove-AssertGoldenBytes
...
Remove AssertGoldenBytes test helper
3 years ago
Matthew Fisher
2878cc8079
replace +build with go:build
...
go:build is the new conditional compilation directive used to specify build constraints. It was introduced in Go 1.17. It is meant to replace the old +build directives.
Now that go.mod points to Go 1.17 we no longer need to support both
build flags.
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
3 years ago
Josh Dolitsky
65d8e72504
Merge pull request #10628 from sabre1041/oci-dependencies-tag
...
Avoid querying for OCI tags can explicit version provided in chart dependencies
4 years ago
Eng Zer Jun
2e3e22a003
test: use `T.TempDir` to create temporary test directory
...
The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
4 years ago
Andrew Block
01ff5bb00d
Avoid querying for OCI tags can explicit version provided in chart dependencies
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Matt Farina
0c8320b685
bump version to v3.8.0
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit d493f29c32
)
4 years ago
David Peraza
7cab1a09e3
Move all the remainder module out of experimental.
...
All the experimental modules were moved to pkg/action
Signed-off-by: David Peraza <dperaza@redhat.com>
4 years ago
David Peraza
9f869c6b21
Removing all the checks for oci experimental flag
...
Signed-off-by: David Peraza <dperaza@redhat.com>
4 years ago
Thomas Runyon
353d74e967
refactor internal/experimental/registry to pkg/registry
...
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
4 years ago
Scott Rigby
808a2d1908
Change underscore (_) back to plus (+) for Helm
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
bd754a054c
Bring exact version check logic from IndexFile.Get into registry tag check
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Andrew Block
9c3b000889
Fixed bad commit
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
828941b273
Readded resolver OCI logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
291c17fcc5
Enabled auth and support http registries for OCI
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Scott Rigby
4c8a3faaa2
Fix import
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
b6bf3905f3
Implement reusable GetTagMatchingVersionOrConstraint
...
Largely borrowed from (IndexFile).Get. However there is not currently a nice
way to make this code also usable to the repo package, as IndexFile depends on
a list of index Entries containing a nexted version.
We could refactor this later to somehow use the same shared function, but for
now keeping separate.
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Andrew Block
4f62d3dc1b
Started work on 'helm pull'
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
df98e18eb7
Working oci code without providing versions
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
0fae7f5008
Updated tag resolver logic
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Andrew Block
834a11db56
Added registryClient to resolver
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Scott Rigby
e3f2fb4235
Add OCI tag verions to the Dependency object before Resolve. TODO: fix HTTP HTTPS error for local registries
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Andrew Block
9a7c362dd1
Initial tag listing support
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
4 years ago
Scott Rigby
3dc9930488
Revert "hack in progress"
...
This reverts commit c0be414e4b8d2928018504c010cb04b1b2450bf3.
Taking a different approach, but keep this work in git history for now until we
know the new approach works.
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
0d2f0116ea
hack in progress
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Allen Bai
e3897ad6b1
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
...
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.
Ref:
- https://github.com/helm/helm/pull/10536#issuecomment-1010144075
- https://github.com/oras-project/oras-go/pull/92
Signed-off-by: Allen Bai <abai@redhat.com>
4 years ago
Allen Bai
e08a9270be
HELM_REGISTRY_CONFIG: change default file of registry config to config.json
...
Changes default registry config file from `registry.json` to
`config.json`. This aligns with the `config.json` that is widely used in docker.
Closes: https://github.com/helm/helm/issues/10156
Related: https://github.com/helm/helm/issues/10122
Signed-off-by: Allen Bai <abai@redhat.com>
4 years ago
Josh Wolf
fed0d31bf5
ensure consistency in registry client Push/Pull function signatures. ensure message is only printed when tags contain a replaced character
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
4 years ago
Scott Rigby
157ac85ab7
Fix typo. Thanks buildbot. Also comments at 80 chars
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Josh Wolf
fb0eeebf66
add oci reference validation and tag scoped (+) replacement to registry client Push/Pull
...
Signed-off-by: Josh Wolf <josh@wolfs.io>
4 years ago
Scott Rigby
8424bc2b60
Update registry underscore message with semver note for extra clarity
...
Add newline to registry underscore message
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
4aacbc44e0
Move plus/underscore change to inside Client. Compare original ref for strict mode
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Scott Rigby
472eb6f096
For OCI, convert + to _ before pull, and + to _ before push
...
Signed-off-by: Scott Rigby <scott@r6by.com>
4 years ago
Simon Alling
dd5db7bc40
Remove AssertGoldenBytes test helper
...
The test suite is thereby simplified somewhat.
Signed-off-by: Simon Alling <alling.simon@gmail.com>
4 years ago
Josh Wolf
fae5009382
ensure error is correctly handled when generating chart's oci manifest
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
4 years ago
Josh Wolf
d2d8e52401
modify oci chart push/pull manifest test values to represent new order sorted by oras
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
4 years ago
Josh Wolf
7cec93d9fb
upgrade oras to 0.5.0, refactor client oci logic to use new oras.Copy()
...
Signed-off-by: Josh Wolf <josh@joshwolf.dev>
4 years ago
Matt Farina
81f0df0ea6
Merge pull request #10182 from spectrocloud/oci-allow-any-media-type
...
changes to support any mediatype for layers on download
4 years ago
Kai Takac
52cbc2f49c
Fix default registry config path of oci protocol provider
...
Signed-off-by: Kai Takac <kai.takac@gmail.com>
4 years ago
LochanRn
9e29f1619b
changes to support any mediatype for layers on download
...
Signed-off-by: LochanRn <rajanaga_ra@srmuniv.edu.in>
4 years ago
Matt Farina
e6a92c4b62
bump version to 3.7
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 7048ef6b30aa23abdcfcaf523cb4c42dff85add9)
4 years ago