Merge pull request #31530 from shuv0id/improve-debug-logging

fix: add missing context to debug logs
pull/31550/head
Robert Sirchia 10 months ago committed by GitHub
commit eb3da36e2e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -87,7 +87,7 @@ func ValidateAgainstSchema(ch chart.Charter, values map[string]interface{}) erro
sb.WriteString(err.Error()) sb.WriteString(err.Error())
} }
} }
slog.Debug("number of dependencies in the chart", "dependencies", len(chrt.Dependencies())) slog.Debug("number of dependencies in the chart", "chart", chrt.Name(), "dependencies", len(chrt.Dependencies()))
// For each dependency, recursively call this function with the coalesced values // For each dependency, recursively call this function with the coalesced values
for _, subchart := range chrt.Dependencies() { for _, subchart := range chrt.Dependencies() {
sub, err := chart.NewAccessor(subchart) sub, err := chart.NewAccessor(subchart)

@ -231,6 +231,7 @@ func statusObserver(cancel context.CancelFunc, desired status.Status) collector.
} }
if aggregator.AggregateStatus(rss, desired) == desired { if aggregator.AggregateStatus(rss, desired) == desired {
slog.Debug("all resources achieved desired status", "desiredStatus", desired, "resourceCount", len(rss))
cancel() cancel()
return return
} }
@ -241,7 +242,7 @@ func statusObserver(cancel context.CancelFunc, desired status.Status) collector.
return nonDesiredResources[i].Identifier.Name < nonDesiredResources[j].Identifier.Name return nonDesiredResources[i].Identifier.Name < nonDesiredResources[j].Identifier.Name
}) })
first := nonDesiredResources[0] first := nonDesiredResources[0]
slog.Debug("waiting for resource", "name", first.Identifier.Name, "kind", first.Identifier.GroupKind.Kind, "expectedStatus", desired, "actualStatus", first.Status) slog.Debug("waiting for resource", "namespace", first.Identifier.Namespace, "name", first.Identifier.Name, "kind", first.Identifier.GroupKind.Kind, "expectedStatus", desired, "actualStatus", first.Status)
} }
} }
} }

Loading…
Cancel
Save